Re: [pgadmin-hackers] Heads-up - Beta 1

[Dave Page]

Guillaume?

On Thu, Jun 20, 2013 at 7:11 AM, Marek Černocký  wrote:
> What my translation and patch
> http://www.postgresql.org/message-id/1366823347.15060.23.camel@sirius
> Can Guillaume see it.
>
>
> Dave Page píše v Út 18. 06. 2013 v 15:48 +0100:
>> I plan to cut the beta 1 release on Monday.
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Debugger Redesign

[Ashesh Vashi]

Hi Dave,

Please find the patch to resolve few of the problems with the debuggers and
introduced during redesigning it.

On Tue, Apr 30, 2013 at 12:56 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Tue, Apr 30, 2013 at 12:48 AM, Dave Page  wrote:
>
>> On Mon, Apr 29, 2013 at 8:10 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Mon, Apr 29, 2013 at 10:30 PM, Dave Page  wrote:
>>>
 Thanks Ashesh - committed (with a few minor tweaks, mostly to
 messages)! Good work :-)

>>> Thanks
>>>

 I think we have the following issues to discuss and possibly resolve
 during beta:

 1) I find the progress dialogue annoying, and as discussed previously
 think we should replace it with a progress indicator on the status bar.

>>> Yeah - I am aware of that.
>>>  I will work on it once I get some time.
>>>

 2) I don't see RAISE DEBUG messages in the server message pane. Perhaps
 we should explicitly set client_min_messages so the user can see their
 debug messages?

>>> Yup
>>>
>> Done.

>
 3) The stack pane shows functions as
 "foo(integer)(param_name=1)@". I think perhaps we should change it
 to: "foo(integer param_name=1)@"

>>> +1
>>>
>>
>> OK, please make those tweaks when you work on the progress indicator (or
>> before, if you get a chance).
>>
>>
>>>
 4) When in-process debugging, if the calling process is terminated we
 get a connection lost error (which I special-cased in the code, as it
 displays an unsightly message from the plugin by default). Instead, I think
 we should just automatically start listening for another calling process.

>>> The problem is: this error message is coming from backend (debugger
>>> plugin).
>>> And hence, it may require us to make changes in the plugin.
>>>
>>
>>  Shouldn't do - don't we just need to reset the breakpoint and wait for
>> it to be hit again? FYI, the old code does seem to do it successfully,
>> though it doesn't do a good job of ensuring the dialogues are re-displayed.
>>
> It was ignore any error in the debugging connection (even if it is a
> connection error or something else).
> I will come up with some other way to figure out the same. (I will also
> take care of this, when doing the modification for the progress bar. Hope -
> that's ok with everybody).
>
Done.
Now - we check for the session (backend) on which the target was running,
if it does not exist, we wait for another session to invoke the target.

Also - resolved couple of other problem related to the debugger:
- On cancellation of progress dialog, it was not closing the debugger.
- In direct debugging, the target was invoked without taking care about
quotes.

This patch also includes couple of other issues introduced by the earlier
patch.
1. Showing the messages multiple times in the message window (Query window)
2. Cancellation of query wasn't working on Query window.

Still working on the progress-bar.

>
>> Thanks!
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>
>
>
> *http://www.linkedin.com/in/asheshvashi*
>
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


debugger_improvements.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Use wxT() instead of _T() which doesn't work on Sol

[Dave Page]

Use wxT() instead of _T() which doesn't work on Solaris.

Branch
--
REL-1_16_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b9bc75dc4d270e49597f83baca0a43465c26bd45

Modified Files
--
pgadmin/dd/dditems/figures/ddColumnKindIcon.cpp|2 +-
pgadmin/dd/dditems/locators/ddAddColLocator.cpp|2 +-
.../dd/dditems/locators/ddMinMaxTableLocator.cpp   |2 +-
.../dd/dditems/locators/ddRemoveTableLocator.cpp   |2 +-
.../dditems/locators/ddScrollBarTableLocator.cpp   |2 +-
.../dd/dditems/locators/ddTableBottomLocator.cpp   |2 +-
pgadmin/dd/ddmodel/ddBrowserDataContainer.cpp  |2 +-
pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp   |   24 ++--
pgadmin/dd/ddmodel/ddGenerationWizard.cpp  |   22 ++--
pgadmin/debugger/dbgPgConn.cpp |2 +-
.../connectors/hdStickyRectangleConnector.cpp  |2 +-
.../figures/defaultAttributes/hdFillAttribute.cpp  |2 +-
.../defaultAttributes/hdFontColorAttribute.cpp |2 +-
.../figures/defaultAttributes/hdLineAttribute.cpp  |2 +-
pgadmin/hotdraw/figures/hdAbstractFigure.cpp   |2 +-
pgadmin/hotdraw/figures/hdAttributeFigure.cpp  |2 +-
pgadmin/hotdraw/figures/hdPolyLineFigure.cpp   |2 +-
.../handles/hdChangeConnectionEndHandle.cpp|2 +-
.../handles/hdChangeConnectionStartHandle.cpp  |2 +-
pgadmin/hotdraw/main/hdDrawing.cpp |2 +-
pgadmin/hotdraw/tools/hdCanvasMenuTool.cpp |2 +-
pgadmin/hotdraw/tools/hdPolyLineFigureTool.cpp |2 +-
pgadmin/hotdraw/tools/hdSimpleTextTool.cpp |2 +-
pgadmin/hotdraw/utilities/hdCollection.cpp |2 +-
pgadmin/hotdraw/utilities/hdPoint.cpp  |2 +-
pgadmin/hotdraw/utilities/hdRemoveDeleteDialog.cpp |2 +-
pgadmin/ogl/basic.cpp  |  136 ++--
pgadmin/ogl/bmpshape.cpp   |4 +-
pgadmin/ogl/composit.cpp   |   40 +++---
pgadmin/ogl/drawn.cpp  |   52 
pgadmin/ogl/lines.cpp  |   22 ++--
pgadmin/ogl/ogldiag.cpp|   60 -
32 files changed, 204 insertions(+), 204 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Use wxT() instead of _T() which doesn't work on Sol

[Dave Page]

Use wxT() instead of _T() which doesn't work on Solaris.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c73b1a97befa6bb98b59f65622da5028ac444b78

Modified Files
--
pgadmin/dd/dditems/figures/ddColumnKindIcon.cpp|2 +-
pgadmin/dd/dditems/locators/ddAddColLocator.cpp|2 +-
.../dd/dditems/locators/ddMinMaxTableLocator.cpp   |2 +-
.../dd/dditems/locators/ddRemoveTableLocator.cpp   |2 +-
.../dditems/locators/ddScrollBarTableLocator.cpp   |2 +-
.../dd/dditems/locators/ddTableBottomLocator.cpp   |2 +-
pgadmin/dd/ddmodel/ddBrowserDataContainer.cpp  |2 +-
pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp   |   24 ++--
pgadmin/dd/ddmodel/ddGenerationWizard.cpp  |   22 ++--
.../connectors/hdStickyRectangleConnector.cpp  |2 +-
.../figures/defaultAttributes/hdFillAttribute.cpp  |2 +-
.../defaultAttributes/hdFontColorAttribute.cpp |2 +-
.../figures/defaultAttributes/hdLineAttribute.cpp  |2 +-
pgadmin/hotdraw/figures/hdAbstractFigure.cpp   |2 +-
pgadmin/hotdraw/figures/hdAttributeFigure.cpp  |2 +-
pgadmin/hotdraw/figures/hdPolyLineFigure.cpp   |2 +-
.../handles/hdChangeConnectionEndHandle.cpp|2 +-
.../handles/hdChangeConnectionStartHandle.cpp  |2 +-
pgadmin/hotdraw/main/hdDrawing.cpp |2 +-
pgadmin/hotdraw/tools/hdCanvasMenuTool.cpp |2 +-
pgadmin/hotdraw/tools/hdPolyLineFigureTool.cpp |2 +-
pgadmin/hotdraw/tools/hdSimpleTextTool.cpp |2 +-
pgadmin/hotdraw/utilities/hdCollection.cpp |2 +-
pgadmin/hotdraw/utilities/hdPoint.cpp  |2 +-
pgadmin/hotdraw/utilities/hdRemoveDeleteDialog.cpp |2 +-
pgadmin/ogl/basic.cpp  |  136 ++--
pgadmin/ogl/bmpshape.cpp   |4 +-
pgadmin/ogl/composit.cpp   |   40 +++---
pgadmin/ogl/drawn.cpp  |   52 
pgadmin/ogl/lines.cpp  |   22 ++--
pgadmin/ogl/ogldiag.cpp|   60 -
pgadmin/pgAdmin3.cpp   |2 +-
32 files changed, 204 insertions(+), 204 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Debugger Redesign

[Dave Page]

Thanks, applied.


On Thu, Jun 20, 2013 at 11:07 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> Hi Dave,
>
> Please find the patch to resolve few of the problems with the debuggers
> and introduced during redesigning it.
>
> On Tue, Apr 30, 2013 at 12:56 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Tue, Apr 30, 2013 at 12:48 AM, Dave Page  wrote:
>>
>>> On Mon, Apr 29, 2013 at 8:10 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Mon, Apr 29, 2013 at 10:30 PM, Dave Page  wrote:

> Thanks Ashesh - committed (with a few minor tweaks, mostly to
> messages)! Good work :-)
>
 Thanks

>
> I think we have the following issues to discuss and possibly resolve
> during beta:
>
> 1) I find the progress dialogue annoying, and as discussed previously
> think we should replace it with a progress indicator on the status bar.
>
 Yeah - I am aware of that.
  I will work on it once I get some time.

>
> 2) I don't see RAISE DEBUG messages in the server message pane.
> Perhaps we should explicitly set client_min_messages so the user can see
> their debug messages?
>
 Yup

>>> Done.
>
>>
> 3) The stack pane shows functions as
> "foo(integer)(param_name=1)@". I think perhaps we should change it
> to: "foo(integer param_name=1)@"
>
 +1

>>>
>>> OK, please make those tweaks when you work on the progress indicator (or
>>> before, if you get a chance).
>>>
>>>

> 4) When in-process debugging, if the calling process is terminated we
> get a connection lost error (which I special-cased in the code, as it
> displays an unsightly message from the plugin by default). Instead, I 
> think
> we should just automatically start listening for another calling process.
>
 The problem is: this error message is coming from backend (debugger
 plugin).
 And hence, it may require us to make changes in the plugin.

>>>
>>>  Shouldn't do - don't we just need to reset the breakpoint and wait for
>>> it to be hit again? FYI, the old code does seem to do it successfully,
>>> though it doesn't do a good job of ensuring the dialogues are re-displayed.
>>>
>> It was ignore any error in the debugging connection (even if it is a
>> connection error or something else).
>> I will come up with some other way to figure out the same. (I will also
>> take care of this, when doing the modification for the progress bar. Hope -
>> that's ok with everybody).
>>
> Done.
> Now - we check for the session (backend) on which the target was running,
> if it does not exist, we wait for another session to invoke the target.
>
> Also - resolved couple of other problem related to the debugger:
> - On cancellation of progress dialog, it was not closing the debugger.
> - In direct debugging, the target was invoked without taking care about
> quotes.
>
> This patch also includes couple of other issues introduced by the earlier
> patch.
> 1. Showing the messages multiple times in the message window (Query window)
> 2. Cancellation of query wasn't working on Query window.
>
> Still working on the progress-bar.
>
>>
>>> Thanks!
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>>
>> --
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL 
>> Company
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>
>
>
> *http://www.linkedin.com/in/asheshvashi*
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin III commit: Check for the session (backend) on which the target

[Dave Page]

Check for the session (backend) on which the target was running, if it does not 
exist, we wait for another session to invoke the target.

Also - resolved couple of other problem related to the debugger:
- On cancellation of progress dialog, it was not closing the debugger.
- In direct debugging, the target was invoked without taking care about quotes.

This patch also includes couple of other issues introduced by the earlier patch.
1. Showing the messages multiple times in the message window (Query window)
2. Cancellation of query wasn't working on Query window.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d5b4002caf858cdf4d0daad353b5a41bb5cdf197
Author: Ashesh Vashi 

Modified Files
--
pgadmin/ctl/ctlSQLResult.cpp |   23 +-
pgadmin/db/pgQueryThread.cpp |  129 --
pgadmin/debugger/dbgController.cpp   |6 ++
pgadmin/debugger/dbgEvents.cpp   |   45 ++-
pgadmin/debugger/dbgTargetInfo.cpp   |4 +-
pgadmin/frm/frmQuery.cpp |4 +
pgadmin/include/db/pgQueryThread.h   |4 +
pgadmin/include/debugger/dbgController.h |4 +
8 files changed, 187 insertions(+), 32 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgadmin-support] bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane

[Ashesh Vashi]

Hi Timon,

I've sent patch to Dave (and, pgadmin-hackers) and he already checked-in.

Can you please confirm both the behavior with the latest code?
(1. Repeated messages and 2. Cancellation on Query Execution)

If you can spend some time, that will be very helpful.

On Tue, Jun 18, 2013 at 2:16 PM, Ashesh Vashi  wrote:

> Thanks Timon for point out.
> I already know about this - I've made that mistake and will resolve it
> very soon.
> Made some changes in pgQueryThread class, which leads to this bug.
>
> Actually - I was busy with some other stuff, and couldn't spend time on
> pgadmin3.
>
> On Tue, Jun 18, 2013 at 2:05 PM, Timon  wrote:
>
>> seems that commit 140e8aee4cb5d423bb76ad81874e442d3e17b5c1 (Rewrite
>> the debugger to resolve numerous known issues and instabilities mostly
>> due to the threading code.) also broke ability to cancel query by
>> pressing stop button in query editor
>>
>> 2013/5/16 Dave Page :
>> > Ashesh - this appears to be related to the debugger changes. Can you
>> > take a look please?
>> >
>> > Thanks.
>> >
>> > On Thu, May 16, 2013 at 2:07 PM, Gabriele Franch  wrote:
>> >> Hello,
>> >> I'm using pgadmin 1.18.0 Alpha 1 (compiled from
>> >>
>> http://ftp.postgresql.org/pub/pgadmin3/release/v1.18.0-alpha1/src/pgadmin3-1.18.0-alpha1.tar.gz
>> ).
>> >>
>> >> Messages are repeated multiple times in messages pane. Version 1.16.1
>> >> does not expose this behavior.
>> >>
>> >> Example SQL:
>> >>
>> >> DROP FUNCTION IF EXISTS raise_something () CASCADE;
>> >> CREATE OR REPLACE FUNCTION raise_something ()
>> >> RETURNS VOID AS
>> >> $BODY$
>> >> BEGIN
>> >>  RAISE WARNING 'Something';
>> >>  RAISE NOTICE 'Something else';
>> >> END
>> >> $BODY$
>> >> LANGUAGE plpgsql;
>> >>
>> >> select * from raise_something();
>> >>
>> >> Gabriele Franch
>> >>
>> >> --
>> >> Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
>> >> To make changes to your subscription:
>> >> http://www.postgresql.org/mailpref/pgadmin-support
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> >
>> > --
>> > Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
>> > To make changes to your subscription:
>> > http://www.postgresql.org/mailpref/pgadmin-support
>>
>>
>>
>> --
>> All bugs reserved
>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>
>
> *http://www.linkedin.com/in/asheshvashi*
>
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


*http://www.linkedin.com/in/asheshvashi*

Re: [pgadmin-hackers] PATCH: Debugger Redesign

[Ashesh Vashi]

Here is one more patch.
This patch includes modification related to replacing the progress dialog
with a progress bar in the statusbar.

On Thu, Jun 20, 2013 at 7:13 PM, Dave Page  wrote:

> Thanks, applied.
>
>
>
> On Thu, Jun 20, 2013 at 11:07 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Please find the patch to resolve few of the problems with the debuggers
>> and introduced during redesigning it.
>>
>> On Tue, Apr 30, 2013 at 12:56 AM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> On Tue, Apr 30, 2013 at 12:48 AM, Dave Page  wrote:
>>>
 On Mon, Apr 29, 2013 at 8:10 PM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> On Mon, Apr 29, 2013 at 10:30 PM, Dave Page  wrote:
>
>> Thanks Ashesh - committed (with a few minor tweaks, mostly to
>> messages)! Good work :-)
>>
> Thanks
>
>>
>> I think we have the following issues to discuss and possibly resolve
>> during beta:
>>
>> 1) I find the progress dialogue annoying, and as discussed previously
>> think we should replace it with a progress indicator on the status bar.
>>
> Yeah - I am aware of that.
>  I will work on it once I get some time.
>
>>
>> 2) I don't see RAISE DEBUG messages in the server message pane.
>> Perhaps we should explicitly set client_min_messages so the user can see
>> their debug messages?
>>
> Yup
>
 Done.
>>
>>>
>> 3) The stack pane shows functions as
>> "foo(integer)(param_name=1)@". I think perhaps we should change it
>> to: "foo(integer param_name=1)@"
>>
> +1
>

 OK, please make those tweaks when you work on the progress indicator
 (or before, if you get a chance).


>
>> 4) When in-process debugging, if the calling process is terminated we
>> get a connection lost error (which I special-cased in the code, as it
>> displays an unsightly message from the plugin by default). Instead, I 
>> think
>> we should just automatically start listening for another calling process.
>>
> The problem is: this error message is coming from backend (debugger
> plugin).
> And hence, it may require us to make changes in the plugin.
>

  Shouldn't do - don't we just need to reset the breakpoint and wait for
 it to be hit again? FYI, the old code does seem to do it successfully,
 though it doesn't do a good job of ensuring the dialogues are re-displayed.

>>> It was ignore any error in the debugging connection (even if it is a
>>> connection error or something else).
>>> I will come up with some other way to figure out the same. (I will also
>>> take care of this, when doing the modification for the progress bar. Hope -
>>> that's ok with everybody).
>>>
>> Done.
>> Now - we check for the session (backend) on which the target was running,
>> if it does not exist, we wait for another session to invoke the target.
>>
>> Also - resolved couple of other problem related to the debugger:
>> - On cancellation of progress dialog, it was not closing the debugger.
>> - In direct debugging, the target was invoked without taking care about
>> quotes.
>>
>> This patch also includes couple of other issues introduced by the earlier
>> patch.
>> 1. Showing the messages multiple times in the message window (Query
>> window)
>> 2. Cancellation of query wasn't working on Query window.
>>
>> Still working on the progress-bar.
>>
>>>
 Thanks!

 --
 Dave Page
 Blog: http://pgsnake.blogspot.com
 Twitter: @pgsnake

 EnterpriseDB UK: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

>>>
>>>
>>>
>>> --
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL 
>>> Company
>>>
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL 
>> Company
>>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


debugger_progress_bar.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Re: [pgadmin-support] bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane

[Timon]

i have tested it already, and it works great. Both problems are solved.
Thank you for your work :)


2013/6/20 Ashesh Vashi 

> Hi Timon,
>
> I've sent patch to Dave (and, pgadmin-hackers) and he already checked-in.
>
> Can you please confirm both the behavior with the latest code?
> (1. Repeated messages and 2. Cancellation on Query Execution)
>
> If you can spend some time, that will be very helpful.
>
> On Tue, Jun 18, 2013 at 2:16 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Thanks Timon for point out.
>> I already know about this - I've made that mistake and will resolve it
>> very soon.
>> Made some changes in pgQueryThread class, which leads to this bug.
>>
>> Actually - I was busy with some other stuff, and couldn't spend time on
>> pgadmin3.
>>
>> On Tue, Jun 18, 2013 at 2:05 PM, Timon  wrote:
>>
>>> seems that commit 140e8aee4cb5d423bb76ad81874e442d3e17b5c1 (Rewrite
>>> the debugger to resolve numerous known issues and instabilities mostly
>>> due to the threading code.) also broke ability to cancel query by
>>> pressing stop button in query editor
>>>
>>> 2013/5/16 Dave Page :
>>> > Ashesh - this appears to be related to the debugger changes. Can you
>>> > take a look please?
>>> >
>>> > Thanks.
>>> >
>>> > On Thu, May 16, 2013 at 2:07 PM, Gabriele Franch 
>>> wrote:
>>> >> Hello,
>>> >> I'm using pgadmin 1.18.0 Alpha 1 (compiled from
>>> >>
>>> http://ftp.postgresql.org/pub/pgadmin3/release/v1.18.0-alpha1/src/pgadmin3-1.18.0-alpha1.tar.gz
>>> ).
>>> >>
>>> >> Messages are repeated multiple times in messages pane. Version 1.16.1
>>> >> does not expose this behavior.
>>> >>
>>> >> Example SQL:
>>> >>
>>> >> DROP FUNCTION IF EXISTS raise_something () CASCADE;
>>> >> CREATE OR REPLACE FUNCTION raise_something ()
>>> >> RETURNS VOID AS
>>> >> $BODY$
>>> >> BEGIN
>>> >>  RAISE WARNING 'Something';
>>> >>  RAISE NOTICE 'Something else';
>>> >> END
>>> >> $BODY$
>>> >> LANGUAGE plpgsql;
>>> >>
>>> >> select * from raise_something();
>>> >>
>>> >> Gabriele Franch
>>> >>
>>> >> --
>>> >> Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org
>>> )
>>> >> To make changes to your subscription:
>>> >> http://www.postgresql.org/mailpref/pgadmin-support
>>> >
>>> >
>>> >
>>> > --
>>> > Dave Page
>>> > Blog: http://pgsnake.blogspot.com
>>> > Twitter: @pgsnake
>>> >
>>> > EnterpriseDB UK: http://www.enterprisedb.com
>>> > The Enterprise PostgreSQL Company
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-support
>>>
>>>
>>>
>>> --
>>> All bugs reserved
>>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL 
>> Company
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>
>
> *http://www.linkedin.com/in/asheshvashi*
>



-- 
All bugs reserved

[pgadmin-hackers] Re: [pgadmin-support] bug: repeated messages in pgadmin (1.18.0 Alpha 1) query tool messages pane

[Ashesh Vashi]

On Fri, Jun 21, 2013 at 10:11 AM, Timon  wrote:

> i have tested it already, and it works great. Both problems are solved.
> Thank you for your work :)
>
Thanks a lot.
That's a relief for me. :-)

>
>
> 2013/6/20 Ashesh Vashi 
>
>> Hi Timon,
>>
>> I've sent patch to Dave (and, pgadmin-hackers) and he already checked-in.
>>
>> Can you please confirm both the behavior with the latest code?
>> (1. Repeated messages and 2. Cancellation on Query Execution)
>>
>> If you can spend some time, that will be very helpful.
>>
>> On Tue, Jun 18, 2013 at 2:16 PM, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>>
>>> Thanks Timon for point out.
>>> I already know about this - I've made that mistake and will resolve it
>>> very soon.
>>> Made some changes in pgQueryThread class, which leads to this bug.
>>>
>>> Actually - I was busy with some other stuff, and couldn't spend time on
>>> pgadmin3.
>>>
>>> On Tue, Jun 18, 2013 at 2:05 PM, Timon  wrote:
>>>
 seems that commit 140e8aee4cb5d423bb76ad81874e442d3e17b5c1 (Rewrite
 the debugger to resolve numerous known issues and instabilities mostly
 due to the threading code.) also broke ability to cancel query by
 pressing stop button in query editor

 2013/5/16 Dave Page :
 > Ashesh - this appears to be related to the debugger changes. Can you
 > take a look please?
 >
 > Thanks.
 >
 > On Thu, May 16, 2013 at 2:07 PM, Gabriele Franch 
 wrote:
 >> Hello,
 >> I'm using pgadmin 1.18.0 Alpha 1 (compiled from
 >>
 http://ftp.postgresql.org/pub/pgadmin3/release/v1.18.0-alpha1/src/pgadmin3-1.18.0-alpha1.tar.gz
 ).
 >>
 >> Messages are repeated multiple times in messages pane. Version 1.16.1
 >> does not expose this behavior.
 >>
 >> Example SQL:
 >>
 >> DROP FUNCTION IF EXISTS raise_something () CASCADE;
 >> CREATE OR REPLACE FUNCTION raise_something ()
 >> RETURNS VOID AS
 >> $BODY$
 >> BEGIN
 >>  RAISE WARNING 'Something';
 >>  RAISE NOTICE 'Something else';
 >> END
 >> $BODY$
 >> LANGUAGE plpgsql;
 >>
 >> select * from raise_something();
 >>
 >> Gabriele Franch
 >>
 >> --
 >> Sent via pgadmin-support mailing list (
 pgadmin-supp...@postgresql.org)
 >> To make changes to your subscription:
 >> http://www.postgresql.org/mailpref/pgadmin-support
 >
 >
 >
 > --
 > Dave Page
 > Blog: http://pgsnake.blogspot.com
 > Twitter: @pgsnake
 >
 > EnterpriseDB UK: http://www.enterprisedb.com
 > The Enterprise PostgreSQL Company
 >
 >
 > --
 > Sent via pgadmin-support mailing list (pgadmin-supp...@postgresql.org
 )
 > To make changes to your subscription:
 > http://www.postgresql.org/mailpref/pgadmin-support



 --
 All bugs reserved
>>>
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL 
>>> Company
>>>
>>>
>>> *http://www.linkedin.com/in/asheshvashi*
>>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL 
>> Company
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>>
>
>
>
> --
> All bugs reserved
>



-- 
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*