Re: [pgadmin-hackers] pgadmin3.hhp.cached

2013-07-22 Thread Dave Page 
On Fri, Jul 19, 2013 at 10:29 PM, Richard PALO  wrote:
> I needed to undo the following workaround put in Makefile.am:
>>
>>  # We need to ensure the help cache is world writeable
>>  install-data-hook:
>> -   touch $(help_dir)/docs/en_US/pgadmin3.hhp.cached
>> -   chmod 0666 $(help_dir)/docs/en_US/pgadmin3.hhp.cached
>> +#  touch $(help_dir)/docs/en_US/pgadmin3.hhp.cached
>> +#  chmod 0666 $(help_dir)/docs/en_US/pgadmin3.hhp.cached
>
>
> Is there not a better solution?

Why did you need to undo it? It's not really a workaround - that file
needs to be world writeable otherwise users that can't write to it
will get an error when they open the helpfile (that's a wxWidgets
requirement).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Fixed some minor issues in frmImport

2013-07-22 Thread Akshay Joshi 
Hi Dave

I have fixed following minor issues in frmImport class

   - Unable to open the help when clicked on Help button of Import dialog.
   - Fixed syntax error when deselect all the column and click on "Import"
   button. I have put a message box to fix the issue.

Please review it and if looks good, can you please commit it.

-- 
*Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246*


frmImport.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

2013-07-22 Thread Akshay Joshi 
Hi Dinesh

I have just started reviewing your code and found on issue where any
changes made on Event Trigger dialog won't be saved. After looking at the
code, you haven't override the ::OnOK() function in dlgEventTrigger.cpp.
Can you please fix this and resend the new patch.


On Wed, Jul 10, 2013 at 9:46 PM, Dinesh Kumar  wrote:

>
>  Yes, we can change this enable check box as a radio button. But,
>>> "REPLICA/ALWAYS" are two enable's properties. Hence, We have implemented
>>> this in the proposed way. Kindly share your opinion on this.
>>>
>>
>> So: "Enabled Replica ( ) Enabled Always ( ) Disabled ( )" ?
>>
>
> Yes Dave.
>
>
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co 
> m
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, 
> whitepapers and
> more 
>



-- 
*Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246*

[pgadmin-hackers] Search Object dialog Help button issue

2013-07-22 Thread Dhiraj Chawla 
Hi Dave,

It was noticed that on clicking the Help button on the Search Object
dialog, the Help dialog was not opening the correct help page related to
Search Object dialog. Attached is a patch that fixes this issue.

Let me know in case of any concerns with the attached patch.

Thanks,

-- 
regards,

*Dhiraj Chawla*
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522


search_object_help_fix.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix path the the Search Objects help doc.

2013-07-22 Thread Dave Page 
Fix path the the Search Objects help doc.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=c076a972576b85747d28900f3997c6eb9cfc6473
Author: Dhiraj Chawla 

Modified Files
--
CHANGELOG   |1 +
pgadmin/dlg/dlgSearchObject.cpp |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix path the the Search Objects help doc.

2013-07-22 Thread Dave Page 
Fix path the the Search Objects help doc.

Conflicts:
CHANGELOG

Branch
--
REL-1_16_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=337815b78312c757aa45bae472f2ac0ddc087ce2
Author: Dhiraj Chawla 

Modified Files
--
CHANGELOG   |1 +
pgadmin/dlg/dlgSearchObject.cpp |2 +-
2 files changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Search Object dialog Help button issue

2013-07-22 Thread Dave Page 
Thanks, applied.

On Mon, Jul 22, 2013 at 1:57 PM, Dhiraj Chawla
 wrote:
> Hi Dave,
>
> It was noticed that on clicking the Help button on the Search Object dialog,
> the Help dialog was not opening the correct help page related to Search
> Object dialog. Attached is a patch that fixes this issue.
>
> Let me know in case of any concerns with the attached patch.
>
> Thanks,
>
> --
> regards,
>
> Dhiraj Chawla
> Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
> Phone: +91-20-30589522



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix the help path on the import dialogue and improv

2013-07-22 Thread Dave Page 
Fix the help path on the import dialogue and improve the error handling.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=18604f0827db2788c24961216218cc2db366f10c
Author: Akshay Joshi 

Modified Files
--
CHANGELOG   |2 ++
pgadmin/frm/frmImport.cpp   |   17 +++--
pgadmin/include/frm/frmImport.h |2 +-
3 files changed, 14 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix the help path on the import dialogue and improv

2013-07-22 Thread Dave Page 
Fix the help path on the import dialogue and improve the error handling.

Branch
--
REL-1_16_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f6c640646709a5e0b98df5e4bb5e69c54b958834
Author: Akshay Joshi 

Modified Files
--
CHANGELOG   |2 ++
pgadmin/frm/frmImport.cpp   |   17 +++--
pgadmin/include/frm/frmImport.h |2 +-
3 files changed, 14 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Fixed some minor issues in frmImport

2013-07-22 Thread Dave Page 
Thanks, patch applied.

On Mon, Jul 22, 2013 at 10:31 AM, Akshay Joshi
 wrote:
> Hi Dave
>
> I have fixed following minor issues in frmImport class
>
> Unable to open the help when clicked on Help button of Import dialog.
> Fixed syntax error when deselect all the column and click on "Import"
> button. I have put a message box to fix the issue.
>
> Please review it and if looks good, can you please commit it.
>
> --
> Akshay Joshi
> Senior Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
> Phone: +91 20-3058-9522
> Mobile: +91 976-788-8246
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

2013-07-22 Thread Dave Page 
Akshay, please let me know when your review is complete and then I'll take
a look.


On Mon, Jul 22, 2013 at 2:09 PM, Dinesh Kumar  wrote:

> Hi Akshay,
>
> Thank you so much for correcting me on this. It's my bad to forgot the
> naming convention in the code. Now, ::OnOK() is get populating the required
> SQL as per the changes.
>
> Please find the new patch and let me know your valuable inputs.
>
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co 
> m
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, 
> whitepapers and
> more 
>
>
> On Mon, Jul 22, 2013 at 5:58 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dinesh
>>
>> I have just started reviewing your code and found on issue where any
>> changes made on Event Trigger dialog won't be saved. After looking at the
>> code, you haven't override the ::OnOK() function in dlgEventTrigger.cpp.
>> Can you please fix this and resend the new patch.
>>
>>
>> On Wed, Jul 10, 2013 at 9:46 PM, Dinesh Kumar <
>> dinesh.ku...@enterprisedb.com> wrote:
>>
>>>
>>>  Yes, we can change this enable check box as a radio button. But,
> "REPLICA/ALWAYS" are two enable's properties. Hence, We have implemented
> this in the proposed way. Kindly share your opinion on this.
>

 So: "Enabled Replica ( ) Enabled Always ( ) Disabled ( )" ?

>>>
>>> Yes Dave.
>>>
>>>
>>>
>>> Dinesh
>>>
>>> --
>>> *Dinesh Kumar*
>>> Software Engineer
>>>
>>> Ph: +918087463317
>>> Skype ID: dinesh.kumar432
>>> www.enterprisedb.co 
>>> m
>>> *
>>> Follow us on Twitter*
>>> @EnterpriseDB
>>>
>>> Visit EnterpriseDB for tutorials, webinars, 
>>> whitepapers and
>>> more 
>>>
>>
>>
>>
>> --
>> *Akshay Joshi
>> Senior Software Engineer
>> EnterpriseDB Corporation
>> The Enterprise PostgreSQL Company
>> Phone: +91 20-3058-9522
>> Mobile: +91 976-788-8246*
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Search Object dialog Help button issue

2013-07-22 Thread Dhiraj Chawla 
Thanks Dave.


On Mon, Jul 22, 2013 at 6:37 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Mon, Jul 22, 2013 at 1:57 PM, Dhiraj Chawla
>  wrote:
> > Hi Dave,
> >
> > It was noticed that on clicking the Help button on the Search Object
> dialog,
> > the Help dialog was not opening the correct help page related to Search
> > Object dialog. Attached is a patch that fixes this issue.
> >
> > Let me know in case of any concerns with the attached patch.
> >
> > Thanks,
> >
> > --
> > regards,
> >
> > Dhiraj Chawla
> > Software Engineer
> > EnterpriseDB Corporation
> > The Enterprise PostgreSQL Company
> >
> > Phone: +91-20-30589522
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
regards,

*Dhiraj Chawla*
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522

[pgadmin-hackers] pgAdmin III commit: Avoid using a Help cache file that needs to be worl

2013-07-22 Thread Dave Page 
Avoid using a Help cache file that needs to be world writeable, and ensure sed 
is happy when post-processing helpfiles.

Branch
--
REL-1_16_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=02a0b814ca3714a5fc7f34c51b44f6aab51b951c

Modified Files
--
CHANGELOG  |3 +++
Makefile.am|5 +
pgadmin/utils/misc.cpp |2 --
3 files changed, 4 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Avoid using a Help cache file that needs to be worl

2013-07-22 Thread Dave Page 
Avoid using a Help cache file that needs to be world writeable, and ensure sed 
is happy when post-processing helpfiles.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=fb53e8357eb9772db2d1b14c8a531c7908e5b442

Modified Files
--
CHANGELOG  |3 +++
Makefile.am|5 +
pgadmin/utils/misc.cpp |2 --
3 files changed, 4 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers