[pgadmin-hackers] pgAdmin website commit: Cleanup of styling and additional cleanup.

2013-09-06 Thread Dave Page 
Cleanup of styling and additional cleanup.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=c054c39570d143e8026300e70e6258a9497cc3ee
Author: Shish Tukay 

Modified Files
--
css/pgadmin-base.css  |  308 +
css/pgadmin-ltr.css   |  276 +---
css/pgadmin-rtl.css   |  275 ---
include/page.php  |   26 ++---
screenshots/index.php |   20 +++-
screenshots/menu.php  |2 +-
6 files changed, 337 insertions(+), 570 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Some website tweaks

2013-09-06 Thread Dave Page 
Thanks - patch applied!!

On Thu, Sep 5, 2013 at 2:57 PM, Shish  wrote:
>> Can you send a patch against git-head please?
>
> I'm not sure how you like your patches, have attached something which is a
> patch of some sort, from git head to my own head. Individual changes are in
> the repo --> https://github.com/shish/pgadmin-www/commits/master
>
>
>
>>> I'm also considering updating the screenshots themselves
>>> [...] I figured I'd see if anyone cares first
>
>>
>> I'm happy to accept appropriate patches though, if you are able
>> to put the effort in. Thanks!
>
> Right'o; my lunch break is over, but will see if I can get round to it later
> :)
>
> -- Shish



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Tag REL-1_18_0 has been created.

2013-09-06 Thread Dave Page 
Tag REL-1_18_0 has been created.
View: 
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=tag;h=refs/tags/REL-1_18_0

Log Message
---
Tag 1.18.0
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix a memory leak in the Event Trigger code.

2013-09-06 Thread Dave Page 
Fix a memory leak in the Event Trigger code.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=7e817b7c87a01cd578cb278f17d773194499861b
Author: Dinesh Kumar 

Modified Files
--
CHANGELOG   |2 ++
pgadmin/frm/frmMain.cpp |   17 -
pgadmin/include/schema/pgEventTrigger.h |1 +
pgadmin/schema/pgEventTrigger.cpp   |   10 +++---
4 files changed, 26 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin Event Trigger Compatibility

2013-09-06 Thread Dave Page 
Hmm, I can't reproduce it now either. Oh well, thanks for checking. Patch
applied!


On Thu, Sep 5, 2013 at 6:27 PM, Dinesh Kumar
wrote:

> Hi Dave,
>
> Sorry for the big delay on this issue.
>
> I have tried to re-produce the above case in mac but unfortunately i am
> not able to re-produce it. I have followed the below steps to reproduce the
> case.
>
> 1) Got the new pgAdmin's master branch.
>
> 2) Applied the given patch.
>
> 3) Created a new event trigger function under the schema.
>
> 4) Created new event trigger.
>
> 5) Modified the created event trigger function's comment from the schema
> node.
>
> 6) Clicked on "OK".
>
> The above steps are working fine.
>
> Kindly let me know, if i miss anything here.
>
> Thanks in advance.
>
> Dinesh
>
> --
> *Dinesh Kumar*
> Software Engineer
>
> Ph: +918087463317
> Skype ID: dinesh.kumar432
> www.enterprisedb.co 
> m
> *
> Follow us on Twitter*
> @EnterpriseDB
>
> Visit EnterpriseDB for tutorials, webinars, 
> whitepapers and
> more 
>
>
> On Wed, Jul 31, 2013 at 6:27 PM, Dinesh Kumar <
> dinesh.ku...@enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> Thanks for your inputs.
>>
>> On Wed, Jul 31, 2013 at 6:00 PM, Dave Page  wrote:
>>
>>> Hi
>>>
>>> On Tue, Jul 30, 2013 at 5:16 PM, Dinesh Kumar
>>>  wrote:
>>> > Hi Dave,
>>> >
>>> > On Mon, Jul 29, 2013 at 9:22 PM, Dave Page  wrote:
>>> >>
>>> >> Hi
>>> >>
>>> >>
>>> >> On Fri, Jul 26, 2013 at 5:58 PM, Dinesh Kumar
>>> >>  wrote:
>>> >>>
>>> >>> Hi Dave,
>>> >>>
>>> >>> Thanks for committing the patch.
>>> >>>
>>> >>> I have found one memory leak issue in the previous implementation and
>>> >>> would like to submit this new patch on top of the
>>> Pg_Event_Trigger_V5.patch.
>>> >>> Please find the below attached patch and valgrind output and let me
>>> know
>>> >>> your inputs and suggestions.
>>> >>
>>>
>> I have applied this patch and tested in windows and linux with the above
>> steps. But, it's not get crashing in windows/linux.
>>
>> Apologizes, i haven't tested this in Mac. Let me setup pgAdmin build in
>> mac, and will try to fix this issue as well.
>>
>> Thank you once again.
>>
>>  >>
>>> >> OK. Some comments:
>>> >>
>>> >> +if(newData->GetMetaType() == PGM_SCHEMA &&
>>> !newData->IsCollection())
>>> >> +{
>>> >> +doNeedEvtTrgRefresh = true;
>>> >> +}
>>> >> +
>>> >> + // Event trigger's backend functions are at schema level.
>>> >> + // Hence, we can consider the Event Triggers are partially belongs
>>> to at
>>> >> schema level.
>>> >> + // So, if any schema got refreshed, we are refreshing the event
>>> trigger
>>> >> collection as like schema's object.
>>> >> + // It's a special case, which effects the schema operations on the
>>> event
>>> >> triggers as well.
>>> >> + //
>>> >> +if (doNeedEvtTrgRefresh)
>>> >> +{
>>> >> +doNeedEvtTrgRefresh = false;
>>> >> +
>>> >>
>>> Refresh(browser->GetObject(browser->GetNextSibling(browser->GetItemParent(browser->GetSelection();
>>> >> +}
>>> >>
>>> >> * Why both with the
>>> >> doNeedEvtTrgRefresh flag here? As it's not used anywhere else, why not
>>> >> just put the Refresh() call into the first conditional?
>>> >>
>>> > Yes, True. There is no need of Flag doNeedEvtTrgRefresh.
>>> >
>>> >
>>> >>
>>> >> * I assume the Refresh call is there to find the "Event Triggers"
>>> node and
>>> >> refresh it? If so, there's no guarantee that the next sibling will
>>> actually
>>> >> be the event triggers node - in the future, we may add a new node
>>> type that
>>> >> sits in that position, or the user may have enabled or disabled some
>>> node
>>> >> types, including Event Triggers.
>>> >>
>>> > Ah. Thanks Dave for your suggestions. I have followed another approach
>>> to
>>> > fix this issue. Kindly check this latest patch and share you inputs and
>>> > suggestions. This patch also fixes the memory leak and schema refresh
>>> > activities.
>>> >
>>> >> * The same comment as above applies to browser->GetPrevSibling().
>>> >>
>>> > Thanks Dave.
>>>
>>> I tweaked the patch to clarify the comments and some variable names
>>> (see attached), then tested it by changing the comment on an event
>>> trigger function from under the schema. I got the following crash
>>> after clicking OK:
>>>
>>> Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
>>> 0   libwx_base_carbonu-2.8.0.dylib 0x0158cc8a wxListBase::Clear() + 78
>>> 1   libwx_macu_core-2.8.0.dylib   0x011ae948
>>> wxListLineData::~wxListLineData() + 72
>>> 2   libwx_macu_core-2.8.0.dylib   0x011a7105
>>> wxListMainWindow::DoDeleteAllItems() + 527
>>> 3   libwx_macu_core-2.8.0.dylib   0x011ac54c
>>> wxListMainWindow::DeleteEverything() + 120
>>> 4   libwx_macu_core-2.8.0.dylib   0x011ac57b
>>> wxGenericListCtrl::ClearAll() + 23
>>> 5   libwx_macu_core-2.8.0.

[pgadmin-hackers] pgAdmin III commit: There won't be a pgAdmin 1.16.2, so all bugs marked

2013-09-06 Thread Dave Page 
There won't be a pgAdmin 1.16.2, so all bugs marked as fixed in it are actually 
fixed in 1.18.0

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=20de7dd01edfd5a2009593fae6606bdc7a98f72d

Modified Files
--
CHANGELOG |   74 ++---
1 file changed, 37 insertions(+), 37 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers