Re: [pgadmin-hackers] Bug report: OIDs, roles and Windows (signedness issue?)
2013/11/22 Ian Lawrence Barwick :
>>
>> BTW other objects (tables, schemas etc.) with OIDs greater than 256^4/2 - 1
>> don't seem to be affected by this.
>
> It's been a while since I've looked at the pgAdmin source, but some wild
> grepping shows that in:
>
> pgadmin/schema/pgRole.cpp
>
> the role OID is set with:
>
> role->iSetOid(roles->GetLong(wxT("oid")));
>
> whereas almost everywhere else it's set with GetOid(), e.g.
>
> table->iSetOid(tables->GetOid(wxT("oid")));
>
> which may or may not have something to do with the issue.
If that is the problem, then here's a patch. Untested as I don't have a Windows
build environment available, though I might be able to cobble one together
next week.
Regards
Ian Barwick
pgadmin-role-oid.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Fixed database statistics report issue
Hi On Fri, Nov 22, 2013 at 11:18 AM, Akshay Joshi < akshay.jo...@enterprisedb.com> wrote: > Hi Dave > > I have fixed one issue where Database statistics table goes beyond the > page headers. Below is the steps to reproduce it > > 1. Connect to database server. > 2. Right click on "Databases" root node. > 3. Choose Reports->Statistics Report. > 4. And give any location for that report. > 5. Then it's showing the statistics tables as like the attached screenshot. > > Attached is the patch file to fix the issue, also attached the screenshot > of the report after fixing the issue. Can you please review it. If fix > looks good to you then can you please commit it. > Can you please fix: - The indenting, so that the contents of the new div are properly indented (as you've added a level to the document hierarchy). - The default-xsl.rst file in the docs, so it matches the new default. Otherwise, I think it looks fine. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
