[pgadmin-hackers] pgAdmin III commit: Resolved an issue related enable/disable menu items

2015-09-22 Thread Ashesh Vashi 
Resolved an issue related enable/disable menu items in Query Editor
specifically for Unity Desktop Environment.

wxWidgets was not able to identify the current focused control in some
cases, during certain event generation. And, that was resulting into
disabling the wrong menu items.
i.e.
Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)

In order to resolve the issue, we will not consider the events
generated, but - no control gets focused, while enabling/disabling the
menus.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83

Modified Files
--
CHANGELOG|3 +++
pgadmin/frm/frmQuery.cpp |   59 +++---
2 files changed, 38 insertions(+), 24 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

2015-09-22 Thread Prasad Somwanshi 
Good. Still surprised that nobody encountered it so far. It would have nice, if 
I got a mention in commit log , :(

regards,
Prasad


 
 

Sent: Tuesday, September 22, 2015 at 6:50 AM
From: "Ashesh Vashi" 
To: "Prasad Somwanshi" 
Cc: pgadmin-hackers 
Subject: Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

Done.

 

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company[http://www.enterprisedb.com]
 
http://www.linkedin.com/in/asheshvashi[http://www.linkedin.com/in/asheshvashi]


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgadmin4 setup.py, first time run

2015-09-22 Thread Ashesh Vashi 
On Tue, Sep 22, 2015 at 3:39 PM, Prasad Somwanshi  wrote:

> Good. Still surprised that nobody encountered it so far.
>
It would have nice, if I got a mention in commit log , :(
>
I sure - you will be for your contribution in future.
Please keep contributing.

Thanks once again.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



>
> regards,
> Prasad
>
>
>
>
>
> Sent: Tuesday, September 22, 2015 at 6:50 AM
> From: "Ashesh Vashi" 
> To: "Prasad Somwanshi" 
> Cc: pgadmin-hackers 
> Subject: Re: [pgadmin-hackers] pgadmin4 setup.py, first time run
>
> Done.
>
>
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company[
> http://www.enterprisedb.com]
>
>
> http://www.linkedin.com/in/asheshvashi[http://www.linkedin.com/in/asheshvashi]
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

[pgadmin-hackers] pgAdmin III commit: Bump version number for beta 1 release.

2015-09-22 Thread Dave Page 
Bump version number for beta 1 release.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f2da55842525d45250bd6f39d087155d4fdc1080

Modified Files
--
pgadmin/include/version.h |8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Move files into relevent project folders.

2015-09-22 Thread Dave Page 
Move files into relevent project folders.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=76daa665593787b521a322b7c3aff60a503fcb01

Modified Files
--
pgadmin/pgAdmin3.vcxproj.filters |   16 
1 file changed, 12 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Copyright updates.

2015-09-22 Thread Dave Page 
Copyright updates.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cda20be9cff1edb68e6af50ed311693190ea7bc0

Modified Files
--
docs/en_US/licence.rst   |2 +-
pgadmin/Makefile.am  |2 +-
pgadmin/agent/dlgJob.cpp |2 +-
pgadmin/agent/dlgSchedule.cpp|2 +-
pgadmin/agent/dlgStep.cpp|2 +-
pgadmin/agent/module.mk  |2 +-
pgadmin/agent/pgaJob.cpp |2 +-
pgadmin/agent/pgaSchedule.cpp|2 +-
pgadmin/agent/pgaStep.cpp|2 +-
pgadmin/ctl/calbox.cpp   |2 +-
pgadmin/ctl/ctlAuiNotebook.cpp   |2 +-
pgadmin/ctl/ctlCheckTreeView.cpp |2 +-
pgadmin/ctl/ctlColourPicker.cpp  |2 +-
pgadmin/ctl/ctlComboBox.cpp  |2 +-
pgadmin/ctl/ctlDefaultSecurityPanel.cpp  |2 +-
pgadmin/ctl/ctlListView.cpp  |2 +-
pgadmin/ctl/ctlMenuToolbar.cpp   |2 +-
pgadmin/ctl/ctlProgressStatusBar.cpp |2 +-
pgadmin/ctl/ctlSQLBox.cpp|2 +-
pgadmin/ctl/ctlSQLGrid.cpp   |2 +-
pgadmin/ctl/ctlSQLResult.cpp |2 +-
pgadmin/ctl/ctlSeclabelPanel.cpp |2 +-
pgadmin/ctl/ctlSecurityPanel.cpp |2 +-
pgadmin/ctl/ctlTree.cpp  |2 +-
pgadmin/ctl/explainCanvas.cpp|2 +-
pgadmin/ctl/explainShape.cpp |2 +-
pgadmin/ctl/module.mk|2 +-
pgadmin/ctl/timespin.cpp |2 +-
pgadmin/ctl/xh_calb.cpp  |2 +-
pgadmin/ctl/xh_ctlchecktreeview.cpp  |2 +-
pgadmin/ctl/xh_ctlcolourpicker.cpp   |2 +-
pgadmin/ctl/xh_ctlcombo.cpp  |2 +-
pgadmin/ctl/xh_ctltree.cpp   |2 +-
pgadmin/ctl/xh_sqlbox.cpp|2 +-
pgadmin/ctl/xh_timespin.cpp  |2 +-
pgadmin/db/module.mk |2 +-
pgadmin/db/pgConn.cpp|2 +-
pgadmin/db/pgQueryThread.cpp |2 +-
pgadmin/db/pgSet.cpp |2 +-
pgadmin/dd/dditems/figures/ddColumnFigure.cpp|2 +-
pgadmin/dd/dditems/figures/ddColumnKindIcon.cpp  |2 +-
pgadmin/dd/dditems/figures/ddColumnOptionIcon.cpp|2 +-
pgadmin/dd/dditems/figures/ddRelationshipFigure.cpp  |2 +-
pgadmin/dd/dditems/figures/ddRelationshipItem.cpp|2 +-
pgadmin/dd/dditems/figures/ddRelationshipTerminal.cpp|2 +-
pgadmin/dd/dditems/figures/ddTableFigure.cpp |2 +-
pgadmin/dd/dditems/figures/ddTextTableItemFigure.cpp |2 +-
pgadmin/dd/dditems/figures/module.mk |2 +-
pgadmin/dd/dditems/figures/xml/ddXmlStorage.cpp  |2 +-
pgadmin/dd/dditems/handles/ddAddColButtonHandle.cpp  |2 +-
pgadmin/dd/dditems/handles/ddAddFkButtonHandle.cpp   |2 +-
pgadmin/dd/dditems/handles/ddMinMaxTableButtonHandle.cpp |2 +-
pgadmin/dd/dditems/handles/ddRemoveTableButtonHandle.cpp |2 +-
pgadmin/dd/dditems/handles/ddScrollBarHandle.cpp |2 +-
pgadmin/dd/dditems/handles/ddSouthTableSizeHandle.cpp|2 +-
pgadmin/dd/dditems/handles/module.mk |2 +-
pgadmin/dd/dditems/locators/ddAddColLocator.cpp  |2 +-
pgadmin/dd/dditems/locators/ddAddFkLocator.cpp   |2 +-
pgadmin/dd/dditems/locators/ddMinMaxTableLocator.cpp |2 +-
pgadmin/dd/dditems/locators/ddRemoveTableLocator.cpp |2 +-
pgadmin/dd/dditems/locators/ddScrollBarTableLocator.cpp

[pgadmin-hackers] pgAdmin III commit: Final copyright changes.

2015-09-22 Thread Dave Page 
Final copyright changes.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=15c11c3054b7c873cef71e08771e844430948705

Modified Files
--
LICENSE   |4 ++--
Makefile.am   |2 +-
acinclude.m4  |2 +-
bootstrap |2 +-
branding/Makefile.am  |2 +-
configure.ac.in   |2 +-
docs/en_US/conf.py.in |2 +-
i18n/Makefile.am  |2 +-
i18n/pgadmin3.lng |2 +-
languages.hwx |2 +-
pgadmin/dd/dditems/figures/xml/module.mk  |2 +-
pgadmin/debugger/module.mk|2 +-
pgadmin/include/copyright.h   |4 ++--
pgadmin/include/db/pgQueryResultEvent.h   |2 +-
pgadmin/include/debugger/module.mk|2 +-
pgadmin/include/hotdraw/figures/xml/module.mk |2 +-
pgadmin/include/pgscript/module.mk|2 +-
pkg/Makefile.am   |2 +-
pkg/debian/Makefile.am|2 +-
pkg/mac/Makefile.am   |2 +-
pkg/mac/licence.r |2 +-
pkg/mandrake/Makefile.am  |2 +-
pkg/redhat/Makefile.am|2 +-
pkg/slackware/Makefile.am |2 +-
pkg/slackware/build-release.in|2 +-
pkg/slackware/build-snapshot  |2 +-
pkg/src/Makefile.am   |2 +-
pkg/src/build-tarball.in  |2 +-
pkg/suse/Makefile.am  |2 +-
plugins.d/Makefile.am |2 +-
stringextract |2 +-
stringmerge   |2 +-
xtra/Makefile.am  |2 +-
xtra/wx-build/Makefile.am |2 +-
34 files changed, 36 insertions(+), 36 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Final copyright changes.

2015-09-22 Thread Dave Page 
Final copyright changes.

Branch
--
REL-1_20_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ffbcc2f1e3a9ade3ba0ca6cc0ba7963657001194

Modified Files
--
LICENSE   |4 ++--
Makefile.am   |2 +-
acinclude.m4  |2 +-
bootstrap |2 +-
branding/Makefile.am  |2 +-
configure.ac.in   |2 +-
docs/en_US/conf.py.in |2 +-
i18n/Makefile.am  |2 +-
i18n/pgadmin3.lng |2 +-
languages.hwx |2 +-
pgadmin/dd/dditems/figures/xml/module.mk  |2 +-
pgadmin/debugger/module.mk|2 +-
pgadmin/include/copyright.h   |4 ++--
pgadmin/include/db/pgQueryResultEvent.h   |2 +-
pgadmin/include/debugger/module.mk|2 +-
pgadmin/include/hotdraw/figures/xml/module.mk |2 +-
pgadmin/include/pgscript/module.mk|2 +-
pkg/Makefile.am   |2 +-
pkg/debian/Makefile.am|2 +-
pkg/mac/Makefile.am   |2 +-
pkg/mac/licence.r |2 +-
pkg/mandrake/Makefile.am  |2 +-
pkg/redhat/Makefile.am|2 +-
pkg/slackware/Makefile.am |2 +-
pkg/slackware/build-release.in|2 +-
pkg/slackware/build-snapshot  |2 +-
pkg/src/Makefile.am   |2 +-
pkg/src/build-tarball.in  |2 +-
pkg/suse/Makefile.am  |2 +-
plugins.d/Makefile.am |2 +-
stringextract |2 +-
stringmerge   |2 +-
xtra/Makefile.am  |2 +-
xtra/wx-build/Makefile.am |2 +-
34 files changed, 36 insertions(+), 36 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Copyright updates.

2015-09-22 Thread Dave Page 
Copyright updates.

Branch
--
REL-1_20_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=4393125563bffd8ecb8184ea631a8148fdd562b4

Modified Files
--
docs/en_US/licence.rst   |2 +-
pgadmin/Makefile.am  |2 +-
pgadmin/agent/dlgJob.cpp |2 +-
pgadmin/agent/dlgSchedule.cpp|2 +-
pgadmin/agent/dlgStep.cpp|2 +-
pgadmin/agent/module.mk  |2 +-
pgadmin/agent/pgaJob.cpp |2 +-
pgadmin/agent/pgaSchedule.cpp|2 +-
pgadmin/agent/pgaStep.cpp|2 +-
pgadmin/ctl/calbox.cpp   |2 +-
pgadmin/ctl/ctlAuiNotebook.cpp   |2 +-
pgadmin/ctl/ctlCheckTreeView.cpp |2 +-
pgadmin/ctl/ctlColourPicker.cpp  |2 +-
pgadmin/ctl/ctlComboBox.cpp  |2 +-
pgadmin/ctl/ctlDefaultSecurityPanel.cpp  |2 +-
pgadmin/ctl/ctlListView.cpp  |2 +-
pgadmin/ctl/ctlMenuToolbar.cpp   |2 +-
pgadmin/ctl/ctlProgressStatusBar.cpp |2 +-
pgadmin/ctl/ctlSQLBox.cpp|2 +-
pgadmin/ctl/ctlSQLGrid.cpp   |2 +-
pgadmin/ctl/ctlSQLResult.cpp |2 +-
pgadmin/ctl/ctlSeclabelPanel.cpp |2 +-
pgadmin/ctl/ctlSecurityPanel.cpp |2 +-
pgadmin/ctl/ctlTree.cpp  |2 +-
pgadmin/ctl/explainCanvas.cpp|2 +-
pgadmin/ctl/explainShape.cpp |2 +-
pgadmin/ctl/module.mk|2 +-
pgadmin/ctl/timespin.cpp |2 +-
pgadmin/ctl/xh_calb.cpp  |2 +-
pgadmin/ctl/xh_ctlchecktreeview.cpp  |2 +-
pgadmin/ctl/xh_ctlcolourpicker.cpp   |2 +-
pgadmin/ctl/xh_ctlcombo.cpp  |2 +-
pgadmin/ctl/xh_ctltree.cpp   |2 +-
pgadmin/ctl/xh_sqlbox.cpp|2 +-
pgadmin/ctl/xh_timespin.cpp  |2 +-
pgadmin/db/module.mk |2 +-
pgadmin/db/pgConn.cpp|2 +-
pgadmin/db/pgQueryThread.cpp |2 +-
pgadmin/db/pgSet.cpp |2 +-
pgadmin/dd/dditems/figures/ddColumnFigure.cpp|2 +-
pgadmin/dd/dditems/figures/ddColumnKindIcon.cpp  |2 +-
pgadmin/dd/dditems/figures/ddColumnOptionIcon.cpp|2 +-
pgadmin/dd/dditems/figures/ddRelationshipFigure.cpp  |2 +-
pgadmin/dd/dditems/figures/ddRelationshipItem.cpp|2 +-
pgadmin/dd/dditems/figures/ddRelationshipTerminal.cpp|2 +-
pgadmin/dd/dditems/figures/ddTableFigure.cpp |2 +-
pgadmin/dd/dditems/figures/ddTextTableItemFigure.cpp |2 +-
pgadmin/dd/dditems/figures/module.mk |2 +-
pgadmin/dd/dditems/figures/xml/ddXmlStorage.cpp  |2 +-
pgadmin/dd/dditems/handles/ddAddColButtonHandle.cpp  |2 +-
pgadmin/dd/dditems/handles/ddAddFkButtonHandle.cpp   |2 +-
pgadmin/dd/dditems/handles/ddMinMaxTableButtonHandle.cpp |2 +-
pgadmin/dd/dditems/handles/ddRemoveTableButtonHandle.cpp |2 +-
pgadmin/dd/dditems/handles/ddScrollBarHandle.cpp |2 +-
pgadmin/dd/dditems/handles/ddSouthTableSizeHandle.cpp|2 +-
pgadmin/dd/dditems/handles/module.mk |2 +-
pgadmin/dd/dditems/locators/ddAddColLocator.cpp  |2 +-
pgadmin/dd/dditems/locators/ddAddFkLocator.cpp   |2 +-
pgadmin/dd/dditems/locators/ddMinMaxTableLocator.cpp |2 +-
pgadmin/dd/dditems/locators/ddRemoveTableLocator.cpp |2 +-
pgadmin/dd/dditems/locators/ddScrollBarTableLocator.cp

Re: [pgadmin-hackers] pgAdmin III commit: Resolved an issue related enable/disable menu items

2015-09-22 Thread J.F. Oster 
Hi Ashesh,

Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).

Tuesday, September 22, 2015, 10:56:32 AM, you wrote:

AV> Resolved an issue related enable/disable menu items in Query Editor
AV> specifically for Unity Desktop Environment.

AV> wxWidgets was not able to identify the current focused control in some
AV> cases, during certain event generation. And, that was resulting into
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)

AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling the
AV> menus.

AV> Branch
AV> --
AV> master

AV> Details
AV> ---
AV> 
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83

AV> Modified Files
AV> --
AV> CHANGELOG|3 +++
AV> pgadmin/frm/frmQuery.cpp |   59
AV> +++---
AV> 2 files changed, 38 insertions(+), 24 deletions(-)





-- 
Best regards,
 J.F.



-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Resolved an issue related enable/disable menu items

2015-09-22 Thread Ashesh Vashi 
On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster  wrote:

> Hi Ashesh,
>
> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
> items are disabled all the time (seen on Ubuntu, Kubuntu).
>
I've tested the patch couple of times on Ubuntu, and OSX both before
committing the changes.

Do you have time to look into it?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>
> AV> Resolved an issue related enable/disable menu items in Query Editor
> AV> specifically for Unity Desktop Environment.
>
> AV> wxWidgets was not able to identify the current focused control in some
> AV> cases, during certain event generation. And, that was resulting into
> AV> disabling the wrong menu items.
> AV> i.e.
> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>
> AV> In order to resolve the issue, we will not consider the events
> AV> generated, but - no control gets focused, while enabling/disabling the
> AV> menus.
>
> AV> Branch
> AV> --
> AV> master
>
> AV> Details
> AV> ---
> AV>
> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
>
> AV> Modified Files
> AV> --
> AV> CHANGELOG|3 +++
> AV> pgadmin/frm/frmQuery.cpp |   59
> AV> +++---
> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>
>
>
>
>
> --
> Best regards,
>  J.F.
>
>

Re: [pgadmin-hackers] pgAdmin III commit: Resolved an issue related enable/disable menu items

2015-09-22 Thread Ashesh Vashi 
On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

> On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster  wrote:
>
>> Hi Ashesh,
>>
>> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
>> items are disabled all the time (seen on Ubuntu, Kubuntu).
>>
> I've tested the patch couple of times on Ubuntu, and OSX both before
> committing the changes.
>
> Do you have time to look into it?
>
Got the reason.
Thanks for the report.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*



>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>>
>> AV> Resolved an issue related enable/disable menu items in Query Editor
>> AV> specifically for Unity Desktop Environment.
>>
>> AV> wxWidgets was not able to identify the current focused control in some
>> AV> cases, during certain event generation. And, that was resulting into
>> AV> disabling the wrong menu items.
>> AV> i.e.
>> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>>
>> AV> In order to resolve the issue, we will not consider the events
>> AV> generated, but - no control gets focused, while enabling/disabling the
>> AV> menus.
>>
>> AV> Branch
>> AV> --
>> AV> master
>>
>> AV> Details
>> AV> ---
>> AV>
>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
>>
>> AV> Modified Files
>> AV> --
>> AV> CHANGELOG|3 +++
>> AV> pgadmin/frm/frmQuery.cpp |   59
>> AV> +++---
>> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>>
>>
>>
>>
>>
>> --
>> Best regards,
>>  J.F.
>>
>>
>

[pgadmin-hackers] pgAdmin III commit: Moved some of the code in wrong place related to en

2015-09-22 Thread Ashesh Vashi 
Moved some of the code in wrong place related to enabling copy/cut/clear
in frmQuery::updateMenu(...) function.

A regression of commit: cd9f615564334ed91d4760c971beae249cf9bd83

Thanks J.F. Oster for the quick report

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=b85fb63538f024e95d11e7aa5bdee4a96e51324b

Modified Files
--
pgadmin/frm/frmQuery.cpp |   12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III commit: Resolved an issue related enable/disable menu items

2015-09-22 Thread Ashesh Vashi 
On Wed, Sep 23, 2015 at 10:36 AM, Ashesh Vashi <
ashesh.va...@enterprisedb.com> wrote:

>
> On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster  wrote:
>>
>>> Hi Ashesh,
>>>
>>> Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
>>> items are disabled all the time (seen on Ubuntu, Kubuntu).
>>>
>> I've tested the patch couple of times on Ubuntu, and OSX both before
>> committing the changes.
>>
>> Do you have time to look into it?
>>
> Got the reason.
> Thanks for the report.
>
Thanks once again.
Please check now.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>>>
>>> Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
>>>
>>> AV> Resolved an issue related enable/disable menu items in Query Editor
>>> AV> specifically for Unity Desktop Environment.
>>>
>>> AV> wxWidgets was not able to identify the current focused control in
>>> some
>>> AV> cases, during certain event generation. And, that was resulting into
>>> AV> disabling the wrong menu items.
>>> AV> i.e.
>>> AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
>>>
>>> AV> In order to resolve the issue, we will not consider the events
>>> AV> generated, but - no control gets focused, while enabling/disabling
>>> the
>>> AV> menus.
>>>
>>> AV> Branch
>>> AV> --
>>> AV> master
>>>
>>> AV> Details
>>> AV> ---
>>> AV>
>>> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
>>>
>>> AV> Modified Files
>>> AV> --
>>> AV> CHANGELOG|3 +++
>>> AV> pgadmin/frm/frmQuery.cpp |   59
>>> AV> +++---
>>> AV> 2 files changed, 38 insertions(+), 24 deletions(-)
>>>
>>>
>>>
>>>
>>>
>>> --
>>> Best regards,
>>>  J.F.
>>>
>>>
>>
>

Re: [pgadmin-hackers] [PATCH] Add Commit/Rollback toolbar action version 2

2015-09-22 Thread John Obaterspok 
Hi Sanket,

Did you give the patch a try? I would really like it to for the next
release :)

-- john

2015-09-16 20:27 GMT+02:00 John Obaterspok :

> Hi Sanket,
>
> Attached patch is rebased now.
>
> Regards,
>
> -- john
>
>
> 2015-09-16 11:20 GMT+02:00 Sanket Mehta :
>
>> Hi John,
>>
>> Patch is not proper.
>> I got below error when I try to apply the patch:
>>
>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435
>> error: pgadmin/frm/frmQuery.cpp: patch does not apply
>>
>> Please do provide the proper patch.
>>
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta <
>> sanket.me...@enterprisedb.com> wrote:
>>
>>> Sure Ashesh,
>>>
>>> I will review the patch.
>>>
>>> Regards,
>>> Sanket Mehta
>>> Sr Software engineer
>>> Enterprisedb
>>>
>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 Sanket,

 Can you please take a look at it?

 --

 Thanks & Regards,

 Ashesh Vashi
 EnterpriseDB INDIA: Enterprise PostgreSQL Company
 


 *http://www.linkedin.com/in/asheshvashi*
 

 On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok <
 john.obaters...@gmail.com> wrote:

> Hello,
>
> I'm updated the patch to add commit/rollback actions in the toolbar
> with the following:
> 1) updated icons (based on existing pgadmin icon with arrows drawn by
> me)
> 2) add entry to menu as well
> 3) disable icons when not in a transaction
> 4) Ctrl+Shift C|R shortcut
>
> Hopefully all issues are resolved now!
>
> Regards,
>
>   John
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

>>>
>>
>