date:20160201

[pgadmin-hackers] PATCH: To fix backgird node ajax cells issue [pgAdmin4]

2016-02-01 Thread Murtuza Zabuawala

Hi,

PFA patch to fix an issue in node ajax cells for backgrid causing unescaped 
values in select2.

Before fix: pg_catalog."C"
After fix: pg_catalog.”C"


Regards,
Murtuza




fix_backgrid_node_ajax_cells.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-01 Thread John Obaterspok

Nice! This is something I wanted to work on myself but have not had the
time to yet.

-- john

2016-01-31 20:03 GMT+01:00 Sergey Busel :

> Hello,
> It's my first time here and I hope I am sending this to the right mailing
> list.
>
> I am starting to use pgAdmin 3 more and more nowadays and thought that
> having a multi tabbed interface would be beneficial especially that most
> (if not all) similar tools go that route. Somewhere in the mail archives
> I've read that tabs are not being implemented because too much code would
> need to be changed. But I thought I'd give it a try anyway.
>
> I have implemented SQL tabs in the 1.22.0 version and have been using it
> for a week. Works just fine for me, so I wonder if there is any interest in
> adding this feature to pgAdmin 3.
>
> Brief overview:
> The changes to existing code were kept to a minimum.
> All SQL tabs still operate on the same connection and share the same
> result pane.
> Each tab has it's own dirty flag, EOL style, and file from/to which it was
> loaded/saved.
>
> Let me know if anybody is interested.
>
> Thanks.
>
>

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-01 Thread Dave Page

On Sun, Jan 31, 2016 at 7:03 PM, Sergey Busel  wrote:
> Hello,
> It's my first time here and I hope I am sending this to the right mailing
> list.
>
> I am starting to use pgAdmin 3 more and more nowadays and thought that
> having a multi tabbed interface would be beneficial especially that most (if
> not all) similar tools go that route. Somewhere in the mail archives I've
> read that tabs are not being implemented because too much code would need to
> be changed. But I thought I'd give it a try anyway.
>
> I have implemented SQL tabs in the 1.22.0 version and have been using it for
> a week. Works just fine for me, so I wonder if there is any interest in
> adding this feature to pgAdmin 3.
>
> Brief overview:
> The changes to existing code were kept to a minimum.
> All SQL tabs still operate on the same connection and share the same result
> pane.
> Each tab has it's own dirty flag, EOL style, and file from/to which it was
> loaded/saved.
>
> Let me know if anybody is interested.

Feel free to send the patch, and we'll take a look.

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Properly quote type names in the Type dialogue, and

2016-02-01 Thread Dave Page

Properly quote type names in the Type dialogue, and
ensure range information is displayed for existing
types [Akshay Joshi]

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=e7cdc2bc013687348c9249f65bbad864e171c9c3

Modified Files
--
CHANGELOG   |  3 +++
pgadmin/dlg/dlgType.cpp | 19 ++-
2 files changed, 17 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Properly quote type names in the Type dialogue, and

2016-02-01 Thread Dave Page

Properly quote type names in the Type dialogue, and
ensure range information is displayed for existing
types [Akshay Joshi]

Branch
--
REL-1_22_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=adad8918fe543f74f9ce712eeaa0c5ffc0961676

Modified Files
--
CHANGELOG   |  3 +++
pgadmin/dlg/dlgType.cpp | 19 ++-
2 files changed, 17 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix typo - s/ressource/resource

2016-02-01 Thread Dave Page

Fix typo - s/ressource/resource

Branch
--
REL-1_22_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=83e9fb9cb67923406dcbbb1ba54cc5ccb4413e1f
Author: Denis Briand 

Modified Files
--
i18n/af_ZA/pgadmin3.po| 6 +++---
i18n/ar_SA/pgadmin3.po| 6 +++---
i18n/bg_BG/pgadmin3.po| 6 +++---
i18n/ca_ES/pgadmin3.po| 6 +++---
i18n/cs_CZ/pgadmin3.po| 6 +++---
i18n/da_DK/pgadmin3.po| 6 +++---
i18n/de_CH/pgadmin3.po| 6 +++---
i18n/de_DE/pgadmin3.po| 6 +++---
i18n/el_GR/pgadmin3.po| 6 +++---
i18n/es_ES/pgadmin3.po| 6 +++---
i18n/fa_IR/pgadmin3.po| 6 +++---
i18n/fi_FI/pgadmin3.po| 6 +++---
i18n/fr_FR/pgadmin3.po| 6 +++---
i18n/gl_ES/pgadmin3.po| 6 +++---
i18n/gu_IN/pgadmin3.po| 6 +++---
i18n/hi_IN/pgadmin3.po| 6 +++---
i18n/hr_HR/pgadmin3.po| 6 +++---
i18n/hu_HU/pgadmin3.po| 6 +++---
i18n/id_ID/pgadmin3.po| 6 +++---
i18n/is_IS/pgadmin3.po| 6 +++---
i18n/it_IT/pgadmin3.po| 6 +++---
i18n/ja_JP/pgadmin3.po| 6 +++---
i18n/ko_KR/pgadmin3.po| 6 +++---
i18n/lt_LT/pgadmin3.po| 6 +++---
i18n/lv_LV/pgadmin3.po| 6 +++---
i18n/mk_MK/pgadmin3.po| 6 +++---
i18n/nb_NO/pgadmin3.po| 6 +++---
i18n/nl_NL/pgadmin3.po| 6 +++---
i18n/pl_PL/pgadmin3.po| 6 +++---
i18n/pt_BR/pgadmin3.po| 6 +++---
i18n/pt_PT/pgadmin3.po| 6 +++---
i18n/ro_RO/pgadmin3.po| 6 +++---
i18n/ru_RU/pgadmin3.po| 6 +++---
i18n/sk_SK/pgadmin3.po| 6 +++---
i18n/sl_SI/pgadmin3.po| 6 +++---
i18n/sr_RS/pgadmin3.po| 6 +++---
i18n/sv_SE/pgadmin3.po| 6 +++---
i18n/te_IN/pgadmin3.po| 6 +++---
i18n/tl_PH/pgadmin3.po| 6 +++---
i18n/tr_TR/pgadmin3.po| 6 +++---
i18n/uk_UA/pgadmin3.po| 6 +++---
i18n/ur_PK/pgadmin3.po| 6 +++---
i18n/vi_VN/pgadmin3.po| 6 +++---
i18n/zh_CN/pgadmin3.po| 6 +++---
i18n/zh_TW/pgadmin3.po| 6 +++---
pgadmin/schema/gpResQueue.cpp | 6 +++---
pgadmin3.pot  | 6 +++---
47 files changed, 141 insertions(+), 141 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Fix typo - s/ressource/resource

2016-02-01 Thread Dave Page

Fix typo - s/ressource/resource

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=0d6bb013bcff99cf11917ed784190b83acb32bf8
Author: Denis Briand 

Modified Files
--
i18n/af_ZA/pgadmin3.po| 6 +++---
i18n/ar_SA/pgadmin3.po| 6 +++---
i18n/bg_BG/pgadmin3.po| 6 +++---
i18n/ca_ES/pgadmin3.po| 6 +++---
i18n/cs_CZ/pgadmin3.po| 6 +++---
i18n/da_DK/pgadmin3.po| 6 +++---
i18n/de_CH/pgadmin3.po| 6 +++---
i18n/de_DE/pgadmin3.po| 6 +++---
i18n/el_GR/pgadmin3.po| 6 +++---
i18n/es_ES/pgadmin3.po| 6 +++---
i18n/fa_IR/pgadmin3.po| 6 +++---
i18n/fi_FI/pgadmin3.po| 6 +++---
i18n/fr_FR/pgadmin3.po| 6 +++---
i18n/gl_ES/pgadmin3.po| 6 +++---
i18n/gu_IN/pgadmin3.po| 6 +++---
i18n/hi_IN/pgadmin3.po| 6 +++---
i18n/hr_HR/pgadmin3.po| 6 +++---
i18n/hu_HU/pgadmin3.po| 6 +++---
i18n/id_ID/pgadmin3.po| 6 +++---
i18n/is_IS/pgadmin3.po| 6 +++---
i18n/it_IT/pgadmin3.po| 6 +++---
i18n/ja_JP/pgadmin3.po| 6 +++---
i18n/ko_KR/pgadmin3.po| 6 +++---
i18n/lt_LT/pgadmin3.po| 6 +++---
i18n/lv_LV/pgadmin3.po| 6 +++---
i18n/mk_MK/pgadmin3.po| 6 +++---
i18n/nb_NO/pgadmin3.po| 6 +++---
i18n/nl_NL/pgadmin3.po| 6 +++---
i18n/pl_PL/pgadmin3.po| 6 +++---
i18n/pt_BR/pgadmin3.po| 6 +++---
i18n/pt_PT/pgadmin3.po| 6 +++---
i18n/ro_RO/pgadmin3.po| 6 +++---
i18n/ru_RU/pgadmin3.po| 6 +++---
i18n/sk_SK/pgadmin3.po| 6 +++---
i18n/sl_SI/pgadmin3.po| 6 +++---
i18n/sr_RS/pgadmin3.po| 6 +++---
i18n/sv_SE/pgadmin3.po| 6 +++---
i18n/te_IN/pgadmin3.po| 6 +++---
i18n/tl_PH/pgadmin3.po| 6 +++---
i18n/tr_TR/pgadmin3.po| 6 +++---
i18n/uk_UA/pgadmin3.po| 6 +++---
i18n/ur_PK/pgadmin3.po| 6 +++---
i18n/vi_VN/pgadmin3.po| 6 +++---
i18n/zh_CN/pgadmin3.po| 6 +++---
i18n/zh_TW/pgadmin3.po| 6 +++---
pgadmin/schema/gpResQueue.cpp | 6 +++---
pgadmin3.pot  | 6 +++---
47 files changed, 141 insertions(+), 141 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Update compiled message catalogs

2016-02-01 Thread Dave Page

Update compiled message catalogs

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=ea7339b2d2112e382d54302ad692113374b1af85

Modified Files
--
i18n/af_ZA/pgadmin3.mo | Bin 154622 -> 154622 bytes
i18n/ar_SA/pgadmin3.mo | Bin 8 -> 8 bytes
i18n/bg_BG/pgadmin3.mo | Bin 185707 -> 185707 bytes
i18n/ca_ES/pgadmin3.mo | Bin 338719 -> 338211 bytes
i18n/cs_CZ/pgadmin3.mo | Bin 346888 -> 346386 bytes
i18n/da_DK/pgadmin3.mo | Bin 61528 -> 61528 bytes
i18n/de_CH/pgadmin3.mo | Bin 46816 -> 46816 bytes
i18n/de_DE/pgadmin3.mo | Bin 272934 -> 272932 bytes
i18n/el_GR/pgadmin3.mo | Bin 78320 -> 78320 bytes
i18n/es_ES/pgadmin3.mo | Bin 343718 -> 343194 bytes
i18n/fa_IR/pgadmin3.mo | Bin 295873 -> 295828 bytes
i18n/fi_FI/pgadmin3.mo | Bin 144976 -> 144976 bytes
i18n/fr_FR/pgadmin3.mo | Bin 356828 -> 356246 bytes
i18n/gl_ES/pgadmin3.mo | Bin 147437 -> 147437 bytes
i18n/gu_IN/pgadmin3.mo | Bin 400 -> 400 bytes
i18n/hi_IN/pgadmin3.mo | Bin 7490 -> 7490 bytes
i18n/hr_HR/pgadmin3.mo | Bin 44690 -> 44690 bytes
i18n/hu_HU/pgadmin3.mo | Bin 58454 -> 58454 bytes
i18n/id_ID/pgadmin3.mo | Bin 62374 -> 62374 bytes
i18n/is_IS/pgadmin3.mo | Bin 400 -> 400 bytes
i18n/it_IT/pgadmin3.mo | Bin 198041 -> 198041 bytes
i18n/ja_JP/pgadmin3.mo | Bin 301131 -> 301128 bytes
i18n/ko_KR/pgadmin3.mo | Bin 199859 -> 199859 bytes
i18n/lt_LT/pgadmin3.mo | Bin 26319 -> 26319 bytes
i18n/lv_LV/pgadmin3.mo | Bin 337017 -> 336493 bytes
i18n/mk_MK/pgadmin3.mo | Bin 1876 -> 1876 bytes
i18n/nb_NO/pgadmin3.mo | Bin 44458 -> 44458 bytes
i18n/nl_NL/pgadmin3.mo | Bin 155215 -> 155215 bytes
i18n/pl_PL/pgadmin3.mo | Bin 334230 -> 334227 bytes
i18n/pt_BR/pgadmin3.mo | Bin 149117 -> 149117 bytes
i18n/pt_PT/pgadmin3.mo | Bin 197719 -> 197719 bytes
i18n/ro_RO/pgadmin3.mo | Bin 62734 -> 62734 bytes
i18n/ru_RU/pgadmin3.mo | Bin 429968 -> 429360 bytes
i18n/sk_SK/pgadmin3.mo | Bin 62790 -> 62790 bytes
i18n/sl_SI/pgadmin3.mo | Bin 92598 -> 92598 bytes
i18n/sr_RS/pgadmin3.mo | Bin 409389 -> 408731 bytes
i18n/sv_SE/pgadmin3.mo | Bin 45185 -> 45185 bytes
i18n/te_IN/pgadmin3.mo | Bin 1917 -> 1917 bytes
i18n/tl_PH/pgadmin3.mo | Bin 26373 -> 26373 bytes
i18n/tr_TR/pgadmin3.mo | Bin 106520 -> 106520 bytes
i18n/uk_UA/pgadmin3.mo | Bin 517 -> 517 bytes
i18n/ur_PK/pgadmin3.mo | Bin 35330 -> 35330 bytes
i18n/vi_VN/pgadmin3.mo | Bin 436 -> 436 bytes
i18n/zh_CN/pgadmin3.mo | Bin 309464 -> 308990 bytes
i18n/zh_TW/pgadmin3.mo | Bin 189506 -> 189454 bytes
45 files changed, 0 insertions(+), 0 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin III commit: Update compiled message catalogs

2016-02-01 Thread Dave Page

Update compiled message catalogs

Branch
--
REL-1_22_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=852b06923335e58f347dd6ffa1585592ddd96fc3

Modified Files
--
i18n/af_ZA/pgadmin3.mo | Bin 154622 -> 154622 bytes
i18n/ar_SA/pgadmin3.mo | Bin 8 -> 8 bytes
i18n/bg_BG/pgadmin3.mo | Bin 185707 -> 185707 bytes
i18n/ca_ES/pgadmin3.mo | Bin 338719 -> 338211 bytes
i18n/cs_CZ/pgadmin3.mo | Bin 346888 -> 346386 bytes
i18n/da_DK/pgadmin3.mo | Bin 61528 -> 61528 bytes
i18n/de_CH/pgadmin3.mo | Bin 46816 -> 46816 bytes
i18n/de_DE/pgadmin3.mo | Bin 272934 -> 272932 bytes
i18n/el_GR/pgadmin3.mo | Bin 78320 -> 78320 bytes
i18n/es_ES/pgadmin3.mo | Bin 343718 -> 343194 bytes
i18n/fa_IR/pgadmin3.mo | Bin 295873 -> 295828 bytes
i18n/fi_FI/pgadmin3.mo | Bin 144976 -> 144976 bytes
i18n/fr_FR/pgadmin3.mo | Bin 356828 -> 356246 bytes
i18n/gl_ES/pgadmin3.mo | Bin 147437 -> 147437 bytes
i18n/gu_IN/pgadmin3.mo | Bin 400 -> 400 bytes
i18n/hi_IN/pgadmin3.mo | Bin 7490 -> 7490 bytes
i18n/hr_HR/pgadmin3.mo | Bin 44690 -> 44690 bytes
i18n/hu_HU/pgadmin3.mo | Bin 58454 -> 58454 bytes
i18n/id_ID/pgadmin3.mo | Bin 62374 -> 62374 bytes
i18n/is_IS/pgadmin3.mo | Bin 400 -> 400 bytes
i18n/it_IT/pgadmin3.mo | Bin 198041 -> 198041 bytes
i18n/ja_JP/pgadmin3.mo | Bin 301131 -> 301128 bytes
i18n/ko_KR/pgadmin3.mo | Bin 199859 -> 199859 bytes
i18n/lt_LT/pgadmin3.mo | Bin 26319 -> 26319 bytes
i18n/lv_LV/pgadmin3.mo | Bin 337017 -> 336493 bytes
i18n/mk_MK/pgadmin3.mo | Bin 1876 -> 1876 bytes
i18n/nb_NO/pgadmin3.mo | Bin 44458 -> 44458 bytes
i18n/nl_NL/pgadmin3.mo | Bin 155215 -> 155215 bytes
i18n/pl_PL/pgadmin3.mo | Bin 334230 -> 334227 bytes
i18n/pt_BR/pgadmin3.mo | Bin 149117 -> 149117 bytes
i18n/pt_PT/pgadmin3.mo | Bin 197719 -> 197719 bytes
i18n/ro_RO/pgadmin3.mo | Bin 62734 -> 62734 bytes
i18n/ru_RU/pgadmin3.mo | Bin 429968 -> 429360 bytes
i18n/sk_SK/pgadmin3.mo | Bin 62790 -> 62790 bytes
i18n/sl_SI/pgadmin3.mo | Bin 92598 -> 92598 bytes
i18n/sr_RS/pgadmin3.mo | Bin 409389 -> 408731 bytes
i18n/sv_SE/pgadmin3.mo | Bin 45185 -> 45185 bytes
i18n/te_IN/pgadmin3.mo | Bin 1917 -> 1917 bytes
i18n/tl_PH/pgadmin3.mo | Bin 26373 -> 26373 bytes
i18n/tr_TR/pgadmin3.mo | Bin 106520 -> 106520 bytes
i18n/uk_UA/pgadmin3.mo | Bin 517 -> 517 bytes
i18n/ur_PK/pgadmin3.mo | Bin 35330 -> 35330 bytes
i18n/vi_VN/pgadmin3.mo | Bin 436 -> 436 bytes
i18n/zh_CN/pgadmin3.mo | Bin 309464 -> 308990 bytes
i18n/zh_TW/pgadmin3.mo | Bin 189506 -> 189454 bytes
45 files changed, 0 insertions(+), 0 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix backgird node ajax cells issue [pgAdmin4]

2016-02-01 Thread Ashesh Vashi

Hi Murtuza,

As discussed personally, we need to escape and unescape the data at UI
level only.
Otherwise - the general purpose cell and control -
NodeAjaxListByIdControl/NodeAjaxListByNameControl, and
NodeAjaxListByNameCell/NodeAjaxListByIdCell, does not work as expected.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

*http://www.linkedin.com/in/asheshvashi*

On Mon, Feb 1, 2016 at 2:00 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix an issue in node ajax cells for backgrid causing
> unescaped values in select2.
>
> Before fix: pg_catalog."C"
> After fix: pg_catalog.”C"
>
>
> Regards,
> Murtuza
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Allow to run the transform to be evaluated as functio

2016-02-01 Thread Ashesh Vashi

Allow to run the transform to be evaluated as function in the 
NodeAjaxOptionsControl

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=14583e68b28bc67aca22712cfe71e4b9deecf522
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js | 1 +
1 file changed, 1 insertion(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To allow transform to run as function [pgAdmin4]

2016-02-01 Thread Ashesh Vashi

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Wed, Jan 27, 2016 at 5:05 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch,Which will allow transform to run as function for
> node-ajax-options control, similar to disable/visible field in schema.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin III commit: Fix selection of conversion functions in the CREATE

2016-02-01 Thread Dave Page

Fix selection of conversion functions in the CREATE CONVERSION dialogue

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=d0a6d561813d327cfeb6ee4c726e955cfc279601
Author: Dmitry Voronin 

Modified Files
--
CHANGELOG | 2 ++
pgadmin/dlg/dlgConversion.cpp | 7 +--
2 files changed, 3 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin website commit: Add a JSON file containing current version numb

2016-02-01 Thread Dave Page

Add a JSON file containing current version numbers for future upgrade 
notifications

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=010780fef10874b3dcd002565a5cb1d5abad75b7

Modified Files
--
versions.json | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-01 Thread Sergey Busel

Patch file for multiple SQL tabs is attached.

Thank you

On Mon, Feb 1, 2016 at 3:01 AM, Dave Page  wrote:

> On Sun, Jan 31, 2016 at 7:03 PM, Sergey Busel  wrote:
> > Hello,
> > It's my first time here and I hope I am sending this to the right mailing
> > list.
> >
> > I am starting to use pgAdmin 3 more and more nowadays and thought that
> > having a multi tabbed interface would be beneficial especially that most
> (if
> > not all) similar tools go that route. Somewhere in the mail archives I've
> > read that tabs are not being implemented because too much code would
> need to
> > be changed. But I thought I'd give it a try anyway.
> >
> > I have implemented SQL tabs in the 1.22.0 version and have been using it
> for
> > a week. Works just fine for me, so I wonder if there is any interest in
> > adding this feature to pgAdmin 3.
> >
> > Brief overview:
> > The changes to existing code were kept to a minimum.
> > All SQL tabs still operate on the same connection and share the same
> result
> > pane.
> > Each tab has it's own dirty flag, EOL style, and file from/to which it
> was
> > loaded/saved.
> >
> > Let me know if anybody is interested.
>
> Feel free to send the patch, and we'll take a look.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff -aur --exclude-from expats /home/sergey/c/pgadmin3-1.22.0/pgadmin/ctl/ctlSQLBox.cpp /home/sergey/c/pgadmin3-1.22.0-dev/pgadmin/ctl/ctlSQLBox.cpp
--- /home/sergey/c/pgadmin3-1.22.0/pgadmin/ctl/ctlSQLBox.cpp	2016-01-04 07:03:33.0 -0600
+++ /home/sergey/c/pgadmin3-1.22.0-dev/pgadmin/ctl/ctlSQLBox.cpp	2016-01-31 12:09:37.689549967 -0600
@@ -184,6 +184,36 @@
 	m_database = db;
 }
 
+void ctlSQLBox::SetChanged(bool b)
+{
+	m_changed = b;
+}
+
+bool ctlSQLBox::IsChanged()
+{
+	return m_changed;
+}
+
+void ctlSQLBox::SetOrigin(int origin)
+{
+	m_origin = origin;
+}
+
+int ctlSQLBox::GetOrigin()
+{
+	return m_origin;
+}
+
+void ctlSQLBox::SetFilename(wxString &filename)
+{
+	m_filename = filename;
+}
+
+wxString ctlSQLBox::GetFilename()
+{
+	return m_filename;
+}
+
 void ctlSQLBox::OnSearchReplace(wxCommandEvent &ev)
 {
 	if (!m_dlgFindReplace)
diff -aur --exclude-from expats /home/sergey/c/pgadmin3-1.22.0/pgadmin/frm/frmQuery.cpp /home/sergey/c/pgadmin3-1.22.0-dev/pgadmin/frm/frmQuery.cpp
--- /home/sergey/c/pgadmin3-1.22.0/pgadmin/frm/frmQuery.cpp	2016-01-04 07:03:33.0 -0600
+++ /home/sergey/c/pgadmin3-1.22.0-dev/pgadmin/frm/frmQuery.cpp	2016-02-01 20:37:52.061428472 -0600
@@ -84,6 +84,7 @@
 
 #define CTRLID_CONNECTION   4200
 #define CTRLID_DATABASELABEL4201
+#define CTL_SQLQUERYBOOK4202
 
 #define XML_FROM_WXSTRING(s) ((const xmlChar *)(const char *)s.mb_str(wxConvUTF8))
 #define WXSTRING_FROM_XML(s) wxString((char *)s, wxConvUTF8)
@@ -106,6 +107,9 @@
 	EVT_MENU(MNU_OPEN,  frmQuery::OnOpen)
 	EVT_MENU(MNU_SAVE,  frmQuery::OnSave)
 	EVT_MENU(MNU_SAVEAS,frmQuery::OnSaveAs)
+	// Handlers to add and remove SQL tabs
+	EVT_MENU(MNU_NEWSQLTAB, frmQuery::OnSqlBookAddPage)
+	EVT_MENU(MNU_CLOSESQLTAB,   frmQuery::OnSqlBookRemovePage)
 	EVT_MENU(MNU_EXPORT,frmQuery::OnExport)
 	EVT_MENU(MNU_SAVEAS_IMAGE_GQB, frmQuery::SaveExplainAsImage)
 	EVT_MENU(MNU_SAVEAS_IMAGE_EXPLAIN, frmQuery::SaveExplainAsImage)
@@ -170,6 +174,9 @@
 	EVT_PGQUERYRESULT(QUERY_COMPLETE, frmQuery::OnQueryComplete)
 	EVT_MENU(PGSCRIPT_COMPLETE, frmQuery::OnScriptComplete)
 	EVT_AUINOTEBOOK_PAGE_CHANGED(CTL_NTBKCENTER, frmQuery::OnChangeNotebook)
+	// sqlQueryBook event handlers
+	EVT_AUINOTEBOOK_PAGE_CHANGED(CTL_SQLQUERYBOOK, frmQuery::OnSqlBookPageChanged)
+	EVT_AUINOTEBOOK_PAGE_CHANGING(CTL_SQLQUERYBOOK, frmQuery::OnSqlBookPageChanging)
 	EVT_SPLITTER_SASH_POS_CHANGED(GQB_HORZ_SASH, frmQuery::OnResizeHorizontally)
 	EVT_BUTTON(CTL_DELETECURRENTBTN, frmQuery::OnDeleteCurrent)
 	EVT_BUTTON(CTL_DELETEALLBTN, frmQuery::OnDeleteAll)
@@ -235,7 +242,7 @@
 
 	loading = true;
 	closing = false;
-	origin = ORIGIN_MANUAL;
+	//origin = ORIGIN_MANUAL;
 
 	dlgName = wxT("frmQuery");
 	recentKey = wxT("RecentFiles");
@@ -263,6 +270,12 @@
 	saveasImageMenu->Append(MNU_SAVEAS_IMAGE_GQB, _("Graphical Query (image)"), _("Save Graphical Query as an image"));
 	saveasImageMenu->Append(MNU_SAVEAS_IMAGE_EXPLAIN, _("Explain (image)"), _("Save output of Explain as an image"));
 	fileMenu->Append(wxID_ANY, _("Save as"), saveasImageMenu);
+
+	// SQL tabs related menu items
+	fileMenu->AppendSeparator();
+	fileMenu->Append(MNU_NEWSQLTAB, _("New SQL &tab"), _("Open a new query tab"));
+	fileMenu->Append(MNU_CLOSESQLTAB, _("&Close SQL tab"), _("Close the current query tab"));
+
 	fileMenu->AppendSeparator();
 	fileMenu->Append(MNU_EXPORT, _("&Export..."),  _("Export data to file"));
 	fileMenu->Append(MNU_QUICKREPORT, _("&Quick report..."),  _("Run a quick report..."));
@@ -495,12 +508,20 @@
 	wxBoxSizer *box

[pgadmin-hackers] [pgAdmin4]PATCH: Fix textarea issue in updateInvalid function

2016-02-01 Thread Surinder Kumar

Hi,

PFA patch to fix below issue

We find all inputs which are not button in updateInvalid() function, this
code breaks with SqlField Control when it updates the field model data.
Because CodeMirror dynamically creates textarea element without name
property which we don't need.
Now the code will find all inputs having name property.


find_input_with_name.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4]PATCH: Fix textarea issue in updateInvalid function

2016-02-01 Thread Surinder Kumar

Please ignore this email.

On Tue, Feb 2, 2016 at 12:28 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix below issue
>
> We find all inputs which are not button in updateInvalid() function, this
> code breaks with SqlField Control when it updates the field model data.
> Because CodeMirror dynamically creates textarea element without name
> property which we don't need.
> Now the code will find all inputs having name property.
>

[pgadmin-hackers] [pgAdmin4] Patch: Added new Control SqlFieldControl

2016-02-01 Thread Surinder Kumar

Hi,


Please find patch for SqlFieldControl.

This control allows the user to write/edit SQL queries.

To use SqlFieldControl, Set *control* property of field to *'sql-field' *in
model's schema like:

{
  id: 'definition', label:'{{ _('Definition') }}', cell: 'string',
  control: 'sql-field'
}



Regards,
Surinder Kumar


SqlFieldControl.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Updated patches

2016-02-01 Thread Neel Patel

Hi Harshal,

Please find below review comments.

- While applying the patch, we are getting warning regarding "trailing
whitespace.". Please remove the warning.
- We are getting error saying "*IndexError: tuple index out of range*" on
python side while connecting to "template0" database.
- Many properties are not getting displayed in "Properties" window when we
click on any database. Check for pgadmin3 to show all the properties.
  e.g.  Connected, System Database, Allow connections etc..
- Do proper formatting while displaying SQL statements in SQL tab. Below
statement semicolon should not be in next line.
   e.g.
  CREATE DATABASE postgres
  WITH OWNER = postgres
  ENCODING = 'UTF8'
  TABLESPACE = pg_default
;

- While creating the new database, tablespace drop down values are not
filled correctly. Current it shows the "Template" field value which is
wrong.
- By default, when user does not specify any "collation" and "character
type" then it should be set as "en_US.UTF8" and accordingly it should
display in
  Properties and SQL window.
- When we connect to database 9.1 then query is getting failed to execute.
Below are the error.

  *2016-02-02 11:46:59,597: ERROR pgadmin: Failed to execute query
(execute_dict) for the server #3- DB:test_db_1 (Query-id: 9678389):*
*Error Message:function expression in FROM cannot refer to other relations
of same query level*
*LINE 27:   aclexplode(datacl) d*

- When we edit any database and PG version is 9.1 then in default
privileges the "Types" tab should not allow to enter the value or it should
not be
  displayed.
- We are not able to edit any database if PG version is 9.1 as we are
getting error due to query is getting failed.
- We need to implement "Statistics" tab window implementation to show the
different properties.
- When we add new parameters in "Variables", it generates the wrong SQL. In
the below Query it should add the database name as well.

  Wrong SQL : -
  ALTER ROLE role1 SET transaction_read_only TO 'on';
  Correct SQL:-
  ALTER ROLE role1 IN DATABASE test_db_3 SET transaction_read_only =
'on';

- While editing the existing database, enter some of the values from
"Variables". Though we add the valid value, it shows error saying "Please
enter
  some value". It should not display the message and allow user to set the
modified parameters.
- When we click on any database, it shows the properties of the selected
node in "Properties" tab. In that window, all the database properties
should be
  "Read only". We should not change the database properties from
"Properties" panel.
- In "Security" tab, After adding new privilege, we are not able to add the
second privilege due to scroll bar issue.
- After clicking on "Add" button in security tab, "Save" button is getting
disabled so we are not able to save the modified parameters.

We are still reviewing the code and we will send more comments once the
review will be completed.

Thanks,
Neel Patel

On Fri, Jan 22, 2016 at 6:46 PM, Ashesh Vashi  wrote:

> Hi Harshal,
>
> On Fri, Jan 22, 2016 at 2:48 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA updated patches:
>>
>> I have made changes as per Ashesh's suggestions.
>>
> As discussed, I've committed the privileges, and variable changes.
>
> I will look into database patch later.
>
> Thanks,
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>>
>>
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB 
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

[pgadmin-hackers] PATCH: To fix backgird node ajax cells issue [pgAdmin4]

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

[pgadmin-hackers] pgAdmin III commit: Properly quote type names in the Type dialogue, and

[pgadmin-hackers] pgAdmin III commit: Properly quote type names in the Type dialogue, and

[pgadmin-hackers] pgAdmin III commit: Fix typo - s/ressource/resource

[pgadmin-hackers] pgAdmin III commit: Fix typo - s/ressource/resource

[pgadmin-hackers] pgAdmin III commit: Update compiled message catalogs

[pgadmin-hackers] pgAdmin III commit: Update compiled message catalogs

Re: [pgadmin-hackers] PATCH: To fix backgird node ajax cells issue [pgAdmin4]

[pgadmin-hackers] pgAdmin 4 commit: Allow to run the transform to be evaluated as functio

Re: [pgadmin-hackers] PATCH: To allow transform to run as function [pgAdmin4]

[pgadmin-hackers] pgAdmin III commit: Fix selection of conversion functions in the CREATE

[pgadmin-hackers] pgAdmin website commit: Add a JSON file containing current version numb

Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

[pgadmin-hackers] [pgAdmin4]PATCH: Fix textarea issue in updateInvalid function

Re: [pgadmin-hackers] [pgAdmin4]PATCH: Fix textarea issue in updateInvalid function

[pgadmin-hackers] [pgAdmin4] Patch: Added new Control SqlFieldControl

Re: [pgadmin-hackers] Updated patches

19 matches

Site Navigation

Mail list logo

Footer information