[pgadmin-hackers] pgAdmin 4 commit: Adding support to serialize the datetime to the JSON

2016-02-05 Thread Ashesh Vashi
Adding support to serialize the datetime to the JSON object properly.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86115cff6cf82e61cee7897e82b4dd29cb62dd2f
Author: Akshay Joshi 

Modified Files
--
web/pgadmin/utils/ajax.py | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Adding new control to show SQL query in a control.

2016-02-05 Thread Ashesh Vashi
Adding new control to show SQL query in a control.

It will be used by the nodes like view, which require to show the code
inside as one parameter.

Also, override the events for the Backform.TextareaControl in order
handle some cases, which were not handling the change in textarea
properly in all situations.

Also, we need to show the error message around the input control with
name attribute only.

Author: Surinder Kumar (small twicks by me).
Reviewed by: Ashesh Vashi

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7df9e752bb8d5f81f7c496f95fafde869b541597

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js | 90 +--
1 file changed, 86 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Do not show the tablespace node as inode ('+' sign fo

2016-02-05 Thread Ashesh Vashi
Do not show the tablespace node as inode ('+' sign for expanding the tree node 
for it).

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=01d020ed9562456a4a18674076add16dc8095857

Modified Files
--
web/pgadmin/browser/server_groups/servers/tablespaces/__init__.py | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Using different strategy to render different type of

2016-02-05 Thread Ashesh Vashi
Using different strategy to render different type of data based on the
type for the Variable control, instead of using the complex DynamicCell.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0648ed54b9a5079434d8a4ebcd09e30e3f54098
Author: Harshal Dhumal 

Modified Files
--
.../server_groups/servers/static/js/variable.js| 147 +++--
web/pgadmin/static/js/backgrid/backgrid.pgadmin.js |  43 ++
2 files changed, 92 insertions(+), 98 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] Re: New mechanism in backgrid to render different types of cells in same column [pgAdmin4]

2016-02-05 Thread Ashesh Vashi
On Fri, Feb 5, 2016 at 2:16 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi, Ashesh,
>
Hi Harshal,

[ Please do not forget to reply to All next time.. :-) ]

>
> Same patch which I send on 19 Jan with very minor change. i.e. properly
> initialize bool cell for dynamic variable cell.
>
Thanks - I've committed the patch.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
>
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB 
>
> On Tue, Jan 19, 2016 at 12:42 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> +
>> Also fixed some minor issues related to Unique column functionality in
>> Variable control in same patch.
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer *
>>
>>
>>
>> EenterpriseDB 
>>
>> On Tue, Jan 19, 2016 at 12:37 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> This patch is replacement for our developed DynamicVariablecell.
>>>
>>> Now we can pass cellFunction in column schema to get appropriate cell
>>> class.
>>> User provided cellFunction must return valid cell class.
>>> cellFunction will be called with context (this) as column and model as
>>> argument.
>>>
>>> eg.:
>>>
>>> schema: [
>>>   {id: 'name', label:'Name', type:'text', editable: false, cell: 'string'},
>>>   {
>>> id: 'value', label:'Value', type: 'text', editable: true,
>>> cellFunction: function(model){
>>>
>>>   if (isNaN(model.get(this.get('name' {
>>>  return "string";
>>>   } else {
>>>   return Backgrid.NumberCell;
>>>  }
>>>   }
>>>   },
>>>   {id: 'database', label:'Database', type: 'text', editable: false},
>>>   .
>>>   .
>>>   .
>>>
>>>
>>>
>>>
>>> --
>>> *Harshal Dhumal*
>>> *Software Engineer *
>>>
>>>
>>>
>>> EenterpriseDB 
>>>
>>
>>
>


Re: [pgadmin-hackers] Minor issue in variable js [pgadmin4]

2016-02-05 Thread Harshal Dhumal
Hi All,

Now ignore this patch as this issue is covered in this commit.


-- 
*Harshal Dhumal*
*Software Engineer *



EenterpriseDB 

On Tue, Feb 2, 2016 at 4:55 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch for variable js.
>
> Issue fixed: Initialize boolean cell with proper data (either true or
> false not undefined).
>
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB 
>


[pgadmin-hackers] pgAdmin 4 commit: Resolved an internal server error while selecting the

2016-02-05 Thread Ashesh Vashi
Resolved an internal server error while selecting the role node on
PostgreSQL/PPAS server (version >= 9.5).

Reported by: Akshay Joshi

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a82f58a8f40ccf8d9991f8e782fb526c1c4db5f7

Modified Files
--
.../servers/roles/templates/role/sql/post9_4/properties.sql   | 2 +-
.../servers/roles/templates/role/sql/post9_4/sql.sql  | 8 
2 files changed, 5 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin4][Patch]: Foreign Data Wrapper

2016-02-05 Thread Neel Patel
Hi All,

Please find attached patch file that include the below three nodes under
the database node.

- Foreign Data Wrappers
- Foreign Servers
- User Mappings

Do review it and let me know for any comments.

Thanks,
Neel Patel


foreign_data_wrapper_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Resolving an error related to not able to generate th

2016-02-05 Thread Ashesh Vashi
Resolving an error related to not able to generate the reversed
engineered SQL from the database when no ACL is defined.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=712f47987f2fce72938c2012091a8e306f06b303

Modified Files
--
.../server_groups/servers/databases/__init__.py| 52 +++---
.../templates/databases/sql/9.3_plus/acl.sql   |  4 +-
.../templates/databases/sql/9.3_plus/defacl.sql|  4 +-
3 files changed, 29 insertions(+), 31 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-05 Thread Akshay Joshi
Hi All

I have added logic to show sql in the "SQL" tab on dashboard and also fixed
some warnings. Please refer and review this patch.

On Thu, Feb 4, 2016 at 5:50 PM, Akshay Joshi 
wrote:

> Hi All
>
> Attached is the patch for the Resource Group Module. Please review it and
> if it looks good then please commit it.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Resource_Group_v1.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin III commit: Fix line endings.

2016-02-05 Thread Dave Page
Fix line endings.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=2f511e8e50279e75b2328d051947263e4131174b

Modified Files
--
xtra/wx-build/Makefile.am | 32 
1 file changed, 16 insertions(+), 16 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin III commit: Fix line endings.

2016-02-05 Thread Dave Page
Fix line endings.

Branch
--
REL-1_22_0_PATCHES

Details
---
http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=f210c035f702fab5973f7282e7bf32d74387978f

Modified Files
--
xtra/wx-build/Makefile.am | 32 
1 file changed, 16 insertions(+), 16 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] pgAdmin III: Muliple SQL tabs

2016-02-05 Thread Dave Page
On Wed, Feb 3, 2016 at 3:07 AM, Sergey Busel  wrote:
> - Removed unused/commented code.
> - Tab names now reflect the file name, if such is associated with a tab.
> - Removed the "Close Tab" menu item. Added X button to the active tab.
> - To tell the user which tab results are related to and to avoid messing
> with perspective, the name of the related tab is now displayed as "Data
> Output [Query 1]" in the output pane. If the tab is named after a file, file
> name will display in the square brackets. If the file name is longer then 15
> chars, it will be truncated to 15 chars.
>
> Let me know any other suggestions you may have.

Thanks - this seems to be working nicely for me. It would be good if
the query name could be displayed in the title bar of the output pane
rather than on the results tab (because it really does apply to all
tabs), but I don't see any sensible way to do that given the weird way
that wxAUI stores it's perspectives.

Ashesh, any ideas?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers