[pgadmin-hackers] pgAdmin 4 commit: Returns an error when the driver couldn't decrypt the

2016-02-22 Thread Ashesh Vashi 
Returns an error when the driver couldn't decrypt the password, and
let the user know the issue.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3b0e1dec41bb2c4fa75842ed4ce25b78f0dc6e7

Modified Files
--
web/pgadmin/utils/driver/psycopg2/__init__.py | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resolved a typo in Server Module related to assigning

2016-02-22 Thread Ashesh Vashi 
Resolved a typo in Server Module related to assigning manager object to
driver variable.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bbf037f005001531728c5957ece1b86d43011ada

Modified Files
--
web/pgadmin/browser/server_groups/servers/__init__.py | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add support for Resource Groups in EDB Advanced Serve

2016-02-22 Thread Dave Page 
Add support for Resource Groups in EDB Advanced Server 9.4+.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dafd2f33234ff5a59f9f5b1c23bcfc81f01f659f
Author: Akshay Joshi 

Modified Files
--
.../servers/resource_groups/__init__.py| 565 +
.../static/img/coll-resource_group.png | Bin 0 -> 1173 bytes
.../resource_groups/static/img/resource_group.png  | Bin 0 -> 966 bytes
.../resource_groups/js/resource_groups.js  | 143 ++
.../templates/resource_groups/sql/create.sql   |  10 +
.../templates/resource_groups/sql/delete.sql   |   8 +
.../templates/resource_groups/sql/getoid.sql   |   4 +
.../templates/resource_groups/sql/properties.sql   |   6 +
.../templates/resource_groups/sql/update.sql   |   9 +
web/pgadmin/browser/templates/browser/js/node.js   |   3 +
10 files changed, 748 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Dave Page 
On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:

> Hi All
>
> On Mon, Feb 15, 2016 at 3:47 PM, Dave Page  wrote:
>
>>
>>
>> On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All
>>>
>>> Attached is the new patch after fixing review comments given by Dave.
>>>
>>> On Fri, Feb 12, 2016 at 10:04 PM, Dave Page  wrote:
>>>


 On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <
 harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> New language patch is working fine.
> Ashesh - Can you please review it ?
> If it looks good then can you please commit ?
>
> Thank you,
> Harshal
>

 A few comments:

 - We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't we
 also therefore omit DROP LANGUAGE?

>>> Fixed.
>>>
 - Please leave a blank line between the file header and python code in
 python files.

>>> Fixed.
>>>
 - The pydoc module description is missing from __init__.py

>>> Fixed.
>>>
 - What about the Dependents and Dependencies tabs?

>>>  Infrastructure is not ready, so not implemented yet.
>>>
>>
>> The first person that needs it should be working on it! I don't want to
>> be committing partially completed features, otherwise we'll have to come
>> back and revisit them all when the infrastructure is done.
>>
>> Having done it before for pgAdmin 3, I don't imagine it's hard. It's
>> really just the same as the Statistics view. Please take a look at it
>> (assuming noone else is already).
>>
>
>Fixed. Attached is the modified patch with support of Dependents and
> Dependencies tabs. Please review it.
>

Committed, with a couple of additional minor changes:

- s/resourcegroups/resource_groups (for consistency with server_groups)

- Added a PyDoc module description to __init__.py

Thanks!

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Do not need to implement the BackendSupported functio

2016-02-22 Thread Ashesh Vashi 
Do not need to implement the BackendSupported function in resource
group, we do have the same function in CollectionModule class, which
will work, when we set the min_ver, max_ver and server_type properly.

Thanks Khushboo for pointing that out, and Akshay for quick testing for
this patch.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c2faa984b293c644788234523f56c586e1bd6aa

Modified Files
--
.../servers/resource_groups/__init__.py| 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resolved the issue related showing errors in the radi

2016-02-22 Thread Ashesh Vashi 
Resolved the issue related showing errors in the radio control.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=db9b5f0e0c54e94028335adf98a228fadec1ba6e

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js | 38 +++
1 file changed, 38 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] backform.pgadmin: fix for showing multiple errors for radio control [pgadmin4]

2016-02-22 Thread Ashesh Vashi 
On Thu, Feb 11, 2016 at 6:44 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch for backform.pgadmin.js
>
> *Issue fixed*: Backform was showing same error multiple times (equal to
> no. of radio buttons in radio group) in dialog.
>
Approach for this patch is wrong, we should not change the common
functionality, and check radio button in it.

That's wrong way to do it.

Though - I've checked-in the fix for it by extending the RadioControl
itself.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


>
> See attached screen shot.
> --
> *Harshal Dhumal*
> *Software Engineer *
>
>
>
> EenterpriseDB 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: Adding Numeric control support for Backform.

2016-02-22 Thread Ashesh Vashi 
Adding Numeric control support for Backform.

This patch also includes an issue related to IntegerControl, which does
not emit any error message, when it has some issues.

In order to fix the issue, it will trigger 'pgadmin-session:invalid'
event, when the input value is not an valid integer.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8186e4584446f9dac8db57dda711eefef59277d6
Author: Akshay Joshi 

Modified Files
--
.../browser/templates/browser/js/browser.js|   1 +
web/pgadmin/static/js/backform.pgadmin.js  | 105 -
2 files changed, 105 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4] Numeric Control for Backform

2016-02-22 Thread Ashesh Vashi 
Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Mon, Feb 15, 2016 at 6:32 PM, Akshay Joshi  wrote:

> Hi All
>
> I have added Numeric Input control for Backform as we already have for
> Integer type. Also fixed one issue in Integer input control.
>
> *Usage:*
>schema: [{
>   id: 'name', label: '{{ _('Group Name') }}', cell: 'string',
>   type: 'text',
> },{
>   id: 'cpu_rate_limit', label:'{{ _('CPU Rate Limit') }}', cell:
> 'string',
>   type: '*numeric*', min:0, max:16777216
> },{
>
> Attached is the patch file, please review it and if looks good then please
> commit it.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Dave Page 
On Mon, Feb 22, 2016 at 10:53 AM, Dave Page  wrote:

>
>
> On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> On Mon, Feb 15, 2016 at 3:47 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi All

 Attached is the new patch after fixing review comments given by Dave.

 On Fri, Feb 12, 2016 at 10:04 PM, Dave Page  wrote:

>
>
> On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> New language patch is working fine.
>> Ashesh - Can you please review it ?
>> If it looks good then can you please commit ?
>>
>> Thank you,
>> Harshal
>>
>
> A few comments:
>
> - We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't we
> also therefore omit DROP LANGUAGE?
>
 Fixed.

> - Please leave a blank line between the file header and python code in
> python files.
>
 Fixed.

> - The pydoc module description is missing from __init__.py
>
 Fixed.

> - What about the Dependents and Dependencies tabs?
>
  Infrastructure is not ready, so not implemented yet.

>>>
>>> The first person that needs it should be working on it! I don't want to
>>> be committing partially completed features, otherwise we'll have to come
>>> back and revisit them all when the infrastructure is done.
>>>
>>> Having done it before for pgAdmin 3, I don't imagine it's hard. It's
>>> really just the same as the Statistics view. Please take a look at it
>>> (assuming noone else is already).
>>>
>>
>>Fixed. Attached is the modified patch with support of Dependents and
>> Dependencies tabs. Please review it.
>>
>
> Committed, with a couple of additional minor changes:
>
> - s/resourcegroups/resource_groups (for consistency with server_groups)
>
> - Added a PyDoc module description to __init__.py
>

Oops, wrong thread. Please ignore.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Resource Group Module

2016-02-22 Thread Dave Page 
Committed, with a couple of additional minor changes:

- s/resourcegroups/resource_groups (for consistency with server_groups)

- Added a PyDoc module description to __init__.py

Thanks!

On Mon, Feb 22, 2016 at 4:29 AM, Neel Patel 
wrote:

> Hi Akshay,
>
> After implementation of the NumericControl, ResourceGroup patch looks good
> to me.
> As resource group does not have any dependencies on "Dependent" and
> "Dependencies" tabs so we can commit this patch.
>
> Thanks,
> Neel Patel
>
> On Tue, Feb 16, 2016 at 11:56 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> On Mon, Feb 15, 2016 at 12:05 PM, Neel Patel > > wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find below review comments.
>>>
>>>- We are getting error at python side saying "*AttributeError:
>>>'Response' object has no attribute 'strip'*"
>>>- "CPU Rate Limit" and "Dirty Rate Limit" should not allowed to
>>>enter the character (a-z). Currently it allows to enter invalid character
>>>so we are getting below SQL error saying "*LINE 2: SET
>>>cpu_rate_limit = 4545, dirty_rate_limit = gfgf;*"
>>>
>>> Both above errors are due to not validated "CPU Rate Limit" and "Dirty
>>> Rate Limit" fields.
>>>
>>
>>To fixed the above I have implemented NumericControl with validation.
>> I have already send separate patch for that. Attached is the new patch
>> which contains the above fix, documentation and fix for "Refresh Properties
>> tab after adding/updating the node". Before applying this patch, you need
>> to apply the NumericControl patch. Please review it.
>>
>>>
>>> Thanks,
>>> Neel Patel
>>>
>>> On Mon, Feb 8, 2016 at 4:13 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi All

 Attached is the patch with the fixes. Please review it and if looks
 good then please commit it.

 On Mon, Feb 8, 2016 at 11:54 AM, Neel Patel <
 neel.pa...@enterprisedb.com> wrote:

> Hi Akshay,
>
> Please find below review comments.
>
>  - As per the pgAdmin3, we should allow to enter the floating point
> value in "CPU Rate Limit" and "Dirty Rate Limit".
>
   Fixed.

  - While creating resource group, we are getting error saying 
 "*generate_browser_node()
> missing 1 required positional argument: 'label'*".
>
  Fixed.

  - Valid range for CPU Rate Limit and Dirty Rate Limit is from 0 to
> 1.67772e+07. We are not able to enter the maximum limit value while
> creating the
>resource group.
>

  Partially fixed, I have limit the max length to 8 digits, but not
 able to fixed it to the exact range.

>
> Thanks,
> Neel Patel
>
> On Fri, Feb 5, 2016 at 6:15 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> I have added logic to show sql in the "SQL" tab on dashboard and also
>> fixed some warnings. Please refer and review this patch.
>>
>> On Thu, Feb 4, 2016 at 5:50 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All
>>>
>>> Attached is the patch for the Resource Group Module. Please review
>>> it and if it looks good then please commit it.
>>>
>>> --
>>> *Akshay Joshi*
>>> *Principal Software Engineer *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91
>>> 976-788-8246*
>>>
>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91
>> 976-788-8246*
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org
>> )
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


 --
 *Akshay Joshi*
 *Principal Software Engineer *



 *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*

>>>
>>>
>>
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246*
>>
>
>


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: public in the privilege control should not be allowed

2016-02-22 Thread Ashesh Vashi 
public in the privilege control should not be allowed to select the
'WITH GRANT' options.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0b956813d4250200145a290c0e99d53a005fe280
Author: Harshal Dhumal 

Modified Files
--
.../server_groups/servers/static/js/privilege.js   | 289 -
1 file changed, 163 insertions(+), 126 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add support for displaying dependency and dependents

2016-02-22 Thread Dave Page 
Add support for displaying dependency and dependents info.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c153032e3bffc4acb88d513a484a150259b64864
Author: Akshay Joshi 

Modified Files
--
.../server_groups/servers/databases/__init__.py|  35 +++
.../databases/templates/databases/js/databases.js  |   1 +
.../server_groups/servers/roles/__init__.py| 144 ++-
.../servers/roles/templates/role/js/role.js|   3 +
.../templates/role/sql/post8_4/dependents.sql  |  40 +++
.../templates/role/sql/post9_0/dependents.sql  |  40 +++
.../templates/role/sql/post9_1/dependents.sql  |  40 +++
.../templates/role/sql/post9_4/dependents.sql  |  40 +++
.../server_groups/servers/tablespaces/__init__.py  | 144 +++
.../templates/tablespaces/js/tablespaces.js|   1 +
.../tablespaces/sql/9.1_plus/dependents.sql|  20 ++
.../tablespaces/sql/9.2_plus/dependents.sql|  20 ++
.../tablespaces/sql/pre_9.1/dependents.sql |  20 ++
.../templates/depends/sql/9.1_plus/dependents.sql  |  90 +++
.../browser/templates/browser/js/browser.js|   4 +-
web/pgadmin/browser/utils.py   | 204 
web/pgadmin/misc/depends/__init__.py   |  28 +++
web/pgadmin/misc/depends/static/js/depends.js  | 271 +
18 files changed, 1140 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Dependecies/Dependents functionality

2016-02-22 Thread Dave Page 
Thanks - patch applied.

On Mon, Feb 22, 2016 at 7:57 AM, Akshay Joshi  wrote:

> Hi All
>
> I have modified the logic as per suggested by Dave. In new implementation
> I have added two methods "get_dependencies" and "get_dependents"  to the
> class "PGChildNodeView".  As per Ashesh's last commit all the
> view(respective node's view) classes is derived from "PGChildNodeView"
> instead of "NodeView", the above two methods will be directly accessible
> in the respective node's view class. If there is a change in the
> functionality to fetch dependencies/dependents for any node, developer of
> that node can easily overload the function and provide their own logic.
> Following are the changes need to be done to add this feature
>
> *Add following lines of code in** .js*
>
>- Add *hasDepends: true *in your file just like we have added *hasSQL*
>.
>
> *Add following lines of code in .__init__.py*
>
> Derive your view class from "PGChildNodeView" instead of "NodeView".
>
> Implement the dependents and dependencies function like below. Pass the
> appropriate node id to the functions "get_dependents" and
> "get_dependencies".
>
> @check_precondition
> def dependents(self, gid, sid, did, lid):
> """
> This function get the dependents and return ajax response
> for the language node.
>
> Args:
> gid: Server Group ID
> sid: Server ID
> did: Database ID
> lid: Language ID
> """
> dependents_result = self.get_dependents(self.conn, lid)
> return ajax_response(
> response=dependents_result,
> status=200
> )
>
> @check_precondition
> def dependencies(self, gid, sid, did, lid):
> """
> This function get the dependencies and return ajax response
> for the language node.
>
> Args:
> gid: Server Group ID
> sid: Server ID
> did: Database ID
> lid: Language ID
> """
> dependencies_result = self.get_dependencies(self.conn, lid)
> return ajax_response(
> response=dependencies_result,
> status=200
> )
>
> On Fri, Feb 19, 2016 at 6:51 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Fri, Feb 19, 2016 at 6:45 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Fri, Feb 19, 2016 at 1:09 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Dave

 On Fri, Feb 19, 2016 at 5:45 PM, Dave Page  wrote:

> Hi
>
> On Fri, Feb 19, 2016 at 10:17 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> I have implemented the logic to show Dependencies/Dependents when
>> user click on browser nodes. Attached is the patch file, please review it
>> and if it looks good then please commit it.
>>
>> I have also added this support in "Database" , "Tablespace" and
>> "Role" as this nodes are already been committed. Following is the
>> information about how to add the support in other nodes
>>
>
> It seems to me that this patch is implemented in a way to violates
> modularity - specifically, it adds smarts about a child node into the code
> for a parent node, rather than leaving each node to be self-contained. For
> example, web/pgadmin/browser/server_groups/servers/depends.py contains the
> SQL and other logic for displaying the dependencies and dependents of
> tablespace and role nodes.
>
> I would expect to see role-specific code confined to the roles module,
> database-specific confined to the database module and so on.
>

If I understand you correctly, you want me to remove logic to fetch
 dependencies/dependent for the "Tablespace" and "Role" node from the
 web/pgadmin/browser/server_groups/servers/depends.py and added it into
 the respective nodes? Logic to fetch Dependents is different for "
 Tablespace" and "Role", but to fetch Dependencies logic is generic for
 all the nodes( for sequence node we have one extra query).  Similarly to
 fetch dependents we will have one extra query for Table and Column Node, so
 you want me to remove that part as well? in that case it's responsibility
 of the developer who will implement the Table/Column/Sequence node to add
 that logic later?

>>>
>>> Yes. Each node should be self-contained, and not include any non-generic
>>> code relating to other nodes.
>>>
>>
>>OK. Will do that
>>
>>>
>>>
>>
>>>

   I have followed the pgAdmin3 code here, and also thought that it's
 better to have whole logic to fetch Dependencies/Dependent in a single
 file, instead of having some code (generic logic) in one file(depends.
 py) and some part in respective modules __init__.py.

>>>
>>> Well you can still have only a single copy of any generic code - put it
>>>

Re: [pgadmin-hackers] [pgAdmin4] [Patch]: Language Module

2016-02-22 Thread Akshay Joshi 
Hi All

Attached is the modified patch with support of Dependents and Dependencies
tabs. Please review it.

On Mon, Feb 22, 2016 at 5:29 PM, Dave Page  wrote:

>
>
> On Mon, Feb 22, 2016 at 10:53 AM, Dave Page  wrote:
>
>>
>>
>> On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi All
>>>
>>> On Mon, Feb 15, 2016 at 3:47 PM, Dave Page  wrote:
>>>


 On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi All
>
> Attached is the new patch after fixing review comments given by Dave.
>
> On Fri, Feb 12, 2016 at 10:04 PM, Dave Page  wrote:
>
>>
>>
>> On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal <
>> harshal.dhu...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> New language patch is working fine.
>>> Ashesh - Can you please review it ?
>>> If it looks good then can you please commit ?
>>>
>>> Thank you,
>>> Harshal
>>>
>>
>> A few comments:
>>
>> - We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't
>> we also therefore omit DROP LANGUAGE?
>>
> Fixed.
>
>> - Please leave a blank line between the file header and python code
>> in python files.
>>
> Fixed.
>
>> - The pydoc module description is missing from __init__.py
>>
> Fixed.
>
>> - What about the Dependents and Dependencies tabs?
>>
>  Infrastructure is not ready, so not implemented yet.
>

 The first person that needs it should be working on it! I don't want to
 be committing partially completed features, otherwise we'll have to come
 back and revisit them all when the infrastructure is done.

 Having done it before for pgAdmin 3, I don't imagine it's hard. It's
 really just the same as the Statistics view. Please take a look at it
 (assuming noone else is already).

>>>
>>>Fixed. Attached is the modified patch with support of Dependents and
>>> Dependencies tabs. Please review it.
>>>
>>
>> Committed, with a couple of additional minor changes:
>>
>> - s/resourcegroups/resource_groups (for consistency with server_groups)
>>
>> - Added a PyDoc module description to __init__.py
>>
>
> Oops, wrong thread. Please ignore.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*


Languages_v4.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Fixed runtime compilation error for Qt4

2016-02-22 Thread Neel Patel 
Hi All,

As sandeep from EDB was doing the setup for pgAdmin4 runtimes in CentOS 7
with Qt4 and found that there were some compilation errors.

Please find the attached patch file which will fix the below compilation
errors for Qt4.

   - QtWebKitWidgets should only be included in Qt5. There is no such
   header in Qt4.
   - QUrl class does not have "url()" function in Qt4 so when we compile
   the code in Qt4 it gives error saying "no such function url()". This is
   fixed by adding common method ( "host()" ) available in both the version of
   Qt.
   - In QTcpSocket class, there is no "bind" method available in Qt4 so it
   gives error during the compilation.
   - "QThread::sleep(1)" is the public method in Qt5 while it is protected
   in Qt4 so we can not use the same method in Qt4. We have written delay
   function to replace this method.
   - Removed "cache()" from Qt project file. Cache file is required by
   qmake to read special setting specified other then project and qmake.conf
   file, as we have not specified any special configuration other then project
   file so we have removed this function.

We have tested in both the versions Qt4 and Qt5 and now it is compiling
without any errors.

Do review it and let us know in case of any comments/queries.

Thanks,
Neel Patel


runtime_compilation_error_fix.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers