Hi
You're going to hate me for this
- I added an un-validated constraint to a domain, then opened the
domain properties and clicked the Validate? option for it. The SQL is
generated, but the Save button is not enabled.
- If I right-click a domain, I get Create options for "Domain" (with a
constraint icon) and "Domain..." with a domain icon.
See attached screenshot.
Thanks.
On Thu, Mar 24, 2016 at 9:54 AM, Khushboo Vashi
wrote:
> Hi,
>
> Please find the attached updated patch for the Domain module.
>
> Thanks,
> Khushboo
>
> On Wed, Mar 23, 2016 at 6:35 PM, Dave Page wrote:
>>
>> Hi
>>
>> Almost there :-s
>>
>> - The hint for default should be a placeholder in the textbox itself
>> (like combos have "Select from the list"
>
> Done
>>
>> - I should be able to check the "Validate?" option on one or more
>> constraints from within the Domain dialogue
>
> Done.
> Constraint Name can also be changed through the Domain dialogue.
>>
>> - Please ensure the capitalisation of all property labels is
>> consistent - it should be "Base type" not "Base Type", "System
>> domain?" not "System Domain?" etc.
>
> Done
>>
>> - The check constraint reverse engineered SQL should include the path
>> to the constraint, e.g.
>>
> Done
>>
>> -- CHECK: schema.domain.check_at
>>
>> Once that's done, it can be committed I think.
>>
>> Thanks.
>>
>> On Wed, Mar 23, 2016 at 7:27 AM, Khushboo Vashi
>> wrote:
>> > Updated one comment.
>> >
>> > On Wed, Mar 23, 2016 at 12:48 PM, Khushboo Vashi
>> > wrote:
>> >>
>> >> Hi,
>> >>
>> >> Please find attached updated patch for the Domains module.
>> >>
>> >> On Wed, Mar 16, 2016 at 9:40 PM, Dave Page wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> On Wed, Mar 16, 2016 at 2:03 PM, Khushboo Vashi
>> >>> wrote:
>> >>> > Hi,
>> >>> >
>> >>> > Please find the updated Domain Module Patch.
>> >>> >
>> >>> > To test this patch, please apply Backgrid Textarea Cell Patch before
>> >>> > this.
>> >>>
>> >>> Thanks. I believe with the following fixes, we'll be done :-)
>> >>>
>> >>> - Default values should be auto-quoted when necessary (ie. strings, on
>> >>> a text-based domain).
>> >>
>> >> As per our discussion, this should leave unquoted.
>> >
>> > And also added a hint to the field stated 'Enter an expression or a
>> > value.'
>> >>
>> >>
>> >>> - "System Domain?" should be in the General section, between owner and
>> >>> comment.
>> >>
>> >> Done
>> >>>
>> >>> - The switches should use the same colouring/styling as other objects,
>> >>> e.g.
>> >>>
>> >>> options: {
>> >>> 'onText': 'Yes', 'offText': 'No',
>> >>> 'onColor': 'success', 'offColor': 'primary',
>> >>> 'size': 'small'
>> >>> }
>> >>
>> >> Done
>> >>>
>> >>> - Please remove the Schema property from the main properties tab (not
>> >>> the properties dialogue).
>> >>
>> >> Done
>> >>>
>> >>> - No icon is show for Checks on the Dependents tab for a domain.
>> >>
>> >> Done
>> >>>
>> >>> - The add button on the Security Labels tab is spelt "Add". Why is
>> >>> that? Other instances of this grid use "ADD" which is the default in
>> >>> backform.pgadmin.js.
>> >>
>> >> Done
>> >>>
>> >>> - Dependencies on domain check constraints are listed as being on a
>> >>> "Type" not a "Domain".
>> >>
>> >> Done
>> >>>
>> >>> - If adding a domain constraint using the grid on the Domain dialogue,
>> >>> I cannot specify "NOT VALID". We need a checkbox for that in a narrow
>> >>> columns at the end. Unchecking it for an existing constraint should be
>> >>> the equivalent of doing "ALTER DOMAIN ... VALIDATE CONSTRAINT"
>> >>
>> >> Done
>> >>>
>> >>> - If I switch the "Don't Validate" switch on a constraint, there are
>> >>> leading blank lines in the generated SQL. The same occurs when adding
>> >>> a comment to a constraint.
>> >>
>> >> Done
>> >>>
>> >>> - I think we need to reverse the meaning of "Don't Validate" and
>> >>> rename to match the "Valid?" field that's on the properties list.
>> >>> Otherwise it's not clear they're the same thing.
>> >>
>> >> Done
>> >>>
>> >>> - s/Not Null/Not Null?/
>> >>
>> >> Done
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com
>> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
