Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Ashesh Vashi
Thanks.
On May 25, 2016 21:01, "Thom Brown"  wrote:

> Thanks.  I've raised all of these in tickets 1231 to 1237.
>
> Thom
>
> On 25 May 2016 at 04:23, Ashesh Vashi 
> wrote:
>
>> Hi Thom,
>>
>> Can you please create RM cases for the same, it will be easy to track
>> those issues?
>> We're using "https://redmine.postgresql.org/projects/pgadmin4/"; for the
>> same.
>>
>> --
>>
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Wed, May 25, 2016 at 6:42 AM, Thom Brown  wrote:
>>
>>> On 25 May 2016 at 02:00, Thom Brown  wrote:
>>> > On 25 May 2016 at 00:29, Thom Brown  wrote:
>>> >> On 24 May 2016 at 19:09, Ashesh Vashi 
>>> wrote:
>>> >>>
>>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> >>>  wrote:
>>> 
>>>  Hi,
>>> 
>>>  PFA patch, which will fixes below mentioned issues,
>>> >>>
>>> >>> Committed.
>>> >>
>>> >>
>>> >> In the Create Table dialog, on the Advanced tab, the "Of type"
>>> drop-down
>>> >> lists tables and composite types, but those are supposed to just be
>>> >> composite types.
>>> >>
>>> >> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE
>>> should
>>> >> be disabled when using OF.  Also, there should probably be a way of
>>> setting
>>> >> options for the columns taken from the composite type.  For example:
>>> >>
>>> >> CREATE TYPE inventory AS (product_id bigint, product_name text, weight
>>> >> numeric);
>>> >>
>>> >> CREATE TABLE stock OF inventory (
>>> >> PRIMARY KEY (product_id),
>>> >> weight WITH OPTIONS DEFAULT 0
>>> >> );
>>> >>
>>> >> There's currently no way of doing this (neither the primary key, nor
>>> the
>>> >> default value for any columns).  It should probably automatically
>>> populate
>>> >> the columns from the composite type on the columns tab.
>>> >>
>>> >> Also, could the generated SQL have an empty line between each
>>> statement?
>>> >
>>> > Another thing I've noticed is that, when adding columns, the "Is
>>> > primary key?" column is greyed out.  Why not just make those
>>> > modifiable in that view rather than having to go into the details for
>>> > each column?
>>> >
>>> > When there's something that hasn't been set up correctly, like adding
>>> > variables for a column, but not actually selecting a variable, the SQL
>>> > pane, correctly, doesn't show an output, but the error message,
>>> > "Please provide input for variable." isn't enough to identify what
>>> > needs checking.  Could the relevant tab and field/row be
>>> > highlighted/coloured in red/bold?  This is more general, so doesn't
>>> > just apply to the create table dialog.
>>>
>>> Last issue today:
>>>
>>> When using "Of type", it's not valid to allow additional columns to be
>>> added, so those should be prevented.
>>>
>>> Thom
>>>
>>
>>
>


[pgadmin-hackers] PATCH: To fix issue in procedure node (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi,

PFA patch to fix the issue in procedure node where only create new
procedure option is available to user (Drop/Properties etc were missing).
(RM-1123)

Additional enhancements:
- Remove arguments from drop statments as procedure can drop only by its
name.
- Remove "Drop cascade" option as procedure do not support it
- Fetch schema name along with procedure name for EXEC Script


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1123.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin4][Patch]: Load nodes under schema at database level

2016-05-26 Thread Surinder Kumar
Hi,

*Issue*: Following nodes :

   1. *domains*
   2. *foreign tables*
   3. *fts configurations*
   4. *fts dictionary and*
   5. *functions*

lists server nodes instead of their child nodes which is wrong.

It is because their javascript files are set to load at schema level, but
they should load at database level.

Please find attached patch and review.

Thanks
Surinder Kumar


load_nodes_on_database_level.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Thom Brown
On 26 May 2016 at 11:20, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch for RM#1231 & RM#1237.
>
> Additionally I have shifted 'Advanced tab' after columns & constraint tab.
>
>
> @Thom,
>
> Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to
> populate "Of type" combo box as given below.
> I was not able to find a way to differentiate between table & composite
> type populating from below given query,
> I'll put in todo list, may be someone from community can help in future.
>
> SELECT t.oid,
>   quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
>   FROM pg_type t, pg_namespace n
> WHERE t.typtype='c' AND t.typnamespace=n.oid
>   AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
> ORDER BY typname;
>
>
This should work:

SELECT c.oid,
  quote_ident(n.nspname)||'.'||quote_ident(c.relname) AS typname
  FROM pg_namespace n, pg_class c
WHERE c.relkind = 'c' AND c.relnamespace=n.oid
  AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
ORDER BY typname;

Although, to avoid confusion, the "typname" alias should probably just be
"relname".

Thom


Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi,

PFA patch for RM#1231 & RM#1237.

Additionally I have shifted 'Advanced tab' after columns & constraint tab.


@Thom,

Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to
populate "Of type" combo box as given below.
I was not able to find a way to differentiate between table & composite
type populating from below given query,
I'll put in todo list, may be someone from community can help in future.

SELECT t.oid,
  quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
  FROM pg_type t, pg_namespace n
WHERE t.typtype='c' AND t.typnamespace=n.oid
  AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
ORDER BY typname;


Regards,
Murtuza


On 25-May-2016, at 9:34 pm, Ashesh Vashi 
wrote:

Thanks.
On May 25, 2016 21:01, "Thom Brown"  wrote:

> Thanks.  I've raised all of these in tickets 1231 to 1237.
>
> Thom
>
> On 25 May 2016 at 04:23, Ashesh Vashi 
> wrote:
>
>> Hi Thom,
>>
>> Can you please create RM cases for the same, it will be easy to track
>> those issues?
>> We're using "https://redmine.postgresql.org/projects/pgadmin4/"; for the
>> same.
>>
>> --
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> 
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> 
>>
>> On Wed, May 25, 2016 at 6:42 AM, Thom Brown  wrote:
>>
>>> On 25 May 2016 at 02:00, Thom Brown  wrote:
>>> > On 25 May 2016 at 00:29, Thom Brown  wrote:
>>> >> On 24 May 2016 at 19:09, Ashesh Vashi 
>>> wrote:
>>> >>>
>>> >>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> >>>  wrote:
>>> 
>>>  Hi,
>>> 
>>>  PFA patch, which will fixes below mentioned issues,
>>> >>>
>>> >>> Committed.
>>> >>
>>> >>
>>> >> In the Create Table dialog, on the Advanced tab, the "Of type"
>>> drop-down
>>> >> lists tables and composite types, but those are supposed to just be
>>> >> composite types.
>>> >>
>>> >> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE
>>> should
>>> >> be disabled when using OF.  Also, there should probably be a way of
>>> setting
>>> >> options for the columns taken from the composite type.  For example:
>>> >>
>>> >> CREATE TYPE inventory AS (product_id bigint, product_name text, weight
>>> >> numeric);
>>> >>
>>> >> CREATE TABLE stock OF inventory (
>>> >> PRIMARY KEY (product_id),
>>> >> weight WITH OPTIONS DEFAULT 0
>>> >> );
>>> >>
>>> >> There's currently no way of doing this (neither the primary key, nor
>>> the
>>> >> default value for any columns).  It should probably automatically
>>> populate
>>> >> the columns from the composite type on the columns tab.
>>> >>
>>> >> Also, could the generated SQL have an empty line between each
>>> statement?
>>> >
>>> > Another thing I've noticed is that, when adding columns, the "Is
>>> > primary key?" column is greyed out.  Why not just make those
>>> > modifiable in that view rather than having to go into the details for
>>> > each column?
>>> >
>>> > When there's something that hasn't been set up correctly, like adding
>>> > variables for a column, but not actually selecting a variable, the SQL
>>> > pane, correctly, doesn't show an output, but the error message,
>>> > "Please provide input for variable." isn't enough to identify what
>>> > needs checking.  Could the relevant tab and field/row be
>>> > highlighted/coloured in red/bold?  This is more general, so doesn't
>>> > just apply to the create table dialog.
>>>
>>> Last issue today:
>>>
>>> When using "Of type", it's not valid to allow additional columns to be
>>> added, so those should be prevented.
>>>
>>> Thom
>>>
>>
>>
>


RM_1231_1237.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] [PATCH] Tables node (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi,

PFA updated patch which will also include new query given by Thom for "Of
type" drop-down.


Regards,
Murtuza


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, May 26, 2016 at 4:04 PM, Thom Brown  wrote:

> On 26 May 2016 at 11:20, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA patch for RM#1231 & RM#1237.
>>
>> Additionally I have shifted 'Advanced tab' after columns & constraint tab.
>>
>>
>> @Thom,
>>
>> Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to
>> populate "Of type" combo box as given below.
>> I was not able to find a way to differentiate between table & composite
>> type populating from below given query,
>> I'll put in todo list, may be someone from community can help in future.
>>
>> SELECT t.oid,
>>   quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
>>   FROM pg_type t, pg_namespace n
>> WHERE t.typtype='c' AND t.typnamespace=n.oid
>>   AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
>> ORDER BY typname;
>>
>>
> This should work:
>
> SELECT c.oid,
>   quote_ident(n.nspname)||'.'||quote_ident(c.relname) AS typname
>   FROM pg_namespace n, pg_class c
> WHERE c.relkind = 'c' AND c.relnamespace=n.oid
>   AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
> ORDER BY typname;
>
> Although, to avoid confusion, the "typname" alias should probably just be
> "relname".
>
> Thom
>


RM_1231_1237.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Documentation patch for pgAdmin 4

2016-05-26 Thread Dave Page
Hi

On Wed, May 25, 2016 at 3:26 PM, Susan Douglas
 wrote:
> Hi All,
>
> I've attached a patch that adds new dialog descriptions to the pgAdmin 4 
> documentation... Thanks!

I see the following issues when building the docs with this patch. Can
you please fix and resend?

/Users/dpage/git/pgadmin4/docs/en_US/foreign_server_dialog.rst:60:
WARNING: image file not readable:
images/foreign_server_sql_example.png
/Users/dpage/git/pgadmin4/docs/en_US/type_dialog.rst:24: WARNING:
image file not readable: images/type_definition.png
/Users/dpage/git/pgadmin4/docs/en_US/type_dialog.rst:117: WARNING:
image file not readable: images/type_sql_example.png
/Users/dpage/git/pgadmin4/docs/en_US/user_mapping_dialog.rst:3:
SEVERE: Title overline & underline mismatch.


The User Mapping Dialog
*

checking consistency...
/Users/dpage/git/pgadmin4/docs/en_US/materialized_view_dialog.rst::
WARNING: document isn't included in any toctree

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Auto-run setup.py if the config database doesn't exis

2016-05-26 Thread Dave Page
Auto-run setup.py if the config database doesn't exist.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0dabbf3dad6e8e84f1a51c59ee4ed971ce01d1b9
Author: Paresh More 

Modified Files
--
web/pgAdmin4.py | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] PATCH: To fix an issue with port validation (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi,

PFA patch to fix an issue where we are allowing to enter port till 65534
and not 65535.
(RM-1147)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1147.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] PATCH: pgAdmin4 windows installer

2016-05-26 Thread Dave Page
Hi

On Fri, May 20, 2016 at 9:33 AM, Paresh More 
wrote:

> Hello Dave.
>
> Attached are two patch for pgAdmin4-windows
>
> pgAdmin4_createDB.patch
> - patch for pgAdmin4.py to autocreate database configuration if does not
> exist.
> - Now pgadmin.db would be not be bundled with installer, it would be
> created if pgAdmin4.py is executed for the first time.
>

This is committed.


>
> *pgAdmin4_windows.patch*
> - Environment variables once set will over ride the existing script
> variables.
> - Issue related to path with quotes are removed.
> - New Readme.txt is added.
> - Modified Error reporting.
> - Python check was missing related to which requirement file it should
> pick for creating private environment based on python version is also fixed.
>

Attached is an update to this patch, which modifies the following:

- Avoids trashing a pre-existing config_local.py, and creates a very simple
one in the staging directory.

- Various tidy-ups of Make.bat.

- Change the default path to %ProgramFiles%\pgAdmin 4\v (added the
v, as  on it's own looks weird)

Please update further to address the following issues. I need this
completed ASAP, thanks:

- Make.bat should take a "clean" parameter, to cleanup all output it
creates in normal mode.

- The package name in the installer should be set from config.py as the
version is.

- I see the following error:

  error: [Error 183] Cannot create a file when that file already exists:
'build\\bdist.win32\\wheel\\importlib-1.0.3.data\\..'

  
  Failed building wheel for importlib

- And the following error:

  C:\Users\dpage\AppData\Local\Programs\Common\Microsoft\Visual C++ for
Python\9.0\VC\Bin\link.exe /DLL /nologo /INCREMENTAL:NO
/LIBPATH:c:\python27\Libs
/LIBPATH:c:\users\dpage\documents\pgadmin4\pkg\win32\release\ve_python\libs
/LIBPATH:c:\users\dpage\documents\pgadmin4\pkg\win32\release\ve_python\PCbuild
/LIBPATH:c:\users\dpage\documents\pgadmin4\pkg\win32\release\ve_python\PC\VS9.0
/LIBPATH:C:/PROGRA~1/PG/pg95/lib ws2_32.lib advapi32.lib secur32.lib
libpq.lib shfolder.lib
build\temp.win32-2.7\Release\psycopg\psycopgmodule.obj
build\temp.win32-2.7\Release\psycopg\green.obj
build\temp.win32-2.7\Release\psycopg\pqpath.obj
build\temp.win32-2.7\Release\psycopg\utils.obj
build\temp.win32-2.7\Release\psycopg\bytes_format.obj
build\temp.win32-2.7\Release\psycopg\connection_int.obj
build\temp.win32-2.7\Release\psycopg\connection_type.obj
build\temp.win32-2.7\Release\psycopg\cursor_int.obj
build\temp.win32-2.7\Release\psycopg\cursor_type.obj
build\temp.win32-2.7\Release\psycopg\diagnostics_type.obj
build\temp.win32-2.7\Release\psycopg\error_type.obj
build\temp.win32-2.7\Release\psycopg\lobject_int.obj
build\temp.win32-2.7\Release\psycopg\lobject_type.obj
build\temp.win32-2.7\Release\psycopg\notify_type.obj
build\temp.win32-2.7\Release\psycopg\xid_type.obj
build\temp.win32-2.7\Release\psycopg\adapter_asis.obj
build\temp.win32-2.7\Release\psycopg\adapter_binary.obj
build\temp.win32-2.7\Release\psycopg\adapter_datetime.obj
build\temp.win32-2.7\Release\psycopg\adapter_list.obj
build\temp.win32-2.7\Release\psycopg\adapter_pboolean.obj
build\temp.win32-2.7\Release\psycopg\adapter_pdecimal.obj
build\temp.win32-2.7\Release\psycopg\adapter_pint.obj
build\temp.win32-2.7\Release\psycopg\adapter_pfloat.obj
build\temp.win32-2.7\Release\psycopg\adapter_qstring.obj
build\temp.win32-2.7\Release\psycopg\microprotocols.obj
build\temp.win32-2.7\Release\psycopg\microprotocols_proto.obj
build\temp.win32-2.7\Release\psycopg\typecast.obj
/OUT:build\lib.win32-2.7\psycopg2\_psycopg.pyd
/IMPLIB:build\temp.win32-2.7\Release\psycopg\_psycopg.lib
/MANIFESTFILE:build\temp.win32-2.7\Release\psycopg\_psycopg.pyd.manifest
  LINK : fatal error LNK1181: cannot open input file 'libpq.lib'
  error: command
'C:\\Users\\dpage\\AppData\\Local\\Programs\\Common\\Microsoft\\Visual C++
for Python\\9.0\\VC\\Bin\\link.exe' failed with exit status 1181

  
  Failed building wheel for psycopg2

  %PGDIR% is set to: C:/Program Files (x86)/PostgreSQL/9.5, but note that
/LIBPATH is including "C:/PROGRA~1/PG/pg95/lib".

- As far as I can see, the Helpfiles are not built or bundled (talk to
Sandeep about this)

- No Start Menu icon is created.

- Why is 3rd_party_licences.txt included? We don't need that.

- pkg/win32/installer.iss should be added to a .gitignore file.

- SplashScreen.bmp doesn't seem to be used (though it is referenced from
the installer config file.

- Running the app fails with the following (I suspect because of the
psycopg2 issue above):

---
Setup
---
Unable to execute file:
C:\Program Files (x86)\pgAdmin 4\v1\runtime\pgAdmin4.exe

CreateProcess failed; code 2.
The system cannot find the file specified.
---
OK
---

The only file in that directory is python27.dll. This is probably caused by
this:

fatal error LNK1112: module machin

[pgadmin-hackers] pgAdmin 4 commit: s/domain-constraints/domain_constraints for consisten

2016-05-26 Thread Dave Page
s/domain-constraints/domain_constraints for consistency.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7aea8f85364b3bfdf7769168165a4a8d05e3cadb

Modified Files
--
.../schemas/domains/domain-constraints/__init__.py | 690 -
.../static/img/coll-domain-constraints.png | Bin 314 -> 0 bytes
.../static/img/domain-constraints-bad.png  | Bin 579 -> 0 bytes
.../static/img/domain-constraints.png  | Bin 406 -> 0 bytes
.../domain-constraints/css/domain-constraints.css  |  23 -
.../domain-constraints/js/domain-constraints.js| 145 -
.../domain-constraints/sql/9.1_plus/create.sql |   3 -
.../domain-constraints/sql/9.1_plus/delete.sql |   4 -
.../domain-constraints/sql/9.1_plus/get_domain.sql |   8 -
.../domain-constraints/sql/9.1_plus/get_oid.sql|   7 -
.../domain-constraints/sql/9.1_plus/properties.sql |  14 -
.../domain-constraints/sql/9.1_plus/update.sql |   3 -
.../domain-constraints/sql/9.2_plus/create.sql |  10 -
.../domain-constraints/sql/9.2_plus/delete.sql |   4 -
.../domain-constraints/sql/9.2_plus/get_domain.sql |   8 -
.../domain-constraints/sql/9.2_plus/get_oid.sql|   7 -
.../sql/9.2_plus/get_type_category.sql |   5 -
.../domain-constraints/sql/9.2_plus/properties.sql |  17 -
.../domain-constraints/sql/9.2_plus/update.sql |  13 -
.../schemas/domains/domain_constraints/__init__.py | 690 +
.../static/img/coll-domain_constraints.png | Bin 0 -> 314 bytes
.../static/img/domain_constraints-bad.png  | Bin 0 -> 579 bytes
.../static/img/domain_constraints.png  | Bin 0 -> 406 bytes
.../domain_constraints/css/domain_constraints.css  |  23 +
.../domain_constraints/js/domain_constraints.js| 145 +
.../domain_constraints/sql/9.1_plus/create.sql |   3 +
.../domain_constraints/sql/9.1_plus/delete.sql |   4 +
.../domain_constraints/sql/9.1_plus/get_domain.sql |   8 +
.../domain_constraints/sql/9.1_plus/get_oid.sql|   7 +
.../domain_constraints/sql/9.1_plus/properties.sql |  14 +
.../domain_constraints/sql/9.1_plus/update.sql |   3 +
.../domain_constraints/sql/9.2_plus/create.sql |  10 +
.../domain_constraints/sql/9.2_plus/delete.sql |   4 +
.../domain_constraints/sql/9.2_plus/get_domain.sql |   8 +
.../domain_constraints/sql/9.2_plus/get_oid.sql|   7 +
.../sql/9.2_plus/get_type_category.sql |   5 +
.../domain_constraints/sql/9.2_plus/properties.sql |  17 +
.../domain_constraints/sql/9.2_plus/update.sql |  13 +
38 files changed, 961 insertions(+), 961 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] pgAdmin 4 commit: Additional docs from Susan.

2016-05-26 Thread Dave Page
Additional docs from Susan.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b85fa58344d7c68c60a2fd433cb65ea137a3fc5a

Modified Files
--
docs/en_US/domain_dialog.rst   |  81 
docs/en_US/foreign_server_dialog.rst   |  66 ++
docs/en_US/fts_configuration_dialog.rst|  61 +
docs/en_US/fts_dictionary_dialog.rst   |  61 +
docs/en_US/images/foreign_server_definition.png| Bin 0 -> 34726 bytes
docs/en_US/images/foreign_server_general.png   | Bin 0 -> 39331 bytes
docs/en_US/images/foreign_server_options.png   | Bin 0 -> 39514 bytes
docs/en_US/images/foreign_server_security.png  | Bin 0 -> 44105 bytes
docs/en_US/images/foreign_server_sql.png   | Bin 0 -> 63914 bytes
docs/en_US/images/fts_configuration_definition.png | Bin 0 -> 39500 bytes
docs/en_US/images/fts_configuration_general.png| Bin 0 -> 42191 bytes
docs/en_US/images/fts_configuration_sql.png| Bin 0 -> 53042 bytes
docs/en_US/images/fts_configuration_tokens.png | Bin 0 -> 42069 bytes
docs/en_US/images/materialized_view_definition.png | Bin 0 -> 34160 bytes
docs/en_US/images/materialized_view_general.png| Bin 0 -> 43921 bytes
docs/en_US/images/materialized_view_security.png   | Bin 0 -> 53850 bytes
docs/en_US/images/materialized_view_sql.png| Bin 0 -> 65319 bytes
docs/en_US/images/materialized_view_storage.png| Bin 0 -> 74586 bytes
docs/en_US/images/type_composite.png   | Bin 0 -> 25971 bytes
docs/en_US/images/type_definition.png  | Bin 0 -> 38541 bytes
docs/en_US/images/type_enumeration.png | Bin 0 -> 25954 bytes
docs/en_US/images/type_external.png| Bin 0 -> 28343 bytes
docs/en_US/images/type_general.png | Bin 0 -> 26220 bytes
docs/en_US/images/type_range.png   | Bin 0 -> 30674 bytes
docs/en_US/images/type_security.png| Bin 0 -> 31316 bytes
docs/en_US/images/type_shell.png   | Bin 0 -> 21101 bytes
docs/en_US/images/type_sql.png | Bin 0 -> 44258 bytes
docs/en_US/images/user_mapping_general.png | Bin 0 -> 26048 bytes
docs/en_US/images/user_mapping_options.png | Bin 0 -> 25836 bytes
docs/en_US/images/user_mapping_sql.png | Bin 0 -> 32799 bytes
docs/en_US/images/view_definition.png  | Bin 0 -> 37470 bytes
docs/en_US/images/view_general.png | Bin 0 -> 39864 bytes
docs/en_US/images/view_security.png| Bin 0 -> 49497 bytes
docs/en_US/images/view_sql.png | Bin 0 -> 71367 bytes
docs/en_US/index.rst   |  18 ++-
docs/en_US/materialized_view_dialog.rst|  79 
docs/en_US/type_dialog.rst | 143 +
docs/en_US/user_mapping_dialog.rst |  48 +++
docs/en_US/view_dialog.rst |  73 +++
.../templates/user_mappings/js/user_mappings.js|   1 +
.../domains/templates/domains/js/domains.js|   1 +
.../fts_configuration/js/fts_configuration.js  |   1 +
.../templates/fts_dictionary/js/fts_dictionary.js  |   1 +
.../schemas/types/templates/type/js/type.js|   1 +
.../schemas/views/templates/mview/js/mview.js  |   1 +
.../schemas/views/templates/view/js/view.js|   1 +
46 files changed, 634 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] PATCH: To fix issue in removing comments in edit mode (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi,

PFA patch to fix the issue in function/procedure/trigger-function node
while updating comments.
(RM#1142)


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1142.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] PATCH: To fix issue in updating comments (pgAdmin4)

2016-05-26 Thread Murtuza Zabuawala
Hi,

PFA patch to fix the issue in updating comments in foreign data
wrapper/foreign table.
(RM#1143)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1143.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers