[pgadmin-hackers] pgAdmin 4 commit: Fix python detection on Linux/Mac.

[Dave Page]

Fix python detection on Linux/Mac.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4dc563d71caaf0a76256c6eb2c1e4de6e38de475

Modified Files
--
runtime/pgAdmin4.pro | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Improve detection of the runtime environment, and sub

[Dave Page]

Improve detection of the runtime environment, and subsequent self-configuration.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=262ae7d28c8c50670d71bfb2d4451153048c54bd

Modified Files
--
web/pgAdmin4.py | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Use a separate class to remove the footer space in th

[Ashesh Vashi]

Use a separate class to remove the footer space in the query editor,
when no of records in a page is set to 0 (or, less than 0). So that -
we do not loose CSS applied on the children DOM Elements dependent of
the original class.

This was regression of commit-id:
f9393aee4488c5f35eece0d2884ccf90ff13d7bf

We were loosing the formatting under the grid table due to this change.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=359b1d017600ae59bda992cb4eace1986be5b2fc

Modified Files
--
web/pgadmin/tools/sqleditor/static/css/sqleditor.css| 6 +-
web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js | 8 
2 files changed, 9 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgadmin4 qmake selects python 3 by default?

[Colin Beckingham]

On openSUSE Leap 42.1, using system with both python2- and 
python3-config, qmake selects python3.

---
qmake
Project MESSAGE: Building for QT4...
Project MESSAGE: Building for Linux/Mac...
Project MESSAGE: Using /usr/bin/python3-config
Project MESSAGE: Python3 detected.
---
Is this a deliberate choice, determined by my system or random? I am 
accustomed to seeing a default to python2, but if python3 works then not 
a problem.
I still am not able to tell if the runtime situation is up due to 
another error (Type str doesn't support the buffer API) which is still 
under investigation.



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] pgadmin4 qmake selects python 3 by default?

[Dave Page]

On Fri, Jun 17, 2016 at 11:02 AM, Colin Beckingham  wrote:
> On openSUSE Leap 42.1, using system with both python2- and python3-config,
> qmake selects python3.
> ---
> qmake
> Project MESSAGE: Building for QT4...
> Project MESSAGE: Building for Linux/Mac...
> Project MESSAGE: Using /usr/bin/python3-config
> Project MESSAGE: Python3 detected.
> ---
> Is this a deliberate choice, determined by my system or random? I am
> accustomed to seeing a default to python2, but if python3 works then not a
> problem.

It was, but on reflection I wonder if it's the best choice, given that
most of us are still using python2.

I'll switch it around.

> I still am not able to tell if the runtime situation is up due to another
> error (Type str doesn't support the buffer API) which is still under
> investigation.


-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: Patch to fix issue in trigger function (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA minor patch to fix the issue where we were getting 'index out of range'
while creating trigger function.
(RM#1212)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1212.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Replace runtime menu with shortcuts for a cleaner UI

[Dave Page]

Replace runtime menu with shortcuts for a cleaner UI (and
because 99% of users don't need those options anyway).

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e27c6280fae31d7062782949512ab7d5ded3425

Modified Files
--
runtime/BrowserWindow.cpp | 51 +--
runtime/BrowserWindow.h   | 14 ++---
2 files changed, 20 insertions(+), 45 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Favour Python 2 as it's more widely tested.

[Dave Page]

Favour Python 2 as it's more widely tested.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9dc1496e2ae62d69eefab9b9a22560748ca1df9

Modified Files
--
runtime/pgAdmin4.pro | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Patch to fix issue in trigger function (pgAdmin4)

[Murtuza Zabuawala]

++

Issue: Error was due to wrong ‘edbspl’ language selection, we have now exclude 
it for trigger function creation.


> On 17-Jun-2016, at 3:50 pm, Murtuza Zabuawala 
>  wrote:
> 
> Hi,
> 
> PFA minor patch to fix the issue where we were getting 'index out of range' 
> while creating trigger function.
> (RM#1212)
>  
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com 
> The Enterprise PostgreSQL Company
> 

[pgadmin-hackers] PATCH: To fix incorrect start date in Backup/Restore dialog (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA minor patch to fix the issue which was showing incorrect datetime in
Backup/Restore dialog.
(RM#1377)

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1377.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue in Restore/Backup dialog

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue in backup/restore while selecting section-> data
option, it was throwing error.
RM#1219

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1219.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: Patch to fix issue in trigger function (pgAdmin4)

[Dave Page]

Thanks, applied.

On Fri, Jun 17, 2016 at 11:37 AM, Murtuza Zabuawala
 wrote:
> ++
>
> Issue: Error was due to wrong ‘edbspl’ language selection, we have now
> exclude it for trigger function creation.
>
>
> On 17-Jun-2016, at 3:50 pm, Murtuza Zabuawala
>  wrote:
>
> Hi,
>
> PFA minor patch to fix the issue where we were getting 'index out of range'
> while creating trigger function.
> (RM#1212)
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
> 
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Don't allow creation of edbspl trigger functions (the

[Dave Page]

Don't allow creation of edbspl trigger functions (they should be created as 
part of the trigger). Fixes #1212.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=014eb2a5c27735a375d1f3f1c9565dd9dad31842
Author: Murtuza Zabuawala 

Modified Files
--
.../functions/templates/trigger_function/js/trigger_functions.js| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix issue which was showing incorrect datetime in Bac

[Dave Page]

Fix issue which was showing incorrect datetime in Backup/Restore dialog. Fixes 
#1377

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b94b47f0216a4e32868aa447dd4117a35f6245ae
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/misc/bgprocess/processes.py | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix incorrect start date in Backup/Restore dialog (pgAdmin4)

[Dave Page]

Thanks, applied.

On Fri, Jun 17, 2016 at 12:47 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch to fix the issue which was showing incorrect datetime in
> Backup/Restore dialog.
> (RM#1377)
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix the issue in backup/restore while selecting secti

[Dave Page]

Fix the issue in backup/restore while selecting section-> data option, it was 
throwing error.. Fixes #1219

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc4703c5b704ed003d6e01bbd4a598218b23e1d7
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/tools/backup/__init__.py   | 22 
.../tools/backup/templates/backup/js/backup.js |  2 +-
web/pgadmin/tools/restore/__init__.py  | 30 +++---
.../tools/restore/templates/restore/js/restore.js  |  2 +-
4 files changed, 35 insertions(+), 21 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Restore/Backup dialog

[Dave Page]

Thanks, applied.

On Fri, Jun 17, 2016 at 1:05 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue in backup/restore while selecting section-> data
> option, it was throwing error.
> RM#1219
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: String improvements.

[Dave Page]

String improvements.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd6c43b3936560a3f03e1caf59146523fd15b5c4

Modified Files
--
web/pgadmin/misc/bgprocess/__init__.py |  6 +++---
web/pgadmin/misc/bgprocess/process_executor.py |  8 
web/pgadmin/misc/bgprocess/processes.py|  8 
web/pgadmin/misc/file_manager/__init__.py  |  6 +++---
web/pgadmin/tools/backup/__init__.py   | 22 +++---
web/pgadmin/tools/restore/__init__.py  | 10 +-
6 files changed, 30 insertions(+), 30 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: String improvements.

[Dave Page]

String improvements.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=69d8f01d01ec72a2458884643e3e8f1493cbe772

Modified Files
--
web/pgadmin/browser/server_groups/servers/ppas.py  | 2 +-
web/pgadmin/browser/server_groups/servers/types.py | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Re-order view data options

[Dave Page]

Re-order view data options

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c279421f3f88720ac963def24957ad27c671965

Modified Files
--
.../tools/datagrid/templates/datagrid/js/datagrid.js   | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Further string improvements.

[Dave Page]

Further string improvements.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3bcc5a4bd336ae67cf1dc272cab208ab77ddd017

Modified Files
--
.../databases/schemas/tables/templates/table/js/table.js |  2 +-
.../server_groups/servers/templates/servers/servers.js   | 12 ++--
web/pgadmin/browser/templates/browser/js/collection.js   |  2 +-
web/pgadmin/browser/templates/browser/js/node.js |  2 +-
4 files changed, 9 insertions(+), 9 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Process manager UI cleanup.

[Dave Page]

Process manager UI cleanup.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f2b6ab816bd33d8dec1a023ef8935e93306c172c

Modified Files
--
.../misc/bgprocess/static/css/bgprocess.css| 28 --
web/pgadmin/misc/bgprocess/static/js/bgprocess.js  |  2 +-
2 files changed, 16 insertions(+), 14 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Missed string change

[Dave Page]

Missed string change

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be100b82e6c4fc7e7b5f3fda5834a6f4d98c7dc6

Modified Files
--
web/pgadmin/tools/datagrid/templates/datagrid/js/datagrid.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Fixed RM #1356

[Akshay Joshi]

Hi Dave

On Thu, Jun 16, 2016 at 6:48 PM, Dave Page  wrote:

>
>
> On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jun 16, 2016 at 6:09 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>


 On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi <
 khushboo.va...@enterprisedb.com> wrote:

>
>
> On Thu, Jun 16, 2016 at 5:07 PM, Dave Page  wrote:
>
>>
>>
>> On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi <
>> khushboo.va...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page 
>>> wrote:
>>>


 On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

> Hi Dave
>
> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi  enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jun 16, 2016 at 2:35 PM, Dave Page 
>> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> However, whilst I was testing, I saw just how slow the tool is:
>>>
>>> SELECT * FROM pg_attribute
>>>
>>> In a PEM database, returns 8150 rows. In pgAdmin 3, this is
>>> timed at 676ms on my laptop. In pgAdmin 4, the busy spinner runs 
>>> for approx
>>> 5 seconds, then the whole UI freezes. I then have to wait a further 
>>> 3
>>> minutes and 46 seconds() for the operation to complete. Once 
>>> loaded,
>>> scrolling is very sluggish.
>>>
>>> Please make this your top priority - and if you have incremental
>>> improvements, send them as you have them.
>>>
>>
>>Sure.
>>
>
>   Below is my initial finding while running "SELECT * FROM
> pg_attribute" on PEM database, returns 8498 rows:
>
>- Fetching data from the server side took consistent time and
>it took 3-4 secs.
>- Create/Render Backgrid without pagination : *1 minute*
>- Create/Render Backgrid with pagination (50 items per page):
>*469ms*
>- Create/Render Backgrid with pagination (500 items per page): *3
>secs*
>- Create/Render Backgrid with pagination (1000 items per
>page): *6 secs*
>- Create/Render Backgrid with pagination (3000 items per
>page): *22 secs*
>- Create/Render Backgrid with pagination (5000 items per
>page): *36 secs*
>
>
 OK, so I guess diving into Backgrid is the next step. Are there any
 profiling tools that could be used?


>>>
>>> Can we use infinity scrolling in case of no pagination?
>>>
>>
>> How would add row work then?
>>
>
> Yeah, in this case user has to wait till the last record to load. :(
> Btw, I was thinking of https://github.com/bhvaleri/backgrid-infinator
>

 This seems to be the good option.

>>>
>>> No - please see my previous comment.
>>>
>>
>> We can add/paste row as top row of the backgrid. In that case will it
>> be fine?
>>
>
> It's a hack, it doesn't solve the underlying problem. The fact that it
> took 4 minutes to load 8000 rows on my top-of-the-range MacBook Pro is not
> good.
>

   I have tried to fix the issue, but unable to figure out any way to do it
.  I have tried following options

   - Same issue found here https://github.com/wyuenho/backgrid/issues/126
   Which will be fixed https://github.com/wyuenho/backgrid/pull/444. I have
   copied the backgrid.js and backgrid.css from "*perf*" branch replace it
   in our code, but faced so many error's and warning, fixed those but some
   how data is not rendered.
   - Another approach is instead of adding all the records to the backbone
   collection at once, I have added them in chunk of 500 records at a time and
   sleep for 500ms, in this case busy spinner won't run for a longer time as
   first 500 records gets rendered, but browser again goes into unresponsive
   state as CPU goes up to 98-99%.


> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>



-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgadmin-hackers] Fixed RM #1356

[Dave Page]

On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi  wrote:

> Hi Dave
>
> On Thu, Jun 16, 2016 at 6:48 PM, Dave Page  wrote:
>
>>
>>
>> On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 6:09 PM, Dave Page  wrote:
>>>


 On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi <
 akshay.jo...@enterprisedb.com> wrote:

>
>
> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>>
>>
>> On Thu, Jun 16, 2016 at 5:07 PM, Dave Page  wrote:
>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
>>>


 On Thu, Jun 16, 2016 at 4:42 PM, Dave Page 
 wrote:

>
>
> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi > enterprisedb.com> wrote:
>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 2:35 PM, Dave Page 
>>> wrote:
>>>
 Thanks, patch applied.

 However, whilst I was testing, I saw just how slow the tool is:

 SELECT * FROM pg_attribute

 In a PEM database, returns 8150 rows. In pgAdmin 3, this is
 timed at 676ms on my laptop. In pgAdmin 4, the busy spinner runs 
 for approx
 5 seconds, then the whole UI freezes. I then have to wait a 
 further 3
 minutes and 46 seconds() for the operation to complete. Once 
 loaded,
 scrolling is very sluggish.

 Please make this your top priority - and if you have
 incremental improvements, send them as you have them.

>>>
>>>Sure.
>>>
>>
>>   Below is my initial finding while running "SELECT * FROM
>> pg_attribute" on PEM database, returns 8498 rows:
>>
>>- Fetching data from the server side took consistent time and
>>it took 3-4 secs.
>>- Create/Render Backgrid without pagination : *1 minute*
>>- Create/Render Backgrid with pagination (50 items per page):
>> *469ms*
>>- Create/Render Backgrid with pagination (500 items per
>>page): *3 secs*
>>- Create/Render Backgrid with pagination (1000 items per
>>page): *6 secs*
>>- Create/Render Backgrid with pagination (3000 items per
>>page): *22 secs*
>>- Create/Render Backgrid with pagination (5000 items per
>>page): *36 secs*
>>
>>
> OK, so I guess diving into Backgrid is the next step. Are there
> any profiling tools that could be used?
>
>

 Can we use infinity scrolling in case of no pagination?

>>>
>>> How would add row work then?
>>>
>>
>> Yeah, in this case user has to wait till the last record to load. :(
>> Btw, I was thinking of https://github.com/bhvaleri/backgrid-infinator
>>
>
> This seems to be the good option.
>

 No - please see my previous comment.

>>>
>>> We can add/paste row as top row of the backgrid. In that case will
>>> it be fine?
>>>
>>
>> It's a hack, it doesn't solve the underlying problem. The fact that it
>> took 4 minutes to load 8000 rows on my top-of-the-range MacBook Pro is not
>> good.
>>
>
>I have tried to fix the issue, but unable to figure out any way to do
> it .  I have tried following options
>
>- Same issue found here https://github.com/wyuenho/backgrid/issues/126
>Which will be fixed https://github.com/wyuenho/backgrid/pull/444. I
>have copied the backgrid.js and backgrid.css from "*perf*" branch
>replace it in our code, but faced so many error's and warning, fixed those
>but some how data is not rendered.
>
> Hmm, that's so old I'm not holding my breath about it being included in a
hurry.


>
>- Another approach is instead of adding all the records to the
>backbone collection at once, I have added them in chunk of 500 records at a
>time and sleep for 500ms, in this case busy spinner won't run for a longer
>time as first 500 records gets rendered, but browser again goes into
>unresponsive state as CPU goes up to 98-99%.
>
> Urgh. I wonder if we need a different grid control for this, something
like SlickGrid which is extremely fast with large data sets.

https://github.com/6pac/SlickGrid

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgadmin-hackers] Fixed RM #1356

[Dave Page]

On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi
 wrote:
>
> On Jun 17, 2016 20:53, "Dave Page"  wrote:
>>
>>
>>
>> On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi
>>  wrote:
>>>
>>> Hi Dave
>>>
>>> On Thu, Jun 16, 2016 at 6:48 PM, Dave Page  wrote:



 On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi
  wrote:
>
>
>
> On Thu, Jun 16, 2016 at 6:09 PM, Dave Page  wrote:
>>
>>
>>
>> On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi
>>  wrote:
>>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi
>>>  wrote:



 On Thu, Jun 16, 2016 at 5:07 PM, Dave Page 
 wrote:
>
>
>
> On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi
>  wrote:
>>
>>
>>
>> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page 
>> wrote:
>>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi
>>>  wrote:

 Hi Dave

 On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi
  wrote:
>
>
>
> On Thu, Jun 16, 2016 at 2:35 PM, Dave Page 
> wrote:
>>
>> Thanks, patch applied.
>>
>> However, whilst I was testing, I saw just how slow the tool
>> is:
>>
>> SELECT * FROM pg_attribute
>>
>> In a PEM database, returns 8150 rows. In pgAdmin 3, this is
>> timed at 676ms on my laptop. In pgAdmin 4, the busy spinner runs 
>> for approx
>> 5 seconds, then the whole UI freezes. I then have to wait a 
>> further 3
>> minutes and 46 seconds() for the operation to complete. Once 
>> loaded,
>> scrolling is very sluggish.
>>
>> Please make this your top priority - and if you have
>> incremental improvements, send them as you have them.
>
>
>Sure.


   Below is my initial finding while running "SELECT * FROM
 pg_attribute" on PEM database, returns 8498 rows:
 Fetching data from the server side took consistent time and it
 took 3-4 secs.
 Create/Render Backgrid without pagination : 1 minute
 Create/Render Backgrid with pagination (50 items per page):
 469ms
 Create/Render Backgrid with pagination (500 items per page): 3
 secs
 Create/Render Backgrid with pagination (1000 items per page): 6
 secs
 Create/Render Backgrid with pagination (3000 items per page): 22
 secs
 Create/Render Backgrid with pagination (5000 items per page): 36
 secs
>>>
>>>
>>> OK, so I guess diving into Backgrid is the next step. Are there
>>> any profiling tools that could be used?
>>>
>>
>>
>> Can we use infinity scrolling in case of no pagination?
>
>
> How would add row work then?


 Yeah, in this case user has to wait till the last record to load. :(
 Btw, I was thinking of
 https://github.com/bhvaleri/backgrid-infinator
>>>
>>>
>>> This seems to be the good option.
>>
>>
>> No - please see my previous comment.
>
>
> We can add/paste row as top row of the backgrid. In that case will
> it be fine?


 It's a hack, it doesn't solve the underlying problem. The fact that it
 took 4 minutes to load 8000 rows on my top-of-the-range MacBook Pro is not
 good.
>>>
>>>
>>>I have tried to fix the issue, but unable to figure out any way to do
>>> it .  I have tried following options
>>> Same issue found here https://github.com/wyuenho/backgrid/issues/126
>>> Which will be fixed https://github.com/wyuenho/backgrid/pull/444. I have
>>> copied the backgrid.js and backgrid.css from "perf" branch replace it in our
>>> code, but faced so many error's and warning, fixed those but some how data
>>> is not rendered.
>>
>> Hmm, that's so old I'm not holding my breath about it being included in a
>> hurry.
>>
>>>
>>> Another approach is instead of adding all the records to the backbone
>>> collection at once, I have added them in chunk of 500 records at a time and
>>> sleep for 500ms, in this case busy spinner won't run for a longer time as
>>> first 500 records gets rendered, but browser again goes into unresponsive
>>> state as CPU goes up to 98-99%.
>>
>> Urgh. I wonder if we need a different grid control for this, something
>> like SlickGrid which is extremely fast with large data sets.
>>
>> https://github.com/6pac/SlickGrid
> That's what I was researching about.
> But - we need to research on adding row, copy 

Re: [pgadmin-hackers] Fixed RM #1356

[Ashesh Vashi]

On Jun 17, 2016 20:53, "Dave Page"  wrote:
>
>
>
> On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
>>
>> Hi Dave
>>
>> On Thu, Jun 16, 2016 at 6:48 PM, Dave Page  wrote:
>>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:



 On Thu, Jun 16, 2016 at 6:09 PM, Dave Page  wrote:
>
>
>
> On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
>>
>>
>>
>> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>>>
>>>
>>>
>>> On Thu, Jun 16, 2016 at 5:07 PM, Dave Page 
wrote:



 On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
>
>
>
> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page 
wrote:
>>
>>
>>
>> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
>>>
>>> Hi Dave
>>>
>>> On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:



 On Thu, Jun 16, 2016 at 2:35 PM, Dave Page 
wrote:
>
> Thanks, patch applied.
>
> However, whilst I was testing, I saw just how slow the tool
is:
>
> SELECT * FROM pg_attribute
>
> In a PEM database, returns 8150 rows. In pgAdmin 3, this is
timed at 676ms on my laptop. In pgAdmin 4, the busy spinner runs for approx
5 seconds, then the whole UI freezes. I then have to wait a further 3
minutes and 46 seconds() for the operation to complete. Once loaded,
scrolling is very sluggish.
>
> Please make this your top priority - and if you have
incremental improvements, send them as you have them.


Sure.
>>>
>>>
>>>   Below is my initial finding while running "SELECT * FROM
pg_attribute" on PEM database, returns 8498 rows:
>>> Fetching data from the server side took consistent time and it
took 3-4 secs.
>>> Create/Render Backgrid without pagination : 1 minute
>>> Create/Render Backgrid with pagination (50 items per page):
 469ms
>>> Create/Render Backgrid with pagination (500 items per page): 3
secs
>>> Create/Render Backgrid with pagination (1000 items per page): 6
secs
>>> Create/Render Backgrid with pagination (3000 items per page):
22 secs
>>> Create/Render Backgrid with pagination (5000 items per page):
36 secs
>>
>>
>> OK, so I guess diving into Backgrid is the next step. Are there
any profiling tools that could be used?
>>
>
>
> Can we use infinity scrolling in case of no pagination?


 How would add row work then?
>>>
>>>
>>> Yeah, in this case user has to wait till the last record to load. :(
>>> Btw, I was thinking of
https://github.com/bhvaleri/backgrid-infinator
>>
>>
>> This seems to be the good option.
>
>
> No - please see my previous comment.


 We can add/paste row as top row of the backgrid. In that case will
it be fine?
>>>
>>>
>>> It's a hack, it doesn't solve the underlying problem. The fact that it
took 4 minutes to load 8000 rows on my top-of-the-range MacBook Pro is not
good.
>>
>>
>>I have tried to fix the issue, but unable to figure out any way to do
it .  I have tried following options
>> Same issue found here https://github.com/wyuenho/backgrid/issues/126
Which will be fixed https://github.com/wyuenho/backgrid/pull/444. I have
copied the backgrid.js and backgrid.css from "perf" branch replace it in
our code, but faced so many error's and warning, fixed those but some how
data is not rendered.
>
> Hmm, that's so old I'm not holding my breath about it being included in a
hurry.
>
>>
>> Another approach is instead of adding all the records to the backbone
collection at once, I have added them in chunk of 500 records at a time and
sleep for 500ms, in this case busy spinner won't run for a longer time as
first 500 records gets rendered, but browser again goes into unresponsive
state as CPU goes up to 98-99%.
>
> Urgh. I wonder if we need a different grid control for this, something
like SlickGrid which is extremely fast with large data sets.
>
> https://github.com/6pac/SlickGrid
That's what I was researching about.
But - we need to research on adding row, copy rows, etc.

--
Ashesh
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company

[pgadmin-hackers] pgAdmin 4 commit: Get rid of canvas colouring in graphical explain.

[Dave Page]

Get rid of canvas colouring in graphical explain.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a53811ef270559eb649a0a501a3f66d1be7549fd

Modified Files
--
web/pgadmin/misc/templates/explain/js/explain.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: File dialogue layout tweaks.

[Dave Page]

File dialogue layout tweaks.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1172e31019c4bd72c9a4cfa0bbb8b9d65a9ea353

Modified Files
--
web/pgadmin/misc/file_manager/static/css/file_manager.css | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Make the file manager work a little more sanely with

[Dave Page]

Make the file manager work a little more sanely with regard to paths.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35243b9869d5191d1fbd5217e87acbfe288df827

Modified Files
--
web/pgadmin/misc/file_manager/__init__.py|  3 ---
.../templates/file_manager/js/file_manager.js| 20 +---
web/pgadmin/tools/sqleditor/__init__.py  |  2 --
web/pgadmin/utils/paths.py   |  4 ++--
4 files changed, 7 insertions(+), 22 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Revert "Make the file manager work a little more sane

[Dave Page]

Revert "Make the file manager work a little more sanely with regard to paths."

This breaks things even more on Windows :-(

This reverts commit 35243b9869d5191d1fbd5217e87acbfe288df827.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c62d1a4b7290b1aac767f022153876e686b0652

Modified Files
--
web/pgadmin/misc/file_manager/__init__.py|  3 +++
.../templates/file_manager/js/file_manager.js| 20 +++-
web/pgadmin/tools/sqleditor/__init__.py  |  2 ++
web/pgadmin/utils/paths.py   |  4 ++--
4 files changed, 22 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Second attempt at fixing the file handling code. Test

[Dave Page]

Second attempt at fixing the file handling code. Tested on Mac and Windows in 
both desktop and server modes.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05e7ee5a05d5a196dcf2272ff5a6e66e08c5a188

Modified Files
--
.../templates/file_manager/js/file_manager.js| 20 +---
web/pgadmin/tools/backup/__init__.py |  4 ++--
.../tools/backup/templates/backup/js/backup.js   | 12 ++--
web/pgadmin/tools/import_export/__init__.py  |  4 ++--
.../templates/import_export/js/import_export.js  |  4 ++--
web/pgadmin/tools/restore/__init__.py|  6 +++---
.../tools/restore/templates/restore/js/restore.js|  6 +++---
web/pgadmin/tools/sqleditor/__init__.py  | 12 +++-
8 files changed, 30 insertions(+), 38 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers