Re: [pgadmin-hackers] [pgAdmin4][debugger]: RM #1354 & RM #1323

2016-06-19 Thread Neel Patel
Hi Dave,

make sense. We should ensure that operations happen sequentially.
Please find attached patch file for the fix.

Thanks,
Neel Patel

On Sat, Jun 18, 2016 at 8:40 PM, Dave Page  wrote:

> Hi
>
> Isn't any solution that relies on artificial delays likely to fail sooner
> or later? Can't we reliably ensure the operations happen sequentially?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK:http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On 18 Jun 2016, at 11:43, Neel Patel  wrote:
>
> Hi,
>
> Please find attached patch file for the fix of RM #1354 and RM #1323.
>
> RM 1354 - Debugging PL/pgSQL causes "Debugger: Error fetching variable
> information".
>
> RM 1323 - Debugger: Continue execution error displayed if debug plpgsql
> function in Desktop Runtime Application.
>
> Both the issue are related. Below are the issue description and solution.
>
> *Issue :- *
>
> We are getting error of "fetching variable information" and "execution
> error" because as one query is already in state of execution and at the
> same time without getting its result we are sending another query to fetch
> the variable and stack information and due to that we are getting the error.
>
> *Solution:-*
>
> We should give enough time for execution query to finish its operation and
> then we should get the function debug information like variable info, stack
> info, breakpoint info etc.
>
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
> 
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


RM_1354_1323_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


[pgadmin-hackers] [pgAdmin4][Patch]: RM#1337 - Query Tool: Cannot copy result set to clipboard.

2016-06-19 Thread Surinder Kumar
Hi,

Please find attached patch for RM#1337 - Query Tool: Cannot copy result set
to clipboard.

In Query tool, add support for copy single grid row to clipboard using:
1 ) CTRL+ c key
2)  *Copy row button* in grid toolbar.
For now only one row can be copied to clipboard.

Please review.

Thanks,
Surinder Kumar


RM#1337.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Re: [pgadmin-hackers] Fixed RM #1356

2016-06-19 Thread Akshay Joshi
Hi Dave

On Fri, Jun 17, 2016 at 9:00 PM, Dave Page  wrote:

> On Fri, Jun 17, 2016 at 4:25 PM, Ashesh Vashi
>  wrote:
> >
> > On Jun 17, 2016 20:53, "Dave Page"  wrote:
> >>
> >>
> >>
> >> On Fri, Jun 17, 2016 at 4:04 PM, Akshay Joshi
> >>  wrote:
> >>>
> >>> Hi Dave
> >>>
> >>> On Thu, Jun 16, 2016 at 6:48 PM, Dave Page  wrote:
> 
> 
> 
>  On Thu, Jun 16, 2016 at 1:43 PM, Akshay Joshi
>   wrote:
> >
> >
> >
> > On Thu, Jun 16, 2016 at 6:09 PM, Dave Page 
> wrote:
> >>
> >>
> >>
> >> On Thu, Jun 16, 2016 at 1:34 PM, Akshay Joshi
> >>  wrote:
> >>>
> >>>
> >>>
> >>> On Thu, Jun 16, 2016 at 5:47 PM, Khushboo Vashi
> >>>  wrote:
> 
> 
> 
>  On Thu, Jun 16, 2016 at 5:07 PM, Dave Page 
>  wrote:
> >
> >
> >
> > On Thu, Jun 16, 2016 at 12:19 PM, Khushboo Vashi
> >  wrote:
> >>
> >>
> >>
> >> On Thu, Jun 16, 2016 at 4:42 PM, Dave Page 
> >> wrote:
> >>>
> >>>
> >>>
> >>> On Thu, Jun 16, 2016 at 12:04 PM, Akshay Joshi
> >>>  wrote:
> 
>  Hi Dave
> 
>  On Thu, Jun 16, 2016 at 2:42 PM, Akshay Joshi
>   wrote:
> >
> >
> >
> > On Thu, Jun 16, 2016 at 2:35 PM, Dave Page <
> dp...@pgadmin.org>
> > wrote:
> >>
> >> Thanks, patch applied.
> >>
> >> However, whilst I was testing, I saw just how slow the tool
> >> is:
> >>
> >> SELECT * FROM pg_attribute
> >>
> >> In a PEM database, returns 8150 rows. In pgAdmin 3, this is
> >> timed at 676ms on my laptop. In pgAdmin 4, the busy spinner
> runs for approx
> >> 5 seconds, then the whole UI freezes. I then have to wait a
> further 3
> >> minutes and 46 seconds() for the operation to complete.
> Once loaded,
> >> scrolling is very sluggish.
> >>
> >> Please make this your top priority - and if you have
> >> incremental improvements, send them as you have them.
> >
> >
> >Sure.
> 
> 
>    Below is my initial finding while running "SELECT * FROM
>  pg_attribute" on PEM database, returns 8498 rows:
>  Fetching data from the server side took consistent time and it
>  took 3-4 secs.
>  Create/Render Backgrid without pagination : 1 minute
>  Create/Render Backgrid with pagination (50 items per page):
>  469ms
>  Create/Render Backgrid with pagination (500 items per page): 3
>  secs
>  Create/Render Backgrid with pagination (1000 items per page):
> 6
>  secs
>  Create/Render Backgrid with pagination (3000 items per page):
> 22
>  secs
>  Create/Render Backgrid with pagination (5000 items per page):
> 36
>  secs
> >>>
> >>>
> >>> OK, so I guess diving into Backgrid is the next step. Are there
> >>> any profiling tools that could be used?
> >>>
> >>
> >>
> >> Can we use infinity scrolling in case of no pagination?
> >
> >
> > How would add row work then?
> 
> 
>  Yeah, in this case user has to wait till the last record to load.
> :(
>  Btw, I was thinking of
>  https://github.com/bhvaleri/backgrid-infinator
> >>>
> >>>
> >>> This seems to be the good option.
> >>
> >>
> >> No - please see my previous comment.
> >
> >
> > We can add/paste row as top row of the backgrid. In that case
> will
> > it be fine?
> 
> 
>  It's a hack, it doesn't solve the underlying problem. The fact that it
>  took 4 minutes to load 8000 rows on my top-of-the-range MacBook Pro
> is not
>  good.
> >>>
> >>>
> >>>I have tried to fix the issue, but unable to figure out any way to
> do
> >>> it .  I have tried following options
> >>> Same issue found here https://github.com/wyuenho/backgrid/issues/126
> >>> Which will be fixed https://github.com/wyuenho/backgrid/pull/444. I
> have
> >>> copied the backgrid.js and backgrid.css from "perf" branch replace it
> in our
> >>> code, but faced so many error's and warning, fixed those but some how
> data
> >>> is not rendered.
> >>
> >> Hmm, that's so old I'm not holding my breath about it being included in
> a
> >> hurry.
> >>
> >>>
> >>> Another approach is instead of adding all the records to the backbone
> >>> collection at once, I have added them in chunk of 500 records at a
> time and
> >>> sleep for 500ms, in this case busy spinner won't run for a longer time
> as
> >>> first 500 recor