[pgadmin-hackers] pgAdmin 4 commit: Implemented Synonym node for EPAS
Implemented Synonym node for EPAS Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a78dd7ad3e9361f9c3b7f1d9d593fe685eb3f66 Author: Murtuza Zabuawala Modified Files -- .../packages/templates/package/js/package.js | 30 +- .../servers/databases/schemas/synonyms/__init__.py | 634 + .../schemas/synonyms/static/img/coll-synonym.png | Bin 0 -> 448 bytes .../schemas/synonyms/static/img/synonym.png| Bin 0 -> 478 bytes .../synonyms/templates/synonym/js/synonym.js | 248 .../templates/synonym/sql/9.1_plus/create.sql | 17 + .../templates/synonym/sql/9.1_plus/delete.sql | 8 + .../templates/synonym/sql/9.1_plus/get_objects.sql | 43 ++ .../templates/synonym/sql/9.1_plus/get_oid.sql | 8 + .../templates/synonym/sql/9.1_plus/nodes.sql | 5 + .../templates/synonym/sql/9.1_plus/properties.sql | 19 + .../templates/synonym/sql/9.1_plus/update.sql | 10 + .../databases/schemas/synonyms/tests/__init__.py | 17 + .../schemas/synonyms/tests/test_synonym_add.py | 74 +++ .../schemas/synonyms/tests/test_synonym_delete.py | 77 +++ .../schemas/synonyms/tests/test_synonym_get.py | 101 .../schemas/synonyms/tests/test_synonym_put.py | 125 .../databases/schemas/synonyms/tests/utils.py | 154 + 18 files changed, 1550 insertions(+), 20 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)
Thanks, patch applied. On Thu, Aug 25, 2016 at 7:58 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > Please find updated patch. > > I have also fixed the issue in package node which was displaying create > menu in PG server. (separate patch attached) > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Aug 25, 2016 at 4:34 PM, Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Murtuza >> >> Following are my review comments: >> >>- Create "Synonym" option is visible for Postgres Servers, when right >>click on schema node. >> >> Fixed > >> >>- Unable to create Public Synonym faced "Internal Server Error". >> >> Fixed > >> >>- SQL help not working when click on "[i]" button. >> >> Fixed, Now it is disbaled > >> >>- "Public Synonyms?" switch control showing True/False when click on >>Synonyms collection node and it is showing Yes/No when click on synonym >>node under properties tab. >> >> Fixed > >> >> On Thu, Aug 25, 2016 at 3:08 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA updated patch with `--binary` option for .png files. >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> Hi, PFA patch for synonym node, this patch also includes basic unit test cases. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company >>> >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
[pgadmin-hackers] pgAdmin 4 commit: Getting 'AttributeError' in pgadmin4/web/pgadmin/brow
Getting 'AttributeError' in pgadmin4/web/pgadmin/browser/server_groups/servers/__init__.py. Fixes #1464 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1b05464a04a533a36f30f808b1bc0ab6d3062180 Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)
Hi Murtuza, Please find my review comments below: 1. Please attach test_advanced_config.json.in file to read the config data 2. While reading data from config file "owner" field is missing 3. Please add synonym pickle object to ../regression/test_utils.py file 4. Can we have config data parameters generated dynamically? (e.g. schema name) Let me know for any assistance. Thank you. On 26 August 2016 at 13:03, Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Aug 25, 2016 at 7:58 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi, >> >> Please find updated patch. >> >> I have also fixed the issue in package node which was displaying create >> menu in PG server. (separate patch attached) >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Thu, Aug 25, 2016 at 4:34 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Murtuza >>> >>> Following are my review comments: >>> >>>- Create "Synonym" option is visible for Postgres Servers, when >>>right click on schema node. >>> >>> Fixed >> >>> >>>- Unable to create Public Synonym faced "Internal Server Error". >>> >>> Fixed >> >>> >>>- SQL help not working when click on "[i]" button. >>> >>> Fixed, Now it is disbaled >> >>> >>>- "Public Synonyms?" switch control showing True/False when click on >>>Synonyms collection node and it is showing Yes/No when click on synonym >>>node under properties tab. >>> >>> Fixed >> >>> >>> On Thu, Aug 25, 2016 at 3:08 PM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> Hi, PFA updated patch with `--binary` option for .png files. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch for synonym node, this patch also includes basic unit test > cases. > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company
Re: [pgadmin-hackers] PATCH: Synonym node for EPAS (pgAdmin4)
1 more point to add: 5. Synonyms should only run for EPAS server On 26 August 2016 at 16:44, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > Hi Murtuza, > > Please find my review comments below: > > 1. Please attach test_advanced_config.json.in file to read the config data > 2. While reading data from config file "owner" field is missing > 3. Please add synonym pickle object to ../regression/test_utils.py file > 4. Can we have config data parameters generated dynamically? (e.g. schema > name) > > Let me know for any assistance. > > Thank you. > > On 26 August 2016 at 13:03, Akshay Joshi > wrote: > >> Thanks, patch applied. >> >> On Thu, Aug 25, 2016 at 7:58 PM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find updated patch. >>> >>> I have also fixed the issue in package node which was displaying create >>> menu in PG server. (separate patch attached) >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> On Thu, Aug 25, 2016 at 4:34 PM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> Hi Murtuza Following are my review comments: - Create "Synonym" option is visible for Postgres Servers, when right click on schema node. Fixed >>> - Unable to create Public Synonym faced "Internal Server Error". Fixed >>> - SQL help not working when click on "[i]" button. Fixed, Now it is disbaled >>> - "Public Synonyms?" switch control showing True/False when click on Synonyms collection node and it is showing Yes/No when click on synonym node under properties tab. Fixed >>> On Thu, Aug 25, 2016 at 3:08 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch with `--binary` option for .png files. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Aug 25, 2016 at 12:27 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch for synonym node, this patch also includes basic unit test >> cases. >> Please review. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > > > > -- > Best, > Priyanka > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company
[pgadmin-hackers] [pgAdmin4][patch]: RM #1226
Hi, Please find attached patch for fix of RM-1226. *Issue :- * Previously, "Set breakpoint" (Indirect debugging) option was missing for trigger and trigger function node. Now with this patch, user can able to debug trigger function. Please review it and let us know for any comments. Thanks, Neel Patel RM_1226.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Re: pgAdmin IV : Unittest modular patch(database child nodes) and trigger function
Hi Dave, PFA patch for sequence node. I have made few modification to delete operation (added cascade delete) and added sequence label to pickle dict as synonym is dependant on it. Thank you. On 23 August 2016 at 18:44, Priyanka Shendge < priyanka.shen...@enterprisedb.com> wrote: > > > On 23 August 2016 at 18:38, Dave Page wrote: > >> >> >> On Tue, Aug 23, 2016 at 1:56 PM, Priyanka Shendge < >> priyanka.shen...@enterprisedb.com> wrote: >> >>> I noticed whilst testing that I've started seeing the error below >>> (with or without the patches I just applied). Any idea what's causing >>> it? >>> >>> The user may already present in database (i.e. a...@example.com) which >>> we creating as dummy user. >>> When we run test case it tries to create dummy user. As user is already >>> present it throws an error. >>> It does not get an id for same user. >>> >> >> Ahh, yes - can you add a check for that so it throws a more helpful error >> please? >> > > Sure, i'll update the code accordingly. > >> >> Also; related to the issue I've been seeing with databases not being >> removed, I recently ran into problems where tablespaces weren't removed, >> following a ctrl+c, which then required manual cleanup once I'd figured out >> what was wrong. We need to fix this; I'd suggest: >> >> - Keep track of objects that are created during tests. This probably just >> needs to be objects to the database level, e.g. pgAdmin users, tablespaces, >> databases and roles (because, if we drop the test database then everything >> in it will go anyway). >> >> - Remove objects from the list again if a test drops them. >> >> - Call a function on exit (or abort/ctrl+c/whatever) that iterates >> through the list of objects that have been created but not dropped, and >> clean them up manually before exiting. >> > > Sure, this can be done and will update the code. > Thank you. > >> >> Thanks! >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > > -- > Best, > Priyanka > > EnterpriseDB Corporation > The Enterprise PostgreSQL Company > -- Best, Priyanka EnterpriseDB Corporation The Enterprise PostgreSQL Company sequence_mod.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
