Re: [pgadmin-hackers] [pgAdmin4][patch]: RM #1226

[Murtuza Zabuawala]

Hi,

Patch is working as expected.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Aug 26, 2016 at 5:01 PM, Neel Patel 
wrote:

> Hi,
>
> Please find attached patch for fix of RM-1226.
>
> *Issue :- *
>
> Previously, "Set breakpoint" (Indirect debugging) option was missing for
> trigger and trigger function node. Now with this patch, user can able to
> debug trigger function.
>
> Please review it and let us know for any comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1238

[Murtuza Zabuawala]

Hi,

Patch is working as expected.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Aug 26, 2016 at 12:07 PM, Neel Patel 
wrote:

> Hi,
>
> Please find attached minor patch for the fix of RM-1238.
>
> *Issue :- *
> Proper quoted SQL string was not generated. To resolve this issue, we
> formed proper SQL and now user can debug the function mentioned in RM case.
>
> Please review it and let us know for any comments.
>
> Thanks,
> Neel Patel
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool (pgAdmin4)

[Neel Patel]

Hi Murtuza,

All the review comments given by Akshay are fixed. Below are some minor
observations.


   - Add two new rows with valid data. Select one row and delete that row.
   Now "Save" button should be enabled because we still have one valid new row
   to save the data.
   - When we click on new blank row and select "By Selection" then it
   throws 'javascript' exception.

   Uncaught TypeError: Cannot read property 'id' of undefined

Thanks,
Neel patel

On Mon, Aug 29, 2016 at 10:43 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> -- Forwarded message --
> From: Murtuza Zabuawala 
> Date: Fri, Aug 26, 2016 at 8:27 PM
> Subject: Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool
> (pgAdmin4)
> To: Akshay Joshi 
> Cc: Dave Page , pgadmin-hackers <
> pgadmin-hackers@postgresql.org>
>
>
> Hi,
>
> PFA updated patch for SlickGrid.
>
> *Note:* This patch contains our own custom Slickgrid changes in SlickGrid
> no need to apply patch sent in last email.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Aug 24, 2016 at 6:27 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Murtuza
>>
>> I have tested the functionality before reviewing the actual code, below
>> are my review comments
>>
>> *Functionality related comments*:
>>
>>- Filter "By Selection" and "Exclude Selection" not working.
>>
>> Done
>
>>
>>- Increase the font size from 8pt to 9pt and also make the table
>>header's in bold.
>>
>> Done
>
>>
>>- User won't be able to enter/copy the data directly from the cell.
>>With current implementation user has to double click on cell then one data
>>editor popped up where user can enter/copy data and will have to press
>>"save" or "cancel" button. Then will have to double click again on the 
>> cell
>>where he/she want's to paste and will have to press "save" or "cancel"
>>button.
>>
>> Copying from selected Cell is done. But for now you have edit target cell
> & paste the data in editor.
> I will create TODO ticket for this pasting data without opening editor in
> to cell as it requires some time.
>
>>
>>- Slick grid not rendered properly when changing tabs or resize "Data
>>output" docker panel. Please refer "Error-1.png"
>>   - *Steps to reproduce*: View table data with more than 100 rows,
>>   scroll down a bit, now either shift tab and back again to "Data output"
>>   panel OR resize the "Data output" docker panel.
>>
>> Done
>
>>
>>- Slick grid is not refreshing properly when deleted multiple rows.
>>
>> Done
>
>>
>>- Error Message is not cleared from "Messages" tab even after
>>successful transaction.
>>   - *Steps to reproduce*: Generate error by saving some wrong data
>>   and check "Messages" tab, now correct the value and save the data 
>> again.
>>   Data gets saved, but "Messages" tab still show error message.
>>
>> Done
>
>>
>>- Paste rows button gets disabled once it is clicked, as per me it
>>should be enabled if some rows are copied to clipboard.
>>
>> Done
>
>>
>>- Facing weird issue for some tables, data is not being saved even if
>>I have given the correct values. Mostly it happens with NOT NULL columns.
>>   -   *Steps to reproduce*: View Data of the table where there are
>>   columns with NOT NULL constraint.  I have tested it for 
>> "public.jobhist"
>>   table of  PPAS-9.5. Add new row and insert values for primary key 
>> columns,
>>   but don't insert any value for NOT NULL column. Now click on Save 
>> button it
>>   will throw an error "null value in column  violates not-null
>>   constraint". Now insert the proper value for that column and try to 
>> save
>>   it, still it will give the same error.
>>
>>  Done
>
>>
>>- Extra space has been added for the drop down menu of query tool
>>toolbar. Please refer "Before_Slickgrid.png" and "After_Slickgrid.png"
>>
>> Done
>
>>
>> On Tue, Aug 23, 2016 at 4:00 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi,
>>>
>>> PFA minor add-on patch on previous Slickgrid v2 patch to remove console
>>> log messages from JS..
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Tue, Aug 23, 2016 at 3:47 PM, Murtuza Zabuawala <
>>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>>
 Hi,

 PFA updated patch & comments inline.

 --
 Regards,
 Murtuza Zabuawala
 EnterpriseDB: http://www.enterprisedb.com
 The Enterprise PostgreSQL Company

 On Thu, Aug 18, 2016 at 9:16 PM, Dave Page  wrote:

> Hi,
>
> On Wed, Aug 17, 2016 at 11:19 AM, Murtuza Zabuawala <
> murtuza.zabuaw...@enter

[pgadmin-hackers] pgAdmin 4 commit: SqlFieldControl enhancements

[Akshay Joshi]

SqlFieldControl enhancements

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2d75eac1177c3c1f890f3423a0b31e2e1b0b3706
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/static/css/overrides.css  | 11 +++
web/pgadmin/static/js/backform.pgadmin.js | 10 +-
2 files changed, 20 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: SqlFieldControl enhancements

[Akshay Joshi]

Thanks, patch applied.

On Tue, Aug 23, 2016 at 12:13 PM, Surinder Kumar <
surinder.ku...@enterprisedb.com> wrote:

> Hi
>
> Following are the enhancements:
> 1) Disable cursor mode if editor is disabled.
> if cursor is enabled. on pressing keys, a false event is generated and on
> validating models it causes Save button to enable.
> 2) If editor is disabled, set dark background colour.
> 3) CodeMirror corners seems to cut around. CodeMirror z-index is greater
> than pgadmin-control class which causing issue. it is fixed.
> 4) CodeMirror not taking full height. set *line-height *css property to
> fix the issue.
>
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Set break point option should present in pgAdmin4 for

[Akshay Joshi]

Set break point option should present in pgAdmin4 for trigger. Fixes #1226

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5249f2e18c32a403a96b418669da738e50357c7
Author: Neel Patel 

Modified Files
--
web/pgadmin/tools/debugger/__init__.py | 44 ++
.../debugger/templates/debugger/js/debugger.js | 28 +-
.../debugger/sql/get_trigger_function_info.sql | 12 ++
3 files changed, 76 insertions(+), 8 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][patch]: RM #1226

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 29, 2016 at 1:03 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Patch is working as expected.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Aug 26, 2016 at 5:01 PM, Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find attached patch for fix of RM-1226.
>>
>> *Issue :- *
>>
>> Previously, "Set breakpoint" (Indirect debugging) option was missing for
>> trigger and trigger function node. Now with this patch, user can able to
>> debug trigger function.
>>
>> Please review it and let us know for any comments.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

[pgadmin-hackers] pgAdmin 4 commit: Debugger listener starting error displayed if user tr

[Akshay Joshi]

Debugger listener starting error displayed if user try to debug plpgsql 
cs_fmt_browser_version function that contains parameters. Fixes #1238

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6f6609bc3dbe2dd61b5b92802389e2b310006e
Author: Neel Patel 

Modified Files
--
web/pgadmin/tools/debugger/templates/debugger/sql/execute_plpgsql.sql | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM#1238

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 29, 2016 at 1:04 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> Patch is working as expected.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Aug 26, 2016 at 12:07 PM, Neel Patel 
> wrote:
>
>> Hi,
>>
>> Please find attached minor patch for the fix of RM-1238.
>>
>> *Issue :- *
>> Proper quoted SQL string was not generated. To resolve this issue, we
>> formed proper SQL and now user can debug the function mentioned in RM case.
>>
>> Please review it and let us know for any comments.
>>
>> Thanks,
>> Neel Patel
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>


-- 
*Akshay Joshi*
*Principal Software Engineer *



*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*

Re: [pgadmin-hackers] PATCH/s: RM#1387 - Bad handling of missing connection database server

[Ashesh Vashi]

Thanks - committed!

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Mon, Aug 29, 2016 at 10:40 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi Ashesh,
>
> Patch is working for me, I did not find any major issues.
> But I have fixed some of the issues where alert was not displaying object
> name,
>
> PFA add-on patch to your previous patch.
>
> Please review.
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Aug 25, 2016 at 3:49 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> Hi Murtuza,
>>
>>
>> On Wed, Aug 24, 2016 at 3:17 PM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>> Hi Ashesh,
>>>
>>> Here are few scenario I tried which does not like working properly,
>>>
>>> 1) "properties" dialog do not open for any object while I'm able to open
>>> "create" dialog
>>>
>> Done.
>>
>>>
>>> 2) Click & connect the server, Now go to Statistics tab, you will see
>>> blank alert info
>>> [Console error] statistics.js:216 Uncaught ReferenceError: that is not
>>> defined
>>>
>> Done.
>>
>>>
>>> 3) Open "Create" dialog fill information, Stop DB & then click on Save
>>> button.
>>> [Console error] pgadmin.defaults.js:90 Uncaught TypeError:
>>> xhr.getResponseHeader is not a function
>>>
>> Done.
>>
>>>
>>> 4) If pgAdmin4 is running & database is connected, Now if database goes
>>> down (eg: stop db service),
>>> server stays as connected & there are no error from application when we
>>> traverse between tabs.
>>>
>> Due to point #2.
>>
>>>
>>> 5) If pgAdmin4 is running & one or more server is connected, Now if any
>>> database server goes down (eg: stop db service)
>>> Refresh entire page now click on expand server-group, loading/expanding
>>> server group goes infinite.
>>>
>> This is not regression of this patch.
>> I will share a separate patch for this.
>>
>> Please try the updated patches.
>>
>>>
>>> Thanks,
>>> Murtuza
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Aug 24, 2016 at 2:17 PM, Ashesh Vashi <
>>> ashesh.va...@enterprisedb.com> wrote:
>>>
 On Wed, Aug 24, 2016 at 11:25 AM, Ashesh Vashi <
 ashesh.va...@enterprisedb.com> wrote:

> Hi Team,
>
> On Sun, Aug 21, 2016 at 3:55 PM, Ashesh Vashi <
> ashesh.va...@enterprisedb.com> wrote:
>
>> On Aug 21, 2016 15:08, "Dave Page"  wrote:
>> >
>> > Yeah, but shouldn't it be caught and handled, with a suitable retry
>> yes/no in the UI?
>> And, that realised me, I missed one case, on which I am already
>> working.
>>
> Please find the updated patches.
>
 Thanks - Murtuza for point out the issue.

 The patches were not generated from the latest changes.
 Please find the updated patches.

 --

 Thanks & Regards,

 Ashesh Vashi
 EnterpriseDB INDIA: Enterprise PostgreSQL Company
 


 *http://www.linkedin.com/in/asheshvashi*
 

>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> 
>
>
> *http://www.linkedin.com/in/asheshvashi*
> 
>
>> --
>> Thanks & Regards,
>>
>> Ashesh Vashi
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.com
>> > Twitter: @pgsnake
>> >
>> > EnterpriseDB UK:http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On 20 Aug 2016, at 12:03, Ashesh Vashi <
>> ashesh.va...@enterprisedb.com> wrote:
>> >
>> >> On Fri, Aug 19, 2016 at 9:32 PM, Dave Page 
>> wrote:
>> >>>
>> >>> Hi
>> >>>
>> >>> Can you re-base please? The nodes patch no longer applies.
>> >>>
>> >>> Ignoring that conflict though, the first test I did was to
>> restart the app server when connected to a database. I then (after it
>> restarted) to open the Schemas node in that database; nothing happened at
>> all in the client, but on the server I saw:
>> >>
>> >> This exception suggests that - pgAdmin 4 was not able to establish
>> the connection again during restarting it.
>> >>
>> >> --
>> >>
>> >> Thanks & Regards,
>> >>
>> >> Ashesh Vashi
>> >> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>> >>
>> >>
>> >> http://www.linkedin.com/in/asheshvashi
>> >>>
>> >>>
>> >>> 2016-08-19 16:59:16,321: INFO werkzeug: 127.0.0.1 - -
>> [19/Aug/2016 16:59:16] "GET /browser/schema/nodes/1/1/219759/
>> HTTP/1.1" 500 -

[pgadmin-hackers] PATCH: To fix the in Synonym node (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to fix the few minor issues in Synonym node.
RM#1607, RM#1608, RM#1609

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Fix_synonyms_node.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To fix the issue in cast node (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA minor patch to fix the issue in cast node due to typo.
RM#1614


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1614.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Sorting the data during tree data loading using the n

[Ashesh Vashi]

Sorting the data during tree data loading using the natural sort
algorithm.

This patch takes care of:
* Consistent behaviour during create, update operation on any node.
  - It should return the node data during creating a new object, or
updating the existing one.
* Now that - we have consistent behaviour during these operations, we
  can consistently move, update the tree item based the node data from
  the server.
* Implemented the methods for each node to get the information about
  that particular node only.
* Using the above changes to implement the 'refresh' operation on tree
  node properly.

I must thank Surinder, and Harshal for helping me implement the 'node'
method, and also changed the behaviour of create & update methods to
return the node data for most of the nodes.

Fixes #1244

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b6f307256b7a48944d9e5a198d0d461b3ac5c5d5

Modified Files
--
libraries.txt  |   1 +
web/pgadmin/browser/collection.py  |   2 +-
web/pgadmin/browser/server_groups/__init__.py  |  50 +-
.../browser/server_groups/servers/__init__.py  |  16 +-
.../server_groups/servers/databases/__init__.py|  34 +-
.../servers/databases/casts/__init__.py| 127 ++-
.../servers/databases/event_triggers/__init__.py   |  51 +-
.../event_triggers/sql/9.3_plus/nodes.sql  |   3 +
.../servers/databases/extensions/__init__.py   | 133 ++--
.../databases/foreign_data_wrappers/__init__.py| 253 +++---
.../foreign_servers/__init__.py| 264 +++---
.../foreign_servers/user_mapping/__init__.py   | 260 +++---
.../servers/databases/languages/__init__.py| 155 ++--
.../servers/databases/schemas/__init__.py  | 104 ++-
.../databases/schemas/catalog_objects/__init__.py  |  40 +
.../schemas/catalog_objects/columns/__init__.py|   6 +-
.../catalog_object/sql/pg/9.1_plus/nodes.sql   |   4 +
.../catalog_object/sql/ppas/9.1_plus/nodes.sql |   4 +
.../databases/schemas/collations/__init__.py   | 169 ++--
.../templates/collation/sql/9.1_plus/get_oid.sql   |  11 +-
.../templates/collation/sql/9.1_plus/nodes.sql |   4 +
.../servers/databases/schemas/domains/__init__.py  | 298 +++
.../schemas/domains/domain_constraints/__init__.py |  48 ++
.../domain_constraints/sql/9.1_plus/properties.sql |   5 +
.../domain_constraints/sql/9.2_plus/properties.sql |   5 +
.../templates/domains/sql/9.1_plus/node.sql|   4 +
.../templates/domains/sql/9.2_plus/node.sql|   4 +
.../databases/schemas/foreign_tables/__init__.py   | 272 ---
.../templates/foreign_tables/sql/9.1_plus/node.sql |   4 +
.../templates/foreign_tables/sql/9.2_plus/node.sql |   4 +
.../templates/foreign_tables/sql/9.5_plus/node.sql |   4 +
.../schemas/fts_configurations/__init__.py | 338 
.../fts_configuration/sql/9.1_plus/properties.sql  |   7 +-
.../fts_configuration/sql/9.1_plus/update.sql  |   4 +-
.../databases/schemas/fts_dictionaries/__init__.py | 320 
.../fts_dictionary/sql/9.1_plus/properties.sql |   9 +-
.../databases/schemas/fts_parser/__init__.py   | 310 
.../templates/fts_parser/sql/9.1_plus/nodes.sql|   4 +-
.../fts_parser/sql/9.1_plus/properties.sql |  10 +-
.../databases/schemas/fts_templates/__init__.py| 399 +-
.../templates/fts_template/sql/9.1_plus/nodes.sql  |   4 +-
.../fts_template/sql/9.1_plus/properties.sql   |   9 +-
.../templates/fts_template/sql/9.1_plus/update.sql |   4 +-
.../databases/schemas/functions/__init__.py| 497 ++--
.../templates/function/pg/sql/9.1_plus/get_oid.sql |   2 +-
.../templates/function/pg/sql/9.1_plus/node.sql|   5 +
.../function/pg/sql/9.1_plus/properties.sql|   5 +-
.../templates/function/pg/sql/9.2_plus/get_oid.sql |   2 +-
.../templates/function/pg/sql/9.2_plus/node.sql|   5 +
.../function/pg/sql/9.2_plus/properties.sql|   3 +-
.../templates/function/pg/sql/9.5_plus/get_oid.sql |   2 +-
.../templates/function/pg/sql/9.5_plus/node.sql|   5 +
.../function/pg/sql/9.5_plus/properties.sql|   5 +-
.../function/ppas/sql/9.1_plus/get_oid.sql |   2 +-
.../templates/function/ppas/sql/9.1_plus/node.sql  |   5 +
.../function/ppas/sql/9.1_plus/properties.sql  |   3 +-
.../function/ppas/sql/9.2_plus/get_oid.sql |   2 +-
.../templates/function/ppas/sql/9.2_plus/node.sql  |   5 +
.../function/ppas/sql/9.2_plus/properties.sql  |   3 +-
.../function/ppas/sql/9.5_plus/get_oid.sql |   2 +-
.../templates/function/ppas/sql/9.5_plus/node.sql  |   5 +
.../function/ppas/sql/9.5_plus/properties.sql  |   3 +-
.../procedure/ppas/sql/9.1_plus/get_oid.sql|   2 +-
.../templates/procedure/ppas/sql/9.1_plus/node.sql |   5 +
.../procedure/ppas/sql/9.1_plus/properties.sql |   3 +-
.../procedure/ppas/sql/9.2_plus/get_oid.sql|   2 +-
.../templa

[pgadmin-hackers] pgAdmin 4 commit: Fixes issues specific to SYNONYMS

[Ashesh Vashi]

Fixes issues specific to SYNONYMS
- On droping a synonyms - the query should be modified in SQL pane.
- A proper message should be given on trying to drop an already dropped
  synonyms.
- Handle the synonyms with special characters.

Fixes #1607, #1608, #1609

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=689ef8d8d140783ea29030262d594bd2db962464
Author: Murtuza Zabuawala 

Modified Files
--
.../servers/databases/schemas/synonyms/__init__.py | 38 +-
.../templates/synonym/sql/9.1_plus/create.sql  |  8 +++--
web/pgadmin/browser/templates/browser/js/node.js   |  4 +--
3 files changed, 38 insertions(+), 12 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the in Synonym node (pgAdmin4)

[Ashesh Vashi]

Thanks - committed with some change.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Mon, Aug 29, 2016 at 7:49 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA patch to fix the few minor issues in Synonym node.
> RM#1607, RM#1608, RM#1609
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

Re: [pgadmin-hackers] PATCH: To fix the issue in cast node (pgAdmin4)

[Ashesh Vashi]

This has already been fixed in
commit: b6f307256b7a48944d9e5a198d0d461b3ac5c5d5.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



*http://www.linkedin.com/in/asheshvashi*


On Mon, Aug 29, 2016 at 7:49 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor patch to fix the issue in cast node due to typo.
> RM#1614
>
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>

[pgadmin-hackers] pgAdmin 4 commit: SlickGrid Integration in to query tool. Fixes #1618

[Akshay Joshi]

SlickGrid Integration in to query tool. Fixes #1618

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c56e4667df7979fe23fab0a0ee2f7809f144ff97
Author: Murtuza Zabuawala 

Modified Files
--
libraries.txt  | 2 +
.../static/css/slickgrid/images/actions.gif|   Bin 0 -> 170 bytes
.../css/slickgrid/images/ajax-loader-small.gif |   Bin 0 -> 1849 bytes
.../static/css/slickgrid/images/arrow_redo.png |   Bin 0 -> 572 bytes
.../slickgrid/images/arrow_right_peppermint.png|   Bin 0 -> 128 bytes
.../css/slickgrid/images/arrow_right_spearmint.png |   Bin 0 -> 128 bytes
.../static/css/slickgrid/images/arrow_undo.png |   Bin 0 -> 578 bytes
.../static/css/slickgrid/images/bullet_blue.png|   Bin 0 -> 241 bytes
.../static/css/slickgrid/images/bullet_star.png|   Bin 0 -> 279 bytes
.../css/slickgrid/images/bullet_toggle_minus.png   |   Bin 0 -> 154 bytes
.../css/slickgrid/images/bullet_toggle_plus.png|   Bin 0 -> 156 bytes
.../static/css/slickgrid/images/calendar.gif   |   Bin 0 -> 1035 bytes
.../static/css/slickgrid/images/collapse.gif   |   Bin 0 -> 846 bytes
.../static/css/slickgrid/images/comment_yellow.gif |   Bin 0 -> 257 bytes
web/pgadmin/static/css/slickgrid/images/down.gif   |   Bin 0 -> 59 bytes
.../static/css/slickgrid/images/drag-handle.png|   Bin 0 -> 1130 bytes
.../css/slickgrid/images/editor-helper-bg.gif  |   Bin 0 -> 1164 bytes
web/pgadmin/static/css/slickgrid/images/expand.gif |   Bin 0 -> 851 bytes
.../static/css/slickgrid/images/header-bg.gif  |   Bin 0 -> 872 bytes
.../css/slickgrid/images/header-columns-bg.gif |   Bin 0 -> 836 bytes
.../slickgrid/images/header-columns-over-bg.gif|   Bin 0 -> 823 bytes
web/pgadmin/static/css/slickgrid/images/help.png   |   Bin 0 -> 345 bytes
web/pgadmin/static/css/slickgrid/images/info.gif   |   Bin 0 -> 80 bytes
.../static/css/slickgrid/images/listview.gif   |   Bin 0 -> 2380 bytes
web/pgadmin/static/css/slickgrid/images/pencil.gif |   Bin 0 -> 914 bytes
.../static/css/slickgrid/images/row-over-bg.gif|   Bin 0 -> 823 bytes
.../static/css/slickgrid/images/sort-asc.gif   |   Bin 0 -> 830 bytes
.../static/css/slickgrid/images/sort-asc.png   |   Bin 0 -> 105 bytes
.../static/css/slickgrid/images/sort-desc.gif  |   Bin 0 -> 833 bytes
.../static/css/slickgrid/images/sort-desc.png  |   Bin 0 -> 107 bytes
.../static/css/slickgrid/images/stripes.png|   Bin 0 -> 1125 bytes
.../static/css/slickgrid/images/tag_red.png|   Bin 0 -> 537 bytes
web/pgadmin/static/css/slickgrid/images/tick.png   |   Bin 0 -> 484 bytes
.../static/css/slickgrid/images/user_identity.gif  |   Bin 0 -> 905 bytes
.../css/slickgrid/images/user_identity_plus.gif|   Bin 0 -> 546 bytes
.../static/css/slickgrid/slick-default-theme.css   |   118 +
web/pgadmin/static/css/slickgrid/slick.grid.css|   158 +
.../images/ui-bg_flat_0_aa_40x100.png  |   Bin 0 -> 212 bytes
.../images/ui-bg_flat_75_ff_40x100.png |   Bin 0 -> 208 bytes
.../images/ui-bg_glass_55_fbf9ee_1x400.png |   Bin 0 -> 335 bytes
.../images/ui-bg_glass_65_ff_1x400.png |   Bin 0 -> 207 bytes
.../images/ui-bg_glass_75_dadada_1x400.png |   Bin 0 -> 262 bytes
.../images/ui-bg_glass_75_e6e6e6_1x400.png |   Bin 0 -> 262 bytes
.../images/ui-bg_glass_95_fef1ec_1x400.png |   Bin 0 -> 332 bytes
.../ui-bg_highlight-soft_75_cc_1x100.png   |   Bin 0 -> 280 bytes
.../smoothness/images/ui-icons_22_256x240.png  |   Bin 0 -> 6922 bytes
.../smoothness/images/ui-icons_2e83ff_256x240.png  |   Bin 0 -> 4549 bytes
.../smoothness/images/ui-icons_454545_256x240.png  |   Bin 0 -> 6992 bytes
.../smoothness/images/ui-icons_88_256x240.png  |   Bin 0 -> 6999 bytes
.../smoothness/images/ui-icons_cd0a0a_256x240.png  |   Bin 0 -> 4549 bytes
.../smoothness/jquery-ui-1.11.3.custom.css |  1225 ++
.../smoothness/jquery-ui-1.11.3.custom.min.css | 7 +
.../static/js/jquery-ui/jquery-ui-1.11.3.js| 16608 +++
.../static/js/jquery-ui/jquery-ui-1.11.3.min.js|13 +
.../static/js/jquery-ui/jquery.event.drag-2.2.js   |   402 +
.../static/js/jquery-ui/jquery.event.drop-2.2.js   |   302 +
.../js/slickgrid/controls/slick.columnpicker.css   |31 +
.../js/slickgrid/controls/slick.columnpicker.js|   152 +
.../static/js/slickgrid/controls/slick.pager.css   |41 +
.../static/js/slickgrid/controls/slick.pager.js|   147 +
.../js/slickgrid/plugins/slick.autotooltips.js |83 +
.../js/slickgrid/plugins/slick.cellcopymanager.js  |86 +
.../slickgrid/plugins/slick.cellrangedecorator.js  |66 +
.../slickgrid/plugins/slick.cellrangeselector.js   |   113 +
.../slickgrid/plugins/slick.cellselectionmodel.js  |   157 +
.../plugins/slick.checkboxselectcolumn.js  |   153 +
.../js/slickgrid/plugins/slick.headerbuttons.css   |39 +
.../js/slickgrid/plu

Re: [pgadmin-hackers] PATCH: SlickGrid integration in query tool (pgAdmin4)

[Akshay Joshi]

Thanks, patch applied.

On Mon, Aug 29, 2016 at 3:30 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA updated patch.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Aug 29, 2016 at 1:18 PM, Neel Patel 
> wrote:
>
>> Hi Murtuza,
>>
>> All the review comments given by Akshay are fixed. Below are some minor
>> observations.
>>
>>
>>- Add two new rows with valid data. Select one row and delete that
>>row. Now "Save" button should be enabled because we still have one valid
>>new row to save the data.
>>
>> Done
>
>>
>>- When we click on new blank row and select "By Selection" then it
>>throws 'javascript' exception.
>>
>>Uncaught TypeError: Cannot read property 'id' of undefined
>>
> Done
>
>>
>> Thanks,
>> Neel patel
>>
>> On Mon, Aug 29, 2016 at 10:43 AM, Murtuza Zabuawala <
>> murtuza.zabuaw...@enterprisedb.com> wrote:
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> -- Forwarded message --
>>> From: Murtuza Zabuawala 
>>> Date: Fri, Aug 26, 2016 at 8:27 PM
>>> Subject: Re: [pgadmin-hackers] PATCH: SlickGrid integration in query
>>> tool (pgAdmin4)
>>> To: Akshay Joshi 
>>> Cc: Dave Page , pgadmin-hackers <
>>> pgadmin-hackers@postgresql.org>
>>>
>>>
>>> Hi,
>>>
>>> PFA updated patch for SlickGrid.
>>>
>>> *Note:* This patch contains our own custom Slickgrid changes in
>>> SlickGrid no need to apply patch sent in last email.
>>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>> On Wed, Aug 24, 2016 at 6:27 PM, Akshay Joshi <
>>> akshay.jo...@enterprisedb.com> wrote:
>>>
 Hi Murtuza

 I have tested the functionality before reviewing the actual code, below
 are my review comments

 *Functionality related comments*:

- Filter "By Selection" and "Exclude Selection" not working.

 Done
>>>

- Increase the font size from 8pt to 9pt and also make the table
header's in bold.

 Done
>>>

- User won't be able to enter/copy the data directly from the cell.
With current implementation user has to double click on cell then one 
 data
editor popped up where user can enter/copy data and will have to press
"save" or "cancel" button. Then will have to double click again on the 
 cell
where he/she want's to paste and will have to press "save" or "cancel"
button.

 Copying from selected Cell is done. But for now you have edit target
>>> cell & paste the data in editor.
>>> I will create TODO ticket for this pasting data without opening editor
>>> in to cell as it requires some time.
>>>

- Slick grid not rendered properly when changing tabs or resize
"Data output" docker panel. Please refer "Error-1.png"
   - *Steps to reproduce*: View table data with more than 100 rows,
   scroll down a bit, now either shift tab and back again to "Data 
 output"
   panel OR resize the "Data output" docker panel.

 Done
>>>

- Slick grid is not refreshing properly when deleted multiple rows.

 Done
>>>

- Error Message is not cleared from "Messages" tab even after
successful transaction.
   - *Steps to reproduce*: Generate error by saving some wrong data
   and check "Messages" tab, now correct the value and save the data 
 again.
   Data gets saved, but "Messages" tab still show error message.

 Done
>>>

- Paste rows button gets disabled once it is clicked, as per me it
should be enabled if some rows are copied to clipboard.

 Done
>>>

- Facing weird issue for some tables, data is not being saved even
if I have given the correct values. Mostly it happens with NOT NULL 
 columns.
   -   *Steps to reproduce*: View Data of the table where there are
   columns with NOT NULL constraint.  I have tested it for 
 "public.jobhist"
   table of  PPAS-9.5. Add new row and insert values for primary key 
 columns,
   but don't insert any value for NOT NULL column. Now click on Save 
 button it
   will throw an error "null value in column  violates not-null
   constraint". Now insert the proper value for that column and try to 
 save
   it, still it will give the same error.

  Done
>>>

- Extra space has been added for the drop down menu of query tool
toolbar. Please refer "Before_Slickgrid.png" and "After_Slickgrid.png"

 Done
>>>

 On Tue, Aug 23, 2016 at 4:00 PM, Murtuza Zabuawala <
 murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
>
> PFA minor add-on patch on p

[pgadmin-hackers] pgAdmin 4 commit: Bump version for RC1 release

[Ashesh Vashi]

Bump version for RC1 release

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7dd8cbab452fb7bde10074e903f82c95816e942

Modified Files
--
web/config.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers