Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary
Hi Dave, Error resolved. Please find the revised patch. On Fri, Sep 16, 2016 at 9:23 PM, Dave Page wrote: > Hi > > On Fri, Sep 16, 2016 at 2:37 PM, Navnath Gadakh > wrote: > > Hi Dave, > > Please find the patch for the enhanced test result summary for > testing > > framework. The code for this, was completed before drop object's > > functionality & independent from drop objects work. > > Drop objects work will take time, I am working on that for remaining > nodes. > > Meanwhile, we go ahead with enhanced test summary. > > > > To run the test suite follow the commands > > 1. python regression/runtests.py --pkg browser.server_groups.servers > > 2. python regression/runtests.py --pkg > > browser.server_groups.servers.databases > > I'm seeing some issues with this patch: > > - There are updates to config.py and setup.py that shouldn't be there. > - I get this error at the end of a successful test run: > > Test Result Summary > > Regression - PG 9.4: 25 tests passed, 0 tests failed > > > Please check output in file: > /Users/dpage/git/pgadmin4/web/regression/regression.log > Error in atexit._run_exitfuncs: > Traceback (most recent call last): > File "/System/Library/Frameworks/Python.framework/Versions/2.7/ > lib/python2.7/atexit.py", > line 24, in _run_exitfuncs > func(*targs, **kargs) > File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line > 360, in drop_objects > file_name, sys.exc_traceback.tb_lineno, exception)) > Exception: test_utils.py: line:337 'NoneType' object has no attribute > '__getitem__' > Error in sys.exitfunc: > Traceback (most recent call last): > File "/System/Library/Frameworks/Python.framework/Versions/2.7/ > lib/python2.7/atexit.py", > line 24, in _run_exitfuncs > func(*targs, **kargs) > File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line > 360, in drop_objects > file_name, sys.exc_traceback.tb_lineno, exception)) > Exception: test_utils.py: line:337 'NoneType' object has no attribute > '__getitem__' > > Thanks. > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Regards, Navnath enhanced_testresult_summary.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] PATCH: To fix the issue in Packages node (pgAdmin4)
Hi, PFA minor patch to fix the issue in Packages node where after updating any package user was getting 'Not Found' error. RM#1625 *Issue:* It was due to wrong parent was provided while sending the node to client. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1625.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary
Hi On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh wrote: > Hi Dave, > Error resolved. Please find the revised patch. I still see the error: Test Result Summary Regression - PG 9.4: 25 tests passed, 0 tests failed Please check output in file: /Users/dpage/git/pgadmin4/web/regression/regression.log Error in atexit._run_exitfuncs: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line 360, in drop_objects file_name, sys.exc_traceback.tb_lineno, exception)) Exception: test_utils.py: line:337 'NoneType' object has no attribute '__getitem__' Error in sys.exitfunc: Traceback (most recent call last): File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py", line 24, in _run_exitfuncs func(*targs, **kargs) File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line 360, in drop_objects file_name, sys.exc_traceback.tb_lineno, exception)) Exception: test_utils.py: line:337 'NoneType' object has no attribute '__getitem__' -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Resolve a refresh issue when updating packages. Fixes
Resolve a refresh issue when updating packages. Fixes #1625 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82d63804c1877f6e272b02a54c1b420ae034bd28 Author: Murtuza Zabuawala Modified Files -- .../server_groups/servers/databases/schemas/packages/__init__.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: To fix the issue in Packages node (pgAdmin4)
Thanks, applied. On Mon, Sep 19, 2016 at 8:20 AM, Murtuza Zabuawala wrote: > Hi, > > PFA minor patch to fix the issue in Packages node where after updating any > package user was getting 'Not Found' error. > RM#1625 > > Issue: > It was due to wrong parent was provided while sending the node to client. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] [pgAdmin4][Patch]: RM1588 - User can not change the code of header through right if package created without body
Hi Please find attached patch with fix: Minor changes in template file. Checks were missing for creating package body and drop package body. Please review. Thanks, Surinder Kumar RM1588.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] PATCH: To fix column editor issue (pgAdmin4)
Hi, PFA patch to fix the issue in column editor where subnode control was not expanding properly. RM#1703/04 *Issue:* There was issue in SecurityGroup function(used to show/hide security tab) which was not able to find node_info property when called from subnode control, due t which it was breaking while expanding subnode control. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1703_1704.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin website commit: Add Linux package info
Add Linux package info Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=b321740bf3193822afade8ec809b43e550e67a7f Modified Files -- download/linux4.php | 22 ++ download/menu.php | 1 + 2 files changed, 23 insertions(+) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin website commit: Fix brain fart
Fix brain fart Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=5aa32cc67ebeda7a9a3a87cc876eac12c6333db7 Modified Files -- download/linux4.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] Finalizing pgadmin4 RPM work
On Fri, Sep 16, 2016 at 9:17 AM, Devrim Gündüz wrote: > > Hi, > > On Mon, 2016-09-12 at 11:46 +0100, Dave Page wrote: >> >> Awesome - thanks Devrim! I owe you a nice cool glass of spring water :-) > > \o/ Can't wait ;) > >> Let me know when packages available and ready to use, and I'll add a >> page to the website to point people at them. > > They are currently available for 9.6 only, on yum.postgresql.org. All testing > has been good so far. Feel free to add info to pgadmin website. I am planning > to write a short blog post about that soon, about installation instructions, > running, etc. https://www.pgadmin.org/download/linux4.php How's that? If you have instructions, please send me text (or better yet, a patch), and I'll add them. Thanks! -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] PATCH: To fix the issue where user gets error following application server restart (pgAdmin4)
Hi, PFA patch to fix the issue where user gets error following application server restart. RM#1707 -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company RM_1707.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary
Hi Dave, In the drop objects function scenario for 'NoneType' was not handled. Code is added in the revised patch. Thanks. On Mon, Sep 19, 2016 at 2:03 PM, Dave Page wrote: > Hi > > On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh > wrote: > > Hi Dave, > > Error resolved. Please find the revised patch. > > I still see the error: > > Test Result Summary > > Regression - PG 9.4: 25 tests passed, 0 tests failed > > > Please check output in file: > /Users/dpage/git/pgadmin4/web/regression/regression.log > Error in atexit._run_exitfuncs: > Traceback (most recent call last): > File "/System/Library/Frameworks/Python.framework/Versions/2.7/ > lib/python2.7/atexit.py", > line 24, in _run_exitfuncs > func(*targs, **kargs) > File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line > 360, in drop_objects > file_name, sys.exc_traceback.tb_lineno, exception)) > Exception: test_utils.py: line:337 'NoneType' object has no attribute > '__getitem__' > Error in sys.exitfunc: > Traceback (most recent call last): > File "/System/Library/Frameworks/Python.framework/Versions/2.7/ > lib/python2.7/atexit.py", > line 24, in _run_exitfuncs > func(*targs, **kargs) > File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line > 360, in drop_objects > file_name, sys.exc_traceback.tb_lineno, exception)) > Exception: test_utils.py: line:337 'NoneType' object has no attribute > '__getitem__' > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > -- Regards, Navnath enhanced_testresult_summary.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] [pgAdmin4][Patch]: Slickgrid loading issue in Query tool
Hi
*Issue:*
Slick-grid libraries loads when an instance of query tool is opened. But
sometimes it throws exception "jQuery is not defined" and it doesn't opens
up.
*Solution:*
As per my understanding, In *datagrid/index.html* file, we set the order of
loading libraries such as
*require(['jquery', 'pgadmin', 'pgadmin.sqleditor']) *
but it still loads *pgadmin.sqleditor.js* file before *jQuery* for unknown
reason.
To fix this, we load *pgadmin.sqleditor.js* file using *require([],
function(){}) *module loader which ensures that the code within
*function(){}* will be executed when pgadmin.sqleditor.js is loaded.
Please find attache patch.
This issue is fixed by *Ashesh Vashi*.
Thanks,
Surinder Kumar
slickgrid_js_load_issue.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
Hi Please find attached patch with fix. > Download as CSV > button should be enabled only for SELECT queries. Please review. Thanks, Surinder Kumar RM1592.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Resolve a syntax error when updating packages with no
Resolve a syntax error when updating packages with no body. Fixes #1588 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc0cb8327750e6ee1b13193d5afdc22ff3754022 Author: Surinder Kumar Modified Files -- .../packages/templates/package/ppas/9.1_plus/update.sql | 12 +--- .../packages/templates/package/ppas/9.2_plus/update.sql | 11 +-- 2 files changed, 2 insertions(+), 21 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1588 - User can not change the code of header through right if package created without body
Thanks, applied. On Mon, Sep 19, 2016 at 10:29 AM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix: > Minor changes in template file. Checks were missing for creating package > body and drop package body. > > Please review. > > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Fix an issue where the edit icon vanished and the def
Fix an issue where the edit icon vanished and the default tab wasn't shown when advanced-editing a column in the table dialogue. Fixes #1704 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2440f89a7134d9c8ff28b8f93ea0baf1e2abb211 Author: Murtuza Zabuawala Modified Files -- .../servers/databases/schemas/templates/schema/js/schema.js| 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: To fix column editor issue (pgAdmin4)
Thanks, applied. On Mon, Sep 19, 2016 at 11:10 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue in column editor where subnode control was not > expanding properly. > RM#1703/04 > > Issue: > There was issue in SecurityGroup function(used to show/hide security tab) > which was not able to find node_info property when called from subnode > control, due t which it was breaking while expanding subnode control. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Fix an exception that could occur when the browser pi
Fix an exception that could occur when the browser pings the server following a restart. Fixes #1707 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=881d2a60a4e1ef357dcf9fcfb5375f8dc3dd2163 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/utils/driver/psycopg2/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] PATCH: To fix the issue where user gets error following application server restart (pgAdmin4)
Thanks, applied. On Mon, Sep 19, 2016 at 12:48 PM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user gets error following application > server restart. > RM#1707 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
Hi On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar wrote: > Hi > > Please find attached patch with fix. >> >> Download as CSV >> button should be enabled only for SELECT queries. I'm not sure there's a way to do this without parsing the query. Simply matching on ^select certainly won't work reliably - for example, there could be multiple statements in the script, or it could be PERFORM ... or UPDATE ... RETURNING ... I think we need to leave the button enabled, but give the user a message if no data is returned, e.g. === Download as CSV - The query executed did not return any data. [OK] -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button
Hi Please find patch with following fixes: 1) Newly added server-group not listing in tree view. 2) On creating a first node for collection node with no child. the created node doesn't show up under its respective parent node. - to add a node to child under its parent node. its parent node attribute must be set 'inode: true' but it always gets false for inode that doesn't add the node. Ashesh - Can you please review it? Thanks Surinder Kumar RM1627.patch Description: Binary data -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote: > Hi > > On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar > wrote: > > Hi > > > > Please find attached patch with fix. > >> > >> Download as CSV > >> button should be enabled only for SELECT queries. > > I'm not sure there's a way to do this without parsing the query. > Simply matching on ^select certainly won't work reliably - for > example, there could be multiple statements in the script, or it could > be PERFORM ... or UPDATE ... RETURNING ... > I wasn't aware of such cases. > > I think we need to leave the button enabled, but give the user a > message if no data is returned, e.g. > ok. sure. > > === > Download as CSV > - > > The query executed did not return any data. > > [OK] > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
[pgadmin-hackers] pgAdmin 4 commit: Enhanced summary output for the test suite.
Enhanced summary output for the test suite. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c84fd83595be4922879c150314e9f1973e087e3f Author: Navnath Gadakh Modified Files -- .../servers/databases/tests/test_db_add.py | 35 +-- .../servers/databases/tests/test_db_delete.py | 19 +- .../servers/databases/tests/test_db_get.py | 40 +-- .../servers/databases/tests/test_db_put.py | 33 ++- .../server_groups/servers/databases/tests/utils.py | 113 +++-- .../server_groups/servers/tests/test_server_add.py | 21 +- .../servers/tests/test_server_delete.py| 28 +-- .../server_groups/servers/tests/test_server_put.py | 33 +-- .../browser/server_groups/servers/tests/utils.py | 37 +-- web/regression/__init__.py | 4 +- web/regression/runtests.py | 49 +++- web/regression/test_utils.py | 279 ++--- 12 files changed, 419 insertions(+), 272 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] pgAdmin IV- Testing framework: Enhanced Test Result Summary
Thanks - applied with minor tweaks to the output formatting. On Mon, Sep 19, 2016 at 2:03 PM, Navnath Gadakh wrote: > Hi Dave, > In the drop objects function scenario for 'NoneType' was not handled. > Code is added in the revised patch. > > Thanks. > > On Mon, Sep 19, 2016 at 2:03 PM, Dave Page > wrote: >> >> Hi >> >> On Mon, Sep 19, 2016 at 8:14 AM, Navnath Gadakh >> wrote: >> > Hi Dave, >> > Error resolved. Please find the revised patch. >> >> I still see the error: >> >> Test Result Summary >> >> Regression - PG 9.4: 25 tests passed, 0 tests failed >> >> >> Please check output in file: >> /Users/dpage/git/pgadmin4/web/regression/regression.log >> Error in atexit._run_exitfuncs: >> Traceback (most recent call last): >> File >> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py", >> line 24, in _run_exitfuncs >> func(*targs, **kargs) >> File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line >> 360, in drop_objects >> file_name, sys.exc_traceback.tb_lineno, exception)) >> Exception: test_utils.py: line:337 'NoneType' object has no attribute >> '__getitem__' >> Error in sys.exitfunc: >> Traceback (most recent call last): >> File >> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/atexit.py", >> line 24, in _run_exitfuncs >> func(*targs, **kargs) >> File "/Users/dpage/git/pgadmin4/web/regression/test_utils.py", line >> 360, in drop_objects >> file_name, sys.exc_traceback.tb_lineno, exception)) >> Exception: test_utils.py: line:337 'NoneType' object has no attribute >> '__getitem__' >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake > > > > > -- > Regards, > Navnath > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Regression errors - database node
Hi Navnath I keep seeing the errors below when running tests. It seems to be consistent on EPAS, but intermittent on PG. Any ideas what the issue is? I'm fairly convinced it's a test issue not an actual problem. 2016-09-19 16:47:49,567:ERROR:STDERR:== 2016-09-19 16:47:49,568:ERROR:STDERR:ERROR: runTest (pgadmin.browser.server_groups.servers.databases.tests.test_db_get.DatabasesGetTestCase) 2016-09-19 16:47:49,568:ERROR:STDERR:This function will fetch added database. (Check Databases Node URL) 2016-09-19 16:47:49,568:ERROR:STDERR:-- 2016-09-19 16:47:49,568:ERROR:STDERR:Traceback (most recent call last): 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/test_db_get.py", line 33, in runTest 2016-09-19 16:47:49,568:ERROR:STDERR:self.db_id) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/tests/utils.py", line 142, in verify_database 2016-09-19 16:47:49,568:ERROR:STDERR:follow_redirects=True) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 788, in post 2016-09-19 16:47:49,568:ERROR:STDERR:return self.open(*args, **kw) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/testing.py", line 113, in open 2016-09-19 16:47:49,568:ERROR:STDERR:follow_redirects=follow_redirects) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 751, in open 2016-09-19 16:47:49,568:ERROR:STDERR:response = self.run_wsgi_app(environ, buffered=buffered) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 668, in run_wsgi_app 2016-09-19 16:47:49,568:ERROR:STDERR:rv = run_wsgi_app(self.application, environ, buffered=buffered) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/werkzeug/test.py", line 871, in run_wsgi_app 2016-09-19 16:47:49,568:ERROR:STDERR:app_rv = app(environ, start_response) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 2000, in __call__ 2016-09-19 16:47:49,568:ERROR:STDERR:return self.wsgi_app(environ, start_response) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1991, in wsgi_app 2016-09-19 16:47:49,568:ERROR:STDERR:response = self.make_response(self.handle_exception(e)) 2016-09-19 16:47:49,568:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1567, in handle_exception 2016-09-19 16:47:49,568:ERROR:STDERR:reraise(exc_type, exc_value, tb) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1988, in wsgi_app 2016-09-19 16:47:49,569:ERROR:STDERR:response = self.full_dispatch_request() 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request 2016-09-19 16:47:49,569:ERROR:STDERR:rv = self.handle_user_exception(e) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1544, in handle_user_exception 2016-09-19 16:47:49,569:ERROR:STDERR:reraise(exc_type, exc_value, tb) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request 2016-09-19 16:47:49,569:ERROR:STDERR:rv = self.dispatch_request() 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1625, in dispatch_request 2016-09-19 16:47:49,569:ERROR:STDERR:return self.view_functions[rule.endpoint](**req.view_args) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/views.py", line 84, in view 2016-09-19 16:47:49,569:ERROR:STDERR:return self.dispatch_request(*args, **kwargs) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line 235, in dispatch_request 2016-09-19 16:47:49,569:ERROR:STDERR:return method(*args, **kwargs) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/__init__.py", line 364, in connect 2016-09-19 16:47:49,569:ERROR:STDERR:conn = manager.connection(did=did, auto_reconnect=True) 2016-09-19 16:47:49,569:ERROR:STDERR: File "/Users/dpage
[pgadmin-hackers] pgAdmin 4 commit: Ensure jQuery is loaded before SlickGrid. Fixes #1712
Ensure jQuery is loaded before SlickGrid. Fixes #1712 Patch by Ashesh with contributions from Surinder. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7ab0eb158f52d8fa662b55035f5dc91b7dd4c332 Author: Ashesh Vashi Modified Files -- .../tools/datagrid/templates/datagrid/index.html | 102 ++--- 1 file changed, 49 insertions(+), 53 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: Slickgrid loading issue in Query tool
Thanks, applied.
On Mon, Sep 19, 2016 at 2:58 PM, Surinder Kumar
wrote:
> Hi
>
> Issue:
> Slick-grid libraries loads when an instance of query tool is opened. But
> sometimes it throws exception "jQuery is not defined" and it doesn't opens
> up.
>
> Solution:
> As per my understanding, In datagrid/index.html file, we set the order of
> loading libraries such as
> require(['jquery', 'pgadmin', 'pgadmin.sqleditor'])
> but it still loads pgadmin.sqleditor.js file before jQuery for unknown
> reason.
>
> To fix this, we load pgadmin.sqleditor.js file using require([],
> function(){}) module loader which ensures that the code within function(){}
> will be executed when pgadmin.sqleditor.js is loaded.
>
> Please find attache patch.
> This issue is fixed by Ashesh Vashi.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1627 - Objects are not visible after creation until press refresh button
Hi On Mon, Sep 19, 2016 at 4:23 PM, Surinder Kumar wrote: > Hi > > Please find patch with following fixes: > > 1) Newly added server-group not listing in tree view. > > 2) On creating a first node for collection node with no child. the created > node doesn't show up under its respective parent node. > - to add a node to child under its parent node. its parent node attribute > must be set 'inode: true' but it always gets false for inode that doesn't > add the node. > > Ashesh - Can you please review it? I tested this by adding a sequence to a database and schema that didn't previously contain any. The node was not added, and in the Javascript console I get: browser.js:1108 Failed to append -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1592 - Download as CSV should be supported for DDL
On Mon, Sep 19, 2016 at 8:59 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > On Mon, Sep 19, 2016 at 8:48 PM, Dave Page wrote: > >> Hi >> >> On Mon, Sep 19, 2016 at 3:03 PM, Surinder Kumar >> wrote: >> > Hi >> > >> > Please find attached patch with fix. >> >> >> >> Download as CSV >> >> button should be enabled only for SELECT queries. >> >> I'm not sure there's a way to do this without parsing the query. >> Simply matching on ^select certainly won't work reliably - for >> example, there could be multiple statements in the script, or it could >> be PERFORM ... or UPDATE ... RETURNING ... >> > I wasn't aware of such cases. > >> >> I think we need to leave the button enabled, but give the user a >> message if no data is returned, e.g. >> > ok. sure. > I discussed the issue with Harshal and this is how download csv works: We just hit the url to download csv, and let the browser handle the response from the server side. we don't have access to response data to check if no data is returned. The other approach is to hit the same query twice. First time an ajax query to check if data is returned or not. if returned, fire another query to download csv otherwise set message in message panel. But the limitation with this approach is that we are just increasing load over server by hitting same query twice, incase returned data rows in billions. Thoughts ? > >> === >> Download as CSV >> - >> >> The query executed did not return any data. >> >> [OK] >> > > >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > >
