[pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1887

[Khushboo Vashi]

Hi,

Please find the patch to fix RM 1887: Preferences values ate not stored
properly.

Thanks,
Khushboo
diff --git a/web/pgadmin/preferences/templates/preferences/preferences.js b/web/pgadmin/preferences/templates/preferences/preferences.js
index 09788fc..e02c926 100644
--- a/web/pgadmin/preferences/templates/preferences/preferences.js
+++ b/web/pgadmin/preferences/templates/preferences/preferences.js
@@ -35,7 +35,7 @@ define(
* This model will be used to keep tracking of the changes done for
* an individual option.
*/
-  var PreferenceModel = pgBrowser.DataModel.extend({
+  var PreferenceModel = Backbone.Model.extend({
 idAttribute: 'id',
 defaults: {
   id: undefined,
@@ -107,8 +107,9 @@ define(
  */
 _.each(prefs, function(p) {
 
-  var m = preferences.get(p.id),
-  f = new Backform.Field(
+  var m = preferences.get(p.id);
+  m.errorModel = new Backbone.Model();
+  var f = new Backform.Field(
 _.extend({}, p, {id: 'value', name: 'value'})
 ),
   cntr = new (f.get("control")) ({

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

[Harshal Dhumal]

Hi,

PFA attached patch for pgagent issue RM1878

issue fixed: ProgrammingError: can't adapt type 'Undefined'

-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/steps/__init__.py b/web/pgadmin/browser/server_groups/servers/pgagent/steps/__init__.py
index ccded7a..4def636 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/steps/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/steps/__init__.py
@@ -232,8 +232,8 @@ SELECT EXISTS(
 res = []
 sql = render_template(
 "/".join([self.template_path, 'nodes.sql']),
-jstid = jstid,
-jid = jid
+jstid=jstid,
+jid=jid
 )
 
 status, result = self.conn.execute_2darray(sql)
@@ -315,13 +315,16 @@ SELECT EXISTS(
 jid: Job ID
 """
 data = {}
-for k, v in request.args.items():
-try:
-data[k] = json.loads(
-v.decode('utf-8') if hasattr(v, 'decode') else v
-)
-except ValueError:
-data[k] = v
+if request.args:
+for k, v in request.args.items():
+try:
+data[k] = json.loads(
+v.decode('utf-8') if hasattr(v, 'decode') else v
+)
+except ValueError:
+data[k] = v
+else:
+data = json.loads(request.data.decode())
 
 sql = render_template(
 "/".join([self.template_path, 'create.sql']),
@@ -337,8 +340,8 @@ SELECT EXISTS(
 
 sql = render_template(
 "/".join([self.template_path, 'nodes.sql']),
-jstid = res,
-jid = jid
+jstid=res,
+jid=jid
 )
 status, res = self.conn.execute_2darray(sql)
 
@@ -417,8 +420,8 @@ SELECT EXISTS(
 
 sql = render_template(
 "/".join([self.template_path, 'nodes.sql']),
-jstid = jstid,
-jid = jid
+jstid=jstid,
+jid=jid
 )
 status, res = self.conn.execute_2darray(sql)
 

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

[Harshal Dhumal]

Hi,

Please ignore this patch as I haven't fixed same issue for schedule. Also
there is issue "malformed array literal" when we try to save schedule.

I'll be sending updated patch.

Thanks Harshal,

-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Oct 21, 2016 at 2:51 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> PFA attached patch for pgagent issue RM1878
>
> issue fixed: ProgrammingError: can't adapt type 'Undefined'
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1599 - Unable to fetch the records for grant wizard if schema contains special characters

[Dave Page]

Thanks, applied.

On Thu, Oct 20, 2016 at 6:40 AM, Surinder Kumar
 wrote:
> Hi,
>
> Issue:
> The schema name was passed into the template files to get schema name in
> response which doesn't escape special characters.
>
> Now schema is fetched using a JOIN statement on needed tables.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure the grant wizard works with objects with speci

[Dave Page]

Ensure the grant wizard works with objects with special characters in the name. 
Fixes #1599

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9155c2111f3f276614987f55e083da63239855d6
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/tools/grant_wizard/__init__.py  | 17 +++--
.../templates/grant_wizard/pg/9.1_plus/sql/function.sql |  5 +++--
.../templates/grant_wizard/pg/9.1_plus/sql/sequence.sql |  7 ---
.../templates/grant_wizard/pg/9.1_plus/sql/table.sql|  7 ---
.../templates/grant_wizard/pg/9.1_plus/sql/view.sql |  5 +++--
.../grant_wizard/ppas/9.1_plus/sql/function.sql |  5 +++--
.../grant_wizard/ppas/9.1_plus/sql/sequence.sql |  7 ---
.../templates/grant_wizard/ppas/9.1_plus/sql/table.sql  |  7 ---
.../templates/grant_wizard/ppas/9.1_plus/sql/view.sql   |  5 +++--
9 files changed, 35 insertions(+), 30 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] patch for RM1861 [pgAdmin4]

[Dave Page]

Thanks, applied.

On Thu, Oct 20, 2016 at 7:28 AM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA minor patch for RM1861.
>
> Issue fixed: SQL not generated for exclusion constraint on table
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Properly generate exclusion constraint SQL. Fixes #18

[Dave Page]

Properly generate exclusion constraint SQL. Fixes #1861

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6874a1a2471e357d21276c432a6a69948650455f
Author: Harshal Dhumal 

Modified Files
--
.../schemas/tables/constraints/exclusion_constraint/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Don't specify ASC/DESC options for index types that d

[Dave Page]

Don't specify ASC/DESC options for index types that don't support them. Fixes 
#1840

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06039320b941d3d98f1ab044320ba177e47d0f9c
Author: Surinder Kumar 

Modified Files
--
.../schemas/tables/templates/index/sql/9.1_plus/create.sql  | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

[Dave Page]

Thanks, applied.

On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar
 wrote:
> Hi,
>
> The options like "sort" and "nulls" must be conditional. i.e. include only
> when access method type is other than "gist" or "gin".
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Add new indexes to the correct parent on the treeview

[Dave Page]

Add new indexes to the correct parent on the treeview. Fixes #1880

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48ee8490f04cbe397d5f010481819d2297e5fa2b
Author: Surinder Kumar 

Modified Files
--
.../server_groups/servers/databases/schemas/tables/indexes/__init__.py  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1728 - Properties are not refreshing after objects are edited

[Dave Page]

Thanks, applied (and I dealt with the RM).

On Thu, Oct 20, 2016 at 7:58 AM, Surinder Kumar
 wrote:
> Hi,
>
> While fixing RM1840, I found when we add new index, it doesn't add under
> right parent. i.e. columns collection. because wrong parent is given in
> response.
> I also verified other nodes. This issue is only with index node.
>
> Do, I need to create separate RM for this case. ?
>
> Please find attached minor patch and review.
>
> On Tue, Oct 18, 2016 at 4:03 PM, Dave Page  wrote:
>>
>> Thanks - applied!
>>
>> On Mon, Oct 17, 2016 at 7:48 AM, Surinder Kumar
>>  wrote:
>> > On Sun, Oct 16, 2016 at 7:29 AM, Dave Page  wrote:
>> >>
>> >> Hi
>> >>
>> >> I just found a case where this patch is broken - if you update the
>> >> comment
>> >> on a type, it looks like it tried to lookup the schema ID using the
>> >> type
>> >> name, which a) isn't in the posted data so gives a 500 response, and b)
>> >> wouldn't be safe anyway, if there were types with the same name in
>> >> multiple
>> >> schemas.
>> >
>> > I have fixed this issue. Now it will lookup the schema ID against the
>> > type
>> > id instead of type name.
>> >>
>> >>
>> >> Actually, it looks like that's an issue when creating a type too - that
>> >> is
>> >> also using an unsafe schema lookup.
>> >>
>> >> Please fix this ASAP (i.e. Monday) and double check to ensure we're not
>> >> doing any more unsafe lookups like this.
>> >
>> > It looks good to me in other nodes.
>> > Please find attached patch and review.
>> >>
>> >>
>> >> Thanks.
>> >>
>> >>
>> >> On Friday, October 14, 2016, Dave Page  wrote:
>> >>>
>> >>> Thanks, applied.
>> >>>
>> >>> On Friday, October 14, 2016, Surinder Kumar
>> >>>  wrote:
>> 
>>  Hi
>> 
>>  Following are the issues fixed in nodes:
>> 
>>  1) If we create/update a node with non-default schema, It should
>>  return
>>  selected schema id in return response. but default schema id is
>>  returned
>>  every time due to which it throws error in properties panel.
>>  Fixed in Domains, Collation, Types, Views & Table node.
>> 
>>  2) Incorrect parent id of object node is returned from nodes method
>>  due
>>  to which wrong parent id is passed while updating object and
>>  thus node didn't get refreshed.
>>  Fixed in FTS Configuration, FTS Parser nodes.
>> 
>>  Also, I have kept changes of first patch which are essential to
>>  refresh
>>  node every time. Without that patch nodes properties panel updates
>>  only
>>  sometimes.
>> 
>>  Please find attached patch. Please review and let me know for
>>  comments.
>> 
>>  Thanks
>>  Surinder Kumar
>> 
>> 
>> 
>>  On Fri, Sep 23, 2016 at 6:00 PM, Dave Page  wrote:
>> >
>> > Umm, no it wasn't - sorry.
>> >
>> > I see the same issue with Types. Can you fix that, and check all
>> > other
>> > nodes as well please?
>> >
>> > Thanks.
>> >
>> > On Fri, Sep 23, 2016 at 1:29 PM, Dave Page 
>> > wrote:
>> > > Thanks, applied.
>> > >
>> > > On Fri, Sep 23, 2016 at 12:05 PM, Surinder Kumar
>> > >  wrote:
>> > >> Hi,
>> > >>
>> > >> Please find updated patch with changes:
>> > >> 1) On debugging through JS files, the issue was in synonym update
>> > >> method
>> > >> which wasn't returning node object.
>> > >> 2) retrieving schema name in node.sql for creating node object in
>> > >> update
>> > >> method.
>> > >>
>> > >> Please review and let me know for comments.
>> > >>
>> > >> On Fri, Sep 23, 2016 at 2:44 PM, Dave Page 
>> > >> wrote:
>> > >>>
>> > >>> Hi
>> > >>>
>> > >>> On Fri, Sep 23, 2016 at 7:39 AM, Surinder Kumar
>> > >>>  wrote:
>> > >>> > Hi
>> > >>> >
>> > >>> > Issue:
>> > >>> > on updating node, we deselect and then again select the node
>> > >>> > updated to
>> > >>> > refresh the panel. but it needs some delay of few milliseconds
>> > >>> > between
>> > >>> > deselect and select to fix this issue.
>> > >>> >
>> > >>> > Please find attached patch and review.
>> > >>>
>> > >>> This does not resolve the issue for me. I tested using a synonym
>> > >>> to
>> > >>> a
>> > >>> package on EPAS 9.5, by changing the target package name.
>> > >>>
>> > >>>
>> > >>> --
>> > >>> Dave Page
>> > >>> Blog: http://pgsnake.blogspot.com
>> > >>> Twitter: @pgsnake
>> > >>>
>> > >>> EnterpriseDB UK: http://www.enterprisedb.com
>> > >>> The Enterprise PostgreSQL Company
>> > >>
>> > >>
>> > >
>> > >
>> > >
>> > > --
>> > > Dave Page
>> > > Blog: http://pgsnake.blogspot.com
>> > > Twitter: @pgsnake
>> > >
>> > > EnterpriseDB UK: http://www.enterprisedb.com
>> > > The Enterprise PostgreSQL Company
>> >
>> >
>> >
>> > --
>> > Dave Page
>> > Blog: http://pgsnake.blogspot.c

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Dave Page]

Hi

There are still issues I'm afraid:

- When execution stops, we seem to keep polling for more results indefinitely.

- When executing for a second time, the messages tab isn't cleared,
and new messages don't seem to be appended to it either. I would
expect the tab to be cleared.

On Thu, Oct 20, 2016 at 9:14 AM, Murtuza Zabuawala
 wrote:
> Hi Dave,
>
> PFA updated patch for the same.
>
> Issue:
> We were not properly fetching result from server in case of direct debugging
> when we restart debugging of same object.
>
> Thanks to Neel for helping in this issue.
>
> Please review.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Oct 7, 2016 at 5:32 PM, Dave Page  wrote:
>>
>> On Fri, Oct 7, 2016 at 12:53 PM, Dave Page  wrote:
>> > On Fri, Oct 7, 2016 at 12:42 PM, Murtuza Zabuawala
>> >  wrote:
>> >> Hi Dave,
>> >>
>> >> I faced the same issue when I initially tried that, but then as per
>> >> Neel
>> >> suggestion I changed SELECT pg_sleep() to PERFORM pg_sleep() in
>> >> function.
>> >> You will face the same in pgAdmin3 if you use select pg_sleep() in your
>> >> function the debug call never returns from DB server.
>> >
>> > In which case, doesn't that imply the debugger is missing critical
>> > debug info? If I run the query in the query tool, I get:
>> >
>> > 
>> > INFO:  EMPNOENAME
>> > INFO:  ----
>> > ERROR:  query has no destination for result data
>> > HINT:  If you want to discard the results of a SELECT, use PERFORM
>> > instead.
>> > CONTEXT:  PL/pgSQL function list_emp() line 11 at SQL statement
>> >
>> >
>> > Query returned successfully in 2 secs.
>> > 
>> >
>> > It seems to me that the debugger should be able to give the same error.
>> >
>> > Regardless of that, I'll test with PERFORM.
>>
>> Which I just did - and whilst it seemed to be fine when stepping
>> through, after a few iterations I hit the continue button, at which
>> point it froze again on "PERFORM pg_sleep(2)", didn't print any more
>> of the 14 names in the emp table, and didn't return :-(
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Language node patch

[Dave Page]

Thanks, applied.

On Thu, Oct 20, 2016 at 10:09 AM, Navnath Gadakh
 wrote:
> Hi Dave,
>Please find revised patch for languages API test cases. Resolved some
> PG9.6 compatibility issues.
>
> Thanks.
>
> On Tue, Oct 18, 2016 at 7:08 PM, Dave Page 
> wrote:
>>
>> Thanks, applied.
>>
>> On Tue, Oct 18, 2016 at 1:48 PM, Priyanka Shendge
>>  wrote:
>> > Hi Dave,
>> >
>> > PFA patch for Languages node.
>> >
>> > Run the test suite by following command:
>> >   python runtests.py
>> >
>> > Thank you.
>> >
>> >
>> > --
>> > Best,
>> > Priyanka
>> >
>> > EnterpriseDB Corporation
>> > The Enterprise PostgreSQL Company
>>
>>
>>
>> --
>> Dave Page
>> VP, Chief Architect, Tools & Installers
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
>
>
> --
> Regards,
> Navnath Gadakh
>
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Resolve a PG 9.6 compatibility issue in the regressio

[Dave Page]

Resolve a PG 9.6 compatibility issue in the regression test for Languages.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1908e86d223b27e2e40ca128432a08589d082a0e
Author: Navnath Gadakh 

Modified Files
--
.../servers/databases/languages/tests/test_language_add.py  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Neel Patel]

Hi,


On Fri, Oct 21, 2016 at 4:48 PM, Dave Page  wrote:

> Hi
>
> There are still issues I'm afraid:
>
> - When execution stops, we seem to keep polling for more results
> indefinitely.
>
Do you mean after completion of first successful debugging ?
If yes, we are polling because user can start same function for debugging
again and we have to listen for the result set for that session.

>
> - When executing for a second time, the messages tab isn't cleared,
> and new messages don't seem to be appended to it either. I would
> expect the tab to be cleared.
>

Ok. We will fix this issue.

>
> On Thu, Oct 20, 2016 at 9:14 AM, Murtuza Zabuawala
>  wrote:
> > Hi Dave,
> >
> > PFA updated patch for the same.
> >
> > Issue:
> > We were not properly fetching result from server in case of direct
> debugging
> > when we restart debugging of same object.
> >
> > Thanks to Neel for helping in this issue.
> >
> > Please review.
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Fri, Oct 7, 2016 at 5:32 PM, Dave Page  wrote:
> >>
> >> On Fri, Oct 7, 2016 at 12:53 PM, Dave Page  wrote:
> >> > On Fri, Oct 7, 2016 at 12:42 PM, Murtuza Zabuawala
> >> >  wrote:
> >> >> Hi Dave,
> >> >>
> >> >> I faced the same issue when I initially tried that, but then as per
> >> >> Neel
> >> >> suggestion I changed SELECT pg_sleep() to PERFORM pg_sleep() in
> >> >> function.
> >> >> You will face the same in pgAdmin3 if you use select pg_sleep() in
> your
> >> >> function the debug call never returns from DB server.
> >> >
> >> > In which case, doesn't that imply the debugger is missing critical
> >> > debug info? If I run the query in the query tool, I get:
> >> >
> >> > 
> >> > INFO:  EMPNOENAME
> >> > INFO:  ----
> >> > ERROR:  query has no destination for result data
> >> > HINT:  If you want to discard the results of a SELECT, use PERFORM
> >> > instead.
> >> > CONTEXT:  PL/pgSQL function list_emp() line 11 at SQL statement
> >> >
> >> >
> >> > Query returned successfully in 2 secs.
> >> > 
> >> >
> >> > It seems to me that the debugger should be able to give the same
> error.
> >> >
> >> > Regardless of that, I'll test with PERFORM.
> >>
> >> Which I just did - and whilst it seemed to be fine when stepping
> >> through, after a few iterations I hit the continue button, at which
> >> point it froze again on "PERFORM pg_sleep(2)", didn't print any more
> >> of the 14 names in the emp table, and didn't return :-(
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Dave Page]

Hi

On Fri, Oct 21, 2016 at 12:32 PM, Neel Patel
 wrote:
> Hi,
>
>
> On Fri, Oct 21, 2016 at 4:48 PM, Dave Page  wrote:
>>
>> Hi
>>
>> There are still issues I'm afraid:
>>
>> - When execution stops, we seem to keep polling for more results
>> indefinitely.
>
> Do you mean after completion of first successful debugging ?
> If yes, we are polling because user can start same function for debugging
> again and we have to listen for the result set for that session.

Yes (or the second). But shouldn't we stop polling until debugging is restarted?

>>
>>
>> - When executing for a second time, the messages tab isn't cleared,
>> and new messages don't seem to be appended to it either. I would
>> expect the tab to be cleared.
>
>
> Ok. We will fix this issue.
>>
>>
>> On Thu, Oct 20, 2016 at 9:14 AM, Murtuza Zabuawala
>>  wrote:
>> > Hi Dave,
>> >
>> > PFA updated patch for the same.
>> >
>> > Issue:
>> > We were not properly fetching result from server in case of direct
>> > debugging
>> > when we restart debugging of same object.
>> >
>> > Thanks to Neel for helping in this issue.
>> >
>> > Please review.
>> >
>> > --
>> > Regards,
>> > Murtuza Zabuawala
>> > EnterpriseDB: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Fri, Oct 7, 2016 at 5:32 PM, Dave Page  wrote:
>> >>
>> >> On Fri, Oct 7, 2016 at 12:53 PM, Dave Page  wrote:
>> >> > On Fri, Oct 7, 2016 at 12:42 PM, Murtuza Zabuawala
>> >> >  wrote:
>> >> >> Hi Dave,
>> >> >>
>> >> >> I faced the same issue when I initially tried that, but then as per
>> >> >> Neel
>> >> >> suggestion I changed SELECT pg_sleep() to PERFORM pg_sleep() in
>> >> >> function.
>> >> >> You will face the same in pgAdmin3 if you use select pg_sleep() in
>> >> >> your
>> >> >> function the debug call never returns from DB server.
>> >> >
>> >> > In which case, doesn't that imply the debugger is missing critical
>> >> > debug info? If I run the query in the query tool, I get:
>> >> >
>> >> > 
>> >> > INFO:  EMPNOENAME
>> >> > INFO:  ----
>> >> > ERROR:  query has no destination for result data
>> >> > HINT:  If you want to discard the results of a SELECT, use PERFORM
>> >> > instead.
>> >> > CONTEXT:  PL/pgSQL function list_emp() line 11 at SQL statement
>> >> >
>> >> >
>> >> > Query returned successfully in 2 secs.
>> >> > 
>> >> >
>> >> > It seems to me that the debugger should be able to give the same
>> >> > error.
>> >> >
>> >> > Regardless of that, I'll test with PERFORM.
>> >>
>> >> Which I just did - and whilst it seemed to be fine when stepping
>> >> through, after a few iterations I hit the continue button, at which
>> >> point it froze again on "PERFORM pg_sleep(2)", didn't print any more
>> >> of the 14 names in the emp table, and didn't return :-(
>> >>
>> >> --
>> >> Dave Page
>> >> Blog: http://pgsnake.blogspot.com
>> >> Twitter: @pgsnake
>> >>
>> >> EnterpriseDB UK: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Don't allow setting of security labels on edbspl stor

[Dave Page]

Don't allow setting of security labels on edbspl stored procedures (by 
correctly checking the node type). Fixes #1576

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d29ccea2997d2cf6c83aab46acc0871f2bda57b5
Author: Murtuza Zabuawala 

Modified Files
--
.../databases/schemas/functions/templates/function/js/functions.js  | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To display Security Label control properly in procedure node(pgAdmin4)

[Dave Page]

Thanks, applied.

On Thu, Oct 20, 2016 at 10:30 AM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA minor patch to fix the issue where behaviour of security label control
> was different when in CREATE mode & in EDIT mode.
> RM#1576
>
> issue:
> Corrected the condition for node type checking.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1872 - Not able to open the File Manager

[Dave Page]

Thanks, patch applied.

On Thu, Oct 20, 2016 at 10:37 AM, Surinder Kumar
 wrote:
> Hi
>
> Issues fixed:
>
> 1) In Python 3, parameter "cmp" is removed from sorted method. So File
> Manager won't open.
> As we are sorting data on JS side using Natural sort, so on server side
> sorting is not required.
>
> 2) Improvement in Exception handling.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix the file manager when used under Python 3. Fixes

[Dave Page]

Fix the file manager when used under Python 3. Fixes #1872

Issues fixed:

1) In Python 3, parameter "cmp" is removed from sorted method. So File Manager 
won't open.
As we are sorting data on JS side using Natural sort, so on server side sorting 
is not required.

2) Improvement in Exception handling.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d806a9ce9ed269e53c256d747dba46810f78eb87
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/misc/file_manager/__init__.py | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Show security labels in the reverse engineered SQL fo

[Dave Page]

Show security labels in the reverse engineered SQL for domains. Fixes #1574

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=406dab069dfff14591a6ace8e6e36a3243f6fea0
Author: Surinder Kumar 

Modified Files
--
.../server_groups/servers/databases/schemas/domains/__init__.py   | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM 1574 - sql is not displayed in SQL pane for security label in both PG and EPAS/PPAS server

[Dave Page]

Thanks, patch applied.

On Thu, Oct 20, 2016 at 11:39 AM, Surinder Kumar
 wrote:
> Hi,
>
> Code to parse security privileges was missing. So, its sql wasn't displayed.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To fix the issue in Debugger module (pgAdmin4)

[Neel Patel]

Hi,


On Fri, Oct 21, 2016 at 5:03 PM, Dave Page  wrote:

> Hi
>
> On Fri, Oct 21, 2016 at 12:32 PM, Neel Patel
>  wrote:
> > Hi,
> >
> >
> > On Fri, Oct 21, 2016 at 4:48 PM, Dave Page  wrote:
> >>
> >> Hi
> >>
> >> There are still issues I'm afraid:
> >>
> >> - When execution stops, we seem to keep polling for more results
> >> indefinitely.
> >
> > Do you mean after completion of first successful debugging ?
> > If yes, we are polling because user can start same function for debugging
> > again and we have to listen for the result set for that session.
>
> Yes (or the second). But shouldn't we stop polling until debugging is
> restarted?
>

I think yes, that can be done.

>
> >>
> >>
> >> - When executing for a second time, the messages tab isn't cleared,
> >> and new messages don't seem to be appended to it either. I would
> >> expect the tab to be cleared.
> >
> >
> > Ok. We will fix this issue.
> >>
> >>
> >> On Thu, Oct 20, 2016 at 9:14 AM, Murtuza Zabuawala
> >>  wrote:
> >> > Hi Dave,
> >> >
> >> > PFA updated patch for the same.
> >> >
> >> > Issue:
> >> > We were not properly fetching result from server in case of direct
> >> > debugging
> >> > when we restart debugging of same object.
> >> >
> >> > Thanks to Neel for helping in this issue.
> >> >
> >> > Please review.
> >> >
> >> > --
> >> > Regards,
> >> > Murtuza Zabuawala
> >> > EnterpriseDB: http://www.enterprisedb.com
> >> > The Enterprise PostgreSQL Company
> >> >
> >> > On Fri, Oct 7, 2016 at 5:32 PM, Dave Page  wrote:
> >> >>
> >> >> On Fri, Oct 7, 2016 at 12:53 PM, Dave Page 
> wrote:
> >> >> > On Fri, Oct 7, 2016 at 12:42 PM, Murtuza Zabuawala
> >> >> >  wrote:
> >> >> >> Hi Dave,
> >> >> >>
> >> >> >> I faced the same issue when I initially tried that, but then as
> per
> >> >> >> Neel
> >> >> >> suggestion I changed SELECT pg_sleep() to PERFORM pg_sleep() in
> >> >> >> function.
> >> >> >> You will face the same in pgAdmin3 if you use select pg_sleep() in
> >> >> >> your
> >> >> >> function the debug call never returns from DB server.
> >> >> >
> >> >> > In which case, doesn't that imply the debugger is missing critical
> >> >> > debug info? If I run the query in the query tool, I get:
> >> >> >
> >> >> > 
> >> >> > INFO:  EMPNOENAME
> >> >> > INFO:  ----
> >> >> > ERROR:  query has no destination for result data
> >> >> > HINT:  If you want to discard the results of a SELECT, use PERFORM
> >> >> > instead.
> >> >> > CONTEXT:  PL/pgSQL function list_emp() line 11 at SQL statement
> >> >> >
> >> >> >
> >> >> > Query returned successfully in 2 secs.
> >> >> > 
> >> >> >
> >> >> > It seems to me that the debugger should be able to give the same
> >> >> > error.
> >> >> >
> >> >> > Regardless of that, I'll test with PERFORM.
> >> >>
> >> >> Which I just did - and whilst it seemed to be fine when stepping
> >> >> through, after a few iterations I hit the continue button, at which
> >> >> point it froze again on "PERFORM pg_sleep(2)", didn't print any more
> >> >> of the 14 names in the emp table, and didn't return :-(
> >> >>
> >> >> --
> >> >> Dave Page
> >> >> Blog: http://pgsnake.blogspot.com
> >> >> Twitter: @pgsnake
> >> >>
> >> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> >> The Enterprise PostgreSQL Company
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >>
> >> --
> >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> >> To make changes to your subscription:
> >> http://www.postgresql.org/mailpref/pgadmin-hackers
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

[pgadmin-hackers] [pgAdmin4][Patch]: RM1867 - User can not drop package body under properties section

[Surinder Kumar]

Hi

While editing the package properties, if pkg body is empty, It should drop
the package. but it wasn't generating drop package query.

Please find attached patch and review.


Thanks,
Surinder Kumar


RM1867.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure the File Manager honours the file type while t

[Dave Page]

Ensure the File Manager honours the file type while traversing the directories. 
Fixes #1858

When a File Manager is closed by clicking cancel button. Its dom element not 
destroyed.. So on traversing into directories, when it tries to get currently 
selected file type, it looks into the dom element but it gets dom of previous 
dialogs not of currently dialog.

Now whenever an instance of File Manager is closed. its dom elements are also 
destroyed.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1e66119ef58e4d310daaece697e3546ec1380712
Author: Surinder Kumar 

Modified Files
--
.../templates/file_manager/js/file_manager.js  | 28 +-
.../sqleditor/templates/sqleditor/js/sqleditor.js  |  7 ++
2 files changed, 29 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1858 - File Manager does not honour the file type while traversing the directories

[Dave Page]

Thanks, patch applied.

On Thu, Oct 20, 2016 at 1:37 PM, Surinder Kumar
 wrote:
> Hi,
>
> When a File Manager is closed by clicking cancel button. Its dom element not
> destroyed.. So on traversing into directories, when it tries to get
> currently selected file type, it looks into the dom element but it gets dom
> of previous dialogs not of currently dialog.
>
> Now whenever an instance of File Manager is closed. its dom elements are
> also destroyed.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Handle non-ascii responses from the server when conne

[Dave Page]

Handle non-ascii responses from the server when connecting. Fixes #1822

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da3a37ab1974b8c862bba86a45a8463527d21c7c
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/browser/server_groups/servers/__init__.py | 3 +++
1 file changed, 3 insertions(+)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1822 - 'ascii' codec can't decode byte

[Dave Page]

Thanks, patch applied.

On Thu, Oct 20, 2016 at 4:40 PM, Surinder Kumar
 wrote:
> Hi
>
> I am able to reproduce the issue by changing server username to "Суриндер"
> in russian locale.
> Steps:
> 1) Rename server username to "Суриндер" by editing server properties.
> 2) Double click on sever. Enter password in Prompt dialog.
> 3) Click OK. Now It will throw "UnicodeDecode Error".
>
> I have decoded the error message displayed for python2.
>
> Please find attached patch and review.
>
> Thanks
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] PATCH: To raise an error if background job fails to start (pgAdmin4)

[Murtuza Zabuawala]

Hi,

PFA patch to fix the issue where it was not reporting error when it fails
to starts & went into infinite loop recursion of popup when task is deleted
from server(which is a transient issue).
RM#1679

*Note:* There is still TODO in this RM which I have added in code, for
which I'm not able find any resolution meanwhile please review this issue.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_1679.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

[Harshal Dhumal]

Hi,

PFA updated patch for RM1878

Issues fixed:

1. ProgrammingError: can't adapt type 'Undefined' for schedule
2. Fixed malformed array literal issue raised by postgres while creating
schedule
3. Fixed update of schedule.
4. Fixed update of step.
5. disabled sql tab (create sql tab) for step.

-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Oct 21, 2016 at 4:11 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:

> Hi,
>
> Please ignore this patch as I haven't fixed same issue for schedule. Also
> there is issue "malformed array literal" when we try to save schedule.
>
> I'll be sending updated patch.
>
> Thanks Harshal,
>
> --
> *Harshal Dhumal*
> *Software Engineer*
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Oct 21, 2016 at 2:51 PM, Harshal Dhumal <
> harshal.dhu...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA attached patch for pgagent issue RM1878
>>
>> issue fixed: ProgrammingError: can't adapt type 'Undefined'
>>
>> --
>> *Harshal Dhumal*
>> *Software Engineer*
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
diff --git a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py
index 24ea1ba..4dd82e8 100644
--- a/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/pgagent/schedules/__init__.py
@@ -219,8 +219,8 @@ class JobScheduleView(PGChildNodeView):
 res = []
 sql = render_template(
 "/".join([self.template_path, 'nodes.sql']),
-jscid = jscid,
-jid = jid
+jscid=jscid,
+jid=jid
 )
 
 status, result = self.conn.execute_2darray(sql)
@@ -298,13 +298,22 @@ class JobScheduleView(PGChildNodeView):
 jid: Job ID
 """
 data = {}
-for k, v in request.args.items():
-try:
-data[k] = json.loads(
-v.decode('utf-8') if hasattr(v, 'decode') else v
-)
-except ValueError:
-data[k] = v
+if request.args:
+for k, v in request.args.items():
+try:
+data[k] = json.loads(
+v.decode('utf-8') if hasattr(v, 'decode') else v
+)
+except ValueError:
+data[k] = v
+else:
+data = json.loads(request.data.decode())
+# convert python list literal to postgres array literal.
+data['jscminutes'] = data['jscminutes'].replace("[", "{").replace("]", "}")
+data['jschours'] = data['jschours'].replace("[", "{").replace("]", "}")
+data['jscweekdays'] = data['jscweekdays'].replace("[", "{").replace("]", "}")
+data['jscmonthdays'] = data['jscmonthdays'].replace("[", "{").replace("]", "}")
+data['jscmonths'] = data['jscmonths'].replace("[", "{").replace("]", "}")
 
 sql = render_template(
 "/".join([self.template_path, 'create.sql']),
@@ -327,8 +336,8 @@ class JobScheduleView(PGChildNodeView):
 self.conn.execute_void('END')
 sql = render_template(
 "/".join([self.template_path, 'nodes.sql']),
-jscid = res,
-jid = jid
+jscid=res,
+jid=jid
 )
 status, res = self.conn.execute_2darray(sql)
 
@@ -357,17 +366,36 @@ class JobScheduleView(PGChildNodeView):
 jscid: JobSchedule ID
 """
 data = {}
-for k, v in request.args.items():
-try:
-data[k] = json.loads(
-v.decode('utf-8') if hasattr(v, 'decode') else v
-)
-except ValueError:
-data[k] = v
+if request.args:
+for k, v in request.args.items():
+try:
+data[k] = json.loads(
+v.decode('utf-8') if hasattr(v, 'decode') else v
+)
+except ValueError:
+data[k] = v
+else:
+data = json.loads(request.data.decode())
+# convert python list literal to postgres array literal.
+if 'jscminutes' in data:
+data['jscminutes'] = data['jscminutes'].replace("[", "{").replace("]", "}")
+
+if 'jschours' in data:
+data['jschours'] = data['jschours'].replace("[", "{").replace("]", "}")
+
+if 'jscweekdays' in data:
+data['jscweekdays'] = data['jscweekdays'].replace("[", "{").replace("]", "}")
+
+if 'jscmonthdays' in data:
+data['jscmonthdays'] = data['jscmonthdays'].replace("[", "{").replace("]", "}")
+
+if 'jscmonths' i

[pgadmin-hackers] [pgAdmin4][Patch]: RM1837 - FTS directory refresh not working

[Surinder Kumar]

Hi

The schema was supposed to be returned from nodes.sql but it wasn't.
I have verified refresh of other nodes which is working fine.

Please find attached patch and review.

Thanks
Surinder Kumar


RM1837.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Properly quote type names in RE-SQL for tables. Fixes

[Dave Page]

Properly quote type names in RE-SQL for tables. Fixes #1863

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aef508ff910a97bd6eeedd5fcb39a1b924998841
Author: Harshal Dhumal 

Modified Files
--
.../servers/databases/schemas/tables/__init__.py| 13 -
.../servers/databases/schemas/tables/column/__init__.py | 12 +++-
.../foreign_key/templates/foreign_key/js/foreign_key.js |  8 
.../server_groups/servers/databases/schemas/utils.py| 11 +++
4 files changed, 22 insertions(+), 22 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] patch for RM1863 [pgadmin4]

[Dave Page]

Thanks, patch applied.

On Thu, Oct 20, 2016 at 7:07 PM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA patch for RM1863.
>
> Issue fixed: Correctly interpret composite data type for columns while
> generating sql.
> also minor UI improvement in foreign key column tab
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1603 & RM 1220

[Dave Page]

Thanks, patch applied.

On Fri, Oct 21, 2016 at 6:14 AM, Khushboo Vashi
 wrote:
> Hi,
>
> Please find the attached patch to fix below RMs:
>
> 1603:  [Web Based] Export database failed if object contains double quotes
> 1220:  Backup database is not working with special characters
> 1221:  Maintenance DB failed if database name contains special characters
>
> In Desktop mode, the import/export didn't work that is also fixed.
>
> Regarding, re-showing the dialogue multiple times, Murtuza is working on
> this issue,
>
> Murtuza,
> Please also look into this thread, so you can have more idea about the
> related bugs.
>
> Thanks,
> Khushboo
>
>
> On Thu, Oct 20, 2016 at 9:40 PM, Dave Page  wrote:
>>
>> On Thu, Oct 20, 2016 at 12:08 PM, Ashesh Vashi
>>  wrote:
>> > On Thu, Oct 20, 2016 at 4:26 PM, Khushboo Vashi
>> >  wrote:
>> >>
>> >>
>> >>
>> >> On Sat, Oct 15, 2016 at 11:52 AM, Dave Page  wrote:
>> >>>
>> >>>
>> >>>
>> >>> On Friday, October 14, 2016, Ashesh Vashi
>> >>> 
>> >>> wrote:
>> 
>>  On Sat, Oct 15, 2016 at 4:59 AM, Dave Page  wrote:
>> >
>> > Hi
>> >
>> > On Friday, October 14, 2016, Khushboo Vashi
>> >  wrote:
>> >>
>> >> Hi,
>> >>
>> >> Please find the attached patch to fix the below 2 bugs.
>> >>
>> >> RM 1603: [Web Based] Export database failed if object contains
>> >> double
>> >> quotes.
>> >> RM 1220: Backup database is not working with special characters
>> >>
>> >> The issues which were fixed:
>> >>
>> >> 1. Client side data were not unescaped
>> >> 2. Required command line arguments were quoted twice
>> >
>> >
>> > This is not working for me: I tested using Table Export as per
>> > Fahar's
>> > instructions. As I'm in desktop mode, the first problem was that we
>> > get an
>> > error at line 210 of import_export/__init__.py, because
>> > get_server_directory
>> > returned None for the directory. If I fix that, then the job says
>> > it's
>> > created, but as far as I can see, nothing else happens.
>> 
>>  hmm..
>> >>>
>> >>>
>> >>> Yes, but please see my followup message. There's clearly something
>> >>> funky
>> >>> going on with the process tracking - for whatever reason it didn't
>> >>> pick up
>> >>> this process until after a restart, and per the bug I escalated
>> >>> earlier
>> >>> (which I think is essential to fix for 1.1 in a little over a week),
>> >>> it
>> >>> doesn't always detect completed processes and then keeps re-showing
>> >>> the
>> >>> alert.
>> >>>
>> >>
>> >>
>> >> The problem here is that, until we click the "Click for details here"
>> >> link
>> >> and close the another details dialogue, the acknowledgement does not
>> >> send to
>> >> the server. So, it keeps re-showing the alert.
>> >>
>> >> I think, we need to clearly mention the steps on the alertify notifier
>> >> itself, so the user can get the idea.
>> >>
>> >> Dave/Ashesh,
>> >> Any other suggestion?
>> >
>> > We can give a acknowledge link along with 'Click here for details' link
>> > to
>> > delete the status, logs, when clicked.
>> > Dave?
>>
>> Sure, we can do that - but with so many instances being reported,
>> clearly there's a root cause to fix first.
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix quoting of objects names for external utilities.

[Dave Page]

Fix quoting of objects names for external utilities. Fixes #1603, fixes #1220, 
fixes #1221

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a1795e4a0c0c97ebfcc30b207d69a7f142cf169
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/tools/backup/__init__.py   |  6 +++---
web/pgadmin/tools/backup/templates/backup/js/backup.js |  6 +++---
web/pgadmin/tools/import_export/__init__.py|  8 +---
.../templates/import_export/js/import_export.js|  6 +++---
web/pgadmin/tools/maintenance/__init__.py  |  2 +-
.../maintenance/templates/maintenance/js/maintenance.js| 12 ++--
web/pgadmin/tools/restore/templates/restore/js/restore.js  | 14 +++---
7 files changed, 28 insertions(+), 26 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] patch for RM1875 exclusion constraint support for pg-9.6 [pgAdmin4]

[Harshal Dhumal]

Hi,

PFA patch for RM1875.

Issue fixed:
1. Exclusion constraint added support for pg-9.6
2. Fixed index out of list (python error) when Exclusion constraint is
created without name.


-- 
*Harshal Dhumal*
*Software Engineer*

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
index b8af0cd..9868280 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/__init__.py
@@ -290,7 +290,11 @@ class TableView(PGChildNodeView, DataTypeReader, VacuumSettings):
 self.template_path = 'table/sql/9.1_plus'
 
 # Template for Column ,check constraint and exclusion constraint node
-if ver >= 90200:
+if ver >= 90600:
+self.column_template_path = 'column/sql/9.2_plus'
+self.check_constraint_template_path = 'check_constraint/sql/9.2_plus'
+self.exclusion_constraint_template_path = 'exclusion_constraint/sql/9.6_plus'
+elif ver >= 90200:
 self.column_template_path = 'column/sql/9.2_plus'
 self.check_constraint_template_path = 'check_constraint/sql/9.2_plus'
 self.exclusion_constraint_template_path = 'exclusion_constraint/sql/9.2_plus'
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/__init__.py
index 6bc0bb0..495064c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/__init__.py
@@ -217,7 +217,9 @@ class ExclusionConstraintView(PGChildNodeView):
 self.conn = self.manager.connection(did=kwargs['did'])
 
 ver = self.manager.version
-if ver >= 90200:
+if ver >= 90600:
+self.template_path = 'exclusion_constraint/sql/9.6_plus'
+elif ver >= 90200:
 self.template_path = 'exclusion_constraint/sql/9.2_plus'
 elif ver >= 90100:
 self.template_path = 'exclusion_constraint/sql/9.1_plus'
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/templates/exclusion_constraint/js/exclusion_constraint.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/templates/exclusion_constraint/js/exclusion_constraint.js
index 96c181e..9250d9f 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/templates/exclusion_constraint/js/exclusion_constraint.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/constraints/exclusion_constraint/templates/exclusion_constraint/js/exclusion_constraint.js
@@ -700,8 +700,14 @@ function($, _, S, pgAdmin, pgBrowser, Alertify) {
   if (column_collection.length > 0 && current_am != previous_am) {
 var msg = '{{ _('Changing access method will clear columns collection') }}';
 Alertify.confirm(msg, function (e) {
-// User clicks Ok, lets clear collection
-column_collection.reset();
+// User clicks Ok, lets clear collection.
+column_collection.each(function(m) {
+  /*
+   * Our datamodel do not support collection reset method.
+   * So remove model one by one.
+   */
+  column_collection.remove(m);
+});
 setTimeout(function() {
   column_collection.trigger('pgadmin:columns:updated', column_collection);
 }, 10);
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/exclusion_constraint/sql/9.1_plus/get_oid_with_transaction.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/exclusion_constraint/sql/9.1_plus/get_oid_with_transaction.sql
index abe636a..0fc1fa8 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/exclusion_constraint/sql/9.1_plus/get_oid_with_transaction.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/exclusion_constraint/sql/9.1_plus/get_oid_with_transaction.sql
@@ -2,5 +2,5 @@ SELECT ct.oid,
 ct.conname as name,
 NOT convalidated as convalidated
 FROM pg_constraint ct
-WHERE contype='f' AND
+WHERE contype='x' AND
 conrelid = {{tid}}::oid LIMIT

[pgadmin-hackers] pgAdmin 4 commit: Ensure preferences values are stored properly. Fixes

[Dave Page]

Ensure preferences values are stored properly. Fixes #1877

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a97d21cc907f32930d7e91c31a943eec83243493
Author: Khushboo Vashi 

Modified Files
--
web/pgadmin/preferences/templates/preferences/preferences.js | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed RM 1887

[Dave Page]

Thanks, applied.

On Fri, Oct 21, 2016 at 8:35 AM, Khushboo Vashi
 wrote:
> Hi,
>
> Please find the patch to fix RM 1887: Preferences values ate not stored
> properly.
>
> Thanks,
> Khushboo
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1867 - User can not drop package body under properties section

[Dave Page]

Thanks, applied.

On Fri, Oct 21, 2016 at 2:18 PM, Surinder Kumar
 wrote:
> Hi
>
> While editing the package properties, if pkg body is empty, It should drop
> the package. but it wasn't generating drop package query.
>
> Please find attached patch and review.
>
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Allow package bodies to be dropped. Fixes #1867

[Dave Page]

Allow package bodies to be dropped. Fixes #1867

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e9108e0f356e7f510dd7fac7a2953b5e1bde235
Author: Surinder Kumar 

Modified Files
--
.../schemas/packages/templates/package/ppas/9.1_plus/update.sql | 2 +-
.../schemas/packages/templates/package/ppas/9.2_plus/update.sql | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure we handle external processes that fail to star

[Dave Page]

Ensure we handle external processes that fail to start. Fixes #1679

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6d018c44f73bcf54644a8341065fbc282792205
Author: Murtuza Zabuawala 

Modified Files
--
web/pgadmin/misc/bgprocess/processes.py   | 14 +++---
web/pgadmin/misc/bgprocess/static/js/bgprocess.js |  5 +++--
2 files changed, 14 insertions(+), 5 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] PATCH: To raise an error if background job fails to start (pgAdmin4)

[Dave Page]

On Fri, Oct 21, 2016 at 2:40 PM, Murtuza Zabuawala
 wrote:
> Hi,
>
> PFA patch to fix the issue where it was not reporting error when it fails to
> starts & went into infinite loop recursion of popup when task is deleted
> from server(which is a transient issue).
> RM#1679

Thanks, applied.

> Note: There is still TODO in this RM which I have added in code, for which
> I'm not able find any resolution meanwhile please review this issue.

Yeah, I'm not entirely sure how to deal with that either.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

[Surinder Kumar]

​I missed to add the check "destroy only if select2 has destroy property'.
in previous patch.
It was reproducible when I select access method of exclusion constraint
from combo box.

Please find attached patch and review.

On Sat, Oct 15, 2016 at 12:50 AM, Dave Page  wrote:

> Thanks, applied.
>
>
> On Friday, October 14, 2016, Surinder Kumar  com> wrote:
>
>> Hi
>>
>> While clicking on Select2 control, it tries to destroy the control and
>> thus it doesn't get this object sometimes and throws error.
>>
>> It should attempt to destroy the select2 object only if this object is
>> not undefined.
>> Adds proper check to handle the case.
>>
>> Please find minor patch and review.
>>
>> Thanks
>> Surinder Kumar
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>


select2_control_destroy_issue_v2.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure steps and schedules can be created in empty jo

[Dave Page]

Ensure steps and schedules can be created in empty jobs. Fixes #1878

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef0d26c29459ef9bd168e249d4578f325e8403f2

Modified Files
--
.../servers/pgagent/schedules/__init__.py  | 68 +++---
.../templates/pga_schedule/js/pga_schedule.js  |  2 +-
.../servers/pgagent/steps/__init__.py  | 29 -
.../pgagent/templates/macros/pga_schedule.macros   |  2 +-
.../templates/pga_schedule/sql/pre3.4/create.sql   |  8 ---
5 files changed, 66 insertions(+), 43 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] Patch for pgagent RM1878 [pgAgent]

[Dave Page]

Thanks - applied, with one change to *enable* the SQL tabs everywhere.

On Fri, Oct 21, 2016 at 2:41 PM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA updated patch for RM1878
>
> Issues fixed:
>
> 1. ProgrammingError: can't adapt type 'Undefined' for schedule
> 2. Fixed malformed array literal issue raised by postgres while creating
> schedule
> 3. Fixed update of schedule.
> 4. Fixed update of step.
> 5. disabled sql tab (create sql tab) for step.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Fri, Oct 21, 2016 at 4:11 PM, Harshal Dhumal
>  wrote:
>>
>> Hi,
>>
>> Please ignore this patch as I haven't fixed same issue for schedule. Also
>> there is issue "malformed array literal" when we try to save schedule.
>>
>> I'll be sending updated patch.
>>
>> Thanks Harshal,
>>
>> --
>> Harshal Dhumal
>> Software Engineer
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Fri, Oct 21, 2016 at 2:51 PM, Harshal Dhumal
>>  wrote:
>>>
>>> Hi,
>>>
>>> PFA attached patch for pgagent issue RM1878
>>>
>>> issue fixed: ProgrammingError: can't adapt type 'Undefined'
>>>
>>> --
>>> Harshal Dhumal
>>> Software Engineer
>>>
>>> EnterpriseDB India: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1837 - FTS directory refresh not working

[Dave Page]

Thanks, patch applied.

On Fri, Oct 21, 2016 at 2:41 PM, Surinder Kumar
 wrote:
> Hi
>
> The schema was supposed to be returned from nodes.sql but it wasn't.
> I have verified refresh of other nodes which is working fine.
>
> Please find attached patch and review.
>
> Thanks
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix refreshing of FTS Dictionaries. Fixes #1837

[Dave Page]

Fix refreshing of FTS Dictionaries. Fixes #1837

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=23a0fc2f223943b574272d7c976c8897e4da7a84
Author: Surinder Kumar 

Modified Files
--
.../fts_dictionaries/templates/fts_dictionary/sql/9.1_plus/nodes.sql   | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Fix exclusion constraint support on 9.6. Fixes #1875

[Dave Page]

Fix exclusion constraint support on 9.6. Fixes #1875

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2952faab5edcaf8dd75870fcab08f41af637ff88
Author: Harshal Dhumal 

Modified Files
--
.../servers/databases/schemas/tables/__init__.py   |  6 -
.../constraints/exclusion_constraint/__init__.py   |  4 ++-
.../js/exclusion_constraint.js | 10 ++--
.../sql/9.1_plus/get_oid_with_transaction.sql  |  2 +-
.../sql/9.2_plus/get_oid_with_transaction.sql  |  2 +-
.../exclusion_constraint/sql/9.6_plus/begin.sql|  1 +
.../exclusion_constraint/sql/9.6_plus/create.sql   | 17 
.../exclusion_constraint/sql/9.6_plus/delete.sql   |  3 +++
.../exclusion_constraint/sql/9.6_plus/end.sql  |  1 +
.../sql/9.6_plus/get_access_methods.sql|  6 +
.../sql/9.6_plus/get_constraint_cols.sql   | 22 
.../exclusion_constraint/sql/9.6_plus/get_name.sql |  3 +++
.../exclusion_constraint/sql/9.6_plus/get_oid.sql  |  4 +++
.../sql/9.6_plus/get_oid_with_transaction.sql  |  6 +
.../sql/9.6_plus/get_oper_class.sql|  7 +
.../sql/9.6_plus/get_operator.sql  | 30 ++
.../sql/9.6_plus/get_parent.sql|  7 +
.../exclusion_constraint/sql/9.6_plus/nodes.sql|  7 +
.../sql/9.6_plus/properties.sql| 30 ++
.../exclusion_constraint/sql/9.6_plus/stats.sql| 28 
.../exclusion_constraint/sql/9.6_plus/update.sql   | 22 
21 files changed, 212 insertions(+), 6 deletions(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] patch for RM1875 exclusion constraint support for pg-9.6 [pgAdmin4]

[Dave Page]

Thanks, applied.

On Fri, Oct 21, 2016 at 3:06 PM, Harshal Dhumal
 wrote:
> Hi,
>
> PFA patch for RM1875.
>
> Issue fixed:
> 1. Exclusion constraint added support for pg-9.6
> 2. Fixed index out of list (python error) when Exclusion constraint is
> created without name.
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

[pgadmin-hackers] pgAdmin 4 commit: Ensure select2 instances have a destroy property befo

[Dave Page]

Ensure select2 instances have a destroy property before calling destroy.

Branch
--
master

Details
---
http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19bd021696247cf895488bef61535f5b2b9444a6
Author: Surinder Kumar 

Modified Files
--
web/pgadmin/static/js/backform.pgadmin.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: Select2 control destroy issue [Minor fix]

[Dave Page]

Thanks, applied.

On Fri, Oct 21, 2016 at 3:55 PM, Surinder Kumar
 wrote:
> I missed to add the check "destroy only if select2 has destroy property'. in
> previous patch.
> It was reproducible when I select access method of exclusion constraint from
> combo box.
>
> Please find attached patch and review.
>
> On Sat, Oct 15, 2016 at 12:50 AM, Dave Page  wrote:
>>
>> Thanks, applied.
>>
>>
>> On Friday, October 14, 2016, Surinder Kumar
>>  wrote:
>>>
>>> Hi
>>>
>>> While clicking on Select2 control, it tries to destroy the control and
>>> thus it doesn't get this object sometimes and throws error.
>>>
>>> It should attempt to destroy the select2 object only if this object is
>>> not undefined.
>>> Adds proper check to handle the case.
>>>
>>> Please find minor patch and review.
>>>
>>> Thanks
>>> Surinder Kumar
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>



-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

[Surinder Kumar]

Hi

This fix is for exclusion constraint.
The options like "order" and "nulls" must be conditional. i.e. include only
when access method type is other than "gist".

Please find attached patch and review.

On Fri, Oct 21, 2016 at 4:38 PM, Dave Page  wrote:

> Thanks, applied.
>
> On Thu, Oct 20, 2016 at 7:47 AM, Surinder Kumar
>  wrote:
> > Hi,
> >
> > The options like "sort" and "nulls" must be conditional. i.e. include
> only
> > when access method type is other than "gist" or "gin".
> >
> > Please find attached patch and review.
> >
> > Thanks,
> > Surinder Kumar
> >
> >
> >
> > --
> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>


RM1840_same_fix_for_exclusion_constraint.patch
Description: Binary data

-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

[Dave Page]

Hi

On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
 wrote:
> Hi
>
> This fix is for exclusion constraint.
> The options like "order" and "nulls" must be conditional. i.e. include only
> when access method type is other than "gist".

When creating an index, the asc/desc options are disabled if gist/gin
used. I think they also should be here.

Also, what about gin indexes in this case?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

[Surinder Kumar]

On Fri, Oct 21, 2016 at 8:52 PM, Dave Page  wrote:

> Hi
>
> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
>  wrote:
> > Hi
> >
> > This fix is for exclusion constraint.
> > The options like "order" and "nulls" must be conditional. i.e. include
> only
> > when access method type is other than "gist".
>
> When creating an index, the asc/desc options are disabled if gist/gin
> used. I think they also should be here.
>
> Also, what about gin indexes in this case?
>
​As per documentation
,
​
*The access method must support amgettuple (see Chapter 52
); at present this
means GIN cannot be used*

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM1840 - cannot create gist index due to enforced ASC, DESC options in generated SQL

[Dave Page]

On Fri, Oct 21, 2016 at 4:42 PM, Surinder Kumar
 wrote:
> On Fri, Oct 21, 2016 at 8:52 PM, Dave Page  wrote:
>>
>> Hi
>>
>> On Fri, Oct 21, 2016 at 4:16 PM, Surinder Kumar
>>  wrote:
>> > Hi
>> >
>> > This fix is for exclusion constraint.
>> > The options like "order" and "nulls" must be conditional. i.e. include
>> > only
>> > when access method type is other than "gist".
>>
>> When creating an index, the asc/desc options are disabled if gist/gin
>> used. I think they also should be here.
>>
>> Also, what about gin indexes in this case?
>
> As per documentation,
> The access method must support amgettuple (see Chapter 52); at present this
> means GIN cannot be used

OK, but this patch (unlike the last one) only seems to check for gist.

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers