[pgadmin-hackers] pgAdmin 4 commit: Correct node labels in Preferences for EDB functions
Correct node labels in Preferences for EDB functions and procedures. Fixes #2126 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cbaad81f00167c715048f55428e7d7915db9314e Author: Surinder Kumar Modified Files -- .../schemas/packages/edbfuncs/__init__.py | 33 ++ 1 file changed, 33 insertions(+) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixes RM2126 - Duplicate values displayed for functions and procedures in Preferences
Thanks, patch applied. On Fri, Feb 10, 2017 at 9:33 AM, Surinder Kumar wrote: > Hi > > Issue: The function and procedure nodes displayed under schema nodes and > packages node, so both were sharing same name. > > Solution: > Overrides the register_preferences method for EdbFuncModule and > EdbProcModule class and update their labels. > > Please find attached patch and review. > > Thanks > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Fix exclusion constraint reverse engineered SQL. Fixe
Fix exclusion constraint reverse engineered SQL. Fixes #2115 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=833629d438d22390e12a77b135ba09684810a82d Author: Surinder Kumar Modified Files -- .../schemas/tables/templates/table/sql/macros/constraints.macro | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][Patch]: RM2115 - Wrong SQL displayed for exclusion constraints with gist method
Thanks, patch applied. On Fri, Feb 10, 2017 at 1:51 PM, Surinder Kumar wrote: > Hi > > The Macro template was referring to the old code that's why it generates > wrong sql. > Now the changes made in RM1840 are incorporated into macro template as well. > > Please find attached patch. > > Thanks > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Various encoding fixes. Fixes #2160
Various encoding fixes. Fixes #2160 Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ad1316990cf54da665546ad2dff367557b98262 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/__init__.py | 12 +--- web/pgadmin/about/__init__.py | 9 +++-- .../browser/server_groups/servers/__init__.py | 5 +++-- web/pgadmin/misc/file_manager/__init__.py | 6 +++--- web/pgadmin/utils/crypto.py | 21 - web/pgadmin/utils/driver/psycopg2/__init__.py | 11 +++ 6 files changed, 45 insertions(+), 19 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [pgAdmin4][PATCH] Handling of non-ascii with Python2.7
Thanks, patch applied. On Mon, Feb 13, 2017 at 6:42 AM, Murtuza Zabuawala wrote: > Hi, > > PFA patch to fix the issue where user enters non ascii username/password > (invalid credentials) while creating new server and it throws error. > RM#2160 > > This patch also includes some other minor fixes for the same issue in some > other files where we are passing error to gettext() if it includes non ascii > words then it breaks in Python2.7. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers][patch] Fixes QT build when not signing
Thanks - patch applied with minor tweaks to make it fail much earlier if framework.conf isn't present, and to update to current versions of Python/Qt. On Tue, Feb 14, 2017 at 3:18 PM, Atira Odhner wrote: > Sure, sounds good. We accidentally had a stray chmod hanging out, which we > removed. We also made it exit if the framework.conf is missing. We opted in > that direction over the auto-using framework.conf.in because we feel like it > is likely that developers will need to set these values to get the build to > work, so failing will make it more obvious where versions need to be set to > line up with their systems. > Here is an updated patch. > > Tira, Sarah & George > > On Tue, Feb 14, 2017 at 5:30 AM, Dave Page wrote: >> >> Hi >> >> On Mon, Feb 13, 2017 at 7:41 PM, George Gelashvili >> wrote: >> > Hello Hackers! >> > >> > We were building the QT app locally with QTDIR, PGDIR, PYTHON_HOME, and >> > PYTHON_VERSION set, and by running: >> > make appbundle >> > >> > We were seeing the runtime error: >> >> >> >> Could not find QtWebEngineProcess >> >> Abort trap: 6 >> > >> > after a successful python server start. >> > >> > We found that the setup before signing in codesign-bundle.sh was >> > necessary >> > to resolve this, whether or not one is planning on signing the app or >> > dmg. >> > The fix requires setting variables appropriately in >> > mac/pkg/framework.conf >> > >> > We've attached a patch with our changes. >> >> I'm seeing the following in the output: >> >> App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin >> 4.app >> usage: chmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a [i][# [ n]]] >> mode|entry file ... >> chmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ... >> Reorganising the framework structure >> >> I wonder if there's any point in building if framework.conf isn't >> present? It clearly doesn't work, so we should probably just exit if >> it's not there (or attempt to run using the default values in >> framework.conf.in. >> >> Thoughts? >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> -- >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >> To make changes to your subscription: >> http://www.postgresql.org/mailpref/pgadmin-hackers > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Ensure the Mac Appbundle builds correctly both with a
Ensure the Mac Appbundle builds correctly both with and without code signing. Correct current versions of Python/Qt while we're passing. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e3041f1113ef492d5c08b241b2fb162d47d5abb1 Author: Atira Odhner Modified Files -- .gitignore | 2 ++ README | 6 pkg/mac/build.sh| 22 +++--- pkg/mac/codesign-bundle.sh | 55 --- pkg/mac/codesign.conf.in| 10 --- pkg/mac/complete-bundle.sh | 1 + pkg/mac/framework-config.sh | 71 + pkg/mac/framework.conf.in | 10 +++ 8 files changed, 108 insertions(+), 69 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Qt 5.8 seems to generate an additional header we shou
Qt 5.8 seems to generate an additional header we should ignore. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9ddd64a8b84b4c00cdb76ccfb99b6d6a2273edf Modified Files -- runtime/.gitignore | 1 + 1 file changed, 1 insertion(+) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Add a makefile target to run the regression tests.
Add a makefile target to run the regression tests. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05d2373c9a5373e051fe983607a5bad1682dd97a Modified Files -- Makefile | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Tidy up the regression test output a little.
Tidy up the regression test output a little. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03f292ce5143a64e76e1c335d800753bee7f888d Modified Files -- .../schemas/fts_configurations/tests/test_fts_configuration_get.py | 3 +-- .../schemas/fts_dictionaries/tests/test_fts_dictionaries_add.py | 2 +- .../schemas/fts_dictionaries/tests/test_fts_dictionaries_get.py | 2 +- .../schemas/fts_dictionaries/tests/test_fts_dictionaries_put.py | 3 +-- .../databases/schemas/fts_parser/tests/test_fts_parser_add.py | 2 +- .../databases/schemas/fts_parser/tests/test_fts_parser_delete.py| 5 + .../databases/schemas/fts_parser/tests/test_fts_parser_get.py | 2 +- .../databases/schemas/fts_parser/tests/test_fts_parser_put.py | 5 + .../schemas/tables/templates/table/sql/tests/test_tables_node.py| 6 +- 9 files changed, 9 insertions(+), 21 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers][patch] Fixes QT build when not signing
Thanks! On Thu, Feb 16, 2017, 6:26 AM Dave Page wrote: > Thanks - patch applied with minor tweaks to make it fail much earlier > if framework.conf isn't present, and to update to current versions of > Python/Qt. > > On Tue, Feb 14, 2017 at 3:18 PM, Atira Odhner wrote: > > Sure, sounds good. We accidentally had a stray chmod hanging out, which > we > > removed. We also made it exit if the framework.conf is missing. We opted > in > > that direction over the auto-using framework.conf.in because we feel > like it > > is likely that developers will need to set these values to get the build > to > > work, so failing will make it more obvious where versions need to be set > to > > line up with their systems. > > Here is an updated patch. > > > > Tira, Sarah & George > > > > On Tue, Feb 14, 2017 at 5:30 AM, Dave Page wrote: > >> > >> Hi > >> > >> On Mon, Feb 13, 2017 at 7:41 PM, George Gelashvili > >> wrote: > >> > Hello Hackers! > >> > > >> > We were building the QT app locally with QTDIR, PGDIR, PYTHON_HOME, > and > >> > PYTHON_VERSION set, and by running: > >> > make appbundle > >> > > >> > We were seeing the runtime error: > >> >> > >> >> Could not find QtWebEngineProcess > >> >> Abort trap: 6 > >> > > >> > after a successful python server start. > >> > > >> > We found that the setup before signing in codesign-bundle.sh was > >> > necessary > >> > to resolve this, whether or not one is planning on signing the app or > >> > dmg. > >> > The fix requires setting variables appropriately in > >> > mac/pkg/framework.conf > >> > > >> > We've attached a patch with our changes. > >> > >> I'm seeing the following in the output: > >> > >> App completed: /Users/dpage/git/pgadmin4/pkg/mac/../../mac-build/pgAdmin > >> 4.app > >> usage: chmod [-fhv] [-R [-H | -L | -P]] [-a | +a | =a [i][# [ n]]] > >> mode|entry file ... > >> chmod [-fhv] [-R [-H | -L | -P]] [-E | -C | -N | -i | -I] file ... > >> Reorganising the framework structure > >> > >> I wonder if there's any point in building if framework.conf isn't > >> present? It clearly doesn't work, so we should probably just exit if > >> it's not there (or attempt to run using the default values in > >> framework.conf.in. > >> > >> Thoughts? > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > >> > >> > >> -- > >> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > >> To make changes to your subscription: > >> http://www.postgresql.org/mailpref/pgadmin-hackers > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
Re: [pgadmin-hackers] connection error
nd here's a patch
On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili
wrote:
> Hi Hackers!
>
> Our tests found a bug with the current version of master, that was
> introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
> It is throwing an error when the server starts up and returns an error
> message of None, and thereby breaking the happy path. There is a function
> ('create' around line 587) in servers/__init__.py that checks against the
> attribute 'decode', which the server doesn't have when there isn't an error
> message.
>
> George & Sarah
>
0001-Fixes-bug-with-connecting-to-server.patch
Description: Binary data
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] connection error
Thanks, applied.
On Thu, Feb 16, 2017 at 4:31 PM, George Gelashvili
wrote:
> nd here's a patch
>
> On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili
> wrote:
>>
>> Hi Hackers!
>>
>> Our tests found a bug with the current version of master, that was
>> introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
>> It is throwing an error when the server starts up and returns an error
>> message of None, and thereby breaking the happy path. There is a function
>> ('create' around line 587) in servers/__init__.py that checks against the
>> attribute 'decode', which the server doesn't have when there isn't an error
>> message.
>>
>> George & Sarah
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Don't try to decode connection error strings that are
Don't try to decode connection error strings that are null. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03a161cc0a48f5dbc0d76c7e2a5a75373c292b30 Author: George Gelashvili Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] Results screen/Data output work
All, I was looking at the mailing list this morning and realized that we had been remiss in discussing what we (Pivotal) are working on. The primary chunk of work we are doing it to get The data output window to behave similarly to how it behaves in pgAdmin3. Specifically we want users to be able to drag highlight copy and paste, or select a cell and use key board shortcuts to expand or shrink what is selected. This work should be coming in as a few patches or patch sets. 1. enable the ability to select columns in the query output 2. enable drag and select in the query output 3. Output selection modified by Shift+direction keyboard shortcuts - This increases or decreases the area selected by one unit 4. Output selection modified by cmd-Shift+direction keyboard shortcuts - This increases or decreases the area selected to the end of the array When we get to the point of having a technical approach we will update the mailing list to discuss. -- Rob
