[pgadmin-hackers] Thoughts on allowing PGAdmin4 config file override
Is anyone working on allowing config file override for the defaults listed in the config.py file for PGAdmin4? I know it's stated that it's recommended to run a "proper" wsgi server behind this, however if I need to change the bind address or logging it's kind of weird changing the config params in the lib. Thoughts?
Re: [pgadmin-hackers] Thoughts on allowing PGAdmin4 config file override
On Wed, Apr 12, 2017 at 8:14 PM, Clifford Richardson wrote: > Is anyone working on allowing config file override for the defaults listed > in the config.py file for PGAdmin4? > > I know it's stated that it's recommended to run a "proper" wsgi server > behind this, however if I need to change the bind address or logging it's > kind of weird changing the config params in the lib. > > Thoughts? Umm, you've never needed to edit config.py. Config options should be overridden in config_local.py (intended for end users), or config_distro.py (intended for packagers): https://www.pgadmin.org/docs4/1.x/server_deployment.html#configuration -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin 4 commit: Tag REL-1_4 has been created.
Tag REL-1_4 has been created. View: http://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-1_4 Log Message --- Tag 1.4 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin website commit: Release 1.4. Restructure FTP site at the same t
Release 1.4. Restructure FTP site at the same time to get rid of legacy paths that make little sense now. Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=92be1b882a4f2f55ef183fe5474d2eeb9b413613 Modified Files -- download/macos.php| 26 +- download/macos4.php | 9 + download/pip4.php | 9 + download/source.php | 28 ++-- download/source4.php | 10 ++ download/windows.php | 26 +- download/windows4.php | 9 + index.php | 8 +++- 8 files changed, 68 insertions(+), 57 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin website commit: Correct pgAgent URL
Correct pgAgent URL Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=839a90070963221e4cf7ae5cfdd91de2ae5b06f5 Modified Files -- download/pgagent.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] pgAdmin website commit: Bump available version
Bump available version Branch -- master Details --- http://git.postgresql.org/gitweb?p=pgadmin-www.git;a=commitdiff;h=13e6624154124e9fd41a15b4e8796a77e6c05cf9 Modified Files -- versions.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers
Re: [pgadmin-hackers] [Design Update] Visual design of query editor and results table
> > Is that a new shade of gray? How many do we have now? It looks to me like >>> it's starting to get messy, with too many different variations of gray plus >>> the light blues used for the codemirror gutter and alternate rows in the >>> grid. >>> >> >> Yes, it is a darker shade of gray. Are you concerned with the number of >> variations on gray, or that the grays are not used appropriately? >> > > Both really. > The shade of gray, I think, doesn't really matter that much and remaining consistent within the app is fine as long as there is sufficient contrast. The use of gray is intentional. The idea being that the eye should be drawn only to the area the user is actively working on. In the picture the area of focus is the query text editor and the blue bar above it actually draws the eye there. After the user decides they need to inspect the results adding blue there makes those results pop. Let me state what I think your concerns are: 1. The application is becoming too monochromatic and washed out 2. the application is becoming too 'flat' I think we agree that both of these things could be problematic, my guess is where we don't agree is on the line. Here are the assumptions we are designing to: - users are going to be on the application for multiple hours per day - a softer aesthetic makes it easier on the eyes for long term use. - color is important to make the product appealing - use of color should be intentional and done to change the users focus. To my knowledge we haven't don't anything to make the application more or less flat. -- Rob
Re: [pgadmin-hackers] [pgAdmin4][Patch]: Fixed 2190 - Move language selection to Preferences.
Hi,
Please find the attached updated patch.
Thanks,
Khushboo
On Sat, Apr 1, 2017 at 12:12 PM, Dave Page wrote:
> Hi
>
>
> On Friday, March 31, 2017, Khushboo Vashi
> wrote:
>
>> Hi,
>>
>> On Mon, Mar 27, 2017 at 9:57 PM, Dave Page wrote:
>>
>>> On Mon, Mar 27, 2017 at 7:49 AM, Khushboo Vashi
>>> wrote:
>>> > Hi Dave,
>>> >
>>> > I have fixed the issue and the patch for the same is attached, but the
>>> > Binary path options are not translated properly.
>>>
>>> Thanks - committed.
>>>
>>> > We register the preferences before the first request of the app. In
>>> this
>>> > case we don't have any language loaded, so it will take only English.
>>> > To fix this issue, I had explicitly added gettext for the labels and
>>> help
>>> > messages while opening the Preference dialogue.
>>> > All the labels and help messages render properly except Binary paths;
>>> as at
>>> > run time we don't get the translation of 'EDB Advanced Server Binary
>>> Path'.
>>> > We have translations like below:
>>> >
>>> > #: pgadmin/browser/server_groups/servers/types.py:59
>>> > msgid "{0} Binary Path"
>>> > msgstr "Ścieżka Binarna {0}"
>>> >
>>> > So, in this case my suggestion is to have the entire label/help
>>> messages
>>> > translations.
>>> > So, that the Preference dialogue can translate run time.
>>>
>>> I'm fine with that; however, the strings should come from the
>>> underlying drivers of course, as only they should have specific
>>> knowledge of details such as the name of the database server they
>>> provide access to.
>>>
>>> The string always comes from drivers as they are being registered from
>> there.
>> I have attached the patch to translate the entire string.
>> I took the reference of the string from the messages.po file and
>> translated, so someone has to validate that this is the correct translation.
>>
>
> All I see in the patch is updates to the message catalog. It seems to me
> there should be chunks in there to push the entire string back into the
> relevant driver, otherwise the changes to the messages.po files will be
> overwritten the next time I do an extract/merge.
>
> Essentially, I think we need to add properties to the drivers, such as:
>
> BIN_PATH_LABEL = _("PostgreSQL Binary Path")
> BIN_PATH_HELP = _("Path to the directory containing the PostgreSQL utility
> programs (pg_dump, pg_restore etc).")
>
> Then in types.py, we'd have something like:
>
> st.utility_path = paths.register(
> 'bin_paths', st.stype + '_bin_dir',
> st.BIN_PATH_LABEL,
> 'text', default_path, category_label=_('Binary paths'),
> help_str=st.BIN_PATH_HELP
> )
> )
>
> Fixed
> Thanks.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
diff --git a/web/pgadmin/browser/server_groups/servers/ppas.py b/web/pgadmin/browser/server_groups/servers/ppas.py
index fe58d12..56f9322 100644
--- a/web/pgadmin/browser/server_groups/servers/ppas.py
+++ b/web/pgadmin/browser/server_groups/servers/ppas.py
@@ -12,6 +12,12 @@ from pgadmin.browser.server_groups.servers.types import ServerType
class PPAS(ServerType):
+UTILITY_PATH_LABEL = gettext("EDB Advanced Server Binary Path")
+UTILITY_PATH_HELP = gettext(
+"Path to the directory containing the EDB Advanced Server utility"
+" programs (pg_dump, pg_restore etc)."
+)
+
def instanceOf(self, ver):
return ver.startswith("EnterpriseDB")
diff --git a/web/pgadmin/browser/server_groups/servers/types.py b/web/pgadmin/browser/server_groups/servers/types.py
index 7f73263..b85fd3a 100644
--- a/web/pgadmin/browser/server_groups/servers/types.py
+++ b/web/pgadmin/browser/server_groups/servers/types.py
@@ -25,6 +25,11 @@ class ServerType(object):
identification based on the version.
"""
registry = dict()
+UTILITY_PATH_LABEL = _("PostgreSQL Binary Path")
+UTILITY_PATH_HELP = _(
+"Path to the directory containing the PostgreSQL utility programs"
+" (pg_dump, pg_restore etc)."
+)
def __init__(self, server_type, description, priority):
self.stype = server_type
@@ -53,14 +58,9 @@ class ServerType(object):
st.utility_path = paths.register(
'bin_paths', st.stype + '_bin_dir',
-_("{0} Binary Path").format(st.desc),
+st.UTILITY_PATH_LABEL,
'text', default_path, category_label=_('Binary paths'),
-help_str=_(
-"Path to the directory containing the {0} utility"
-" programs (pg_dump, pg_restore etc).".format(
-st.desc
-)
-)
+help_str=st.UTILITY_PATH_HELP
)
@property
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subs
[pgadmin-hackers] [pgAdmin4][Patch]: RM #2339 - Horizontal scrolling in the treeview
Hi,
Please find the attached patch to fix the RM #2339: Horizontal scrolling in
the treeview.
I wanted to change the pgadmin.css file to fix this issue but the aciTree
library is located at browser/static/vendor/, so I have included this
change in the browser/static/css/browser.css file.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/static/css/browser.css b/web/pgadmin/browser/static/css/browser.css
index 3ad1dcd..c426dda 100644
--- a/web/pgadmin/browser/static/css/browser.css
+++ b/web/pgadmin/browser/static/css/browser.css
@@ -45,3 +45,7 @@
.pgadmin-node-select option {
padding-left: 20px;
}
+
+.aciTree .aciTreeUl {
+ display: table !important;
+}
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
[pgadmin-hackers] [pgAdmin4][Patch]: RM 2318: Fixed Foreign Table column order
Hi,
Please find the attached patch to fix the RM #2318: Foreign Table create
script puts columns in alphabetical order instead of the actual order of
the columns as the table was originally created
Fixed the column order in get_columns.sql template for PG 9.5 and above.
Other than this templates have the correct order.
Thanks,
Khushboo
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/9.5_plus/get_columns.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/9.5_plus/get_columns.sql
index 3417208..6e82a09 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/9.5_plus/get_columns.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/foreign_tables/templates/foreign_tables/sql/9.5_plus/get_columns.sql
@@ -40,4 +40,4 @@ LEFT OUTER JOIN
WHERE
att.attrelid={{foid}}::oid
AND att.attnum>0
-ORDER BY att.attname;
+ORDER BY att.attnum;
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
