[BUGS] BUG #8456: Ldap connection with accents

2013-09-16 Thread yoann . perollet
The following bug has been logged on the website:

Bug reference:  8456
Logged by:  yoann perollet
Email address:  yoann.perol...@veremes.com
PostgreSQL version: 9.0.6
Operating system:   Windows 8 x64
Description:

I use LDAP authentification with postgres to connect.


Being on windows my ldap system is Active Directory.


Everything is ok when users login does not contain accents.


But when my user login contains an accent, i have the following error :


2013-09-13 14:20:12 CESTLOG:  échec de connexion LDAP pour l'utilisateur «
sébast...@siege.veremes.com » sur le serveur « roussillon » :
code d'erreur 49
2013-09-13 14:20:12 CESTFATAL:  authentification LDAP échouée pour
l'utilisateur « sébast...@siege.veremes.com »


All my databases encoding are UTF8


Here my pg_hba.conf file configuration :


# IPv4 local connections:
hostall u_scheduler  127.0.0.1/32 trust
hostall +superusers 127.0.0.1/32md5
hostall +gtf_siege.veremes.com  127.0.0.1/32 ldap
ldapserver=roussillon ldapprefix=
hostall all 127.0.0.1/32md5
hostall u_scheduler  192.168.1.43/32 trust
hostall +gtf_siege.veremes.com  192.168.1.43/32 ldap
ldapserver=roussillon ldapprefix=


I don't know what to do, I think it's a bug


Please excuse me if not.


Regards.


Yoann Perollet



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] BUG #8455: spanish pgadmin3.mo

2013-09-16 Thread j . romero
The following bug has been logged on the website:

Bug reference:  8455
Logged by:  Jesus Romero
Email address:  j.rom...@salsa.es
PostgreSQL version: 9.1.9
Operating system:   Ubuntu server 12.04
Description:

The actual version of pgadmin3 1.18 includes a wrong file pgadmin3.mo for
the spanish languaje. The file included is catalan languaje not the spanish
one.


Thanks.



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8453: uninitialized memory access in pg_receivexlog and other bugs

2013-09-16 Thread Heikki Linnakangas

On 15.09.2013 15:02, and...@tao11.riddles.org.uk wrote:

The following bug has been logged on the website:

Bug reference:  8453
Logged by:  Andrew Gierth
Email address:  and...@tao11.riddles.org.uk
PostgreSQL version: 9.3.0
Operating system:   any
Description:

The first snprintf in writeTimeLineHistoryFile in receivelog.c accesses
uninitialized data in the path variable, thus creating the .tmp file in a
random place (usually the current dir, leading to unexpected EXDEV errors on
the rename).


Ouch, that was a silly bug!


Also, receivexlog is ignoring .partial and .history files when determining
which timeline to start streaming from, which means that if there are two
timeline changes that are not separated by a WAL segment switch, it will
fail to operate due to attempting to start from a too-old timeline (for
which xlogs are not available on the server).


There's nothing we can do with .history files here. The point is to find 
out how far we have already received WAL, and the presence of a .history 
file doesn't tell you anything about that.


There is a comment about .partial files though:


/*
 * Check if the filename looks like an xlog file, or a .partial 
file.
 * Xlog files are always 24 characters, and .partial files are 
32
 * characters.
 */
if (strlen(dirent-d_name) != 24 ||
strspn(dirent-d_name, 0123456789ABCDEF) != 24)
continue;


The comment says that .partial files are taken into account, but the 
code doesn't match the comment.


Attached is a patch to fix both of these issues. I'm too tired right now 
to thoroughly test it and commit, so I'll get back to this tomorrow. 
Meanwhile, please take a look and let me know if you can see something 
wrong.


- Heikki
diff --git a/src/bin/pg_basebackup/pg_receivexlog.c b/src/bin/pg_basebackup/pg_receivexlog.c
index 787a395..ca89438 100644
--- a/src/bin/pg_basebackup/pg_receivexlog.c
+++ b/src/bin/pg_basebackup/pg_receivexlog.c
@@ -121,6 +121,7 @@ FindStreamingStart(uint32 *tli)
 	struct dirent *dirent;
 	XLogSegNo	high_segno = 0;
 	uint32		high_tli = 0;
+	bool		high_ispartial = false;
 
 	dir = opendir(basedir);
 	if (dir == NULL)
@@ -132,20 +133,33 @@ FindStreamingStart(uint32 *tli)
 
 	while ((dirent = readdir(dir)) != NULL)
 	{
-		char		fullpath[MAXPGPATH];
-		struct stat statbuf;
 		uint32		tli;
 		unsigned int log,
 	seg;
 		XLogSegNo	segno;
+		bool		ispartial;
 
 		/*
 		 * Check if the filename looks like an xlog file, or a .partial file.
 		 * Xlog files are always 24 characters, and .partial files are 32
 		 * characters.
 		 */
-		if (strlen(dirent-d_name) != 24 ||
-			strspn(dirent-d_name, 0123456789ABCDEF) != 24)
+		if (strlen(dirent-d_name) == 24)
+		{
+			if (strspn(dirent-d_name, 0123456789ABCDEF) != 24)
+continue;
+			ispartial = false;
+		}
+		else if (strlen(dirent-d_name) == 32)
+		{
+			if (strspn(dirent-d_name, 0123456789ABCDEF) != 24)
+continue;
+			if (strcmp(dirent-d_name[24], .partial) != 0)
+continue;
+
+			ispartial = true;
+		}
+		else
 			continue;
 
 		/*
@@ -160,31 +174,40 @@ FindStreamingStart(uint32 *tli)
 		}
 		segno = ((uint64) log)  32 | seg;
 
-		/* Check if this is a completed segment or not */
-		snprintf(fullpath, sizeof(fullpath), %s/%s, basedir, dirent-d_name);
-		if (stat(fullpath, statbuf) != 0)
+		/*
+		 * Check that the segment has the right size, if it's supposed to be
+		 * completed.
+		 */
+		if (!ispartial)
 		{
-			fprintf(stderr, _(%s: could not stat file \%s\: %s\n),
-	progname, fullpath, strerror(errno));
-			disconnect_and_exit(1);
-		}
+			struct stat statbuf;
+			char		fullpath[MAXPGPATH];
 
-		if (statbuf.st_size == XLOG_SEG_SIZE)
-		{
-			/* Completed segment */
-			if (segno  high_segno || (segno == high_segno  tli  high_tli))
+			snprintf(fullpath, sizeof(fullpath), %s/%s, basedir, dirent-d_name);
+			if (stat(fullpath, statbuf) != 0)
+			{
+fprintf(stderr, _(%s: could not stat file \%s\: %s\n),
+		progname, fullpath, strerror(errno));
+disconnect_and_exit(1);
+			}
+
+			if (statbuf.st_size != XLOG_SEG_SIZE)
 			{
-high_segno = segno;
-high_tli = tli;
+fprintf(stderr,
+		_(%s: segment file \%s\ has incorrect size %d, skipping\n),
+		progname, dirent-d_name, (int) statbuf.st_size);
 continue;
 			}
 		}
-		else
+
+		/* Looks like a valid segment. Remember that we saw it */
+		if ((segno  high_segno) ||
+			(segno == high_segno  tli  high_tli) ||
+			(segno == high_segno  tli == high_tli  high_ispartial  !ispartial))
 		{
-			fprintf(stderr,
-			  _(%s: segment file \%s\ has incorrect size %d, skipping\n),
-	progname, dirent-d_name, (int) statbuf.st_size);
-			continue;
+			high_segno = segno;
+			high_tli = tli;
+			high_ispartial = ispartial;
 		}
 	}
 
@@ -195,10 +218,12 @@ FindStreamingStart(uint32 *tli)
 		XLogRecPtr	high_ptr;
 
 		/*
-		 * Move the starting 

[BUGS] BUG #8458: Missing Fedora RPMs

2013-09-16 Thread lrr
The following bug has been logged on the website:

Bug reference:  8458
Logged by:  Larry Rogers
Email address:  l...@cert.org
PostgreSQL version: 9.3.0
Operating system:   Linux
Description:

Hi:


The 9.3 non-RC1 RPMs are missing for Fedora 17 and 18 for i386.


If those will not be made available, I'd be happy to rebuild from source
once you release the SRPM for 9.3


Thanks!


Larry Rogers



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


[BUGS] BUG #8457: Ldap connection with accents

2013-09-16 Thread yoann . perollet
The following bug has been logged on the website:

Bug reference:  8457
Logged by:  yoann perollet
Email address:  yoann.perol...@veremes.com
PostgreSQL version: 9.0.6
Operating system:   Windows 8 x64
Description:

I use LDAP authentification with postgres to connect.


Being on windows my ldap system is Active Directory.


Everything is ok when users login does not contain accents.


But when my user login contains an accent, i have the following error :


2013-09-13 14:20:12 CESTLOG:  échec de connexion LDAP pour l'utilisateur «
sébast...@siege.veremes.com » sur le serveur « roussillon » :
code d'erreur 49
2013-09-13 14:20:12 CESTFATAL:  authentification LDAP échouée pour
l'utilisateur « sébast...@siege.veremes.com »


All my databases encoding are UTF8


Here my pg_hba.conf file configuration :


# IPv4 local connections:
hostall u_scheduler  127.0.0.1/32 trust
hostall +superusers 127.0.0.1/32md5
hostall +gtf_siege.veremes.com  127.0.0.1/32 ldap
ldapserver=roussillon ldapprefix=
hostall all 127.0.0.1/32md5
hostall u_scheduler  192.168.1.43/32 trust
hostall +gtf_siege.veremes.com  192.168.1.43/32 ldap
ldapserver=roussillon ldapprefix=


I don't know what to do, I think it's a bug


Please excuse me if not.


Regards.


Yoann Perollet



-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs


Re: [BUGS] BUG #8453: uninitialized memory access in pg_receivexlog and other bugs

2013-09-16 Thread Andrew Gierth
 Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes:

  Also, receivexlog is ignoring .partial and .history files when
  determining which timeline to start streaming from, which means
  that if there are two timeline changes that are not separated by a
  WAL segment switch, it will fail to operate due to attempting to
  start from a too-old timeline (for which xlogs are not available
  on the server).

 Heikki There's nothing we can do with .history files here. The point
 Heikki is to find out how far we have already received WAL, and the
 Heikki presence of a .history file doesn't tell you anything about
 Heikki that.

I was thinking that the presence of a history file might at least be
useful for setting a bound on what TLI we're going to use; but if a
possible .partial file is taken into account the issue should be moot
anyway I guess.

 Heikki Attached is a patch to fix both of these issues. I'm too
 Heikki tired right now to thoroughly test it and commit, so I'll get
 Heikki back to this tomorrow. Meanwhile, please take a look and let
 Heikki me know if you can see something wrong.

A quick eyeball check looks ok; I'll see about reproducing the
original scenario with this patch applied.

-- 
Andrew (irc:RhodiumToad)


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs