pgsql: doc PG 17 relnotes: add item about libpq large data transfers

2024-05-13 Thread Bruce Momjian
doc PG 17 relnotes:  add item about libpq large data transfers

Reported-by: Jelte Fennema-Nio

Discussion: 
https://postgr.es/m/cageczqtz5auqlel6dald2hu2fxs_losh4kedndj1fwthsb_...@mail.gmail.com

Reviewed-by: Joe Conway

Backpatch-through: master

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e87e7324555a93d7645e831209eee3404b9c05d3

Modified Files
--
doc/src/sgml/release-17.sgml | 11 +++
1 file changed, 11 insertions(+)



pgsql: Revert "Temporarily install debugging in partition_prune test"

2024-05-13 Thread David Rowley
Revert "Temporarily install debugging in partition_prune test"

1db689715 added debugging output to the partition_prune regression test
to help us figure out why buildfarm member Parula was occasionally
failing.

We've not seen any failures in around 4 weeks and the best guess as to
what the problem was is a compiler bug.  Since there are no recent
failures, there's now no need to keep this debugging code, so revert it.

Discussion: 
https://postgr.es/m/CAApHDvqyLF881EvDtXT=ossa0i4iojbtw2c0wbouzt5d3hd...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ec1a405adc24bc20523eef83ccc85232ec23eaa9

Modified Files
--
src/test/regress/expected/partition_prune.out | 62 ---
src/test/regress/sql/partition_prune.sql  | 14 --
2 files changed, 76 deletions(-)



pgsql: doc PG 17 relnotes: add psql connection control-C item

2024-05-13 Thread Bruce Momjian
doc PG 17 relnotes:  add psql connection control-C item

Reported-by: Jelte Fennema-Nio

Discussion: 
https://postgr.es/m/cageczqtz5auqlel6dald2hu2fxs_losh4kedndj1fwthsb_...@mail.gmail.com

Reviewed-by: Tom Lane

Backpatch-through: master

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/6961753381d8b2437195ce40d219a619a61002b6

Modified Files
--
doc/src/sgml/release-17.sgml | 11 +++
1 file changed, 11 insertions(+)



pgsql: Remove COMMAND_TAG_NEXTTAG from enum CommandTag.

2024-05-13 Thread Tom Lane
Remove COMMAND_TAG_NEXTTAG from enum CommandTag.

COMMAND_TAG_NEXTTAG isn't really a valid command tag.  Declaring it
as if it were one prompts complaints from Coverity and perhaps other
static analyzers.  Our only use of it is in an entirely-unnecessary
array sizing declaration, so let's just drop it.

Ranier Vilela

Discussion: 
https://postgr.es/m/caeudqaoy0xrkutax7w10zsjjupkbpfrtdcyscb3z0fb2v6h...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/1f7452fa598ee5f1ed32f1fcce101c63c6f1933f

Modified Files
--
src/backend/tcop/cmdtag.c | 2 +-
src/include/tcop/cmdtag.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)



pgsql: Fix typo

2024-05-13 Thread Alvaro Herrera
Fix typo

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/11c1984cccad1d41f461d3bb00f9e662332d002b

Modified Files
--
doc/src/sgml/catalogs.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



pgsql: Fix regression tests conflict in 3ca43dbbb6

2024-05-13 Thread Alexander Korotkov
Fix regression tests conflict in 3ca43dbbb6

3ca43dbbb6 adds regression tests with permission checks.  The conflict has
been observed at buildfarm member piculet.

This commit fixes the conflict in the following way.
1. partition_split.sql now uses role names regress_partition_split_alice and
   regress_partition_split_bob (it mistakenly used
   regress_partition_merge_alice and regress_partition_merge_bob before).
2. Permissions on schemas partitions_merge_schema and partition_split_schema
   are granted to corresponding roles.  Before, the lack of permissions led to
   the creation of objects in the public schema and potential conflict.

Reported-by: Daniel Gustafsson
Discussion: https://postgr.es/m/03A07EF6-98D2-419B-A3AA-A111C64CC207%40yesql.se

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/2a679ae94e46ea2fa1ff5461c9d0767faecc6c8c

Modified Files
--
src/test/regress/expected/partition_merge.out |  4 
src/test/regress/expected/partition_split.out | 25 +++--
src/test/regress/sql/partition_merge.sql  |  4 
src/test/regress/sql/partition_split.sql  | 25 +++--
4 files changed, 38 insertions(+), 20 deletions(-)



pgsql: Revert structural changes to not-null constraints

2024-05-13 Thread Alvaro Herrera
Revert structural changes to not-null constraints

There are some problems with the new way to handle these constraints
that were detected at the last minute, and require fixes that appear too
invasive to be doing this late in the cycle.  Revert this (again) for
now, we'll try again with these problems fixed.

The following commits are reverted:

b0e96f311985  Catalog not-null constraints
9b581c534186  Disallow changing NO INHERIT status of a not-null constraint
d0ec2ddbe088  Fix not-null constraint test
ac22a9545ca9  Move privilege check to the right place
b0f7dd915bca  Check stack depth in new recursive functions
3af721794272  Update information_schema definition for not-null constraints
c3709100be73  Fix propagating attnotnull in multiple inheritance
d9f686a72ee9  Fix restore of not-null constraints with inheritance
d72d32f52d26  Don't try to assign smart names to constraints
0cd711271d42  Better handle indirect constraint drops
13daa33fa5a6  Disallow NO INHERIT not-null constraints on partitioned tables
d45597f72fe5  Disallow direct change of NO INHERIT of not-null constraints
21ac38f498b3  Fix inconsistencies in error messages

Discussion: https://postgr.es/m/202405110940.joxlqcx4dogd@alvherre.pgsql

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/6f8bb7c1e9610dd7af20cdaf74c4ff6e6d678d44

Modified Files
--
contrib/sepgsql/expected/alter.out |3 +
contrib/sepgsql/expected/ddl.out   |2 -
contrib/test_decoding/expected/ddl.out |   12 -
doc/src/sgml/catalogs.sgml |   13 +-
doc/src/sgml/ddl.sgml  |   55 +-
doc/src/sgml/ref/alter_table.sgml  |   13 +-
doc/src/sgml/ref/create_table.sgml |8 +-
src/backend/catalog/heap.c |  386 +
src/backend/catalog/information_schema.sql |   71 +-
src/backend/catalog/pg_constraint.c|  441 +-
src/backend/commands/tablecmds.c   | 1664 +---
src/backend/optimizer/util/plancat.c   |2 -
src/backend/parser/gram.y  |   19 +-
src/backend/parser/parse_utilcmd.c |  288 +---
src/backend/utils/adt/ruleutils.c  |   22 -
src/backend/utils/cache/relcache.c |   42 +-
src/bin/pg_dump/common.c   |   19 +-
src/bin/pg_dump/pg_dump.c  |  322 +---
src/bin/pg_dump/pg_dump.h  |9 +-
src/bin/pg_dump/t/002_pg_dump.pl   |   10 +-
src/bin/psql/describe.c|   44 -
src/include/catalog/catversion.h   |2 +-
src/include/catalog/heap.h |8 +-
src/include/catalog/pg_constraint.h|7 -
src/include/nodes/parsenodes.h |   11 +-
.../test_ddl_deparse/expected/alter_table.out  |   18 +-
.../test_ddl_deparse/expected/create_table.out |   26 +-
.../modules/test_ddl_deparse/test_ddl_deparse.c|6 +-
src/test/regress/expected/alter_table.out  |   24 +-
src/test/regress/expected/cluster.out  |7 +-
src/test/regress/expected/constraints.out  |  518 --
src/test/regress/expected/create_table.out |   35 +-
src/test/regress/expected/create_table_like.out|   10 -
src/test/regress/expected/event_trigger.out|2 -
src/test/regress/expected/foreign_data.out |  108 +-
src/test/regress/expected/foreign_key.out  |   16 +-
src/test/regress/expected/generated.out|2 -
src/test/regress/expected/identity.out |4 -
src/test/regress/expected/indexing.out |   38 +-
src/test/regress/expected/inherit.out  |  510 --
src/test/regress/expected/partition_merge.out  |2 -
src/test/regress/expected/publication.out  |6 -
src/test/regress/expected/replica_identity.out |   24 -
src/test/regress/expected/rowsecurity.out  |2 -
src/test/regress/sql/alter_table.sql   |   12 +-
src/test/regress/sql/constraints.sql   |  217 ---
src/test/regress/sql/indexing.sql  |5 +-
src/test/regress/sql/inherit.sql   |  229 ---
src/test/regress/sql/replica_identity.sql  |   15 -
49 files changed, 709 insertions(+), 4600 deletions(-)



pgsql: Fix test case to do what it intends to

2024-05-13 Thread Alvaro Herrera
Fix test case to do what it intends to

This test case intended to fail because setting a column as generated to
the partitioned table while leaving the partition alone is not allowed;
but instead failed because of a discrepancy of not-null constraint.  Fix
this by adding the not-null constraint first, then set the column as
generated in a separate ALTER TABLE command, which gets the expected
error.  Also, because the next test also wants to set the column as
not-null, add a BEGIN/ROLLBACK block so that the added not-null is
removed.

Oversight in 699586315704.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e89f4c66182e409b6643b1e8426371011dc25217

Modified Files
--
src/test/regress/expected/identity.out | 6 --
src/test/regress/sql/identity.sql  | 4 +++-
2 files changed, 7 insertions(+), 3 deletions(-)