pgsql: Fix dumping role comments when using --no-role-passwords

2024-03-21 Thread Daniel Gustafsson
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera 
Author: Daniel Gustafsson 
Reported-by: Bartosz Chroł 
Discussion: 
https://postgr.es/m/as8p194mb1271cda0adca7b75fcd8e767f7...@as8p194mb1271.eurp194.prod.outlook.com
Discussion: 
https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d82cb467bbc292375283b40f5cc65868024c82b4

Modified Files
--
src/bin/pg_dump/pg_dumpall.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)



pgsql: Fix dumping role comments when using --no-role-passwords

2024-03-21 Thread Daniel Gustafsson
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera 
Author: Daniel Gustafsson 
Reported-by: Bartosz Chroł 
Discussion: 
https://postgr.es/m/as8p194mb1271cda0adca7b75fcd8e767f7...@as8p194mb1271.eurp194.prod.outlook.com
Discussion: 
https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/affc46b76d50a42c44ae1322545769eceaa509c6

Modified Files
--
src/bin/pg_dump/pg_dumpall.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)



pgsql: Fix dumping role comments when using --no-role-passwords

2024-03-21 Thread Daniel Gustafsson
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera 
Author: Daniel Gustafsson 
Reported-by: Bartosz Chroł 
Discussion: 
https://postgr.es/m/as8p194mb1271cda0adca7b75fcd8e767f7...@as8p194mb1271.eurp194.prod.outlook.com
Discussion: 
https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/be01c8c3450e48fbe8baa13625e1d36e0814c29b

Modified Files
--
src/bin/pg_dump/pg_dumpall.c | 21 -
1 file changed, 12 insertions(+), 9 deletions(-)



pgsql: Fix dumping role comments when using --no-role-passwords

2024-03-21 Thread Daniel Gustafsson
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera 
Author: Daniel Gustafsson 
Reported-by: Bartosz Chroł 
Discussion: 
https://postgr.es/m/as8p194mb1271cda0adca7b75fcd8e767f7...@as8p194mb1271.eurp194.prod.outlook.com
Discussion: 
https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/12128be623fdfd1f15167a477d7de46744fb9bca

Modified Files
--
src/bin/pg_dump/pg_dumpall.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)



pgsql: Fix dumping role comments when using --no-role-passwords

2024-03-21 Thread Daniel Gustafsson
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera 
Author: Daniel Gustafsson 
Reported-by: Bartosz Chroł 
Discussion: 
https://postgr.es/m/as8p194mb1271cda0adca7b75fcd8e767f7...@as8p194mb1271.eurp194.prod.outlook.com
Discussion: 
https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/5863bacb87c1e6cd1a322c9c4a5a861b27768379

Modified Files
--
src/bin/pg_dump/pg_dumpall.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)



pgsql: Fix dumping role comments when using --no-role-passwords

2024-03-21 Thread Daniel Gustafsson
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera 
Author: Daniel Gustafsson 
Reported-by: Bartosz Chroł 
Discussion: 
https://postgr.es/m/as8p194mb1271cda0adca7b75fcd8e767f7...@as8p194mb1271.eurp194.prod.outlook.com
Discussion: 
https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/7e65ad197f9dff7466cea7986450f9573adb4448

Modified Files
--
src/bin/pg_dump/pg_dumpall.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)