pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1414821e1688c86266c5ecaad378086785152332

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)



pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/4fc4856849deb51c8d8822d79b6f10d571dab4f6

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)



pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/99f5888d358a5db375ce0299b18fb47ccfa1646c

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)



pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/d5ad7a09afd066dce423f282bb2b338f48614d32

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)



pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ab64b474d9bec8486b42e550526a121f0d81b681

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)



pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
REL_11_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/c0bf35421529ab210479ea0e828270e6626adff6

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)



pgsql: Fix traversing to the deleted GIN page via downlink

2019-11-19 Thread Alexander Korotkov
Fix traversing to the deleted GIN page via downlink

Current GIN code appears to don't handle traversing to the deleted page via
downlink.  This commit fixes that by stepping right from the delete page like
we do in nbtree.

This commit also fixes setting 'deleted' flag to the GIN pages.  Now other page
flags are not erased once page is deleted.  That helps to keep our assertions
true if we arrive deleted page via downlink.

Discussion: 
https://postgr.es/m/CAPpHfdvMvsw-NcE5bRS7R1BbvA4BxoDnVVjkXC5W0Czvy9LVrg%40mail.gmail.com
Author: Alexander Korotkov
Reviewed-by: Peter Geoghegan
Backpatch-through: 9.4

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ee437ca7408b67f2b785e4221c7e567aecf68b47

Modified Files
--
src/backend/access/gin/ginbtree.c| 7 ---
src/backend/access/gin/gindatapage.c | 3 +++
src/backend/access/gin/ginvacuum.c   | 2 +-
src/backend/access/gin/ginxlog.c | 2 +-
4 files changed, 5 insertions(+), 9 deletions(-)