pgsql: Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security con

2024-02-08 Thread Heikki Linnakangas
Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security context

The internal commands in REFRESH MATERIALIZED VIEW CONCURRENTLY are
correctly executed in SECURITY_RESTRICTED_OPERATION mode, except for
creating the temporary "diff" table, because you cannot create
temporary tables in SRO mode. But creating the temporary "diff" table
is a pretty complex CTAS command that selects from another temporary
table created earlier in the command. If you can cajole that CTAS
command to execute code defined by the table owner, the table owner
can run code with the privileges of the user running the REFRESH
command.

The proof-of-concept reported to the security team relied on CREATE
RULE to convert the internally-built temp table to a view. That's not
possible since commit b23cd185fd, and I was not able to find a
different way to turn the SELECT on the temp table into code
execution, so as far as I know this is only exploitable in v15 and
below. That's a fiddly assumption though, so apply this patch to
master and all stable versions.

Thanks to Pedro Gallegos for the report.

Security: CVE-2023-5869
Reviewed-by: Noah Misch

Branch
--
REL_14_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f4f2883521fc3f81765ab82eab2ffa31574f0a07

Modified Files
--
src/backend/commands/matview.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)



pgsql: Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security con

2024-02-08 Thread Heikki Linnakangas
Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security context

The internal commands in REFRESH MATERIALIZED VIEW CONCURRENTLY are
correctly executed in SECURITY_RESTRICTED_OPERATION mode, except for
creating the temporary "diff" table, because you cannot create
temporary tables in SRO mode. But creating the temporary "diff" table
is a pretty complex CTAS command that selects from another temporary
table created earlier in the command. If you can cajole that CTAS
command to execute code defined by the table owner, the table owner
can run code with the privileges of the user running the REFRESH
command.

The proof-of-concept reported to the security team relied on CREATE
RULE to convert the internally-built temp table to a view. That's not
possible since commit b23cd185fd, and I was not able to find a
different way to turn the SELECT on the temp table into code
execution, so as far as I know this is only exploitable in v15 and
below. That's a fiddly assumption though, so apply this patch to
master and all stable versions.

Thanks to Pedro Gallegos for the report.

Security: CVE-2023-5869
Reviewed-by: Noah Misch

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d6a61cb3bef3c8fbc35c2a6182e75a8c1d351e41

Modified Files
--
src/backend/commands/matview.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)



pgsql: Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security con

2024-02-08 Thread Heikki Linnakangas
Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security context

The internal commands in REFRESH MATERIALIZED VIEW CONCURRENTLY are
correctly executed in SECURITY_RESTRICTED_OPERATION mode, except for
creating the temporary "diff" table, because you cannot create
temporary tables in SRO mode. But creating the temporary "diff" table
is a pretty complex CTAS command that selects from another temporary
table created earlier in the command. If you can cajole that CTAS
command to execute code defined by the table owner, the table owner
can run code with the privileges of the user running the REFRESH
command.

The proof-of-concept reported to the security team relied on CREATE
RULE to convert the internally-built temp table to a view. That's not
possible since commit b23cd185fd, and I was not able to find a
different way to turn the SELECT on the temp table into code
execution, so as far as I know this is only exploitable in v15 and
below. That's a fiddly assumption though, so apply this patch to
master and all stable versions.

Thanks to Pedro Gallegos for the report.

Security: CVE-2023-5869
Reviewed-by: Noah Misch

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f2fdea198b3d0ab30b9e8478a762488ecebabd88

Modified Files
--
src/backend/commands/matview.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)



pgsql: Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security con

2024-02-08 Thread Heikki Linnakangas
Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security context

The internal commands in REFRESH MATERIALIZED VIEW CONCURRENTLY are
correctly executed in SECURITY_RESTRICTED_OPERATION mode, except for
creating the temporary "diff" table, because you cannot create
temporary tables in SRO mode. But creating the temporary "diff" table
is a pretty complex CTAS command that selects from another temporary
table created earlier in the command. If you can cajole that CTAS
command to execute code defined by the table owner, the table owner
can run code with the privileges of the user running the REFRESH
command.

The proof-of-concept reported to the security team relied on CREATE
RULE to convert the internally-built temp table to a view. That's not
possible since commit b23cd185fd, and I was not able to find a
different way to turn the SELECT on the temp table into code
execution, so as far as I know this is only exploitable in v15 and
below. That's a fiddly assumption though, so apply this patch to
master and all stable versions.

Thanks to Pedro Gallegos for the report.

Security: CVE-2023-5869
Reviewed-by: Noah Misch

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/5a9167c3971211d6fe65ecdd83025625e4af0b8b

Modified Files
--
src/backend/commands/matview.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)



pgsql: Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security con

2024-02-08 Thread Heikki Linnakangas
Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security context

The internal commands in REFRESH MATERIALIZED VIEW CONCURRENTLY are
correctly executed in SECURITY_RESTRICTED_OPERATION mode, except for
creating the temporary "diff" table, because you cannot create
temporary tables in SRO mode. But creating the temporary "diff" table
is a pretty complex CTAS command that selects from another temporary
table created earlier in the command. If you can cajole that CTAS
command to execute code defined by the table owner, the table owner
can run code with the privileges of the user running the REFRESH
command.

The proof-of-concept reported to the security team relied on CREATE
RULE to convert the internally-built temp table to a view. That's not
possible since commit b23cd185fd, and I was not able to find a
different way to turn the SELECT on the temp table into code
execution, so as far as I know this is only exploitable in v15 and
below. That's a fiddly assumption though, so apply this patch to
master and all stable versions.

Thanks to Pedro Gallegos for the report.

Security: CVE-2023-5869
Reviewed-by: Noah Misch

Branch
--
REL_13_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d541ce3b6f0582723150f45d52eab119985d3c19

Modified Files
--
src/backend/commands/matview.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)



pgsql: Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security con

2024-02-08 Thread Heikki Linnakangas
Run REFRESH MATERIALIZED VIEW CONCURRENTLY in right security context

The internal commands in REFRESH MATERIALIZED VIEW CONCURRENTLY are
correctly executed in SECURITY_RESTRICTED_OPERATION mode, except for
creating the temporary "diff" table, because you cannot create
temporary tables in SRO mode. But creating the temporary "diff" table
is a pretty complex CTAS command that selects from another temporary
table created earlier in the command. If you can cajole that CTAS
command to execute code defined by the table owner, the table owner
can run code with the privileges of the user running the REFRESH
command.

The proof-of-concept reported to the security team relied on CREATE
RULE to convert the internally-built temp table to a view. That's not
possible since commit b23cd185fd, and I was not able to find a
different way to turn the SELECT on the temp table into code
execution, so as far as I know this is only exploitable in v15 and
below. That's a fiddly assumption though, so apply this patch to
master and all stable versions.

Thanks to Pedro Gallegos for the report.

Security: CVE-2023-5869
Reviewed-by: Noah Misch

Branch
--
REL_12_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2699fc035a75d0774c1f013e9320882287f78adb

Modified Files
--
src/backend/commands/matview.c | 33 ++---
1 file changed, 26 insertions(+), 7 deletions(-)