pgsql: Align stats_fetch_consistency definition with guc.c default.

2022-05-28 Thread Andres Freund
Align stats_fetch_consistency definition with guc.c default.

Somewhat embarrassing oversight in 98f897339b0. Does not have a functional
impact, but is unnecessarily confusing.

Reported-By: Michael Paquier 
Discussion: https://postgr.es/m/Yo2351qVYqd/[email protected]

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0107855b1480d381f28f935e279ec3b64f410ef7

Modified Files
--
src/backend/utils/activity/pgstat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



Re: pgsql: Extend pg_publication_tables to display column list and row filt

2022-05-28 Thread Andres Freund
Hi,

On 2022-05-19 08:59:13 +0530, Amit Kapila wrote:
> On Thu, May 19, 2022 at 8:40 AM Tom Lane  wrote:
> >
> > Amit Kapila  writes:
> > > Extend pg_publication_tables to display column list and row filter.
> >
> > Is this really something to be doing post-beta1?
> >
> 
> I am sorry if we don't allow to make catalog changes post-beta1.

I don't think there's a hard prohibition of catalog changes. But we should be
careful doing them because it makes testing more painful etc.


> If we can't do that then I can revert this and try to find a different
> solution to the problem?

What "problem"? This just seems like a feature in a problem's clothing? The
commit message says:

> This information will be useful to users and we also need this for the
> later commit that prohibits combining multiple publications with different
> column lists for the same table.

which doesn't at all strike me as a justification for committing it post
feature freeze, i.e. it sounds like a feature.

If you want to argue that it's a rough corner in v15 work, that it's worth
committing now, do that explicitly.

Greetings,

Andres Freund




pgsql: Doc: Document pg_stat_recovery_prefetch.stats_reset.

2022-05-28 Thread Thomas Munro
Doc: Document pg_stat_recovery_prefetch.stats_reset.

This column was missing from the table that describes the new view.

Author: Shinoda, Noriyoshi (PN Japan FSIP) 
Discussion: 
https://postgr.es/m/dm4pr84mb173401c19a0eb9b1caab197cee...@dm4pr84mb1734.namprd84.prod.outlook.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/cfce3be818ab6778cf2c314ff4f6f398b74f75eb

Modified Files
--
doc/src/sgml/monitoring.sgml | 11 +++
1 file changed, 11 insertions(+)