pgsql: Disable autovacuum on primary in 040_standby_failover_slots_sync

2024-02-16 Thread Amit Kapila
Disable autovacuum on primary in 040_standby_failover_slots_sync test.

Disable autovacuum to avoid generating xid during stats update as
otherwise the new XID could then be replicated to standby at some random
point making slots at primary lag behind standby during slot sync.

As per buildfarm

Author: Hou Zhijie
Discussion: 
https://postgr.es/m/514f6f2f-6833-4539-39f1-96cd1e011...@enterprisedb.com
Discussion: 
https://postgr.es/m/CAA4eK1Jun8SGCoc6JEktxY_+L7GmoJWrdsx-KCEP=gl-ssw...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/b7bdade6a42f49021d41955d6534f334e827775c

Modified Files
--
src/test/recovery/t/040_standby_failover_slots_sync.pl | 4 
1 file changed, 4 insertions(+)



pgsql: Remove non-existing file from .gitattributes

2024-02-16 Thread Peter Eisentraut
Remove non-existing file from .gitattributes

The file was removed by ac25173cdbc.

Author: Jelte Fennema-Nio 
Discussion: 
https://www.postgresql.org/message-id/flat/CAGECzQQGzbroAXi%2BYicp3HvcCo4%3Dg84kaOgjuvQ5MW9F0ubOGg%40mail.gmail.com

Branch
--
REL_15_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1d577f2eaa88b1d4caab3e859a01d25ecd9f81c5

Modified Files
--
.gitattributes | 1 -
1 file changed, 1 deletion(-)



pgsql: Remove non-existing file from .gitattributes

2024-02-16 Thread Peter Eisentraut
Remove non-existing file from .gitattributes

The file was removed by ac25173cdbc.

Author: Jelte Fennema-Nio 
Discussion: 
https://www.postgresql.org/message-id/flat/CAGECzQQGzbroAXi%2BYicp3HvcCo4%3Dg84kaOgjuvQ5MW9F0ubOGg%40mail.gmail.com

Branch
--
REL_16_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2c7f2eb0c8aa8b2163cc41c1666c71de4267f80c

Modified Files
--
.gitattributes | 1 -
1 file changed, 1 deletion(-)



pgsql: Remove non-existing file from .gitattributes

2024-02-16 Thread Peter Eisentraut
Remove non-existing file from .gitattributes

The file was removed by ac25173cdbc.

Author: Jelte Fennema-Nio 
Discussion: 
https://www.postgresql.org/message-id/flat/CAGECzQQGzbroAXi%2BYicp3HvcCo4%3Dg84kaOgjuvQ5MW9F0ubOGg%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e85732dac0e9933cf1ec4f9df1d8ed9c221c17da

Modified Files
--
.gitattributes | 1 -
1 file changed, 1 deletion(-)



pgsql: Improve compression and storage support with inheritance

2024-02-16 Thread Peter Eisentraut
Improve compression and storage support with inheritance

A child table can specify a compression or storage method different
from its parents.  This was previously an error.  (But this was
inconsistently enforced because for example the settings could be
changed later using ALTER TABLE.)  This now also allows an explicit
override if multiple parents have different compression or storage
settings, which was previously an error that could not be overridden.

The compression and storage properties remains unchanged in a child
inheriting from parent(s) after its creation, i.e., when using ALTER
TABLE ...  INHERIT.  (This is not changed.)

Before this change, the error detail would mention the first pair of
conflicting parent compression or storage methods.  But with this
change it waits till the child specification is considered by which
time we may have encountered many such conflicting pairs.  Hence the
error detail after this change does not include the conflicting
compression/storage methods.  Those can be obtained from parent
definitions if necessary.  The code to maintain list of all
conflicting methods or even the first conflicting pair does not seem
worth the convenience it offers.  This change is inline with what we
do with conflicting default values.

Before this commit, the specified storage method could be stored in
ColumnDef::storage (CREATE TABLE ... LIKE) or ColumnDef::storage_name
(CREATE TABLE ...).  This caused the MergeChildAttribute() and
MergeInheritedAttribute() to ignore a storage method specified in the
child definition since it looked only at ColumnDef::storage.  This
commit removes ColumnDef::storage and instead uses
ColumnDef::storage_name to save any storage method specification. This
is similar to how compression method specification is handled.

Author: Ashutosh Bapat 
Discussion: 
https://www.postgresql.org/message-id/flat/24656cec-d6ef-4d15-8b5b-e8dfc9c83...@eisentraut.org

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0413a556990ba628a3de8a0b58be020fd9a14ed0

Modified Files
--
doc/src/sgml/ref/create_table.sgml  |   8 +-
src/backend/catalog/pg_type.c   |  23 
src/backend/commands/tablecmds.c| 138 +++-
src/backend/nodes/makefuncs.c   |   2 +-
src/backend/parser/gram.y   |   7 +-
src/backend/parser/parse_utilcmd.c  |   7 +-
src/include/catalog/pg_type.h   |   2 +
src/include/nodes/parsenodes.h  |   5 +-
src/test/regress/expected/compression.out   | 101 +++--
src/test/regress/expected/compression_1.out | 111 +--
src/test/regress/expected/create_table_like.out |  12 +--
src/test/regress/expected/inherit.out   |  38 +++
src/test/regress/sql/compression.sql|  43 +++-
src/test/regress/sql/create_table_like.sql  |   2 +-
src/test/regress/sql/inherit.sql|  20 
15 files changed, 408 insertions(+), 111 deletions(-)



pgsql: Remove timeouts-long.out

2024-02-16 Thread Alexander Korotkov
Remove timeouts-long.out

bf82f43790 removes timeouts-long.spec, but forgets to remove timeouts-long.out.

Reported-by: Alexander Lakhin

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/eb49e1bdd90b0f0434c01e6e00dedcd9466b5a6e

Modified Files
--
src/test/isolation/expected/timeouts-long.out | 69 ---
1 file changed, 69 deletions(-)



pgsql: Add missing check_stack_depth() to some recursive functions

2024-02-16 Thread Alexander Korotkov
Add missing check_stack_depth() to some recursive functions

Reported-by: Egor Chindyaskin, Alexander Lakhin
Discussion: https://postgr.es/m/1672760457.940462079%40f306.i.mail.ru

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/d57b7cc3338e9d9aa1d7c5da1b25a17c5a72dcce

Modified Files
--
src/backend/catalog/dependency.c  |  7 +++
src/backend/catalog/heap.c|  3 +++
src/backend/commands/tablecmds.c  | 13 +
src/backend/optimizer/util/clauses.c  |  4 
src/backend/utils/adt/jsonpath_exec.c |  3 +++
5 files changed, 30 insertions(+)



pgsql: Replace calls to pg_qsort() with the qsort() macro.

2024-02-16 Thread Nathan Bossart
Replace calls to pg_qsort() with the qsort() macro.

Calls to this function might give the impression that pg_qsort()
is somehow different than qsort(), when in fact there is a qsort()
macro in port.h that expands all in-tree uses to pg_qsort().

Reviewed-by: Mats Kindahl
Discussion: 
https://postgr.es/m/CA%2B14426g2Wa9QuUpmakwPxXFWG_1FaY0AsApkvcTBy-YfS6uaw%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/5497daf3aa2ae6ec9d5097f25c40627f8c801de8

Modified Files
--
contrib/pg_prewarm/autoprewarm.c|  4 ++--
src/backend/access/brin/brin_minmax_multi.c |  2 +-
src/backend/optimizer/plan/analyzejoins.c   |  4 ++--
src/backend/storage/buffer/bufmgr.c |  4 ++--
src/backend/utils/cache/syscache.c  | 10 +-
src/include/port.h  |  4 
6 files changed, 16 insertions(+), 12 deletions(-)



pgsql: Add assert to WALReadFromBuffers().

2024-02-16 Thread Jeff Davis
Add assert to WALReadFromBuffers().

Per suggestion from Andres.

Discussion: 
https://postgr.es/m/20240214025508.6mcblauossthv...@awork3.anarazel.de

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9ecbf54075a91ed155cc779fcc1870de0fff5fef

Modified Files
--
src/backend/access/transam/xlog.c | 24 ++--
1 file changed, 6 insertions(+), 18 deletions(-)



pgsql: Pass correct count to WALRead().

2024-02-16 Thread Jeff Davis
Pass correct count to WALRead().

Previously, some callers requested XLOG_BLCKSZ bytes
unconditionally. While this did not cause a problem, because the extra
bytes are ignored, it's confusing and makes it harder to add safety
checks. Additionally, the comment about zero padding was incorrect.

With this commit, all callers request the number of bytes they
actually need.

Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi
Discussion: 
https://postgr.es/m/CALj2ACWBRFac2TingD3PE3w2EBHXUHY3=aeezpjmqhpeobg...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/73f0a1326608ac3a7d390706fdeec59fe4dc42c0

Modified Files
--
src/backend/access/transam/xlogutils.c | 7 +--
src/backend/postmaster/walsummarizer.c | 7 +--
src/backend/replication/walsender.c| 2 +-
3 files changed, 3 insertions(+), 13 deletions(-)



pgsql: Introduce overflow-safe integer comparison functions.

2024-02-16 Thread Nathan Bossart
Introduce overflow-safe integer comparison functions.

This commit adds integer comparison functions that are designed to
be as efficient as possible while avoiding overflow.  A follow-up
commit will make use of these functions in many of the in-tree
qsort() comparators.  The new functions are not better in all cases
(e.g., when the comparator function is inlined), so it is important
to consider the context before using them.

Author: Mats Kindahl
Reviewed-by: Tom Lane, Heikki Linnakangas, Andres Freund, Thomas Munro, Andrey 
Borodin, Fabrízio de Royes Mello
Discussion: 
https://postgr.es/m/CA%2B14426g2Wa9QuUpmakwPxXFWG_1FaY0AsApkvcTBy-YfS6uaw%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/6b80394781c8de17fe7cae6996476088af3c319f

Modified Files
--
src/include/common/int.h| 75 +++--
src/include/lib/sort_template.h | 13 +++
2 files changed, 86 insertions(+), 2 deletions(-)



pgsql: Use new overflow-safe integer comparison functions.

2024-02-16 Thread Nathan Bossart
Use new overflow-safe integer comparison functions.

Commit 6b80394781 introduced integer comparison functions designed
to be as efficient as possible while avoiding overflow.  This
commit makes use of these functions in many of the in-tree qsort()
comparators to help ensure transitivity.  Many of these comparator
functions should also see a small performance boost.

Author: Mats Kindahl
Reviewed-by: Andres Freund, Fabrízio de Royes Mello
Discussion: 
https://postgr.es/m/CA%2B14426g2Wa9QuUpmakwPxXFWG_1FaY0AsApkvcTBy-YfS6uaw%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/3b42bdb47169c617cb79123c407a19d16458b49a

Modified Files
--
contrib/hstore/hstore_gist.c|  4 +++-
contrib/intarray/_int_tool.c|  9 +++--
contrib/intarray/_intbig_gist.c |  4 +++-
contrib/pg_stat_statements/pg_stat_statements.c |  8 ++--
contrib/pg_trgm/trgm_op.c   |  8 ++--
src/backend/access/nbtree/nbtinsert.c   |  8 ++--
src/backend/access/nbtree/nbtpage.c | 10 +++---
src/backend/access/nbtree/nbtsplitloc.c |  8 ++--
src/backend/access/spgist/spgdoinsert.c |  5 ++---
src/backend/access/spgist/spgtextproc.c |  3 ++-
src/backend/backup/basebackup_incremental.c |  8 ++--
src/backend/backup/walsummary.c |  7 ++-
src/backend/catalog/heap.c  |  7 ++-
src/backend/nodes/list.c| 13 +++--
src/backend/nodes/tidbitmap.c   |  7 ++-
src/backend/parser/parse_agg.c  |  3 ++-
src/backend/postmaster/autovacuum.c |  7 +++
src/backend/replication/logical/reorderbuffer.c |  7 ++-
src/backend/replication/syncrep.c   |  8 ++--
src/backend/utils/adt/oid.c |  7 ++-
src/backend/utils/adt/tsgistidx.c   | 10 +++---
src/backend/utils/adt/tsquery_gist.c|  7 +++
src/backend/utils/adt/tsvector.c|  5 ++---
src/backend/utils/adt/tsvector_op.c |  5 ++---
src/backend/utils/adt/xid.c |  7 ++-
src/backend/utils/cache/relcache.c  |  3 ++-
src/backend/utils/cache/syscache.c  |  5 ++---
src/backend/utils/cache/typcache.c  |  8 ++--
src/backend/utils/resowner/resowner.c   | 10 ++
src/bin/pg_dump/pg_dump_sort.c  |  7 ++-
src/bin/pg_upgrade/function.c   | 12 ++--
src/bin/pg_walsummary/pg_walsummary.c   |  8 ++--
src/bin/psql/crosstabview.c |  3 ++-
src/include/access/gin_private.h|  8 ++--
34 files changed, 80 insertions(+), 159 deletions(-)



pgsql: Remove remaining references to timeouts-long

2024-02-16 Thread Alexander Korotkov
Remove remaining references to timeouts-long

Reported-by: Alexander Lakhin

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/a6c21887a9f0251fa2331ea3ad0dd20b31c4d11d

Modified Files
--
src/test/isolation/Makefile | 3 ---
1 file changed, 3 deletions(-)