Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Alexander Korotkov writes: > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: >> You are aware that we are in release freeze, no? > I missed that. Should I revert this commit now? Yes, I think so. If you feel it's critical enough to go in on a release weekend, you should ask pgsql-release@ for an exception. regards, tom lane
pgsql: Revert "Refactor ChangeVarNodesExtended() using the custom callb
Revert "Refactor ChangeVarNodesExtended() using the custom callback" This reverts commit 250a718aadad68793e82103282247556a46a3cfc. It shouldn't be pushed during the release freeze. Reported-by: Tom Lane Discussion: https://postgr.es/m/E1uBIbY-000owH-0O%40gemulon.postgresql.org Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2782f3b8454676c9df408aa0bc960efca0f3eb22 Modified Files -- src/backend/optimizer/plan/analyzejoins.c | 160 +++--- src/backend/rewrite/rewriteManip.c| 138 -- src/include/rewrite/rewriteManip.h| 17 +--- src/tools/pgindent/typedefs.list | 1 - 4 files changed, 124 insertions(+), 192 deletions(-)
Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
On Sat, May 3, 2025 at 11:06 PM Tom Lane wrote: > > Alexander Korotkov writes: > > On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > >> You are aware that we are in release freeze, no? > > > I missed that. Should I revert this commit now? > > Yes, I think so. If you feel it's critical enough to go in on a > release weekend, you should ask pgsql-release@ for an exception. I don't think it's critical enough. Reverted. My apologies for breaking the rules. -- Regards, Alexander Korotkov Supabase
pgsql: doc PG 18 relnotes: move protocol version item to "server"
doc PG 18 relnotes: move protocol version item to "server" Reported-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/cageczqstbgtsdjpxohwko7106-ynnyqgzpznjdis+xtkguh...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/04b269da56db966bd439bf4634a0f33c166eae2e Modified Files -- doc/src/sgml/release-18.sgml | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)
Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Alexander Korotkov writes: > Refactor ChangeVarNodesExtended() using the custom callback You are aware that we are in release freeze, no? regards, tom lane
pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Refactor ChangeVarNodesExtended() using the custom callback fc069a3a6319 implemented Self-Join Elimination (SJE) and put related logic to ChangeVarNodes_walker(). This commit provides refactoring to remove the SJE-related logic from ChangeVarNodes_walker() but adds a custom callback to ChangeVarNodesExtended(), which has a chance to process a node before ChangeVarNodes_walker(). Passing this callback to ChangeVarNodesExtended() allows SJE-related node handling to be kept within the analyzejoins.c. Reported-by: Richard Guo Discussion: https://postgr.es/m/CAMbWs49PE3CvnV8vrQ0Dr%3DHqgZZmX0tdNbzVNJxqc8yg-8kDQQ%40mail.gmail.com Author: Andrei Lepikhov Author: Alexander Korotkov Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/250a718aadad68793e82103282247556a46a3cfc Modified Files -- src/backend/optimizer/plan/analyzejoins.c | 160 +++--- src/backend/rewrite/rewriteManip.c| 138 ++ src/include/rewrite/rewriteManip.h| 17 +++- src/tools/pgindent/typedefs.list | 1 + 4 files changed, 192 insertions(+), 124 deletions(-)
Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
On Sat, May 3, 2025 at 10:34 PM Tom Lane wrote: > > Alexander Korotkov writes: > > Refactor ChangeVarNodesExtended() using the custom callback > > You are aware that we are in release freeze, no? I missed that. Should I revert this commit now? -- Regards, Alexander Korotkov Supabase
pgsql: doc PG 18 relnotes: add GROUP BY column elimination item
doc PG 18 relnotes: add GROUP BY column elimination item With a nod to PG 9.6. Reported-by: jian he Discussion: https://postgr.es/m/CACJufxEqs=exzetwtaoootfhzrtxvswg8m2upfzjnts3wq6...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/24987c6f0687576da97b593c6dd5740ccdd23277 Modified Files -- doc/src/sgml/release-18.sgml | 17 + 1 file changed, 17 insertions(+)
pgsql: doc: update guidelines on non-ASCII characters in docs
doc: update guidelines on non-ASCII characters in docs Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fb21ed6c38da719149443e78048790c0347e2c9b Modified Files -- doc/src/sgml/README.non-ASCII | 9 + 1 file changed, 5 insertions(+), 4 deletions(-)
pgsql: doc PG 18 relnotes: fix libpq wording
doc PG 18 relnotes: fix libpq wording Reported-by: Jelte Fennema-Nio Discussion: https://postgr.es/m/CAGECzQT4804OLOP+nDBxDpMw3Soq=g+fkoe7nrybhggy4gg...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a675149e87706d01e4007150a0124b89bdef08be Modified Files -- doc/src/sgml/release-18.sgml | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-)
pgsql: Fix typos in comments.
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.gmail.com Backpatch-through: 15 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8209a3a95158d115bf0c0693639879d5549ee3be Modified Files -- src/backend/utils/activity/pgstat_database.c | 4 ++-- src/backend/utils/activity/pgstat_function.c | 4 ++-- src/backend/utils/activity/pgstat_relation.c | 4 ++-- src/backend/utils/activity/pgstat_subscription.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
pgsql: Fix memory allocation/copy mistakes.
Fix memory allocation/copy mistakes. The previous code was allocating more memory and copying more data than necessary because it specified the wrong PgStat_KindInfo member as the size argument for MemoryContextAlloc and memcpy, respectively. Although these issues exist since 5891c7a8e, there have been no reports from the field. So for now, it seems sufficient to fix them in master. Author: Etsuro Fujita Reviewed-by: Heikki Linnakangas Reviewed-by: Gurjeet Singh Discussion: https://postgr.es/m/CAPmGK15eTRCZTnfgQ4EuBNo%3DQLYGFEbXS_7m2dXqtkcT7L8qrQ%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5201bba266d7127397e08a2d954faa5a996c0139 Modified Files -- src/backend/utils/activity/pgstat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
pgsql: Fix typos in comments.
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.gmail.com Backpatch-through: 15 Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ee2486989e7a9d84a530268276e3330b4ea3cc73 Modified Files -- src/backend/utils/activity/pgstat_database.c | 4 ++-- src/backend/utils/activity/pgstat_function.c | 4 ++-- src/backend/utils/activity/pgstat_relation.c | 4 ++-- src/backend/utils/activity/pgstat_subscription.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
pgsql: Fix typos in comments.
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.gmail.com Backpatch-through: 15 Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c8a393537c39077efa20357fa13d136c643cff5a Modified Files -- src/backend/utils/activity/pgstat_database.c | 4 ++-- src/backend/utils/activity/pgstat_function.c | 4 ++-- src/backend/utils/activity/pgstat_relation.c | 4 ++-- src/backend/utils/activity/pgstat_subscription.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
pgsql: Fix typos in comments.
Fix typos in comments. Also adjust the phrasing in the comments. Author: Etsuro Fujita Author: Heikki Linnakangas Reviewed-by: Tender Wang Reviewed-by: Gurjeet Singh Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/CAPmGK17%3DPHSDZ%2B0G6jcj12buyyE1bQQc3sbp1Wxri7tODT-SDw%40mail.gmail.com Backpatch-through: 15 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6e91b9c16ff53fadf75a545aabe5907f1c046d2f Modified Files -- src/backend/utils/activity/pgstat_database.c | 4 ++-- src/backend/utils/activity/pgstat_function.c | 4 ++-- src/backend/utils/activity/pgstat_relation.c | 4 ++-- src/backend/utils/activity/pgstat_subscription.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
