[COMMITTERS] pgsql: Skip recently-added umask() call on Windows.

[Noah Misch]

Skip recently-added umask() call on Windows.

Symbols S_IRWXG and S_IRWXO became available to Windows builds in commit
1319002e2ee166c06b38cdbc5e8508c7205fa115, so PostgreSQL 9.0 cannot use
them in platform-independent code.  Rewrite commit
24aed2124a5273e4cb543b06d4b7bb2c2ad5bf3c to not change Windows builds.
The new umask() call had no effect on Windows, anyway.  Per buildfarm.

Branch
--
REL9_0_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/c69e7d5c78af946b22d46afc60823d20197ca3e3

Modified Files
--
src/bin/pg_dump/pg_backup_tar.c |   27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Teach planstate_tree_walker about custom scans.

[Robert Haas]

Teach planstate_tree_walker about custom scans.

This logic was missing from ExplainPreScanNode, from which I derived
planstate_tree_walker.  But it shouldn't be missing, especially not
from a generic walker function, so add it.

KaiGai Kohei

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/262e56bcae4f529c47ce4fbb8306fd6e26762975

Modified Files
--
src/backend/nodes/nodeFuncs.c |8 
1 file changed, 8 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix sepgsql regression tests (9.2-only patch).

[Joe Conway]

Fix sepgsql regression tests (9.2-only patch).

The regression tests for sepgsql were broken by changes in the
base distro as-shipped policies. Specifically, definition of
unconfined_t in the system default policy was changed to bypass
multi-category rules, which the regression test depended on.
Fix that by defining a custom privileged domain
(sepgsql_regtest_superuser_t) and using it instead of system's
unconfined_t domain. The new sepgsql_regtest_superuser_t domain
performs almost like the current unconfined_t, but restricted by
multi-category policy as the traditional unconfined_t was.

The custom policy module is a self defined domain, and so should not
be affected by related future system policy changes. However, it still
uses the unconfined_u:unconfined_r pair for selinux-user and role.
Those definitions have not been changed for several years and seem
less risky to rely on than the unconfined_t domain. Additionally, if
we define custom user/role, they would need to be manually defined
at the operating system level, adding more complexity to an already
non-standard and complex regression test.

Applies only to 9.2. Unlike the previous similar patch, commit 794e2558b,
this also fixes a bug related to processing SELECT INTO statement.
Because v9.2 didn't have ObjectAccessPostCreate to inform the context
when a relation is newly created, sepgsql had an alternative method.
However, related code in sepgsql_object_access() neglected to consider
T_CreateTableAsStmt, thus no label was assigned on the new relation.
This logic was removed and replaced starting in 9.3.

Patch by Kohei KaiGai.

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/e90a629e126b9459b1f1d8ee8aa8c8598dc36b16

Modified Files
--
contrib/sepgsql/expected/ddl.out   |  208 ++--
contrib/sepgsql/expected/dml.out   |6 +-
contrib/sepgsql/expected/label.out |  106 +-
contrib/sepgsql/hooks.c|1 +
contrib/sepgsql/launcher   |2 +-
contrib/sepgsql/sepgsql-regtest.te |   98 ++---
contrib/sepgsql/sql/ddl.sql|2 +-
contrib/sepgsql/sql/dml.sql|2 +-
contrib/sepgsql/sql/label.sql  |   20 ++--
9 files changed, 255 insertions(+), 190 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Geoff Winkless]

On 22 September 2015 at 21:22, David Steele  wrote:

> I think conversations like this are a part of why we have trouble
> attracting new contributors (of any gender) to the community.
>

​It's very clear that my use of the word (which I shan't make the mistake
of repeating!) is not acceptable to many on this list. I ​apologise
unreservedly to anyone I have unintentionally offended by the use of this
word, I shall not do so again; I would only say in my defence that I was
not intending to characterise all feminists in that way, rather to
distinguish the sort of feminists to whom the fact that a text refers to
"man"​ or "he" is offensive from the sort of feminists who I admire and
respect - those who fight for real equality, who use intelligent argument
and who have affected real change for good in my lifetime.

I can clearly see that my use of language has, ironically enough,
invalidated my argument somewhat. I have said my last on the subject​.

Geoff

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Adam Brightwell]

> I think conversations like this are a part of why we have trouble attracting
> new contributors (of any gender) to the community.

+1


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[David Steele]

On 9/22/15 11:00 AM, Andrew Dunstan wrote:

On 09/22/2015 10:29 AM, Geoff Winkless wrote:

​ That's your opinion; my opinion remains otherwise. It's not
"perfectly reasonable" to abuse the plural because some 1960s
feminazis either misunderstood or didn't like the fact that (because
of history) in English the gender-neutral singular happens to also be
the male singular.


Wow, 1960s feminazis, eh? I originally thought you were just a narrow
minded, pedantic and antiquated grammarian. Now I realize that's the
least of your troubles. Please take your misogyny elsewhere. I hear the
Rabid Puppies have openings.


I think conversations like this are a part of why we have trouble 
attracting new contributors (of any gender) to the community.


--
-David
da...@pgmasters.net


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Mark Dilger]

> On Sep 22, 2015, at 6:09 AM, Andrew Dunstan  wrote:
> 
> You are fighting a losing battle. Think of they/them/their/theirs as being 
> indefinitely gendered third person singular pronouns, as well as being third 
> person plural pronouns. Yes it's a relatively new usage, but I don't think 
> its at all unreasonable (speaking as someone who has been known to dislike 
> some new usages and neologisms). It's not at all sloppy. On the contrary, 
> it's quite deliberate. It's just not quite traditional. You need to get over 
> that.

The use of "their" as singular dates back at least as far as Chaucer in the 
14th century, prior to 
the use of "you" as a singular pronoun.  Militant grammarian schoolteachers may 
have told you
not to use it that way, but that doesn't change the history of its use.

Mark Dilger



-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Peter Geoghegan]

On Tue, Sep 22, 2015 at 7:11 AM, Andrew Dunstan  wrote:
> You can think that if you like, but it's not even remotely true. It's a
> deliberate choice to use a new, perfectly reasonable and now widely accepted
> style of which you disapprove, but it's not lazy.

It never occurred to me that this usage is even non-traditional. I am
a native English speaker born in Ireland in the 1980s.

-- 
Peter Geoghegan


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Andrew Dunstan]

On 09/22/2015 10:29 AM, Geoff Winkless wrote:
Oh, good! We're actually going to have this argument? Even though I 
said I don't care what you do?


On 22 September 2015 at 15:11, Andrew Dunstan > wrote:


On 09/22/2015 09:25 AM, Geoff Winkless wrote:

 If someone sends me a document that uses "their" in a
singular usage, I will think that person is lazy. That will
continue to be the case, whether people tell me that it's
accepted usage or not.


You can think that if you like,


​Thanks!​ That's a great relief to me, as I'm sure you can imagine.

but it's not even remotely true. 



​ You just stated that the reason you don't want to use the plural 
form I suggested is because it's too hard/time-consuming. That does 
suggest you accept that it's a valid solution but you're too lazy to 
use it.​


It's a deliberate choice to use a new, perfectly reasonable and
now widely accepted style of which you disapprove, but it's not lazy.


​ That's your opinion; my opinion remains otherwise. It's not 
"perfectly reasonable" to abuse the plural because some 1960s 
feminazis either misunderstood or didn't like the fact that (because 
of history) in English the gender-neutral singular happens to also be 
the male singular.


Happily for me, I can continue to write documents in a grammatically 
correct way, and no-one will read them and think I'm a grammar-nazi 
(or obstinate, or old-fashioned or whatever) because unless they're 
specifically looking for it no-one will notice that I'm avoiding the 
contentious usage altogether. On the other hand, there _will_ be a 
(perhaps significant) proportion of people who read your documents and 
think that you're incapable of writing a grammatically correct sentence.






Wow, 1960s feminazis, eh? I originally thought you were just a narrow 
minded, pedantic and antiquated grammarian. Now I realize that's the 
least of your troubles. Please take your misogyny elsewhere. I hear the 
Rabid Puppies have openings.


cheers

andrew





--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/b1d5cc375b8786b2ff6293b3f3986c8edf120898

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/d546ce7281c57b2bff3fc8702b88035dbcb0826c

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/a86eab94304a9dee7a2c1504e0051f1959a37b6a

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/f5f9d1b74e9cbf3a19ef947ac36376f73a0c10f5

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/11b44d1cf65bcd59f0a827e1ffab1f1bba1cd1e2

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
REL9_0_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/68e83c12088aa2272ccdd632a37d647ea67548a0

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Docs: fix typo in to_char() example.

[Tom Lane]

Docs: fix typo in to_char() example.

Per bug #13631 from KOIZUMI Satoru.

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/fe6d2ab473fdbe4b9408d8da3e97a5091171c743

Modified Files
--
doc/src/sgml/func.sgml |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Geoff Winkless]

Oh, good! We're actually going to have this argument? Even though I said I
don't care what you do?

On 22 September 2015 at 15:11, Andrew Dunstan  wrote:

> On 09/22/2015 09:25 AM, Geoff Winkless wrote:
>
>>  If someone sends me a document that uses "their" in a singular usage, I
>> will think that person is lazy. That will continue to be the case, whether
>> people tell me that it's accepted usage or not.
>
>
> You can think that if you like,


​Thanks!​ That's a great relief to me, as I'm sure you can imagine.


> but it's not even remotely true.


​You just stated that the reason you don't want to use the plural form I
suggested is because it's too hard/time-consuming. That does suggest you
accept that it's a valid solution but you're too lazy to use it.​


> It's a deliberate choice to use a new, perfectly reasonable and now widely
> accepted style of which you disapprove, but it's not lazy.
>

​That's your opinion; my opinion remains otherwise. It's not "perfectly
reasonable" to abuse the plural because some 1960s feminazis either
misunderstood or didn't like the fact that (because of history) in English
the gender-neutral singular happens to also be the male singular.

Happily for me, I can continue to write documents in a grammatically
correct way, and no-one will read them and think I'm a grammar-nazi (or
obstinate, or old-fashioned or whatever) because unless they're
specifically looking for it no-one will notice that I'm avoiding the
contentious usage altogether. On the other hand, there _will_ be a (perhaps
significant) proportion of people who read your documents and think that
you're incapable of writing a grammatically correct sentence.

Geoff

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Andrew Dunstan]

On 09/22/2015 09:25 AM, Geoff Winkless wrote:
 If someone sends me a document that uses "their" in a singular usage, 
I will think that person is lazy. That will continue to be the case, 
whether people tell me that it's accepted usage or not.



You can think that if you like, but it's not even remotely true. It's a 
deliberate choice to use a new, perfectly reasonable and now widely 
accepted style of which you disapprove, but it's not lazy.



cheers

andrew


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Restrict file mode creation mask during tmpfile().

[Andres Freund]

On 2015-09-21 11:14:10 -0400, Noah Misch wrote:
> On Mon, Sep 21, 2015 at 01:00:46AM +, Noah Misch wrote:
> > Restrict file mode creation mask during tmpfile().
> 
> > REL9_0_STABLE
> 
> This broke buildfarm member frogmouth (Windows, gcc) on this branch only.  I
> will look into it.

Seems to have broken more than just frogmouth. At least baiji,
currawong, narwahl are also affected. Likely a question of 5132ad8b only
being in 9.1+:
andres@alap3:~/src/postgresql$ git branch -r --contains 5132ad8b upstream/REL*
  upstream/REL9_1_STABLE
  upstream/REL9_2_STABLE
  upstream/REL9_3_STABLE
  upstream/REL9_4_STABLE
  upstream/REL9_5_STABLE

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: test_decoding: Protect against rare spurious test failures.

[Andres Freund]

test_decoding: Protect against rare spurious test failures.

A bunch of tests missed specifying that empty transactions shouldn't be
displayed. That causes problems when e.g. autovacuum runs in an
unfortunate moment. The tests in question only run for a very short
time, making this quite unlikely.

Reported-By: Buildfarm member axolotl
Backpatch: 9.4, where logical decoding was introduced

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/55728ea501de5a153e4dc55c21fb4b6f4d0f44c4

Modified Files
--
contrib/test_decoding/expected/binary.out |8 
contrib/test_decoding/sql/binary.sql  |8 
2 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: test_decoding: Protect against rare spurious test failures.

[Andres Freund]

test_decoding: Protect against rare spurious test failures.

A bunch of tests missed specifying that empty transactions shouldn't be
displayed. That causes problems when e.g. autovacuum runs in an
unfortunate moment. The tests in question only run for a very short
time, making this quite unlikely.

Reported-By: Buildfarm member axolotl
Backpatch: 9.4, where logical decoding was introduced

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/a3e58e79a97f26ae20a0520ba98b82478a9d66ef

Modified Files
--
contrib/test_decoding/expected/binary.out |8 
contrib/test_decoding/sql/binary.sql  |8 
2 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: test_decoding: Protect against rare spurious test failures.

[Andres Freund]

test_decoding: Protect against rare spurious test failures.

A bunch of tests missed specifying that empty transactions shouldn't be
displayed. That causes problems when e.g. autovacuum runs in an
unfortunate moment. The tests in question only run for a very short
time, making this quite unlikely.

Reported-By: Buildfarm member axolotl
Backpatch: 9.4, where logical decoding was introduced

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/eef34e523693c15eb4ad7067c96269ab96c87ef5

Modified Files
--
contrib/test_decoding/expected/binary.out |8 
contrib/test_decoding/sql/binary.sql  |8 
2 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Geoff Winkless]

On 22 September 2015 at 14:09, Andrew Dunstan  wrote:

> You are fighting a losing battle. Think of they/them/their/theirs as being
> indefinitely gendered third person singular pronouns, as well as being
> third person plural pronouns. Yes it's a relatively new usage, but I don't
> think its at all unreasonable (speaking as someone who has been known to
> dislike some new usages and neologisms). It's not at all sloppy. On the
> contrary, it's quite deliberate. It's just not quite traditional.
>

​​It _is_ sloppy. It says "I can't be bothered to write a sentence that's
grammatically correct".
​

> You need to get over that.
>

I don't need to get over anything. If someone sends me a document that uses
"their" in a singular usage, I will think that person is lazy. That will
continue to be the case, whether people tell me that it's accepted usage or
not.

In much the same way, I know that I can safely discount the opinion of
anyone who uses "literally" to mean anything other than "literally"
 (
​similarly anyone who uses
"like" as a quotative)
​, even though both of those things are now in fairly common usage.​
​


> Your proposed style would make writing docs a lot harder,
>

I don't buy that at all. It takes a couple of seconds, if that, to come up
with something.


> forcing us to avoid use of the singular in cases where it is quite
> natural.
>

​Better than using the plural in the singular case.
​

> I'm strongly opposed to such a style rule.
>

​Meh. I don't really care how it's written, certainly not enough to make a
stand about it. I'd rather you guys concentrate on writing the brilliant
software than wasting time on stuff like this. I only replied because the
conversation popped up in my inbox and it seemed to be something on which
opinions were requested.

Geoff

Re: [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Andrew Dunstan]

On 09/22/2015 12:32 AM, Erik Rijkers wrote:



-   might not be the same as the database user he needs to connect as.
+   might not be the same as the database user that is to be connect as.


It is not an improvement.  I would like to see this change rolled back.





I agree this is awkward.

I would use "might not be the same as the database user they need to 
connect as." Let's be consistent about the use of they/them/their/theirs 
as indefinitely gendered singular pronouns.


cheers

andrew



--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Andrew Dunstan]

On 09/22/2015 06:17 AM, Geoff Winkless wrote:
On 22 September 2015 at 10:52, Gavin Flower 
>wrote:


On 22/09/15 21:33, Geoff Winkless wrote:

​ ​
Without wanting to get into a grammar war, ​I'm not so sure I
agree that it "condones" it. Dictionaries reflect the current
state of usage, they don't act as arbiters of correctness. The
abuse of "literally" as an emphasiser (which usage is now
listed in the OED) is a prime example.

I would prefer "his or her" over "their". Perhaps our American
cousins might disagree though.

I prefer "their" rather than "his or her", it is less clumsy &
there is no point in specifying gender unless it is relevant!


I agree in that I prefer "their" in informal speech; however in a 
formal document I would find it sloppy.​ I don't think "his or her" is 
inherently clumsy; m

aybe I'm just showing my age.​

Besides, some people are neither, or their biological gender is
ambiguous - so a few people fit into neither the male nor the
female category (depending on precise definitions, about 0.5%)!


My understanding is that most intersex (and certainly all trans) 
people would identify with one or the other, and even those who don't 
select exclusively identify with a mix of both (and would therefore 
still be covered by "his or her", no?) although I don't pretend to be 
an expert.


Perhaps it would be easier to avoid the controversy by actually 
rewording into the plural, where possible?


So

"any user can make such a change for his session."

becomes

"Users can make such a change for their individual sessions"

or similar?





You are fighting a losing battle. Think of they/them/their/theirs as 
being indefinitely gendered third person singular pronouns, as well as 
being third person plural pronouns. Yes it's a relatively new usage, but 
I don't think its at all unreasonable (speaking as someone who has been 
known to dislike some new usages and neologisms). It's not at all 
sloppy. On the contrary, it's quite deliberate. It's just not quite 
traditional. You need to get over that.


Your proposed style would make writing docs a lot harder, forcing us to 
avoid use of the singular in cases where it is quite natural. I'm 
strongly opposed to such a style rule.


cheers

andrew



--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Gavin Flower]

On 22/09/15 22:17, Geoff Winkless wrote:
On 22 September 2015 at 10:52, Gavin Flower 
>wrote:


On 22/09/15 21:33, Geoff Winkless wrote:

​ ​
Without wanting to get into a grammar war, ​I'm not so sure I
agree that it "condones" it. Dictionaries reflect the current
state of usage, they don't act as arbiters of correctness. The
abuse of "literally" as an emphasiser (which usage is now
listed in the OED) is a prime example.

I would prefer "his or her" over "their". Perhaps our American
cousins might disagree though.

I prefer "their" rather than "his or her", it is less clumsy &
there is no point in specifying gender unless it is relevant!


I agree in that I prefer "their" in informal speech; however in a 
formal document I would find it sloppy.​ I don't think "his or her" is 
inherently clumsy; m

aybe I'm just showing my age.​

Besides, some people are neither, or their biological gender is
ambiguous - so a few people fit into neither the male nor the
female category (depending on precise definitions, about 0.5%)!


My understanding is that most intersex (and certainly all trans) 
people would identify with one or the other, and even those who don't 
select exclusively identify with a mix of both (and would therefore 
still be covered by "his or her", no?) although I don't pretend to be 
an expert.


Perhaps it would be easier to avoid the controversy by actually 
rewording into the plural, where possible?


So

"any user can make such a change for his session."

becomes

"Users can make such a change for their individual sessions"

or similar?

Geoff
To me, the key things is NOT to specify gender, unless it is relevant - 
and I don't think gender is relevant in describing how to use a database.


I was using "Gender Appropriate" language long before the Politically 
Correct craze started (over 50 years ago)!  I was told references to 
"he" in rules included females, which I thought was daft!



Cheers,
Gavin


--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Wolfgang Wilhelm]

Hello all,

I'm a non-native speaker and to my shame not very good in english at all. So 
just my 2c on the topic:

"Users can make such a change for their individual sessions" is for me 
perfectly understandable.
"any user can make such a change for their session" is for me a mixture of a 
singular and a plural form and difficult to understand whether this is just a 
spelling error (is it individual sessions?) or just another gap in my 
knowledge. From my point of view the documentation is not just for english 
native speakers but for all the ones which don't have a translation to their 
language and as such one shouldn't look at the newest trends in "correctness".

RegardsWolfgang



 Geoff Winkless  schrieb am 12:18 Dienstag, 
22.September 2015:
   

 On 22 September 2015 at 10:52, Gavin Flower  
wrote:

On 22/09/15 21:33, Geoff Winkless wrote:

​​Without wanting to get into a grammar war, ​I'm not so sure I agree that it 
"condones" it. Dictionaries reflect the current state of usage, they don't act 
as arbiters of correctness. The abuse of "literally" as an emphasiser (which 
usage is now listed in the OED) is a prime example.

I would prefer "his or her" over "their". Perhaps our American cousins might 
disagree though.




I prefer "their" rather than "his or her", it is less clumsy & there is no 
point in specifying gender unless it is relevant!


I agree in that I prefer "their" in informal speech; however in a formal 
document I would find it sloppy.​ I don't think "his or her" is inherently 
clumsy; maybe I'm just showing my age.​

Besides, some people are neither, or their biological gender is ambiguous - so 
a few people fit into neither the male nor the female category (depending on 
precise definitions, about 0.5%)!


My understanding is that most intersex (and certainly all trans) people would 
identify with one or the other, and even those who don't select exclusively 
identify with a mix of both (and would therefore still be covered by "his or 
her", no?) although I don't pretend to be an expert.
Perhaps it would be easier to avoid the controversy by actually rewording into 
the plural, where possible?
So
"any user can make such a change for his session."

becomes
"Users can make such a change for their individual sessions"
or similar?
Geoff

  

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Bill Moran]

On Tue, 22 Sep 2015 11:17:54 +0100
Geoff Winkless  wrote:

> On 22 September 2015 at 10:52, Gavin Flower 
> wrote:
> 
> > On 22/09/15 21:33, Geoff Winkless wrote:
> >> ??
> >> Without wanting to get into a grammar war, ?I'm not so sure I agree that
> >> it "condones" it. Dictionaries reflect the current state of usage, they
> >> don't act as arbiters of correctness. The abuse of "literally" as an
> >> emphasiser (which usage is now listed in the OED) is a prime example.
> >>
> >> I would prefer "his or her" over "their". Perhaps our American cousins
> >> might disagree though.
> >>
> >> I prefer "their" rather than "his or her", it is less clumsy & there is
> > no point in specifying gender unless it is relevant!
> 
> I agree in that I prefer "their" in informal speech; however in a formal
> document I would find it sloppy.? I don't think "his or her" is inherently
> clumsy; m
> aybe I'm just showing my age.?
> 
> Besides, some people are neither, or their biological gender is ambiguous -
> > so a few people fit into neither the male nor the female category
> > (depending on precise definitions, about 0.5%)!
> 
> My understanding is that most intersex (and certainly all trans) people
> would identify with one or the other, and even those who don't select
> exclusively identify with a mix of both (and would therefore still be
> covered by "his or her", no?) although I don't pretend to be an expert.
> 
> Perhaps it would be easier to avoid the controversy by actually rewording
> into the plural, where possible?
> 
> So
> 
> "any user can make such a change for his session."
> 
> becomes
> 
> "Users can make such a change for their individual sessions"
> 
> or similar?

+1

As an American/native English speaker, I find the use of the plural pronoun
in combination with a singular noun (which is not grammatically correct)
in formal writing to be sloppy and jarring to read. The change you suggest
above reads more professionally while still avoiding offending anyone.

-- 
Bill Moran


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Geoff Winkless]

On 22 September 2015 at 10:52, Gavin Flower 
wrote:

> On 22/09/15 21:33, Geoff Winkless wrote:
>
>> ​​
>> Without wanting to get into a grammar war, ​I'm not so sure I agree that
>> it "condones" it. Dictionaries reflect the current state of usage, they
>> don't act as arbiters of correctness. The abuse of "literally" as an
>> emphasiser (which usage is now listed in the OED) is a prime example.
>>
>> I would prefer "his or her" over "their". Perhaps our American cousins
>> might disagree though.
>>
>> I prefer "their" rather than "his or her", it is less clumsy & there is
> no point in specifying gender unless it is relevant!
>

I agree in that I prefer "their" in informal speech; however in a formal
document I would find it sloppy.​ I don't think "his or her" is inherently
clumsy; m
aybe I'm just showing my age.​

Besides, some people are neither, or their biological gender is ambiguous -
> so a few people fit into neither the male nor the female category
> (depending on precise definitions, about 0.5%)!
>

My understanding is that most intersex (and certainly all trans) people
would identify with one or the other, and even those who don't select
exclusively identify with a mix of both (and would therefore still be
covered by "his or her", no?) although I don't pretend to be an expert.

Perhaps it would be easier to avoid the controversy by actually rewording
into the plural, where possible?

So

"any user can make such a change for his session."

becomes

"Users can make such a change for their individual sessions"

or similar?

Geoff

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Gavin Flower]

On 22/09/15 21:33, Geoff Winkless wrote:
On 22 September 2015 at 09:28, Albe Laurenz >wrote:


Peter Geoghegan wrote:
> On Mon, Sep 21, 2015 at 9:32 PM, Erik Rijkers mailto:e...@xs4all.nl>> wrote:
>> I think this compulsive 'he'-avoiding is making the text worse.
>>
>>
>> -  environment variable); any user can make such a change
for his session.
>> +  environment variable); any user can make such a change
for their session.
>
> -1. It seems fine to me.

(Disclaimer: I am not a native speaker.)

Using the pronoun of the third person plural as a replacement for
"his or her"
has become widely used, at least in the U.S., and the OED condones
that use:
http://www.oxforddictionaries.com/definition/english/they


Without wanting to get into a grammar war, ​I'm not so sure I agree 
that it "condones" it. Dictionaries reflect the current state of 
usage, they don't act as arbiters of correctness. The abuse of 
"literally" as an emphasiser (which usage is now listed in the OED) is 
a prime example.


As an Englishman ​I would prefer "his or her" over "their". Perhaps 
our American cousins might disagree though.


WRT the second, it probably doesn't help that "might not be the same 
as the database user that is to be connect as" is incorrect anyway - 
it should perhaps be "that is to be connect*ed *as" (although I still 
find the construction clumsy).


Geoff

I am an Englishman.

I prefer "their" rather than "his or her", it is less clumsy & there is 
no point in specifying gender unless it is relevant!


Besides, some people are neither, or their biological gender is 
ambiguous - so a few people fit into neither the male nor the female 
category (depending on precise definitions, about 0.5%)!



Cheers,
Gavin



--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Geoff Winkless]

On 22 September 2015 at 09:28, Albe Laurenz  wrote:

> Peter Geoghegan wrote:
> > On Mon, Sep 21, 2015 at 9:32 PM, Erik Rijkers  wrote:
> >> I think this compulsive 'he'-avoiding is making the text worse.
> >>
> >>
> >> -  environment variable); any user can make such a change for his
> session.
> >> +  environment variable); any user can make such a change for their
> session.
> >
> > -1. It seems fine to me.
>
> (Disclaimer: I am not a native speaker.)
>
> Using the pronoun of the third person plural as a replacement for "his or
> her"
> has become widely used, at least in the U.S., and the OED condones that
> use:
> http://www.oxforddictionaries.com/definition/english/they
>
>
Without wanting to get into a grammar war, ​I'm not so sure I agree that it
"condones" it. Dictionaries reflect the current state of usage, they don't
act as arbiters of correctness. The abuse of "literally" as an emphasiser
(which usage is now listed in the OED) is a prime example.

As an Englishman ​I would prefer "his or her" over "their". Perhaps our
American cousins might disagree though.

WRT the second, it probably doesn't help that "might not be the same as the
database user that is to be connect as" is incorrect anyway - it should
perhaps be "that is to be connect*ed *as" (although I still find the
construction clumsy).

Geoff

[COMMITTERS] pgsql: Correct value of LW_SHARED_MASK.

[Andres Freund]

Correct value of LW_SHARED_MASK.

The previous wrong value lead to wrong LOCK_DEBUG output, never showing
any shared lock holders.

Reported-By: Alexander Korotkov
Discussion: CAPpHfdsPmWqz9FB0AnxJrwp1=KLF0n=-ib+qvr0q8gsmpfv...@mail.gmail.com
Backpatch: 9.5, where the bug was introduced.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/98d5b084d23b0304569ef2c1b4794754166cf0a5

Modified Files
--
src/backend/storage/lmgr/lwlock.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Correct value of LW_SHARED_MASK.

[Andres Freund]

Correct value of LW_SHARED_MASK.

The previous wrong value lead to wrong LOCK_DEBUG output, never showing
any shared lock holders.

Reported-By: Alexander Korotkov
Discussion: CAPpHfdsPmWqz9FB0AnxJrwp1=KLF0n=-ib+qvr0q8gsmpfv...@mail.gmail.com
Backpatch: 9.5, where the bug was introduced.

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/62e503b0c29bbb9e0ac7ebce6990bf3c7c3c9a89

Modified Files
--
src/backend/storage/lmgr/lwlock.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Add some notes about coding conventions do the docs.

[Andres Freund]

Add some notes about coding conventions do the docs.

This deserves to be greatly expanded and improved, but it's a start.

Discussion: 20150827145219.gi2...@awork2.anarazel.de

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/d9cb34abb40c547325dbf24e8986698dffc9ffa8

Modified Files
--
doc/src/sgml/sources.sgml |  105 +
1 file changed, 105 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [HACKERS] [COMMITTERS] pgsql: Use gender-neutral language in documentation

[Albe Laurenz]

Peter Geoghegan wrote:
> On Mon, Sep 21, 2015 at 9:32 PM, Erik Rijkers  wrote:
>> I think this compulsive 'he'-avoiding is making the text worse.
>>
>>
>> -  environment variable); any user can make such a change for his 
>> session.
>> +  environment variable); any user can make such a change for their 
>> session.
> 
> -1. It seems fine to me.

(Disclaimer: I am not a native speaker.)

Using the pronoun of the third person plural as a replacement for "his or her"
has become widely used, at least in the U.S., and the OED condones that use:
http://www.oxforddictionaries.com/definition/english/they

Do we want to have that everywhere?

Yours,
Laurenz Albe 

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers