[COMMITTERS] pgsql: Fix comments

[Peter Eisentraut]

Fix comments

Some of these comments were copied and pasted without updating them,
some of them were duplicates.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/cc074bf6c1a5305a5e23067c6d9a377840add303

Modified Files
--
src/backend/utils/mb/Unicode/UCS_to_EUC_CN.pl | 6 +-
src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl | 4 
src/backend/utils/mb/Unicode/UCS_to_EUC_KR.pl | 6 +-
src/backend/utils/mb/Unicode/UCS_to_EUC_TW.pl | 6 +-
src/backend/utils/mb/Unicode/UCS_to_SJIS.pl   | 4 
5 files changed, 3 insertions(+), 23 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: UCS_to_most.pl: Make executable, for consistency with other scri

[Peter Eisentraut]

UCS_to_most.pl: Make executable, for consistency with other scripts

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9a3e06baa2e42a5018dcd6afda31255b4e772518

Modified Files
--
src/backend/utils/mb/Unicode/UCS_to_most.pl | 0
1 file changed, 0 insertions(+), 0 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Add Unicode map generation scripts as rule prerequisites

[Peter Eisentraut]

Add Unicode map generation scripts as rule prerequisites

That way, the rules will trigger when the scripts change.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/bd6cf3f237c9aeb4dad1ac3ec2008c5768fe4c1b

Modified Files
--
src/backend/utils/mb/Unicode/Makefile | 32 
1 file changed, 16 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Suppress scary-looking log messages from async-notify isolation

[Tom Lane]

Suppress scary-looking log messages from async-notify isolation test.

I noticed that the async-notify test results in log messages like these:

LOG:  could not send data to client: Broken pipe
FATAL:  connection to client lost

This is because it unceremoniously disconnects a client session that is
about to have some NOTIFY messages delivered to it.  Such log messages
during a regression test might well cause people to go looking for a
problem that doesn't really exist (it did cause me to waste some time that
way).  We can shut it up by adding an UNLISTEN command to session teardown.

Patch HEAD only; this doesn't seem significant enough to back-patch.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3d523564c53ab8f35edf4d20627f0a375a17624d

Modified Files
--
src/test/isolation/specs/async-notify.spec | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

[Tom Lane]

Improve error message for rejecting RETURNING clauses with dropped columns.

This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns.  Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work.  Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it.  Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.

Discussion: 1456176604.17219.9.ca...@jordogskog.no

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/8d8ff5f7db7d58240fac7d5f620308c91485b253

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

[Tom Lane]

Improve error message for rejecting RETURNING clauses with dropped columns.

This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns.  Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work.  Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it.  Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.

Discussion: 1456176604.17219.9.ca...@jordogskog.no

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/f32b8bc9e0e0e3096bcdae15f9946b39851e10f9

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

[Tom Lane]

Improve error message for rejecting RETURNING clauses with dropped columns.

This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns.  Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work.  Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it.  Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.

Discussion: 1456176604.17219.9.ca...@jordogskog.no

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/ff4527408c0d469d2c2b0134940cc51191ff5965

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

[Tom Lane]

Improve error message for rejecting RETURNING clauses with dropped columns.

This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns.  Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work.  Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it.  Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.

Discussion: 1456176604.17219.9.ca...@jordogskog.no

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/55965eb7d2f28d9325e80b7dd6f593bb22aa29b9

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

[Tom Lane]

Improve error message for rejecting RETURNING clauses with dropped columns.

This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns.  Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work.  Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it.  Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.

Discussion: 1456176604.17219.9.ca...@jordogskog.no

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/dcba544dd5f76974ea273cd689ab9ff41a22af1e

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Improve error message for rejecting RETURNING clauses with dropp

[Tom Lane]

Improve error message for rejecting RETURNING clauses with dropped columns.

This error message was written with only ON SELECT rules in mind, but since
then we also made RETURNING-clause targetlists go through the same logic.
This means that you got a rather off-topic error message if you tried to
add a rule with RETURNING to a table having dropped columns.  Ideally we'd
just support that, but some preliminary investigation says that it might be
a significant amount of work.  Seeing that Nicklas Avén's complaint is the
first one we've gotten about this in the ten years or so that the code's
been like that, I'm unwilling to put much time into it.  Instead, improve
the error report by issuing a different message for RETURNING cases, and
revise the associated comment based on this investigation.

Discussion: 1456176604.17219.9.ca...@jordogskog.no

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/ca778d01e7f0f216bf2a8b0f45952c4c3ef5321a

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Minor tweaks for new src/test/recovery

[Alvaro Herrera]

Minor tweaks for new src/test/recovery

Author: Michael Paquier

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5847397deca66fb4a4b3d2e0dcb3414dd5c4e180

Modified Files
--
doc/src/sgml/install-windows.sgml  | 7 ---
src/test/README| 3 +++
src/test/recovery/.gitignore   | 1 -
src/test/recovery/Makefile | 3 +++
src/test/recovery/README   | 6 +-
src/test/recovery/t/002_archiving.pl   | 2 +-
src/test/recovery/t/004_timeline_switch.pl | 2 +-
src/tools/msvc/clean.bat   | 1 +
8 files changed, 14 insertions(+), 11 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typos

[Alvaro Herrera]

Fix typos

Author: Amit Langote

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/4ef26fff7b0e8e5b786887387bfa0ed67ea0ad29

Modified Files
--
src/backend/replication/syncrep.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typos

[Alvaro Herrera]

Fix typos

Author: Amit Langote

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/10b4852215a37915e55f034f919a6dc8bc72e988

Modified Files
--
src/backend/replication/syncrep.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typos

[Alvaro Herrera]

Fix typos

Author: Amit Langote

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0a3070baf3c48def1f7c46f57a6313adc26be4fa

Modified Files
--
src/backend/replication/syncrep.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typos

[Alvaro Herrera]

Fix typos

Author: Amit Langote

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/9ca3789191f80c6e6ac01c12171d4fba4c95f55d

Modified Files
--
src/backend/replication/syncrep.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typos

[Alvaro Herrera]

Fix typos

Author: Amit Langote

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0bd51dee6e9c15f9283224cb0a475c20b7ef3e86

Modified Files
--
src/backend/replication/syncrep.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typos

[Alvaro Herrera]

Fix typos

Author: Amit Langote

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/36d43f05109e944f431e85ff559727c411ab7089

Modified Files
--
src/backend/replication/syncrep.c | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

[Alvaro Herrera]

doc: document MANPATH as /usr/local/pgsql/share/man

The docs were advising to use /usr/local/pgsql/man instead, but that's
wrong.

Reported-By: Slawomir Sudnik
Backpatch-To: 9.1
Bug: #13894

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/6f3f50ad4a304b5617275b5c8592a2a3abb129b2

Modified Files
--
doc/src/sgml/installation.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

[Alvaro Herrera]

doc: document MANPATH as /usr/local/pgsql/share/man

The docs were advising to use /usr/local/pgsql/man instead, but that's
wrong.

Reported-By: Slawomir Sudnik
Backpatch-To: 9.1
Bug: #13894

Branch
--
REL9_1_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/397d247bac480c2ea7689b057bc9eb3ab49c87a5

Modified Files
--
doc/src/sgml/installation.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

[Alvaro Herrera]

doc: document MANPATH as /usr/local/pgsql/share/man

The docs were advising to use /usr/local/pgsql/man instead, but that's
wrong.

Reported-By: Slawomir Sudnik
Backpatch-To: 9.1
Bug: #13894

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/6fdc6262ca188ad7f4c7a9857e28684328a9869b

Modified Files
--
doc/src/sgml/installation.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

[Alvaro Herrera]

doc: document MANPATH as /usr/local/pgsql/share/man

The docs were advising to use /usr/local/pgsql/man instead, but that's
wrong.

Reported-By: Slawomir Sudnik
Backpatch-To: 9.1
Bug: #13894

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/8504ec929de7eb9ac49a019194f6ec2788caabba

Modified Files
--
doc/src/sgml/installation.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: document MANPATH as /usr/local/pgsql/share/man

[Alvaro Herrera]

doc: document MANPATH as /usr/local/pgsql/share/man

The docs were advising to use /usr/local/pgsql/man instead, but that's
wrong.

Reported-By: Slawomir Sudnik
Backpatch-To: 9.1
Bug: #13894

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/1c7c189fc1961f890bc06d6adb6bdfc739f5f927

Modified Files
--
doc/src/sgml/installation.sgml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Make new isolationtester test more stable

[Alvaro Herrera]

Make new isolationtester test more stable

The original coding of the test was relying too much on the ordering in
which backends are awakened once an advisory lock which they wait for is
released.  Change the code so that each backend uses its own advisory
lock instead, so that the output becomes stable.  Also add a few seconds
of sleep between lock releases, so that the test isn't broken in
overloaded buildfarm animals, as suggested by Tom Lane.

Per buildfarm members spoonbill and guaibasaurus.

Discussion: 
https://www.postgresql.org/message-id/19294.1456551587%40sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/54638f5708e59e5fd7c79b8315d8c6e810d7bc13

Modified Files
--
src/test/isolation/expected/tuplelock-update.out | 26 +---
src/test/isolation/specs/tuplelock-update.spec   | 16 ++-
2 files changed, 30 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

[Tom Lane]

Alvaro Herrera  writes:
> Tom Lane wrote:
>> guaibasaurus is not a particularly slow machine, and it's not using any
>> special build flags AFAICT.  So I'm not sure what to make of this case,
>> except that it proves the timing problem can manifest on normal builds.

> Hmm, I suppose I could fix this by using three different advisory locks
> rather than a single one.  (My assumption is that the timing dependency
> is the order in which the backends are awakened when the advisory lock
> is released.)  I would release the locks one by one rather than all
> together.

Sounds plausible.  You would probably need several seconds' pg_sleep() in
between the lock releases to ensure that even on slow/overloaded machines,
there's enough time for all wakened backends to do what they're supposed
to do.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

[Alvaro Herrera]

Tom Lane wrote:
> I wrote:
> > Alvaro Herrera  writes:
> >> Add isolationtester spec for old heapam.c bug
> 
> > Hmmm 
> 
> > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spoonbill=2016-02-27%2000%3A00%3A06
> 
> > This failure looks a lot like the timing-related problems I was chasing
> > last week with deadlock-hard on the CLOBBER_CACHE_ALWAYS critters.
> > spoonbill isn't CLOBBER_CACHE_ALWAYS, but it uses some weird malloc debug
> > stuff that slows it down by similar orders of magnitude.  You seem to need
> > to think about how to make this test less timing-dependent.
> 
> The plot thickens:
> 
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus=2016-02-29%2016%3A17%3A01
> 
> guaibasaurus is not a particularly slow machine, and it's not using any
> special build flags AFAICT.  So I'm not sure what to make of this case,
> except that it proves the timing problem can manifest on normal builds.

Hmm, I suppose I could fix this by using three different advisory locks
rather than a single one.  (My assumption is that the timing dependency
is the order in which the backends are awakened when the advisory lock
is released.)  I would release the locks one by one rather than all
together.

-- 
Álvaro Herrerahttp://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Add isolationtester spec for old heapam.c bug

[Tom Lane]

I wrote:
> Alvaro Herrera  writes:
>> Add isolationtester spec for old heapam.c bug

> Hmmm 

> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spoonbill=2016-02-27%2000%3A00%3A06

> This failure looks a lot like the timing-related problems I was chasing
> last week with deadlock-hard on the CLOBBER_CACHE_ALWAYS critters.
> spoonbill isn't CLOBBER_CACHE_ALWAYS, but it uses some weird malloc debug
> stuff that slows it down by similar orders of magnitude.  You seem to need
> to think about how to make this test less timing-dependent.

The plot thickens:

http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=guaibasaurus=2016-02-29%2016%3A17%3A01

guaibasaurus is not a particularly slow machine, and it's not using any
special build flags AFAICT.  So I'm not sure what to make of this case,
except that it proves the timing problem can manifest on normal builds.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Remove useless unary plus.

[Tom Lane]

Remove useless unary plus.

It's harmless, but might confuse readers.  Seems to have been introduced
in 6bc8ef0b7f1f1df3.  Back-patch, just to avoid cosmetic cross-branch
differences.

Amit Langote

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/28d65f99e21429b7138d8dddcc2b6217ae0e6763

Modified Files
--
src/backend/utils/init/postinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Remove useless unary plus.

[Tom Lane]

Remove useless unary plus.

It's harmless, but might confuse readers.  Seems to have been introduced
in 6bc8ef0b7f1f1df3.  Back-patch, just to avoid cosmetic cross-branch
differences.

Amit Langote

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c110678a47aac87c661785a70061e160cd17713d

Modified Files
--
src/backend/utils/init/postinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Remove useless unary plus.

[Tom Lane]

Remove useless unary plus.

It's harmless, but might confuse readers.  Seems to have been introduced
in 6bc8ef0b7f1f1df3.  Back-patch, just to avoid cosmetic cross-branch
differences.

Amit Langote

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/0a20d07ea6558484b51e57cbcab11f97180a3dee

Modified Files
--
src/backend/utils/init/postinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix build under OPTIMIZER_DEBUG.

[Tom Lane]

Fix build under OPTIMIZER_DEBUG.

In commit 19a541143a09c067 I replaced RelOptInfo.width with
RelOptInfo.reltarget.width, but I missed updating debug_print_rel()
for that because it's not compiled by default.
Reported by Salvador Fandino, patch by Michael Paquier.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/05893712cc9950b7c4c312aa9d3d444375bf15a2

Modified Files
--
src/backend/optimizer/path/allpaths.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix incorrect varlevelsup in security_barrier_replace_vars().

[Dean Rasheed]

Fix incorrect varlevelsup in security_barrier_replace_vars().

When converting an RTE with securityQuals into a security barrier
subquery RTE, ensure that the Vars in the new subquery's targetlist
all have varlevelsup = 0 so that they correctly refer to the
underlying base relation being wrapped.

The original code was creating new Vars by copying them from existing
Vars referencing the base relation found elsewhere in the query, but
failed to account for the fact that such Vars could come from sublink
subqueries, and hence have varlevelsup > 0. In practice it looks like
this could only happen with nested security barrier views, where the
outer view has a WHERE clause containing a correlated subquery, due to
the order in which the Vars are processed.

Bug: #13988
Reported-by: Adam Guthrie
Backpatch-to: 9.4, where updatable SB views were introduced

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/41fedc24626696fdf55d0c43131d91757dbe1c66

Modified Files
--
src/backend/optimizer/prep/prepsecurity.c |  1 +
src/test/regress/expected/updatable_views.out | 39 +++
src/test/regress/sql/updatable_views.sql  | 34 +++
3 files changed, 74 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix incorrect varlevelsup in security_barrier_replace_vars().

[Dean Rasheed]

Fix incorrect varlevelsup in security_barrier_replace_vars().

When converting an RTE with securityQuals into a security barrier
subquery RTE, ensure that the Vars in the new subquery's targetlist
all have varlevelsup = 0 so that they correctly refer to the
underlying base relation being wrapped.

The original code was creating new Vars by copying them from existing
Vars referencing the base relation found elsewhere in the query, but
failed to account for the fact that such Vars could come from sublink
subqueries, and hence have varlevelsup > 0. In practice it looks like
this could only happen with nested security barrier views, where the
outer view has a WHERE clause containing a correlated subquery, due to
the order in which the Vars are processed.

Bug: #13988
Reported-by: Adam Guthrie
Backpatch-to: 9.4, where updatable SB views were introduced

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/9b69d5c1daeb62804eeaeab2f804191dbe0a943d

Modified Files
--
src/backend/optimizer/prep/prepsecurity.c |  1 +
src/test/regress/expected/updatable_views.out | 39 +++
src/test/regress/sql/updatable_views.sql  | 34 +++
3 files changed, 74 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers