[COMMITTERS] pgsql: Handle ALTER EXTENSION ADD/DROP with pg_init_privs
Handle ALTER EXTENSION ADD/DROP with pg_init_privs In commit 6c268df, pg_init_privs was added to track the initial privileges of catalog objects and extensions. Unfortunately, that commit didn't include understanding of ALTER EXTENSION ADD/DROP, which allows the objects associated with an extension to be changed after the initial CREATE EXTENSION script has been run. The result of this meant that ACLs for objects added through ALTER EXTENSION ADD were not recorded into pg_init_privs and we would end up including those ACLs in pg_dump when we shouldn't have. This commit corrects that by making sure to have pg_init_privs updated when ALTER EXTENSION ADD/DROP is run, recording the permissions as they are at ALTER EXTENSION ADD time, and removing any if/when ALTER EXTENSION DROP is called. This issue was pointed out by Moshe Jacobson as commentary on bug #14456 (which was actually a bug about versions prior to 9.6 not handling custom ACLs on extensions correctly, an issue now addressed with pg_init_privs in 9.6). Back-patch to 9.6 where pg_init_privs was introduced. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e54f75722c720b596ec5e72154cc899da199de5b Modified Files -- src/backend/catalog/aclchk.c | 436 +++-- src/backend/commands/extension.c | 21 + src/include/utils/acl.h| 4 + .../modules/test_pg_dump/expected/test_pg_dump.out | 100 - src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 108 - src/test/modules/test_pg_dump/t/001_base.pl| 92 + 6 files changed, 732 insertions(+), 29 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Handle ALTER EXTENSION ADD/DROP with pg_init_privs
Handle ALTER EXTENSION ADD/DROP with pg_init_privs In commit 6c268df, pg_init_privs was added to track the initial privileges of catalog objects and extensions. Unfortunately, that commit didn't include understanding of ALTER EXTENSION ADD/DROP, which allows the objects associated with an extension to be changed after the initial CREATE EXTENSION script has been run. The result of this meant that ACLs for objects added through ALTER EXTENSION ADD were not recorded into pg_init_privs and we would end up including those ACLs in pg_dump when we shouldn't have. This commit corrects that by making sure to have pg_init_privs updated when ALTER EXTENSION ADD/DROP is run, recording the permissions as they are at ALTER EXTENSION ADD time, and removing any if/when ALTER EXTENSION DROP is called. This issue was pointed out by Moshe Jacobson as commentary on bug #14456 (which was actually a bug about versions prior to 9.6 not handling custom ACLs on extensions correctly, an issue now addressed with pg_init_privs in 9.6). Back-patch to 9.6 where pg_init_privs was introduced. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/20064c0ec201fd2302757c1fdb2279e9dc9a4030 Modified Files -- src/backend/catalog/aclchk.c | 436 +++-- src/backend/commands/extension.c | 21 + src/include/utils/acl.h| 4 + .../modules/test_pg_dump/expected/test_pg_dump.out | 100 - src/test/modules/test_pg_dump/sql/test_pg_dump.sql | 108 - src/test/modules/test_pg_dump/t/001_base.pl| 92 + 6 files changed, 732 insertions(+), 29 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup
test_pg_dump TAP test whitespace cleanup The formatting of the perl hashes used in the TAP tests for test_pg_dump was rather horribly inconsistent and made it more difficult than it really should have been to add new tests or adjust what tests are for what runs, etc. Reformat to clean that all up. Whitespace-only changes. Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/73cd4896f41052bdaf779fa1b63aca5f10c56a62 Modified Files -- src/test/modules/test_pg_dump/t/001_base.pl | 784 1 file changed, 462 insertions(+), 322 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup
test_pg_dump TAP test whitespace cleanup The formatting of the perl hashes used in the TAP tests for test_pg_dump was rather horribly inconsistent and made it more difficult than it really should have been to add new tests or adjust what tests are for what runs, etc. Reformat to clean that all up. Whitespace-only changes. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/fb94ca77f1400e236b00d432dccfbe4f1124971c Modified Files -- src/test/modules/test_pg_dump/t/001_base.pl | 784 1 file changed, 462 insertions(+), 322 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
