Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

2017-03-09 Thread Tom Lane 
Andres Freund  writes:
> On 2017-03-10 03:55:50 +, Tom Lane wrote:
>> contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

> Heh, I just wanted to push a patch removing the assertion because it
> doesn't add that much.  There's imo no reason not to mark the variable
> PGDLLIMPORT, so I'm good with this too.

Oh, I hadn't looked closely enough to notice that the only reference
there was

Assert(TransactionIdIsValid(RecentGlobalXmin));

I agree: that is just about utterly useless.  Let's revert my patch
and remove that Assert.  I'm not eager to encourage people to reference
the xmin globals if we don't have to.

regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix hard-coded relkind constants in assorted other files.

2017-03-09 Thread Tom Lane 
Fix hard-coded relkind constants in assorted other files.

Although it's reasonable to expect that most of these constants will
never change, that does not make it good programming style to hard-code
the value rather than using the RELKIND_FOO macros.

I think I've now gotten all the hard-coded references in C code.
Unfortunately there's no equally convenient way to parameterize
SQL files ...

Discussion: https://postgr.es/m/11145.1488931...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9c2635e26f6f4e34b3b606c0fc79d0e111953a74

Modified Files
--
contrib/oid2name/oid2name.c   | 17 -
contrib/postgres_fdw/postgres_fdw.c   |  7 ++-
contrib/vacuumlo/vacuumlo.c   |  4 +++-
src/backend/utils/adt/xml.c   | 17 +++--
src/tools/findoidjoins/findoidjoins.c | 20 
5 files changed, 48 insertions(+), 17 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: amcheck: editorialize variable name & comment.

2017-03-09 Thread Andres Freund 
amcheck: editorialize variable name & comment.

No exclusive lock is taken anymore...

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/fcd8d25d38b5f42ec4ae77a673813c2dc279ccf7

Modified Files
--
contrib/amcheck/verify_nbtree.c | 77 -
1 file changed, 38 insertions(+), 39 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

2017-03-09 Thread Andres Freund 
On 2017-03-10 03:55:50 +, Tom Lane wrote:
> contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.
> 
> Per buildfarm.  Maybe some of the other xmin variables in snapmgr.h
> ought to get this too, but for the moment I'm just interested in
> un-breaking the buildfarm.

Heh, I just wanted to push a patch removing the assertion because it
doesn't add that much.  There's imo no reason not to mark the variable
PGDLLIMPORT, so I'm good with this too.

- Andres


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

2017-03-09 Thread Tom Lane 
contrib/amcheck needs RecentGlobalXmin to be PGDLLIMPORT'ified.

Per buildfarm.  Maybe some of the other xmin variables in snapmgr.h
ought to get this too, but for the moment I'm just interested in
un-breaking the buildfarm.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/56018bf26eec1a0b4bf20303c98065a8eb1b0c5d

Modified Files
--
src/include/utils/snapmgr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Add .gitignore to contrib/amcheck.

2017-03-09 Thread Tom Lane 
Add .gitignore to contrib/amcheck.

Oversight in commit 3717dc149.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/574268e37b3b7b3449eb0034013443d88f4bd320

Modified Files
--
contrib/amcheck/.gitignore | 4 
1 file changed, 4 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix hard-coded relkind constants in assorted src/bin files.

2017-03-09 Thread Tom Lane 
Fix hard-coded relkind constants in assorted src/bin files.

Although it's reasonable to expect that most of these constants will
never change, that does not make it good programming style to hard-code
the value rather than using the RELKIND_FOO macros.

Discussion: https://postgr.es/m/11145.1488931...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/fcd778eb703c154c0fbba249e17c21b7ae4de19b

Modified Files
--
src/bin/initdb/initdb.c | 17 
src/bin/pg_dump/pg_dump_sort.c  | 14 +++--
src/bin/pg_upgrade/info.c   |  4 +++-
src/bin/pg_upgrade/pg_upgrade.c | 11 --
src/bin/pg_upgrade/version.c|  7 ++-
src/bin/psql/command.c  |  5 +++--
src/bin/psql/tab-complete.c | 45 -
src/bin/scripts/vacuumdb.c  | 10 +++--
8 files changed, 81 insertions(+), 32 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Fix pgbench's failure to honor the documented long-form option "

2017-03-09 Thread Alvaro Herrera 
Fabien COELHO wrote:
> 
> > Not only did it not accept --builtin as a synonym for -b, but what it did
> > accept as a synonym was --tpc-b (huh?), which it got even further wrong
> > by marking as no_argument, so that if you did try that you got a core
> > dump.  I suppose this is leftover from some early design for the new
> > switches added by commit 8bea3d221, but it's still pretty sloppy work.
> 
> Argh, shame on me. I think at some point --tpc-b was an alias for the
> default script which then got replaced by builtin + name, but the
> implementation did not follow the upgrade:-( Sorry for the result.

Ouch, this is terrible.  I was so focused on the actual feature that I
forgot to verify that the UI was sane.  I know I only tested using -b ...

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Create INSTALL file via XSLT

2017-03-09 Thread Peter Eisentraut 
On 3/8/17 09:38, Tom Lane wrote:
> Peter Eisentraut  writes:
>> Replacing jade with xsltproc removes jade from the requirements for
>> distribution building.
> 
> If we no longer need jade, surely we should remove the configure
> infrastructure for finding it, as well as the assorted mentions of
> it in docguide.sgml and elsewhere.

Yeah, that should be cleaned up before the release.  Right now, we're
still supporting it for PDF builds and "oldhtml".  oldhtml should go
away before the release, too.


-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix portability problem in Catalog.pm.

2017-03-09 Thread Tom Lane 
Fix portability problem in Catalog.pm.

Commit 7666e73a2 introduced a dependency on filehandles' input_line_number
method, but apparently that's a Perl neologism.  Use $. instead, which
works at least back to Perl 5.10, and hopefully back to 5.8.

Jeff Janes

Discussion: 
https://postgr.es/m/CAMkU=1wuQW=xvfu-14a4vcvxo0ohkd3m9vk6hoj_dprqokn...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/15bb93e28e49fdf4f28d509c07d1527886acb3e2

Modified Files
--
src/backend/catalog/Catalog.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix hard-coded relkind constants in psql/describe.c.

2017-03-09 Thread Tom Lane 
Fix hard-coded relkind constants in psql/describe.c.

Although it's reasonable to expect that most of these constants will
never change, that does not make it good programming style to hard-code
the value rather than using the RELKIND_FOO macros.

Discussion: https://postgr.es/m/11145.1488931...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/395bfaae8e786eb17fc9dd79e4636f97c9d9b820

Modified Files
--
src/bin/psql/describe.c | 203 
1 file changed, 120 insertions(+), 83 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: pgstattuple: Fix typo partitiond -> partitioned

2017-03-09 Thread Stephen Frost 
pgstattuple: Fix typo partitiond -> partitioned

Pointed out by Michael Paquier

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/90e91e242fe99582b6d2dc18177e79d99c91695d

Modified Files
--
contrib/pgstattuple/expected/pgstattuple.out | 2 +-
contrib/pgstattuple/sql/pgstattuple.sql  | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Add amcheck extension to contrib.

2017-03-09 Thread Andres Freund 
Add amcheck extension to contrib.

This is the beginning of a collection of SQL-callable functions to
verify the integrity of data files.  For now it only contains code to
verify B-Tree indexes.

This adds two SQL-callable functions, validating B-Tree consistency to
a varying degree.  Check the, extensive, docs for details.

The goal is to later extend the coverage of the module to further
access methods, possibly including the heap.  Once checks for
additional access methods exist, we'll likely add some "dispatch"
functions that cover multiple access methods.

Author: Peter Geoghegan, editorialized by Andres Freund
Reviewed-By: Andres Freund, Tomas Vondra, Thomas Munro,
   Anastasia Lubennikova, Robert Haas, Amit Langote
Discussion: cam3swzqzlmhmwmbqjzk+prkxrnuz4w90wymuwfkev8mz3de...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/3717dc149ecf44b8be95350a68605ba7299474fd

Modified Files
--
contrib/Makefile |1 +
contrib/amcheck/Makefile |   21 +
contrib/amcheck/amcheck--1.0.sql |   24 +
contrib/amcheck/amcheck.control  |5 +
contrib/amcheck/expected/check.out   |1 +
contrib/amcheck/expected/check_btree.out |   90 +++
contrib/amcheck/sql/check.sql|1 +
contrib/amcheck/sql/check_btree.sql  |   59 ++
contrib/amcheck/verify_nbtree.c  | 1249 ++
doc/src/sgml/amcheck.sgml|  273 +++
doc/src/sgml/contrib.sgml|1 +
doc/src/sgml/filelist.sgml   |1 +
src/tools/pgindent/typedefs.list |2 +
13 files changed, 1728 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Make CppAsString2() more visible in c.h.

2017-03-09 Thread Tom Lane 
Make CppAsString2() more visible in c.h.

For some reason this standard C string-processing hack was buried in an
NLS-related section of c.h.  Put it beside CppAsString() so that people
are more likely to find it and not be tempted to reinvent local copies,
as I nearly did.  And provide a more helpful comment, too.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/9cfc4deeb9e6bd8162bd85dce5809d4d7aea2b66

Modified Files
--
src/include/c.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix hard-coded relkind constants in pg_dump.c.

2017-03-09 Thread Tom Lane 
Fix hard-coded relkind constants in pg_dump.c.

Although it's reasonable to expect that most of these constants will
never change, that does not make it good programming style to hard-code
the value rather than using the RELKIND_FOO macros.  There were only
a few such violations, and all relatively new AFAICT.

Existing style is mostly to inject relkind values into constructed
query strings using %c.  I did not bother to touch places that did it
like that, but really a better technique is to stringify the RELKIND
macro, at least in places where you'd want single quotes around the
code character.  That avoids any runtime effort and keeps the RELKIND
symbol close to where it's used.

Discussion: https://postgr.es/m/11145.1488931...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/fe797b4a6a69ec0c9bf6ff992eac20c4084fda41

Modified Files
--
src/bin/pg_dump/pg_dump.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Throw an error if a DATA() line contains wrong # of attributes.

2017-03-09 Thread Robert Haas 
Throw an error if a DATA() line contains wrong # of attributes.

David Christensen, reviewed by Dagfinn Ilmari Mannsåker

Discussion: 
http://postgr.es/m/20170215154018.fs5vwtqhp5d2s...@veeddeux.attlocal.net

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/7666e73a2e9e0e91a9f3b246a4299b44daadcbf8

Modified Files
--
src/backend/catalog/Catalog.pm | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Use group updates when setting transaction status in clog.

2017-03-09 Thread Robert Haas 
Use group updates when setting transaction status in clog.

Commit 0e141c0fbb211bdd23783afa731e3eef95c9ad7a introduced a mechanism
to reduce contention on ProcArrayLock by having a single process clear
XIDs in the procArray on behalf of multiple processes, reducing the
need to hand the lock around.  Use a similar mechanism to reduce
contention on CLogControlLock.  Testing shows that this very
significantly reduces the amount of time waiting for CLogControlLock
on high-concurrency pgbench tests run on a large multi-socket
machines; whether that translates into a TPS improvement depends on
how much of that contention is simply shifted to some other lock,
particularly WALWriteLock.

Amit Kapila, with some cosmetic changes by me.  Extensively reviewed,
tested, and benchmarked over a period of about 15 months by Simon
Riggs, Robert Haas, Andres Freund, Jesper Pedersen, and especially by
Tomas Vondra and Dilip Kumar.

Discussion: 
http://postgr.es/m/CAA4eK1L_snxM_JcrzEstNq9P66++F4kKFce=1r5+d1vzpof...@mail.gmail.com
Discussion: 
http://postgr.es/m/CAA4eK1LyR2A+m=RBSZ6rcPEwJ=rvi1adpsndxhzdjn56yqo...@mail.gmail.com
Discussion: 
http://postgr.es/m/91d57161-d3ea-0cc2-6066-80713e4f9...@2ndquadrant.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/ccce90b398673d55b0387b3de66639b1b30d451b

Modified Files
--
src/backend/access/transam/clog.c | 239 --
src/backend/access/transam/twophase.c |   2 +-
src/backend/storage/lmgr/proc.c   |   9 ++
src/include/access/twophase.h |  13 ++
src/include/storage/proc.h|  14 ++
5 files changed, 268 insertions(+), 9 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix timestamptz regression test to still work with latest IANA z

2017-03-09 Thread Tom Lane 
Fix timestamptz regression test to still work with latest IANA zone data.

The IANA timezone crew continues to chip away at their project of removing
timezone abbreviations that have no real-world currency from their
database.  The tzdata2017a update removes all such abbreviations for
South American zones, as well as much of the Pacific.  This breaks some
test cases in timestamptz.sql that were expecting America/Santiago and
America/Caracas to have non-numeric abbreviations.

The test cases involving America/Santiago seem to have selected that
zone more or less at random, so just replace it with America/New_York,
which is of similar longitude.  The cases involving America/Caracas are
harder since they were chosen to test a time-varying zone abbreviation
around a point where it changed meaning in the backwards direction.
Fortunately, Europe/Moscow has a similar case in 2014, and the MSK/MSD
abbreviations are well enough attested that IANA seems unlikely to
decide to remove them from the database in future.

With these changes, this regression test should pass when using any IANA
zone database from 2015 or later.  One could wish that there were a few
years more daylight on how out-of-date your zone database can be ... but
really the --with-system-tzdata option is only meant for use on platforms
where the zone database is kept up-to-date pretty faithfully, so I do not
think this is a big objection.

Discussion: https://postgr.es/m/6749.1489087...@sss.pgh.pa.us

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/52f6b2e5a640ab2e6a7a214cad7e95995e3c211d

Modified Files
--
src/test/regress/expected/timestamptz.out | 252 +-
src/test/regress/sql/timestamptz.sql  |  97 +---
2 files changed, 109 insertions(+), 240 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix timestamptz regression test to still work with latest IANA z

2017-03-09 Thread Tom Lane 
Fix timestamptz regression test to still work with latest IANA zone data.

The IANA timezone crew continues to chip away at their project of removing
timezone abbreviations that have no real-world currency from their
database.  The tzdata2017a update removes all such abbreviations for
South American zones, as well as much of the Pacific.  This breaks some
test cases in timestamptz.sql that were expecting America/Santiago and
America/Caracas to have non-numeric abbreviations.

The test cases involving America/Santiago seem to have selected that
zone more or less at random, so just replace it with America/New_York,
which is of similar longitude.  The cases involving America/Caracas are
harder since they were chosen to test a time-varying zone abbreviation
around a point where it changed meaning in the backwards direction.
Fortunately, Europe/Moscow has a similar case in 2014, and the MSK/MSD
abbreviations are well enough attested that IANA seems unlikely to
decide to remove them from the database in future.

With these changes, this regression test should pass when using any IANA
zone database from 2015 or later.  One could wish that there were a few
years more daylight on how out-of-date your zone database can be ... but
really the --with-system-tzdata option is only meant for use on platforms
where the zone database is kept up-to-date pretty faithfully, so I do not
think this is a big objection.

Discussion: https://postgr.es/m/6749.1489087...@sss.pgh.pa.us

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/92f6e6829a4461e686648e68183908b60ed4ae71

Modified Files
--
src/test/regress/expected/timestamptz.out | 324 ++
src/test/regress/sql/timestamptz.sql  | 109 --
2 files changed, 151 insertions(+), 282 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix timestamptz regression test to still work with latest IANA z

2017-03-09 Thread Tom Lane 
Fix timestamptz regression test to still work with latest IANA zone data.

The IANA timezone crew continues to chip away at their project of removing
timezone abbreviations that have no real-world currency from their
database.  The tzdata2017a update removes all such abbreviations for
South American zones, as well as much of the Pacific.  This breaks some
test cases in timestamptz.sql that were expecting America/Santiago and
America/Caracas to have non-numeric abbreviations.

The test cases involving America/Santiago seem to have selected that
zone more or less at random, so just replace it with America/New_York,
which is of similar longitude.  The cases involving America/Caracas are
harder since they were chosen to test a time-varying zone abbreviation
around a point where it changed meaning in the backwards direction.
Fortunately, Europe/Moscow has a similar case in 2014, and the MSK/MSD
abbreviations are well enough attested that IANA seems unlikely to
decide to remove them from the database in future.

With these changes, this regression test should pass when using any IANA
zone database from 2015 or later.  One could wish that there were a few
years more daylight on how out-of-date your zone database can be ... but
really the --with-system-tzdata option is only meant for use on platforms
where the zone database is kept up-to-date pretty faithfully, so I do not
think this is a big objection.

Discussion: https://postgr.es/m/6749.1489087...@sss.pgh.pa.us

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/d8ec6b9c8c265c2f29b1c0e0e4205895baaa326d

Modified Files
--
src/test/regress/expected/timestamptz.out | 324 ++
src/test/regress/sql/timestamptz.sql  | 109 --
2 files changed, 151 insertions(+), 282 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix timestamptz regression test to still work with latest IANA z

2017-03-09 Thread Tom Lane 
Fix timestamptz regression test to still work with latest IANA zone data.

The IANA timezone crew continues to chip away at their project of removing
timezone abbreviations that have no real-world currency from their
database.  The tzdata2017a update removes all such abbreviations for
South American zones, as well as much of the Pacific.  This breaks some
test cases in timestamptz.sql that were expecting America/Santiago and
America/Caracas to have non-numeric abbreviations.

The test cases involving America/Santiago seem to have selected that
zone more or less at random, so just replace it with America/New_York,
which is of similar longitude.  The cases involving America/Caracas are
harder since they were chosen to test a time-varying zone abbreviation
around a point where it changed meaning in the backwards direction.
Fortunately, Europe/Moscow has a similar case in 2014, and the MSK/MSD
abbreviations are well enough attested that IANA seems unlikely to
decide to remove them from the database in future.

With these changes, this regression test should pass when using any IANA
zone database from 2015 or later.  One could wish that there were a few
years more daylight on how out-of-date your zone database can be ... but
really the --with-system-tzdata option is only meant for use on platforms
where the zone database is kept up-to-date pretty faithfully, so I do not
think this is a big objection.

Discussion: https://postgr.es/m/6749.1489087...@sss.pgh.pa.us

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/c6dc45d157a6e04b00231d34a7d7acd296b7e56e

Modified Files
--
src/test/regress/expected/timestamptz.out | 252 +-
src/test/regress/sql/timestamptz.sql  |  97 +---
2 files changed, 109 insertions(+), 240 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix timestamptz regression test to still work with latest IANA z

2017-03-09 Thread Tom Lane 
Fix timestamptz regression test to still work with latest IANA zone data.

The IANA timezone crew continues to chip away at their project of removing
timezone abbreviations that have no real-world currency from their
database.  The tzdata2017a update removes all such abbreviations for
South American zones, as well as much of the Pacific.  This breaks some
test cases in timestamptz.sql that were expecting America/Santiago and
America/Caracas to have non-numeric abbreviations.

The test cases involving America/Santiago seem to have selected that
zone more or less at random, so just replace it with America/New_York,
which is of similar longitude.  The cases involving America/Caracas are
harder since they were chosen to test a time-varying zone abbreviation
around a point where it changed meaning in the backwards direction.
Fortunately, Europe/Moscow has a similar case in 2014, and the MSK/MSD
abbreviations are well enough attested that IANA seems unlikely to
decide to remove them from the database in future.

With these changes, this regression test should pass when using any IANA
zone database from 2015 or later.  One could wish that there were a few
years more daylight on how out-of-date your zone database can be ... but
really the --with-system-tzdata option is only meant for use on platforms
where the zone database is kept up-to-date pretty faithfully, so I do not
think this is a big objection.

Discussion: https://postgr.es/m/6749.1489087...@sss.pgh.pa.us

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/e573bc3f9a0e3d455ed774b5527896a39a2932cf

Modified Files
--
src/test/regress/expected/timestamptz.out | 324 ++
src/test/regress/sql/timestamptz.sql  | 109 --
2 files changed, 151 insertions(+), 282 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix timestamptz regression test to still work with latest IANA z

2017-03-09 Thread Tom Lane 
Fix timestamptz regression test to still work with latest IANA zone data.

The IANA timezone crew continues to chip away at their project of removing
timezone abbreviations that have no real-world currency from their
database.  The tzdata2017a update removes all such abbreviations for
South American zones, as well as much of the Pacific.  This breaks some
test cases in timestamptz.sql that were expecting America/Santiago and
America/Caracas to have non-numeric abbreviations.

The test cases involving America/Santiago seem to have selected that
zone more or less at random, so just replace it with America/New_York,
which is of similar longitude.  The cases involving America/Caracas are
harder since they were chosen to test a time-varying zone abbreviation
around a point where it changed meaning in the backwards direction.
Fortunately, Europe/Moscow has a similar case in 2014, and the MSK/MSD
abbreviations are well enough attested that IANA seems unlikely to
decide to remove them from the database in future.

With these changes, this regression test should pass when using any IANA
zone database from 2015 or later.  One could wish that there were a few
years more daylight on how out-of-date your zone database can be ... but
really the --with-system-tzdata option is only meant for use on platforms
where the zone database is kept up-to-date pretty faithfully, so I do not
think this is a big objection.

Discussion: https://postgr.es/m/6749.1489087...@sss.pgh.pa.us

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/f077e1b2e374fadc443b6aa9fa54ad9bb6f908c7

Modified Files
--
src/test/regress/expected/timestamptz.out | 324 ++
src/test/regress/sql/timestamptz.sql  | 109 --
2 files changed, 151 insertions(+), 282 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Add relkind checks to certain contrib modules

2017-03-09 Thread Stephen Frost 
Add relkind checks to certain contrib modules

The contrib extensions pageinspect, pg_visibility and pgstattuple only
work against regular relations which have storage.  They don't work
against foreign tables, partitioned (parent) tables, views, et al.

Add checks to the user-callable functions to return a useful error
message to the user if they mistakenly pass an invalid relation to a
function which doesn't accept that kind of relation.

In passing, improve some of the existing checks to use ereport() instead
of elog(), add a function to consolidate common checks where
appropriate, and add some regression tests.

Author: Amit Langote, with various changes by me
Reviewed by: Michael Paquier and Corey Huinker
Discussion: 
https://postgr.es/m/ab91fd9d-4751-ee77-c87b-4dd704c1e...@lab.ntt.co.jp

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/c08d82f38ebf763b79bd43ae34b7310ee47aaacd

Modified Files
--
contrib/pageinspect/expected/page.out|   9 ++
contrib/pageinspect/rawpage.c|   5 +
contrib/pageinspect/sql/page.sql |   9 ++
contrib/pg_visibility/.gitignore |   4 +
contrib/pg_visibility/Makefile   |   2 +
contrib/pg_visibility/expected/pg_visibility.out | 142 +++
contrib/pg_visibility/pg_visibility.c|  58 ++---
contrib/pg_visibility/sql/pg_visibility.sql  |  83 +
contrib/pgstattuple/expected/pgstattuple.out | 107 +
contrib/pgstattuple/pgstatindex.c|  52 +++--
contrib/pgstattuple/pgstattuple.c|   3 +
contrib/pgstattuple/sql/pgstattuple.sql  |  64 ++
12 files changed, 517 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Document lack of validation when attaching foreign partitions.

2017-03-09 Thread Robert Haas 
Document lack of validation when attaching foreign partitions.

Ashutosh Bapat, revised a bit by me.

Discussion: 
http://postgr.es/m/CAFjFpRdLaCa-1wJase0=ywg5o3cjnbuut_vrqm2tdbkm_vq...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/b54aad8e34bd6299093e965c50f4a23da96d7cc3

Modified Files
--
doc/src/sgml/ref/alter_table.sgml | 31 +++
1 file changed, 19 insertions(+), 12 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Document some new parallel query capabilities.

2017-03-09 Thread Robert Haas 
Document some new parallel query capabilities.

This updates the text for parallel index scan, parallel index-only
scan, parallel bitmap heap scan, and parallel merge join.  It also
expands the discussion of parallel joins slightly.

Discussion: 
http://postgr.es/m/CA+TgmoZnCUoM31w3w7JSakVQJQOtcuTyX=HLUr-X1rto2=2...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/054637d2e08cda6a096f48cc99696136a06f4ef5

Modified Files
--
doc/src/sgml/parallel.sgml | 73 --
1 file changed, 57 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix bug in parallel tidbitmap iteration.

2017-03-09 Thread Robert Haas 
Fix bug in parallel tidbitmap iteration.

Avoid computing idxpages[istate->spageptr] until after checking
that istate->spageptr is a legal index.

Dilip Kumar, per a report from David Rowley

Discussion: 
http://postgr.es/m/CAKJS1f8OtrHE+-P+=E=4ycnl29e9idzkuatq6o2mbhvgn9d...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/6a468c343b31aabead7d3a5e11079bfcddbfd667

Modified Files
--
src/backend/nodes/tidbitmap.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix a couple of planner bugs in Gather Merge.

2017-03-09 Thread Robert Haas 
Fix a couple of planner bugs in Gather Merge.

Neha Sharma reported these to Rushabh Lathia just after I commit
355d3993c53ed62c5b53d020648e4fbcfbf5f155 went in.  The patch is
Rushabh's, with input from me.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/0ee92e1c9b570f90d043e5b033a19b67497ea1f6

Modified Files
--
src/backend/optimizer/plan/createplan.c | 3 ++-
src/backend/optimizer/plan/planner.c| 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Use SQL standard error code for nextval

2017-03-09 Thread Peter Eisentraut 
Use SQL standard error code for nextval

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/cd603a4d6b5381cb28e993c6219037c2582100c9

Modified Files
--
src/backend/commands/sequence.c | 4 ++--
src/backend/utils/errcodes.txt  | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Enable replication connections by default in pg_hba.conf

2017-03-09 Thread Peter Eisentraut 
Enable replication connections by default in pg_hba.conf

initdb now initializes a pg_hba.conf that allows replication connections
from the local host, same as it does for regular connections.  The
connecting user still needs to have the REPLICATION attribute or be a
superuser.

The intent is to allow pg_basebackup from the local host to succeed
without requiring additional configuration.

Michael Paquier  and me

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/be37c2120a2a88e5ba852d42952c77b6bf5d5271

Modified Files
--
doc/src/sgml/ref/initdb.sgml | 16 +++-
src/backend/libpq/pg_hba.conf.sample |  6 +++---
src/bin/initdb/initdb.c  |  5 -
src/bin/pg_basebackup/t/010_pg_basebackup.pl |  7 ++-
src/test/perl/PostgresNode.pm| 19 ++-
5 files changed, 18 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Add a Gather Merge executor node.

2017-03-09 Thread Robert Haas 
Add a Gather Merge executor node.

Like Gather, we spawn multiple workers and run the same plan in each
one; however, Gather Merge is used when each worker produces the same
output ordering and we want to preserve that output ordering while
merging together the streams of tuples from various workers.  (In a
way, Gather Merge is like a hybrid of Gather and MergeAppend.)

This works out to a win if it saves us from having to perform an
expensive Sort.  In cases where only a small amount of data would need
to be sorted, it may actually be faster to use a regular Gather node
and then sort the results afterward, because Gather Merge sometimes
needs to wait synchronously for tuples whereas a pure Gather generally
doesn't.  But if this avoids an expensive sort then it's a win.

Rushabh Lathia, reviewed and tested by Amit Kapila, Thomas Munro,
and Neha Sharma, and reviewed and revised by me.

Discussion: 
http://postgr.es/m/cagpqqf09opx-cqrpbks0gq49z+m6kbxgxd_p9gx8ckk_d75...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/355d3993c53ed62c5b53d020648e4fbcfbf5f155

Modified Files
--
doc/src/sgml/config.sgml  |  14 +
src/backend/commands/explain.c|  23 +
src/backend/executor/Makefile |   2 +-
src/backend/executor/execProcnode.c   |  17 +
src/backend/executor/nodeGatherMerge.c| 687 ++
src/backend/nodes/copyfuncs.c |  28 ++
src/backend/nodes/outfuncs.c  |  46 ++
src/backend/nodes/readfuncs.c |  22 +
src/backend/optimizer/path/allpaths.c |  36 +-
src/backend/optimizer/path/costsize.c |  68 +++
src/backend/optimizer/plan/createplan.c   |  86 
src/backend/optimizer/plan/planner.c  | 127 -
src/backend/optimizer/plan/setrefs.c  |   1 +
src/backend/optimizer/plan/subselect.c|   1 +
src/backend/optimizer/util/pathnode.c |  60 +++
src/backend/utils/misc/guc.c  |   9 +
src/include/executor/nodeGatherMerge.h|  27 +
src/include/nodes/execnodes.h |  29 ++
src/include/nodes/nodes.h |   3 +
src/include/nodes/plannodes.h |  16 +
src/include/nodes/relation.h  |  13 +
src/include/optimizer/cost.h  |   5 +
src/include/optimizer/pathnode.h  |   7 +
src/test/regress/expected/select_parallel.out |  27 +
src/test/regress/expected/sysviews.out|   3 +-
src/test/regress/sql/select_parallel.sql  |  11 +
src/tools/pgindent/typedefs.list  |   3 +
27 files changed, 1355 insertions(+), 16 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers