[COMMITTERS] pgsql: doc: Fix a few typos and awkward links

2017-03-18 Thread Peter Eisentraut
doc: Fix a few typos and awkward links

Branch
--
REL9_4_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/03ca8c249953e0051193183a5f987d64fcef4aa5

Modified Files
--
doc/src/sgml/config.sgml| 4 ++--
doc/src/sgml/ecpg.sgml  | 2 +-
doc/src/sgml/high-availability.sgml | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Fix a few typos and awkward links

2017-03-18 Thread Peter Eisentraut
doc: Fix a few typos and awkward links

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/767ce36ff36747e334ce3e163d57d5376403db37

Modified Files
--
doc/src/sgml/backup.sgml| 4 ++--
doc/src/sgml/config.sgml| 4 ++--
doc/src/sgml/ecpg.sgml  | 2 +-
doc/src/sgml/high-availability.sgml | 2 +-
doc/src/sgml/protocol.sgml  | 4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Fix a few typos and awkward links

2017-03-18 Thread Peter Eisentraut
doc: Fix a few typos and awkward links

Branch
--
REL9_5_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/3e04d005c455153a2242c172ed61db2f0b362bc6

Modified Files
--
doc/src/sgml/config.sgml| 4 ++--
doc/src/sgml/ecpg.sgml  | 2 +-
doc/src/sgml/high-availability.sgml | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Fix a few typos and awkward links

2017-03-18 Thread Peter Eisentraut
doc: Fix a few typos and awkward links

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/09079b72b7fd354f9d18833bdb7ac15e9cc35a86

Modified Files
--
doc/src/sgml/backup.sgml| 4 ++--
doc/src/sgml/config.sgml| 4 ++--
doc/src/sgml/ecpg.sgml  | 2 +-
doc/src/sgml/high-availability.sgml | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Fix a few typos and awkward links

2017-03-18 Thread Peter Eisentraut
doc: Fix a few typos and awkward links

Branch
--
REL9_2_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/10a3637eaf9d95c3b8a969a380895ddac1cbbe0f

Modified Files
--
doc/src/sgml/config.sgml| 4 ++--
doc/src/sgml/ecpg.sgml  | 2 +-
doc/src/sgml/high-availability.sgml | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Fix a few typos and awkward links

2017-03-18 Thread Peter Eisentraut
doc: Fix a few typos and awkward links

Branch
--
REL9_3_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/5fdc70826fd023498c1480ae7f398183a5c9be91

Modified Files
--
doc/src/sgml/config.sgml| 4 ++--
doc/src/sgml/ecpg.sgml  | 2 +-
doc/src/sgml/high-availability.sgml | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Avoid use of already-closed relcache entry.

2017-03-18 Thread Tom Lane
Avoid use of already-closed relcache entry.

Oversight in commit 17f8ffa1e.  Per buildfarm member prion.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/e3044f6184beac395e88b4e1230e6c9d449db7f2

Modified Files
--
src/backend/commands/matview.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix REFRESH MATERIALIZED VIEW to report activity to the stats co

2017-03-18 Thread Tom Lane
Fix REFRESH MATERIALIZED VIEW to report activity to the stats collector.

The non-concurrent code path for REFRESH MATERIALIZED VIEW failed to
report its updates to the stats collector.  This is bad since it means
auto-analyze doesn't know there's any work to be done.  Adjust it to
report the refresh as a table truncate followed by insertion of an
appropriate number of rows.

Since a matview could contain more than INT_MAX rows, change the
signature of pgstat_count_heap_insert() to accept an int64 rowcount.
(The accumulator it's adding into is already int64, but existing
callers could not insert more than a small number of rows at once,
so the argument had been declared just "int n".)

This is surely a bug fix, but changing pgstat_count_heap_insert()'s API
seems too risky for the back branches.  Given the lack of previous
complaints, I'm not sure it's a big enough problem to justify a kluge
solution that would avoid that.  So, no back-patch, at least for now.

Jim Mlodgenski, adjusted a bit by me

Discussion: 
https://postgr.es/m/cab_5srchsz7-wmdo5szdikng8oj_ggqjytrk1krd11yhcms...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/17f8ffa1e331cd0d95a3c4ccec66ea83d8b893c5

Modified Files
--
src/backend/commands/matview.c  | 30 +++---
src/backend/postmaster/pgstat.c |  2 +-
src/include/pgstat.h|  2 +-
3 files changed, 29 insertions(+), 5 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Improve wording

2017-03-18 Thread Peter Eisentraut
doc: Improve wording

Link to CREATE and ALTER ROLE consistently, instead of mixing CREATE
USER and ALTER ROLE.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/27f1f585fd7ee749cacd3de8c2c77a457ef4c288

Modified Files
--
doc/src/sgml/config.sgml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Avoid having vacuum set reltuples to 0 on non-empty relations in

2017-03-18 Thread Bruce Momjian
On Fri, Mar 17, 2017 at 10:00:17AM -0400, Tom Lane wrote:
> Andrew Dunstan  writes:
> > On 03/17/2017 09:30 AM, Robert Haas wrote:
> >> In the department of nitpicks, we usually try to write commit messages
> >> so that the first line is a summary line which stands alone, and then
> >> there's a blank line, and then more follows.  a la
> >> https://chris.beams.io/posts/git-commit/#separate
> 
> > Yeah, In our case email subjects seem to be truncated at 64 chars, so
> > it's best to stay under that limit if possible - 50 chars is sometimes
> > pretty limiting.
> 
> FWIW, I usually try to keep line length in commit messages to <= 75
> characters, as that is the wrap boundary in "git log" output.  It's
> nice if the summary line can be made shorter, but it's often damn
> hard to cram an adequate summary into 75 chars, let alone fewer.
> 
> (Links to mailing-list threads must ignore the length limit, sadly.)

Here are the length limits I have found, and I display this in my email
editor when I am creating a commit message:

-- email subject limit -
-- gitweb summary limit --

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Add markup

2017-03-18 Thread Peter Eisentraut
doc: Add markup

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/a72188a35bbd71a8cc29f10eab27d4140d296b9d

Modified Files
--
doc/src/sgml/installation.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Update compatibility claim

2017-03-18 Thread Peter Eisentraut
doc: Update compatibility claim

Update outdated claim that TRUNCATE is a PostgreSQL extension.

Add cross-links between DELETE and TRUNCATE references pages.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5e86bb51eaeeb5c70f64102f46c4431cb12999e9

Modified Files
--
doc/src/sgml/ref/delete.sgml   | 11 +--
doc/src/sgml/ref/truncate.sgml |  8 
2 files changed, 17 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Tweak reference page header style

2017-03-18 Thread Peter Eisentraut
doc: Tweak reference page header style

Change the header style of references pages in HTML and PDF output to be
more like the old style under DSSSL.  In particular, the page should
start with a header containing the command name, instead of just "Name".

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/cb5fa4130ed5bdd37a51ce8cade3c2a2461097b9

Modified Files
--
doc/src/sgml/stylesheet-common.xsl | 2 ++
1 file changed, 2 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Adjust number of tests for pg_dump 001_basic.pl

2017-03-18 Thread Stephen Frost
Adjust number of tests for pg_dump 001_basic.pl

When removing a test, need to make sure the count of tests is adjusted
when it isn't calculated.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/805e8bc7029b6eb19f0ca3a68051cfda5bd07ef3

Modified Files
--
src/bin/pg_dump/t/001_basic.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: pg_dump: Remove "option requires an argument -- j" test

2017-03-18 Thread Stephen Frost
pg_dump: Remove "option requires an argument -- j" test

This is really testing getopt more than pg_dump, and what getopt returns
exactly appears to differ based on platform, so remove this test.

Per buildfarm.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/5abda5a3e9e7f2a472ccbb1b8389d9166d4a9eca

Modified Files
--
src/bin/pg_dump/t/001_basic.pl | 5 -
1 file changed, 5 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Improve pg_dump regression tests and code coverage

2017-03-18 Thread Stephen Frost
Improve pg_dump regression tests and code coverage

These improvements bring the lines-of-code coverage of pg_dump.c up to
87.7% (at least using LCOV 1.12, 1.11 seems to differ slightly).  Nearly
every function is covered, three of the four which aren't are only
called when talking to older PG instances.

There is more which can, and should, be done here to improve the
coverage but it's past time to see what the buildfarm thinks of this.

What has been added:

- Coverage for many more command-line options
- Use command_fails_like instead of command_exit_is
- Operator classes, operator families
- Text search configuration, templates, parsers, dictionaries
- FDWs, servers, foreign tables
- Materialized views
- Improved Publications / Subscriptions test (though this needs work,
  see PG10 open items and tests marked with XXX in 002_pg_dump.pl)
- Unlogged tables
- Partitioned tables
- Additional ACL testing for various object types

There is room for improvement, specifically:

- Various type-based option (alignment, storage, etc)
- Composite type collation
- Extra Procedural language functions (inline, validator)
- Different function options (SRF, Transform, config, security definer,
  cost, leakproof)
- OpClass options (default, storage, order by, recheck)
- OpFamily options (order by, recheck)
- Aggregate functions (combinefunc, serialfunc, deserialfunc, etc)
- Text Search parser 'headline'
- Text Search template 'init'
- FDW options (handler, validator, options)
- Server options (type, version, options)
- User mapping options
- Default ACLs for sequences, types
- Security labels
- View circular dependencies (last function that needs coverage)
- Toast table autovacuum options
- Replica identity options
- Independent indexes (plus marking them as clustered on)
- Deferrable / initially deferred constraints
- Independent domain constraints

There's bits of extension pg_dump'ing also not covered, but those will
need to go into test_pg_dump (such as having a filter for config
tables).

Last, but not least, this approximately halves the number of tests run
with 'ok()' by removing the ok()-based checking of if all runs are
covered by each test.  Instead, 002_pg_dump.pl will just exit out in
such a case (with a message in the log file).  In general, when adding
tests, cover all runs unless there is a very good reason not to (such as
adding a 'catch-all' case).  With these changes, the resulting output
and number of "tests" run is actually reduced.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/31a8b77a9244a0883e1968adcff9b6038e575d77

Modified Files
--
src/bin/pg_dump/t/001_basic.pl   |  128 +-
src/bin/pg_dump/t/002_pg_dump.pl | 3773 --
2 files changed, 3340 insertions(+), 561 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: doc: Correct row count in table

2017-03-18 Thread Peter Eisentraut
doc: Correct row count in table

The incorrect count causes FOP to error out.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/164bdbe9c2412d90b62d6f145a43f9e41a90003b

Modified Files
--
doc/src/sgml/monitoring.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Create and use wait events for read, write, and fsync operations

2017-03-18 Thread Robert Haas
Create and use wait events for read, write, and fsync operations.

Previous commits, notably 53be0b1add7064ca5db3cd884302dfc3268d884e and
6f3bd98ebfc008cbd676da777bb0b2376c4c4bfa, made it possible to see from
pg_stat_activity when a backend was stuck waiting for another backend,
but it's also fairly common for a backend to be stuck waiting for an
I/O.  Add wait events for those operations, too.

Rushabh Lathia, with further hacking by me.  Reviewed and tested by
Michael Paquier, Amit Kapila, Rajkumar Raghuwanshi, and Rahila Syed.

Discussion: 
http://postgr.es/m/CAGPqQf0LsYHXREPAZqYGVkDqHSyjf=KsD=k0gtvpauzythh...@mail.gmail.com

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/249cf070e36721a65be74838c53acf8249faf935

Modified Files
--
doc/src/sgml/monitoring.sgml| 271 
src/backend/access/heap/rewriteheap.c   |  17 +-
src/backend/access/transam/slru.c   |  12 ++
src/backend/access/transam/timeline.c   |  11 +
src/backend/access/transam/twophase.c   |   9 +
src/backend/access/transam/xlog.c   |  31 +++
src/backend/access/transam/xlogutils.c  |   3 +
src/backend/postmaster/pgstat.c | 233 
src/backend/replication/logical/reorderbuffer.c |   9 +
src/backend/replication/logical/snapbuild.c |  14 ++
src/backend/replication/slot.c  |  13 ++
src/backend/replication/walsender.c |   4 +
src/backend/storage/file/buffile.c  |  11 +-
src/backend/storage/file/copydir.c  |   7 +-
src/backend/storage/file/fd.c   |  28 ++-
src/backend/storage/ipc/dsm_impl.c  |   3 +
src/backend/storage/smgr/md.c   |  21 +-
src/backend/utils/cache/relmapper.c |   7 +
src/backend/utils/init/miscinit.c   |  17 ++
src/include/pgstat.h|  78 +++
src/include/storage/fd.h|  12 +-
21 files changed, 782 insertions(+), 29 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix schedule of ecpg test files to only try two-phase commit tes

2017-03-18 Thread Michael Meskes
Fix schedule of ecpg test files to only try two-phase commit test when possible.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/928250aef5f8363825acbf58540328089c26b0d4

Modified Files
--
src/interfaces/ecpg/test/Makefile  | 13 -
src/interfaces/ecpg/test/ecpg_schedule |  1 -
2 files changed, 12 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers