[COMMITTERS] pgsql: Teach pgrowlocks to check relkind before scanning

[Peter Eisentraut]

Teach pgrowlocks to check relkind before scanning

Author: Amit Langote 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/b56818abd450a87e2e3cb03b2cf3eede73487926

Modified Files
--
contrib/pgrowlocks/pgrowlocks.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix possibility of creating a "phantom" segment after promotion.

[Andres Freund]

Fix possibility of creating a "phantom" segment after promotion.

When promoting a standby just after a XLOG_SWITCH record was replayed,
and next segment(s) are already are locally available (via walsender,
restore_command + trigger/recovery target), that segment could
accidentally be recycled onto the past of the new timeline.  Later
checkpointer would create a .ready file for it, assuming there was an
error during creation, and it would get archived.  That causes trouble
if another standby is later brought up from a basebackup from before
the timeline creation, because it would try to read the
segment, because XLogFileReadAnyTLI just tries all possible timelines,
which doesn't have valid contents.  Thus replay would fail.

The problem, if already occurred, can be fixed by removing the segment
and/or having restore_command filter it out.

The reason for the creation of such "phantom" segments was, that after
an XLOG_SWITCH record the EndOfLog variable points to the beginning of
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().
Normally RemoveXlogFile() doing so is harmless, because the last
segment will still exist preventing InstallXLogFileSegment() from
causing harm, but just after promotion there's no previous segment on
the new timeline.

Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().

Author: Andres Freund
Reported-By: Greg Burek
Discussion: 
https://postgr.es/m/20170619073026.zcwpe6mydsaz5...@alap3.anarazel.de
Backpatch: 9.2-, bug older than all supported versions

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/7775ebaf016771cc9dc9b07921127ee87d6725f4

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix possibility of creating a "phantom" segment after promotion.

[Andres Freund]

Fix possibility of creating a "phantom" segment after promotion.

When promoting a standby just after a XLOG_SWITCH record was replayed,
and next segment(s) are already are locally available (via walsender,
restore_command + trigger/recovery target), that segment could
accidentally be recycled onto the past of the new timeline.  Later
checkpointer would create a .ready file for it, assuming there was an
error during creation, and it would get archived.  That causes trouble
if another standby is later brought up from a basebackup from before
the timeline creation, because it would try to read the
segment, because XLogFileReadAnyTLI just tries all possible timelines,
which doesn't have valid contents.  Thus replay would fail.

The problem, if already occurred, can be fixed by removing the segment
and/or having restore_command filter it out.

The reason for the creation of such "phantom" segments was, that after
an XLOG_SWITCH record the EndOfLog variable points to the beginning of
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().
Normally RemoveXlogFile() doing so is harmless, because the last
segment will still exist preventing InstallXLogFileSegment() from
causing harm, but just after promotion there's no previous segment on
the new timeline.

Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().

Author: Andres Freund
Reported-By: Greg Burek
Discussion: 
https://postgr.es/m/20170619073026.zcwpe6mydsaz5...@alap3.anarazel.de
Backpatch: 9.2-, bug older than all supported versions

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/823a51ed30c0985718175666e938b3f0e68d8e42

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix possibility of creating a "phantom" segment after promotion.

[Andres Freund]

Fix possibility of creating a "phantom" segment after promotion.

When promoting a standby just after a XLOG_SWITCH record was replayed,
and next segment(s) are already are locally available (via walsender,
restore_command + trigger/recovery target), that segment could
accidentally be recycled onto the past of the new timeline.  Later
checkpointer would create a .ready file for it, assuming there was an
error during creation, and it would get archived.  That causes trouble
if another standby is later brought up from a basebackup from before
the timeline creation, because it would try to read the
segment, because XLogFileReadAnyTLI just tries all possible timelines,
which doesn't have valid contents.  Thus replay would fail.

The problem, if already occurred, can be fixed by removing the segment
and/or having restore_command filter it out.

The reason for the creation of such "phantom" segments was, that after
an XLOG_SWITCH record the EndOfLog variable points to the beginning of
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().
Normally RemoveXlogFile() doing so is harmless, because the last
segment will still exist preventing InstallXLogFileSegment() from
causing harm, but just after promotion there's no previous segment on
the new timeline.

Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().

Author: Andres Freund
Reported-By: Greg Burek
Discussion: 
https://postgr.es/m/20170619073026.zcwpe6mydsaz5...@alap3.anarazel.de
Backpatch: 9.2-, bug older than all supported versions

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/511d803ca41ae571574de9a8f1084370dcbcb88c

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix possibility of creating a "phantom" segment after promotion.

[Andres Freund]

Fix possibility of creating a "phantom" segment after promotion.

When promoting a standby just after a XLOG_SWITCH record was replayed,
and next segment(s) are already are locally available (via walsender,
restore_command + trigger/recovery target), that segment could
accidentally be recycled onto the past of the new timeline.  Later
checkpointer would create a .ready file for it, assuming there was an
error during creation, and it would get archived.  That causes trouble
if another standby is later brought up from a basebackup from before
the timeline creation, because it would try to read the
segment, because XLogFileReadAnyTLI just tries all possible timelines,
which doesn't have valid contents.  Thus replay would fail.

The problem, if already occurred, can be fixed by removing the segment
and/or having restore_command filter it out.

The reason for the creation of such "phantom" segments was, that after
an XLOG_SWITCH record the EndOfLog variable points to the beginning of
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().
Normally RemoveXlogFile() doing so is harmless, because the last
segment will still exist preventing InstallXLogFileSegment() from
causing harm, but just after promotion there's no previous segment on
the new timeline.

Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().

Author: Andres Freund
Reported-By: Greg Burek
Discussion: 
https://postgr.es/m/20170619073026.zcwpe6mydsaz5...@alap3.anarazel.de
Backpatch: 9.2-, bug older than all supported versions

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/fb886c153bc168eeb1c3fd2f24562b5b808357d6

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix possibility of creating a "phantom" segment after promotion.

[Andres Freund]

Fix possibility of creating a "phantom" segment after promotion.

When promoting a standby just after a XLOG_SWITCH record was replayed,
and next segment(s) are already are locally available (via walsender,
restore_command + trigger/recovery target), that segment could
accidentally be recycled onto the past of the new timeline.  Later
checkpointer would create a .ready file for it, assuming there was an
error during creation, and it would get archived.  That causes trouble
if another standby is later brought up from a basebackup from before
the timeline creation, because it would try to read the
segment, because XLogFileReadAnyTLI just tries all possible timelines,
which doesn't have valid contents.  Thus replay would fail.

The problem, if already occurred, can be fixed by removing the segment
and/or having restore_command filter it out.

The reason for the creation of such "phantom" segments was, that after
an XLOG_SWITCH record the EndOfLog variable points to the beginning of
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().
Normally RemoveXlogFile() doing so is harmless, because the last
segment will still exist preventing InstallXLogFileSegment() from
causing harm, but just after promotion there's no previous segment on
the new timeline.

Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().

Author: Andres Freund
Reported-By: Greg Burek
Discussion: 
https://postgr.es/m/20170619073026.zcwpe6mydsaz5...@alap3.anarazel.de
Backpatch: 9.2-, bug older than all supported versions

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/39e30cbc16cf8d2bd8fb8c5697d02eb220d26ffc

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix possibility of creating a "phantom" segment after promotion.

[Andres Freund]

Fix possibility of creating a "phantom" segment after promotion.

When promoting a standby just after a XLOG_SWITCH record was replayed,
and next segment(s) are already are locally available (via walsender,
restore_command + trigger/recovery target), that segment could
accidentally be recycled onto the past of the new timeline.  Later
checkpointer would create a .ready file for it, assuming there was an
error during creation, and it would get archived.  That causes trouble
if another standby is later brought up from a basebackup from before
the timeline creation, because it would try to read the
segment, because XLogFileReadAnyTLI just tries all possible timelines,
which doesn't have valid contents.  Thus replay would fail.

The problem, if already occurred, can be fixed by removing the segment
and/or having restore_command filter it out.

The reason for the creation of such "phantom" segments was, that after
an XLOG_SWITCH record the EndOfLog variable points to the beginning of
the next segment, and RemoveXlogFile() used XLByteToPrevSeg().
Normally RemoveXlogFile() doing so is harmless, because the last
segment will still exist preventing InstallXLogFileSegment() from
causing harm, but just after promotion there's no previous segment on
the new timeline.

Fix that by using XLByteToSeg() instead of XLByteToPrevSeg().

Author: Andres Freund
Reported-By: Greg Burek
Discussion: 
https://postgr.es/m/20170619073026.zcwpe6mydsaz5...@alap3.anarazel.de
Backpatch: 9.2-, bug older than all supported versions

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/81bf7b5b1e4b33a5c6396d2ff6157f74c05b20c8

Modified Files
--
src/backend/access/transam/xlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

Re: [COMMITTERS] pgsql: Adjust pgindent script to use pg_bsd_indent 2.0.

[Bruce Momjian]

On Wed, Jun 21, 2017 at 06:26:29PM +, Tom Lane wrote:
> Adjust pgindent script to use pg_bsd_indent 2.0.
> 
> Update version-checking code and list of switches.  Delete obsolete
> quasi-support for using GNU indent.  Remove a lot of no-longer-needed
> workarounds for bugs of the old version, and improve comments for
> the hacks that remain.  Update run_build() subroutine to fetch the

Another hack of mine bits the dust.  I see a few did remain.  :-)

-- 
  Bruce Momjian  http://momjian.us
  EnterpriseDB http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+  Ancient Roman grave inscription +


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Manually un-break a few URLs that pgindent used to insist on spl

[Tom Lane]

Manually un-break a few URLs that pgindent used to insist on splitting.

These will no longer get re-split by pgindent runs, so it's worth cleaning
them up now.

Discussion: https://postgr.es/m/e1damxk-0006ee...@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/780b3a4c43fd47867825d5d628e96a0966e63aa8

Modified Files
--
src/backend/utils/adt/numeric.c  | 3 +--
src/backend/utils/adt/selfuncs.c | 3 +--
src/bin/pg_ctl/pg_ctl.c  | 6 ++
src/bin/psql/copy.c  | 3 +--
4 files changed, 5 insertions(+), 10 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Remove entab and associated detritus.

[Tom Lane]

Remove entab and associated detritus.

We don't need this anymore, because pg_bsd_indent has been taught to
follow the same tab-vs-space rules that entab used to enforce.

Discussion: https://postgr.es/m/e1damxk-0006ee...@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/81f056c7256f01a39ecc926bf6a4d2d1fa525633

Modified Files
--
src/tools/entab/.gitignore  |   1 -
src/tools/entab/Makefile|  20 ---
src/tools/entab/entab.1 |  51 
src/tools/entab/entab.c | 277 
src/tools/pgindent/README   |   4 +-
src/tools/pgindent/pgindent |  60 +
src/tools/pgindent/pgindent.man |   3 -
7 files changed, 2 insertions(+), 414 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Reformat comments about ResultRelInfo

[Peter Eisentraut]

Reformat comments about ResultRelInfo

Also add a comment on its new member PartitionRoot.

Reported-by: Etsuro Fujita 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/113b0045e20d40f726a0a30e33214455e4f1385e

Modified Files
--
src/include/nodes/execnodes.h | 80 +++
1 file changed, 50 insertions(+), 30 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Phase 3 of pgindent updates.

[Tom Lane]

Phase 3 of pgindent updates.

Don't move parenthesized lines to the left, even if that means they
flow past the right margin.

By default, BSD indent lines up statement continuation lines that are
within parentheses so that they start just to the right of the preceding
left parenthesis.  However, traditionally, if that resulted in the
continuation line extending to the right of the desired right margin,
then indent would push it left just far enough to not overrun the margin,
if it could do so without making the continuation line start to the left of
the current statement indent.  That makes for a weird mix of indentations
unless one has been completely rigid about never violating the 80-column
limit.

This behavior has been pretty universally panned by Postgres developers.
Hence, disable it with indent's new -lpl switch, so that parenthesized
lines are always lined up with the preceding left paren.

This patch is much less interesting than the first round of indent
changes, but also bulkier, so I thought it best to separate the effects.

Discussion: https://postgr.es/m/e1damxk-0006ee...@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/382ceffdf7f620d8f2d50e451b4167d291ae2348

Modified Files
--
contrib/adminpack/adminpack.c  |   4 +-
contrib/amcheck/verify_nbtree.c|  62 ++--
contrib/auth_delay/auth_delay.c|   2 +-
contrib/auto_explain/auto_explain.c|   6 +-
contrib/bloom/bloom.h  |   4 +-
contrib/bloom/blvacuum.c   |   4 +-
contrib/btree_gin/btree_gin.c  |   4 +-
contrib/btree_gist/btree_cash.c|   4 +-
contrib/btree_gist/btree_date.c|  18 +-
contrib/btree_gist/btree_enum.c|   4 +-
contrib/btree_gist/btree_float4.c  |   4 +-
contrib/btree_gist/btree_float8.c  |   4 +-
contrib/btree_gist/btree_inet.c|   6 +-
contrib/btree_gist/btree_int2.c|   4 +-
contrib/btree_gist/btree_int4.c|   4 +-
contrib/btree_gist/btree_int8.c|   4 +-
contrib/btree_gist/btree_interval.c|   4 +-
contrib/btree_gist/btree_macaddr.c |   4 +-
contrib/btree_gist/btree_macaddr8.c|   4 +-
contrib/btree_gist/btree_oid.c |   4 +-
contrib/btree_gist/btree_time.c|  16 +-
contrib/btree_gist/btree_ts.c  |   4 +-
contrib/btree_gist/btree_utils_var.c   |   4 +-
contrib/btree_gist/btree_uuid.c|   6 +-
contrib/cube/cube.c|   8 +-
contrib/dblink/dblink.c|  56 +--
contrib/earthdistance/earthdistance.c  |   2 +-
contrib/file_fdw/file_fdw.c|   2 +-
contrib/hstore/hstore_io.c |  16 +-
contrib/hstore/hstore_op.c |  26 +-
contrib/intarray/_int_bool.c   |   4 +-
contrib/intarray/_int_gist.c   |   2 +-
contrib/intarray/_int_op.c |   4 +-
contrib/intarray/_int_selfuncs.c   |  12 +-
contrib/isn/isn.c  |   4 +-
contrib/ltree/_ltree_op.c  |   2 +-
contrib/ltree/lquery_op.c  |   2 +-
contrib/ltree/ltree.h  |   2 +-
contrib/ltree/ltree_gist.c |  12 +-
contrib/ltree/ltree_io.c   |   8 +-
contrib/oid2name/oid2name.c|   6 +-
contrib/pageinspect/brinfuncs.c|   2 +-
contrib/pageinspect/btreefuncs.c   |   4 +-
contrib/pageinspect/ginfuncs.c |   2 +-
contrib/pageinspect/hashfuncs.c|   2 +-
contrib/pageinspect/heapfuncs.c|   8 +-
contrib/pageinspect/rawpage.c  |   2 +-
contrib/passwordcheck/passwordcheck.c  |   2 +-
contrib/pg_prewarm/pg_prewarm.c|   4 +-
contrib/pg_standby/pg_standby.c|   4 +-
contrib/pg_stat_statements/pg_stat_statements.c|  32 +-
contrib/pg_visibility/pg_visibility.c  |   4 +-
contrib/pgcrypto/crypt-blowfish.c  |   2 +-
contrib/pgcrypto/crypt-gensalt.c   |   8 +-
contrib/pgcrypto/pgp-pgsql.c   |   4 +-
contrib/pgcrypto/px-crypt.h|   8 +-
contrib/pgrowlocks/pgrowlocks.c|   2 +-
contrib/pgstattuple/pgstatapprox.c |   2 +-
contrib/pgstattuple/pgstatindex.c  |  12 +-
contrib/postgres_fdw/connection.c  |  20 +-
contrib/postgres_fdw/deparse.c | 

[COMMITTERS] pgsql: Restart logical replication launcher when killed

[Peter Eisentraut]

Restart logical replication launcher when killed

Author: Yugo Nagata 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f669c09989bda894d6ba01634ccb229f0687c08a

Modified Files
--
src/backend/tcop/postgres.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Initial pgindent run with pg_bsd_indent version 2.0.

[Tom Lane]

Initial pgindent run with pg_bsd_indent version 2.0.

The new indent version includes numerous fixes thanks to Piotr Stefaniak.
The main changes visible in this commit are:

* Nicer formatting of function-pointer declarations.
* No longer unexpectedly removes spaces in expressions using casts,
  sizeof, or offsetof.
* No longer wants to add a space in "struct structname *varname", as
  well as some similar cases for const- or volatile-qualified pointers.
* Declarations using PG_USED_FOR_ASSERTS_ONLY are formatted more nicely.
* Fixes bug where comments following declarations were sometimes placed
  with no space separating them from the code.
* Fixes some odd decisions for comments following case labels.
* Fixes some cases where comments following code were indented to less
  than the expected column 33.

On the less good side, it now tends to put more whitespace around typedef
names that are not listed in typedefs.list.  This might encourage us to
put more effort into typedef name collection; it's not really a bug in
indent itself.

There are more changes coming after this round, having to do with comment
indentation and alignment of lines appearing within parentheses.  I wanted
to limit the size of the diffs to something that could be reviewed without
one's eyes completely glazing over, so it seemed better to split up the
changes as much as practical.

Discussion: https://postgr.es/m/e1damxk-0006ee...@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e3860ffa4dd0dad0dd9eea4be9cc1412373a8c89

Modified Files
--
contrib/bloom/blutils.c|   2 +-
contrib/btree_gist/btree_utils_var.c   |   2 +-
contrib/dblink/dblink.c|   4 +-
contrib/fuzzystrmatch/fuzzystrmatch.c  |   4 +-
contrib/intarray/_int_gin.c|   2 +-
contrib/ltree/lquery_op.c  |   2 +-
contrib/oid2name/oid2name.c|  14 +-
contrib/pg_stat_statements/pg_stat_statements.c|   2 +-
contrib/pg_trgm/trgm_op.c  |   8 +-
contrib/pg_visibility/pg_visibility.c  |   2 +-
contrib/pgcrypto/imath.c   |   8 +-
contrib/pgcrypto/imath.h   |   5 +-
contrib/pgcrypto/internal.c|   2 +-
contrib/pgcrypto/mbuf.h|   4 +-
contrib/pgcrypto/pgp-decrypt.c |   8 +-
contrib/pgcrypto/pgp-pgsql.c   |  10 +-
contrib/pgcrypto/px-crypt.c|   4 +-
contrib/pgcrypto/px.h  |   6 +-
contrib/pgcrypto/rijndael.h|   3 +-
contrib/pgcrypto/sha1.c|  10 +-
contrib/pgstattuple/pgstatapprox.c |   2 +-
contrib/pgstattuple/pgstattuple.c  |   6 +-
contrib/sepgsql/hooks.c|   2 +-
contrib/sepgsql/label.c|   4 +-
contrib/sepgsql/selinux.c  |   4 +-
contrib/sepgsql/sepgsql.h  |   2 +-
contrib/sepgsql/uavc.c |   2 +-
contrib/spi/timetravel.c   |   2 +-
contrib/uuid-ossp/uuid-ossp.c  |  10 +-
contrib/vacuumlo/vacuumlo.c|   4 +-
contrib/xml2/xpath.c   |   2 +-
src/backend/access/common/reloptions.c |  28 +--
src/backend/access/gin/ginarrayproc.c  |   2 +-
src/backend/access/gin/gindatapage.c   |   2 +-
src/backend/access/hash/hash.c |   2 +-
src/backend/access/hash/hash_xlog.c|   4 +-
src/backend/access/hash/hashovfl.c |   2 +-
src/backend/access/heap/rewriteheap.c  |  10 +-
src/backend/access/heap/tuptoaster.c   |  22 +-
src/backend/access/nbtree/nbtree.c |   8 +-
src/backend/access/spgist/spgdoinsert.c|   4 +-
src/backend/access/spgist/spgscan.c|   4 +-
src/backend/access/transam/parallel.c  |   2 +-
src/backend/access/transam/slru.c  |   2 +-
src/backend/access/transam/twophase.c  |   4 +-
src/backend/access/transam/xlog.c  |   8 +-
src/backend/catalog/index.c|   2 +-
src/backend/catalog/partition.c|   6 +-
src/backend/commands/copy.c|   2 +-
src/backend/commands/extension.c   |   3 +-
src/backend/commands/functioncmds.c|   2 +-
src/backend/commands/publicationcmds.c |   2 +-
src/backend/commands/tablecmds.c   |  56 +++--
src/backend/commands/trigger.c |   6 +-
src/backend/commands/vacuumlazy.c  |   8 +-

[COMMITTERS] pgsql: Adjust pgindent script to use pg_bsd_indent 2.0.

[Tom Lane]

Adjust pgindent script to use pg_bsd_indent 2.0.

Update version-checking code and list of switches.  Delete obsolete
quasi-support for using GNU indent.  Remove a lot of no-longer-needed
workarounds for bugs of the old version, and improve comments for
the hacks that remain.  Update run_build() subroutine to fetch the
pg_bsd_indent code from the newly established git repo for it.

In passing, fix pgindent to not overwrite files that require no changes;
this makes it a bit more friendly to run on a built tree.

Adjust relevant documentation.

Remove indent.bsd.patch; it's not relevant anymore (and was obsolete
long ago anyway).  Likewise remove pgcppindent, since we're no longer
in the business of shipping C++ code.

Piotr Stefaniak is responsible for most of the algorithmic changes
to the pgindent script; I did the rest.

Discussion: https://postgr.es/m/e1damxk-0006ee...@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/8ff6d4ec7840b0af56f1207073f44b7f2afae96d

Modified Files
--
src/tools/pgindent/README   |  21 ++-
src/tools/pgindent/indent.bsd.patch | 288 
src/tools/pgindent/pgcppindent  |  29 
src/tools/pgindent/pgindent | 157 +---
src/tools/pgindent/pgindent.man |   5 +-
5 files changed, 52 insertions(+), 448 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Final pgindent run with old pg_bsd_indent (version 1.3).

[Tom Lane]

Final pgindent run with old pg_bsd_indent (version 1.3).

This is just to have a clean basis for comparison with the results of
the new version (which will indeed end up reverting some of these
changes...)

Discussion: https://postgr.es/m/e1damxk-0006ee...@gemulon.postgresql.org
Discussion: https://postgr.es/m/30527.1495162...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9ef2dbefc7fb3ac22e1528bc22a41a5c6c6a9539

Modified Files
--
src/backend/catalog/objectaddress.c |  2 +-
src/backend/optimizer/plan/createplan.c |  2 +-
src/backend/rewrite/rewriteDefine.c |  4 ++--
src/backend/storage/lmgr/predicate.c|  4 ++--
src/backend/utils/time/snapmgr.c| 14 +++---
src/bin/pg_upgrade/check.c  |  8 
src/bin/psql/describe.c |  4 ++--
src/include/catalog/pg_proc.h   |  2 +-
src/include/nodes/parsenodes.h  | 10 +-
src/include/replication/reorderbuffer.h |  6 +++---
src/tools/pgindent/typedefs.list|  1 +
11 files changed, 29 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Prevent table partitions from being turned into views.

[Dean Rasheed]

Prevent table partitions from being turned into views.

A table partition must be a table, not a view, so don't allow a
"_RETURN" rule to be added that would convert an existing table
partition into a view.

Amit Langote

Discussion: 
https://postgr.es/m/CAEZATCVzFcAjZwC1bTFvJ09skB_sgkF4SwPKMywev-XTnimp9Q%40mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/bcbf392ec84362040faf72daad22c647c74e2b2a

Modified Files
--
src/backend/rewrite/rewriteDefine.c | 6 ++
src/test/regress/expected/rules.out | 5 +
src/test/regress/sql/rules.sql  | 5 +
3 files changed, 16 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typo in comment.

[Heikki Linnakangas]

Fix typo in comment.

Etsuro Fujita

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6fd9930e68a3de6a05e6f60b08b16f219982ad05

Modified Files
--
src/backend/executor/execMain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typo in comment.

[Heikki Linnakangas]

Fix typo in comment.

Etsuro Fujita

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/26bef29fdd4cf754ebdf0157858b776abe90932c

Modified Files
--
src/backend/executor/execMain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Fix typo in comment.

[Heikki Linnakangas]

Fix typo in comment.

Etsuro Fujita

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/ba1f017069dd87d309e2716bf08a40df42b29baa

Modified Files
--
src/backend/executor/execMain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers