[COMMITTERS] pgsql: Revert test case added by commit 1e165d05fe06a9072867607886f818b

[Tom Lane]

Revert test case added by commit 1e165d05fe06a9072867607886f818bc255507db.

The buildfarm is still showing at least three distinct behaviors for
a bad locale name in CREATE COLLATION.  Although this test was helpful
for getting the error reporting code into some usable shape, it doesn't
seem worth carrying multiple expected-files in order to support the
test in perpetuity.  So pull it back out.

Discussion: 
https://postgr.es/m/CAKKotZS-wcDcofXDCH=sidiuaje+nqhn2cgjllx78anydmi...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/32ca22b02da9d8088b58b3dc64ad78464c7513a3

Modified Files
--
src/test/regress/expected/collate.out | 3 ---
src/test/regress/sql/collate.sql  | 1 -
2 files changed, 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Second try at getting useful errors out of newlocale/_create_loc

[Tom Lane]

Second try at getting useful errors out of newlocale/_create_locale.

The early buildfarm returns for commit 1e165d05f are pretty awful:
not only does Windows not return a useful error, but it looks like
a lot of Unix-ish platforms don't either.  Given the number of
different errnos seen so far, guess that what's really going on is
that some newlocale() implementations fail to set errno at all.
Hence, let's try zeroing errno just before newlocale() and then
if it's still zero report as though it's ENOENT.  That should cover
the Windows case too.

It's clear that we'll have to drop the regression test case, unless
we want to maintain a separate expected-file for platforms without
HAVE_LOCALE_T.  But I'll leave it there awhile longer to see if this
actually improves matters or not.

Discussion: 
https://postgr.es/m/CAKKotZS-wcDcofXDCH=sidiuaje+nqhn2cgjllx78anydmi...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/514f6132935d5bda84a475d4b70fe2bcfe116766

Modified Files
--
src/backend/utils/adt/pg_locale.c | 16 
1 file changed, 12 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Suppress less info in regression tests using DROP CASCADE.

[Tom Lane]

Suppress less info in regression tests using DROP CASCADE.

DROP CASCADE doesn't currently promise to visit dependent objects in
a fixed order, so when the regression tests use it, we typically need
to suppress the details of which objects get dropped in order to have
predictable test output.  Traditionally we've done that by setting
client_min_messages higher than NOTICE, but there's a better way:
we can "\set VERBOSITY terse" in psql.  That suppresses the DETAIL
message with the object list, but we still get the basic notice telling
how many objects were dropped.  So at least the test case can verify
that the expected number of objects were dropped.

The VERBOSITY method was already in use in a few places, but run
around and use it wherever it makes sense.

Discussion: https://postgr.es/m/10766.1501608...@sss.pgh.pa.us

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/8e7537261c4b7d296fc10513b93bd67dc3d415b0

Modified Files
--
src/test/regress/expected/alter_generic.out  |  6 +-
src/test/regress/expected/create_index.out   |  4 ++--
src/test/regress/expected/create_view.out|  4 +++-
src/test/regress/expected/object_address.out |  4 +++-
src/test/regress/expected/privileges.out |  9 +
src/test/regress/expected/rowsecurity.out| 18 +-
src/test/regress/expected/rules.out  |  5 +++--
src/test/regress/expected/stats_ext.out  |  6 --
src/test/regress/expected/typed_table.out|  4 
src/test/regress/sql/alter_generic.sql   |  2 +-
src/test/regress/sql/create_index.sql|  3 +--
src/test/regress/sql/create_view.sql |  2 +-
src/test/regress/sql/object_address.sql  |  2 +-
src/test/regress/sql/privileges.sql  |  8 
src/test/regress/sql/rowsecurity.sql | 16 ++--
src/test/regress/sql/rules.sql   |  4 ++--
src/test/regress/sql/stats_ext.sql   |  4 ++--
src/test/regress/sql/typed_table.sql |  7 ---
18 files changed, 52 insertions(+), 56 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Try to deliver a sane message for _create_locale() failure on Wi

[Tom Lane]

Try to deliver a sane message for _create_locale() failure on Windows.

We were just printing errno, which is certainly not gonna work on
Windows.  Now, it's not entirely clear from Microsoft's documentation
whether _create_locale() adheres to standard Windows error reporting
conventions, but let's assume it does and try to map the GetLastError
result to an errno.  If this turns out not to work, probably the best
thing to do will be to assume the error is always ENOENT on Windows.

This is a longstanding bug, but given the lack of previous field
complaints, I'm not excited about back-patching it.

Per report from Murtuza Zabuawala.

Discussion: 
https://postgr.es/m/CAKKotZS-wcDcofXDCH=sidiuaje+nqhn2cgjllx78anydmi...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/1e165d05fe06a9072867607886f818bc255507db

Modified Files
--
src/backend/utils/adt/pg_locale.c | 9 +++--
src/test/regress/expected/collate.out | 3 +++
src/test/regress/sql/collate.sql  | 1 +
3 files changed, 11 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: Fix typo

[Peter Eisentraut]

doc: Fix typo

Author: Fabien COELHO 

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/c1bb7870463bd8ab2b28b363616ec60a9041e13a

Modified Files
--
doc/src/sgml/ref/pgbench.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: doc: Fix typo

[Peter Eisentraut]

doc: Fix typo

Author: Fabien COELHO 

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ac219b92d3aa94641cc9628b59b478d0e1b7f542

Modified Files
--
doc/src/sgml/ref/pgbench.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Allow creation of C/POSIX collations without depending on libc b

[Tom Lane]

Allow creation of C/POSIX collations without depending on libc behavior.

Most of our collations code has special handling for the locale names
"C" and "POSIX", allowing those collations to be used whether or not
the system libraries think those locale names are valid, or indeed
whether said libraries even have any locale support.  But we missed
handling things that way in CREATE COLLATION.  This meant you couldn't
clone the C/POSIX collations, nor explicitly define a new collation
using those locale names, unless the libraries allow it.  That's pretty
pointless, as well as being a violation of pg_newlocale_from_collation's
API specification.

The practical effect of this change is quite limited: it allows creating
such collations even on platforms that don't HAVE_LOCALE_T, and it allows
making "POSIX" collation objects on Windows, which before this would only
let you make "C" collation objects.  Hence, even though this is a bug fix
IMO, it doesn't seem worth the trouble to back-patch.

In passing, suppress the DROP CASCADE detail messages at the end of the
collation regression test.  I'm surprised we've never been bit by
message ordering issues there.

Per report from Murtuza Zabuawala.

Discussion: 
https://postgr.es/m/CAKKotZS-wcDcofXDCH=sidiuaje+nqhn2cgjllx78anydmi...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/f97256570f45c33abf695a189ab11b25e6cd7985

Modified Files
--
src/backend/commands/collationcmds.c  | 12 
src/test/regress/expected/collate.out | 29 +
src/test/regress/sql/collate.sql  | 12 
3 files changed, 33 insertions(+), 20 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Further improve consistency of configure's program searching.

[Tom Lane]

Further improve consistency of configure's program searching.

Peter Eisentraut noted that commit 40b9f1921 had broken a configure
behavior that some people might rely on: AC_CHECK_PROGS(FOO,...) will
allow the search to be overridden by specifying a value for FOO on
configure's command line or in its environment, but AC_PATH_PROGS(FOO,...)
accepts such an override only if it's an absolute path.  We had worked
around that behavior for some, but not all, of the pre-existing uses
of AC_PATH_PROGS by just skipping the macro altogether when FOO is
already set.  Let's standardize on that workaround for all uses of
AC_PATH_PROGS, new and pre-existing, by wrapping AC_PATH_PROGS in a
new macro PGAC_PATH_PROGS.  While at it, fix a deficiency of the old
workaround code by making sure we report the setting to configure's log.

Eventually I'd like to improve PGAC_PATH_PROGS so that it converts
non-absolute override inputs to absolute form, eg "PYTHON=python3"
becomes, say, PYTHON = /usr/bin/python3.  But that will take some
nontrivial coding so it doesn't seem like a thing to do in late beta.

Discussion: 
https://postgr.es/m/90a92a7d-938e-507a-3bd7-ecd2b4004...@2ndquadrant.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/b21c569cea58a1396d9ffd8a7e7a84aa991a1123

Modified Files
--
config/docbook.m4  |   2 +-
config/perl.m4 |   5 +-
config/programs.m4 |  31 +--
config/python.m4   |   6 +-
config/tcl.m4  |   2 +-
configure  | 247 -
configure.in   |  26 +++---
7 files changed, 267 insertions(+), 52 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

[COMMITTERS] pgsql: Comment fix for partition_rbound_cmp().

[Dean Rasheed]

Comment fix for partition_rbound_cmp().

This was an oversight in d363d42.

Beena Emerson

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/4de6216877a32e869fe1cf168c1fe1ffb8c3d576

Modified Files
--
src/backend/catalog/partition.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers