[COMMITTERS] pgsql: Fix unlikely shared memory leak after failure in dshash_create()
Fix unlikely shared memory leak after failure in dshash_create(). Tidy-up for commit 8c0d7bafad36434cb08ac2c78e69ae72c194ca20, based on a complaint from Andres Freund. Author: Thomas Munro Reviewed-By: Andres Freund Discussion: https://postgr.es/m/20170823054644.efuzftxjpfi6wwqs%40alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4569715bd6faa4c43e489a7069ab7abca68ff663 Modified Files -- src/backend/lib/dshash.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add minimal regression test for blessed record type transfer.
Add minimal regression test for blessed record type transfer. Test that blessed records can be transferred through a TupleQueue and correctly decoded by another backend. While touching the file, make sure that force_parallel_mode settings only cover relevant tests. Author: Thomas Munro, editorialized by Andres Freund Reviewed-By: Andres Freund Discussion: https://postgr.es/m/20170823054644.efuzftxjpfi6wwqs%40alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d36f7efb39e1b9613193b2e12717dbe2418ddae5 Modified Files -- src/test/regress/expected/select_parallel.out | 38 ++- src/test/regress/sql/select_parallel.sql | 31 -- 2 files changed, 66 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Consolidate the function pointer types used by dshash.c.
Consolidate the function pointer types used by dshash.c. Commit 8c0d7bafad36434cb08ac2c78e69ae72c194ca20 introduced dshash with hash and compare functions like DynaHash's, and also variants that take a user data pointer instead of size. Simplify the interface by merging them into a single pair of function pointer types that take both size and a user data pointer. Since it is anticipated that memcmp and tag_hash behavior will be a common requirement, provide wrapper functions dshash_memcmp and dshash_memhash that conform to the new function types. Author: Thomas Munro Reviewed-By: Andres Freund Discussion: https://postgr.es/m/20170823054644.efuzftxjpfi6wwqs%40alap3.anarazel.de Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d7694fc148707cd8335d9ccfde9f4c17290189db Modified Files -- src/backend/lib/dshash.c | 65 +--- src/include/lib/dshash.h | 37 --- 2 files changed, 39 insertions(+), 63 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix harmless thinko in dsa.c.
Fix harmless thinko in dsa.c. Commit 16be2fd100199bdf284becfcee02c5eb20d8a11d added DSA_ALLOC_HUGE, DSA_ALLOC_ZERO and DSA_ALLOC_NO_OOM which have the same numerical values and meanings as the similarly named MCXT_... macros. In one place we accidentally used MCXT_ALLOC_NO_OOM when DSA_ALLOC_NO_OOM is wanted, so tidy that up. Author: Thomas Munro Discussion: http://postgr.es/m/CAEepm=2aimhxvkkxnmfqvbzmkxy0ukbva0-d38c5-qwrcm4...@mail.gmail.com Backpatch: 10, where dsa was introduced. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1563b8fa673800e79a54fac899f78c836f22ff5c Modified Files -- src/backend/utils/mmgr/dsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix harmless thinko in dsa.c.
Fix harmless thinko in dsa.c. Commit 16be2fd100199bdf284becfcee02c5eb20d8a11d added DSA_ALLOC_HUGE, DSA_ALLOC_ZERO and DSA_ALLOC_NO_OOM which have the same numerical values and meanings as the similarly named MCXT_... macros. In one place we accidentally used MCXT_ALLOC_NO_OOM when DSA_ALLOC_NO_OOM is wanted, so tidy that up. Author: Thomas Munro Discussion: http://postgr.es/m/CAEepm=2aimhxvkkxnmfqvbzmkxy0ukbva0-d38c5-qwrcm4...@mail.gmail.com Backpatch: 10, where dsa was introduced. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/20fbf25533763c8c78c9c668b718d831236fb111 Modified Files -- src/backend/utils/mmgr/dsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix bug that can cause walsender not to terminating at shutdown.
Fix bug that can cause walsender not to terminating at shutdown. When backpatching c6c333436 I (Andres Freund) mis-resolved a conflict in the 9.4 branch. Unfortunately that leads to walsenders waiting forever when shutting down with connected standbys, unless immediate mode is used, or the standbys are forced to disconnect by other means. Author: Marco Nenciarini Reported-By: Abhijit Gharami, Marco Nenciarini Discussion: http://postgr.es/m/1434ad79-ab0d-d6a9-4ea2-1afb1c06a...@2ndquadrant.it http://postgr.es/m/caa5_dud0o1xym8onozhrepypu-t8nzklzs1pt2jpzp0ns+v...@mail.gmail.com Backpatch: 9.4 only Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/b51c8efc6aff292912d8e77235eae8eef7ec909c Modified Files -- src/backend/replication/walsender.c | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: psql: Fix \gx when FETCH_COUNT is used
psql: Fix \gx when FETCH_COUNT is used Set expanded output when requested through \gx in ExecQueryUsingCursor() (used when FETCH_COUNT is set). Discussion: https://www.postgresql.org/message-id/CB7A53AA-5645-4BDD-AB07-4D22CD9D8FF1%40gmx.net Author: Tobias Bussmann Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/51d0fa8ed93fe5befe91498f1a3eb5aede32677a Modified Files -- src/bin/psql/common.c | 4 src/test/regress/expected/psql.out | 25 + src/test/regress/sql/psql.sql | 10 ++ 3 files changed, 39 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: psql: Fix \gx when FETCH_COUNT is used
psql: Fix \gx when FETCH_COUNT is used Set expanded output when requested through \gx in ExecQueryUsingCursor() (used when FETCH_COUNT is set). Discussion: https://www.postgresql.org/message-id/CB7A53AA-5645-4BDD-AB07-4D22CD9D8FF1%40gmx.net Author: Tobias Bussmann Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0cdc3e47bea442643c9870dc419364b9f2f52dcb Modified Files -- src/bin/psql/common.c | 4 src/test/regress/expected/psql.out | 25 + src/test/regress/sql/psql.sql | 10 ++ 3 files changed, 39 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: pg_upgrade: Remove dead code
pg_upgrade: Remove dead code Remove code meant for upgrading to a particular version of PostgreSQL 9.0. Since pg_upgrade only supports upgrading to the current major version, this code is no longer useful. Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8a7beca69112755094a3f2ca1daa745d378dd452 Modified Files -- src/bin/pg_upgrade/check.c | 6 -- 1 file changed, 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: pg_upgrade: Remove dead code
pg_upgrade: Remove dead code Remove code meant for upgrading to a particular version of PostgreSQL 9.0. Since pg_upgrade only supports upgrading to the current major version, this code is no longer useful. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6ce6a61840cc90172ad3da7bf303656132fa5fab Modified Files -- src/bin/pg_upgrade/check.c | 6 -- 1 file changed, 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Increase SCRAM salt length
Increase SCRAM salt length The original value 12 was set based on RFC 5802 for SCRAM-SHA-1, but RFC 7677 for SCRAM-SHA-256 uses 16, so use that. (This does not affect the validity of already stored verifiers.) Discussion: https://www.postgresql.org/message-id/flat/12cc9297-7e05-932f-d863-765e5626ead4%402ndquadrant.com Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cf98e3837db36d985507a924e392847e2ab857d0 Modified Files -- src/include/common/scram-common.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Increase SCRAM salt length
Increase SCRAM salt length The original value 12 was set based on RFC 5802 for SCRAM-SHA-1, but RFC 7677 for SCRAM-SHA-256 uses 16, so use that. (This does not affect the validity of already stored verifiers.) Discussion: https://www.postgresql.org/message-id/flat/12cc9297-7e05-932f-d863-765e5626ead4%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/fe7774144d5c3f3a2941a2ca51e61352e4005991 Modified Files -- src/include/common/scram-common.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make new regression test case parallel-safe, and improve its out
Make new regression test case parallel-safe, and improve its output. The test case added by commit 1f6d515a6 fails on buildfarm members that have force_parallel_mode turned on, because we currently don't report sort performance details from worker processes back to the master. To fix that, just make the test table be temp rather than regular; that's a good idea anyway to forestall any possible interference from auto-analyze. (The restriction that workers can't access temp tables might go away someday, but almost certainly not before the other thing gets fixed.) Also, improve the test so that we retain as much as possible of the EXPLAIN ANALYZE output. This aids debugging failures, and might also expose problems that the preceding version masked. Discussion: http://postgr.es/m/cade5jyluugneeusyw6q_4mzfytxhxavcqmgasf0yiy8zdgg...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1177ab1dabf72bafee8f19d904cee3a299f25892 Modified Files -- src/test/regress/expected/subselect.out | 77 - src/test/regress/sql/subselect.sql | 67 +--- 2 files changed, 66 insertions(+), 78 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Improve plural handling in error message
On 8/24/17 00:37, Tom Lane wrote: > Peter Eisentraut writes: >> Improve plural handling in error message > > You missed at least one expected-file update, see > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=frogmouth&dt=2017-08-24%2002%3A30%3A24 fixed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix up secondary expected files
Fix up secondary expected files for commit 237a0b87b1dc90f8789aa5441a2a11e67f46c96e Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/27b89876c0fb08faa17768c68101186cda2e4bef Modified Files -- src/test/regress/expected/geometry_1.out | 2 +- src/test/regress/expected/geometry_2.out | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
