[COMMITTERS] pgsql: Fix bug so logical rep launcher saves correctly time of last sta
Fix bug so logical rep launcher saves correctly time of last startup of worker. Previously the logical replication launcher stored the last timestamp when it started the worker, in the local variable "last_start_time", in order to check whether wal_retrive_retry_interval elapsed since the last startup of worker. If it has elapsed, the launcher sees pg_subscription and starts new worker if necessary. This is for limitting the startup of worker to once a wal_retrieve_retry_interval. The bug was that the variable "last_start_time" was defined and always initialized with 0 at the beginning of the launcher's main loop. So even if it's set to the last timestamp in later phase of the loop, it's always reset to 0. Therefore the launcher could not check correctly whether wal_retrieve_retry_interval elapsed since the last startup. This patch moves the variable "last_start_time" outside the main loop so that it will not be reset. Reviewed-by: Petr Jelinek Discussion: http://postgr.es/m/cahgqgwgjrpo++xm4mfenawpy1egxksgdguyv43guglgu-x8...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9f11fcec6624511ca85c1a6b049201be1fed6ef4 Modified Files -- src/backend/replication/logical/launcher.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in comment.
Fix typo in comment. Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1f8b060121d654fbb08702752f63d251f5ce8088 Modified Files -- src/backend/commands/subscriptioncmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Set the priorities of all quorum synchronous standbys to 1.
Set the priorities of all quorum synchronous standbys to 1. In quorum-based synchronous replication, all the standbys listed in synchronous_standby_names equally have chances to be chosen as synchronous standbys. So they should have the same priority. However, previously, quorum standbys whose names appear earlier in the list were given higher priority values though the difference of those priority values didn't affect the selection of synchronous standbys. Users could see those "meaningless" priority values in pg_stat_replication and this was confusing. This commit gives all the quorum synchronous standbys the same highest priority, i.e., 1, in order to remove such confusion. Author: Fujii Masao Reviewed-by: Masahiko Sawada, Kyotaro Horiguchi Discussion: http://postgr.es/m/CAHGQGwEKOw=smplxjzkbsh6wwdbgonvz46qjhbtsiz-d-2r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/346199dcab4cfb2c023373fb3d859583b59810d7 Modified Files -- src/backend/replication/syncrep.c | 9 - src/test/recovery/t/007_sync_rep.pl | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Update copyright in recently added files.
On Wed, Apr 26, 2017 at 12:03 AM, Tom Lane wrote: > Fujii Masao writes: >> Update copyright in recently added files. >> This commit also fixes copyright line missed by the automated script. > > Just for the record, none of those were "missed by the automated script"; > if they had been, that would be a bug we need to fix. I suppose you are > thinking of the 2016 copyright in Gen_fmgrtab.pl, but git blame says that > was added by 352a24a1f which was pushed on 2017-01-17. Yes, I was thinking that. You're right. Sorry for my fault... Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Update copyright in recently added files.
Update copyright in recently added files. This commit also fixes copyright line missed by the automated script. Author: Masahiko Sawada Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7cc14ae9d8a46a6fac002cb5d7ef385fc6ccdeb4 Modified Files -- src/backend/replication/pgoutput/pgoutput.c | 2 +- src/backend/utils/Gen_fmgrtab.pl| 2 +- src/backend/utils/mmgr/memdebug.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Get rid of extern declarations of non-existent functions.
Get rid of extern declarations of non-existent functions. Those extern declartions were mistakenly added by commit 7c4f52409. Author: Petr Jelinek Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cbc2270e3fcfae0831e4aa22f797f1dcac483d46 Modified Files -- src/include/replication/logical.h | 6 -- 1 file changed, 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent log_replication_commands from causing SQL commands to be
Prevent log_replication_commands from causing SQL commands to be logged. Commit 7c4f524 allowed walsender to execute normal SQL commands to support table sync feature in logical replication. Previously while log_statement caused such SQL commands to be logged, log_replication_commands caused them to be logged, too. That is, such SQL commands were logged twice unexpectedly when those settings were both enabled. This commit forces log_replication_commands to log only replication commands, to prevent normal SQL commands from being logged twice. Author: Masahiko Sawada Reviewed-by: Kyotaro Horiguchi Reported-by: Fujii Masao Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=zosy3kx_pna9r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3a66581dd12b4108ce22fb4dad38258df39cb685 Modified Files -- src/backend/replication/walsender.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Mark some columns in pg_subscription as NOT NULL.
Mark some columns in pg_subscription as NOT NULL. In pg_subscription, subconninfo, subslotname, subsynccommit and subpublications are expected not to be NULL. Therefore this patch adds BKI_FORCE_NOT_NULL markings to them. This patch is basically unnecessary unless the code has a bug which wrongly sets either of those columns to NULL. But it's good to have this as a safeguard. Author: Masahiko Sawada Reviewed-by: Kyotaro Horiguchi Reported-by: Fujii Masao Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=zosy3kx_pna9r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/88b0a31926331eb5336ec92010b3b4f7e6efb53c Modified Files -- src/include/catalog/pg_subscription.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Don't call the function that may raise an error while holding sp
Don't call the function that may raise an error while holding spinlock. It's not safe to raise an error while holding spinlock. But previously logical replication worker for table sync called the function which reads the system catalog and may raise an error while it's holding spinlock. Which could lead to the trouble where spinlock will never be released and the server gets stuck infinitely. Author: Petr Jelinek Reviewed-by: Kyotaro Horiguchi and Fujii Masao Reported-by: Fujii Masao Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=zosy3kx_pna9r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/8bbc618b4825b13a9776f2289acd06483e140300 Modified Files -- src/backend/replication/logical/tablesync.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve documentation and comment for quorum-based sync replicat
Improve documentation and comment for quorum-based sync replication. Author: Masahiko Sawada, heavily modified by me Discussion: http://postgr.es/m/CAHGQGwEKOw=smplxjzkbsh6wwdbgonvz46qjhbtsiz-d-2r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a790ed9f69ef584c12aec68d0d80e6b6b543bacb Modified Files -- doc/src/sgml/high-availability.sgml | 21 - src/backend/replication/syncrep.c | 5 + 2 files changed, 21 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: A collection of small fixes for logical replication.
A collection of small fixes for logical replication. * Be sure to reset the launcher's pid (LogicalRepCtx->launcher_pid) to 0 even when the launcher emits an error. * Declare ApplyLauncherWakeup() as a static function because it's called only in launcher.c. * Previously IsBackendPId() was used to check whether the launcher's pid was valid. IsBackendPid() was necessary because there was the bug where the launcher's pid was not reset to 0. But now it's fixed, so IsBackendPid() is not necessary and this patch removes it. Author: Masahiko Sawada Reviewed-by: Kyotaro Horiguchi Reported-by: Fujii Masao Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=zosy3kx_pna9r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/280c53ecfbcad442c4b5eaab4cc3e65408f486eb Modified Files -- src/backend/replication/logical/launcher.c | 19 +-- src/include/replication/logicallauncher.h | 1 - 2 files changed, 17 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use DatumGetInt32() to extract 32-bit integer value from a datum
Use DatumGetInt32() to extract 32-bit integer value from a datum. Previously DatumGetObjectId() was wrongly used for that. Author: Masahiko Sawada Reviewed-by: Kyotaro Horiguchi Reported-by: Fujii Masao Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=zosy3kx_pna9r...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/39a6772d04940b994acd9a3fd954cacdc2f88b26 Modified Files -- src/backend/replication/logical/launcher.c | 2 +- src/backend/replication/logical/worker.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typos in comment and log message.
Fix typos in comment and log message. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/9e0e5550c5f273dc4133687b1a682eb39933f47e Modified Files -- src/backend/catalog/aclchk.c | 2 +- src/backend/commands/subscriptioncmds.c| 2 +- src/test/regress/expected/subscription.out | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Move pg_stat_progress_vacuum to the table of Dynamic Statistics
Move pg_stat_progress_vacuum to the table of Dynamic Statistics Views in doc. Previously the description about pg_stat_progress_vacuum was in the table of "Collected Statistics Views" in the doc. But since it repors dynamic information, i.e., the current progress of VACUUM, its description should be in the table of "Dynamic Statistics Views". Back-patch to 9.6 where pg_stat_progress_vacuum was added. Author: Amit Langote Discussion: http://postgr.es/m/7ab51b59-8d4d-6193-c60a-b75f222ef...@lab.ntt.co.jp Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/7a3e8d7b503c25e009b9f591554617a2434c72eb Modified Files -- doc/src/sgml/monitoring.sgml | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Move pg_stat_progress_vacuum to the table of Dynamic Statistics
Move pg_stat_progress_vacuum to the table of Dynamic Statistics Views in doc. Previously the description about pg_stat_progress_vacuum was in the table of "Collected Statistics Views" in the doc. But since it repors dynamic information, i.e., the current progress of VACUUM, its description should be in the table of "Dynamic Statistics Views". Back-patch to 9.6 where pg_stat_progress_vacuum was added. Author: Amit Langote Discussion: http://postgr.es/m/7ab51b59-8d4d-6193-c60a-b75f222ef...@lab.ntt.co.jp Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5c63dab83836f9287e3809d5193117ea3bdd9adb Modified Files -- doc/src/sgml/monitoring.sgml | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve documentations for ALTER PUBLICATION and ALTER SUBSCRIPT
Improve documentations for ALTER PUBLICATION and ALTER SUBSCRIPTION. Discussion: http://postgr.es/m/cad21aoc32ygtatenqtfxztjmhhe6hxs4cpjtnd3n-ts8f-a...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/a6e7d591d0129bc7f1f186cb40a6ebd7963956ab Modified Files -- doc/src/sgml/ref/alter_publication.sgml | 19 +++ doc/src/sgml/ref/alter_subscription.sgml | 19 +++ 2 files changed, 38 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve tab-completion of DDL for publication and subscription.
Improve tab-completion of DDL for publication and subscription. Author: Masahiko Sawada Discussion: http://postgr.es/m/cad21aoc32ygtatenqtfxztjmhhe6hxs4cpjtnd3n-ts8f-a...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c525f740661104e3d8578a133ed6b4a8cd7028ac Modified Files -- src/bin/psql/tab-complete.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add max_sync_workers_per_subscription to postgresql.conf.sample.
Add max_sync_workers_per_subscription to postgresql.conf.sample. This commit also does - add REPLICATION_SUBSCRIBERS into config_group - mark max_logical_replication_workers and max_sync_workers_per_subscription as REPLICATION_SUBSCRIBERS parameters - move those parameters into "Subscribers" section in postgresql.conf.sample Author: Masahiko Sawada, Petr Jelinek and me Reported-by: Masahiko Sawada Discussion: http://postgr.es/m/CAD21AoAonSCoa=v=87ZO3vhfUZA1k_E2XRNHTt=xiowgua+...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ff7bce174390ae063c122ab04020bd4ee070d6ad Modified Files -- src/backend/utils/misc/guc.c | 6 -- src/backend/utils/misc/postgresql.conf.sample | 8 +++- src/include/utils/guc_tables.h| 1 + 3 files changed, 12 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin
On Wed, Mar 29, 2017 at 3:31 PM, Masahiko Sawada wrote: > On Wed, Mar 29, 2017 at 1:32 AM, Fujii Masao wrote: >> On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada >> wrote: >>> On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada >>> wrote: >>>> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote: >>>>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada >>>>> wrote: >>>>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs >>>>>> wrote: >>>>>>> Allow vacuums to report oldestxmin >>>>>>> >>>>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they >>>>>>> used while cleaning tables, helping to make better sense out of >>>>>>> the other statistics we report in various cases. >>>>>>> >>>>>>> Branch >>>>>>> -- >>>>>>> master >>>>>>> >>>>>>> Details >>>>>>> --- >>>>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c >>>>>>> >>>>>>> Modified Files >>>>>>> -- >>>>>>> src/backend/commands/vacuumlazy.c | 9 + >>>>>>> 1 file changed, 5 insertions(+), 4 deletions(-) >>>>>>> >>>>>>> >>>>>> >>>>>> Should we change the example in vacuum.sgml file as well? Attached patch. >>>>> >>>>> "tuples" in the above should be "row versions"? >>>>> We should review not only this line but also all the lines in the example >>>>> of VERBOSE output, I think. >>>> >>>> Right. These verbose log messages are out of date. I ran >>>> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as >>>> possible. Attached patch updates verbose log messages. >>>> >>>> >>> >>> Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is >>> introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003. >> >> This is the evidence that no one cares about the details of VACUUM VERBOSE >> output example. So I'm tempted to simplify the example (please see the >> attached patch) instead of keeping updating the example. > > Yes. I agree. Pushed. I back-patched to all supported versions according to Alvaro's comment upthread. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that activity report in 2003, but we had forgotten to update the example. So basically we need to update the example. But since no one cared about the details of VACUUM output and complained about that mistake for such long time, per discussion on hackers, we decided to get rid of the detailed activity report from the example and simplify it. Back-patch to all supported versions. Reported by Masahiko Sawada, patch by me. Discussion: https://postgr.es/m/cad21aoaga2pb3p-cwmtkxbsbkzs1bcdgblcyvcvcdxspg_x...@mail.gmail.com Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/75eea8d7f54b922ab13ac96ab3d751f61c21d487 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 33 +++-- 1 file changed, 3 insertions(+), 30 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that activity report in 2003, but we had forgotten to update the example. So basically we need to update the example. But since no one cared about the details of VACUUM output and complained about that mistake for such long time, per discussion on hackers, we decided to get rid of the detailed activity report from the example and simplify it. Back-patch to all supported versions. Reported by Masahiko Sawada, patch by me. Discussion: https://postgr.es/m/cad21aoaga2pb3p-cwmtkxbsbkzs1bcdgblcyvcvcdxspg_x...@mail.gmail.com Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/82f7c325530064d487fe6a9d378e59472d8346dc Modified Files -- doc/src/sgml/ref/vacuum.sgml | 33 +++-- 1 file changed, 3 insertions(+), 30 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that activity report in 2003, but we had forgotten to update the example. So basically we need to update the example. But since no one cared about the details of VACUUM output and complained about that mistake for such long time, per discussion on hackers, we decided to get rid of the detailed activity report from the example and simplify it. Back-patch to all supported versions. Reported by Masahiko Sawada, patch by me. Discussion: https://postgr.es/m/cad21aoaga2pb3p-cwmtkxbsbkzs1bcdgblcyvcvcdxspg_x...@mail.gmail.com Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/cb366b507995cf8fd17c538a9b4dd35204e80de6 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 33 +++-- 1 file changed, 3 insertions(+), 30 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that activity report in 2003, but we had forgotten to update the example. So basically we need to update the example. But since no one cared about the details of VACUUM output and complained about that mistake for such long time, per discussion on hackers, we decided to get rid of the detailed activity report from the example and simplify it. Back-patch to all supported versions. Reported by Masahiko Sawada, patch by me. Discussion: https://postgr.es/m/cad21aoaga2pb3p-cwmtkxbsbkzs1bcdgblcyvcvcdxspg_x...@mail.gmail.com Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/86f0e538955ebacf6b79655807b635ca23ed6d28 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that activity report in 2003, but we had forgotten to update the example. So basically we need to update the example. But since no one cared about the details of VACUUM output and complained about that mistake for such long time, per discussion on hackers, we decided to get rid of the detailed activity report from the example and simplify it. Back-patch to all supported versions. Reported by Masahiko Sawada, patch by me. Discussion: https://postgr.es/m/cad21aoaga2pb3p-cwmtkxbsbkzs1bcdgblcyvcvcdxspg_x...@mail.gmail.com Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/fa0d1fd8955ca22642890421721bcc2de6a54c2b Modified Files -- doc/src/sgml/ref/vacuum.sgml | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Simplify the example of VACUUM in documentation.
Simplify the example of VACUUM in documentation. Previously a detailed activity report by VACUUM VERBOSE ANALYZE was described as an example of VACUUM in docs. But it had been obsolete for a long time. For example, commit feb4f44d296b88b7f0723f4a4f3945a371276e0b updated the content of that activity report in 2003, but we had forgotten to update the example. So basically we need to update the example. But since no one cared about the details of VACUUM output and complained about that mistake for such long time, per discussion on hackers, we decided to get rid of the detailed activity report from the example and simplify it. Back-patch to all supported versions. Reported by Masahiko Sawada, patch by me. Discussion: https://postgr.es/m/cad21aoaga2pb3p-cwmtkxbsbkzs1bcdgblcyvcvcdxspg_x...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ec19693014ed48fa1d8c7e0ce450795f752c4456 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin
On Tue, Mar 28, 2017 at 1:06 AM, Masahiko Sawada wrote: > On Sun, Mar 26, 2017 at 2:26 AM, Masahiko Sawada > wrote: >> On Sun, Mar 26, 2017 at 1:37 AM, Fujii Masao wrote: >>> On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada >>> wrote: >>>> On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs wrote: >>>>> Allow vacuums to report oldestxmin >>>>> >>>>> Allow VACUUM and Autovacuum to report the oldestxmin value they >>>>> used while cleaning tables, helping to make better sense out of >>>>> the other statistics we report in various cases. >>>>> >>>>> Branch >>>>> -- >>>>> master >>>>> >>>>> Details >>>>> --- >>>>> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c >>>>> >>>>> Modified Files >>>>> -- >>>>> src/backend/commands/vacuumlazy.c | 9 + >>>>> 1 file changed, 5 insertions(+), 4 deletions(-) >>>>> >>>>> >>>> >>>> Should we change the example in vacuum.sgml file as well? Attached patch. >>> >>> "tuples" in the above should be "row versions"? >>> We should review not only this line but also all the lines in the example >>> of VERBOSE output, I think. >> >> Right. These verbose log messages are out of date. I ran >> VACUUM(VERBOSE, ANALYZE) with same scenario as current example as >> possible. Attached patch updates verbose log messages. >> >> > > Surprisingly the changes "tuples" -> "row versions" in vacuumlazy.c is > introduced by commit feb4f44d296b88b7f0723f4a4f3945a371276e0b in 2003. This is the evidence that no one cares about the details of VACUUM VERBOSE output example. So I'm tempted to simplify the example (please see the attached patch) instead of keeping updating the example. > If this patch is applied, it should back-patch to all supported > branches. Not sure if it's worth back-patching that. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Allow vacuums to report oldestxmin
On Mon, Mar 6, 2017 at 9:37 PM, Masahiko Sawada wrote: > On Fri, Mar 3, 2017 at 10:50 PM, Simon Riggs wrote: >> Allow vacuums to report oldestxmin >> >> Allow VACUUM and Autovacuum to report the oldestxmin value they >> used while cleaning tables, helping to make better sense out of >> the other statistics we report in various cases. >> >> Branch >> -- >> master >> >> Details >> --- >> http://git.postgresql.org/pg/commitdiff/9eb344faf54a849898d9be012ddfa8204cfeb57c >> >> Modified Files >> -- >> src/backend/commands/vacuumlazy.c | 9 + >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> > > Should we change the example in vacuum.sgml file as well? Attached patch. "tuples" in the above should be "row versions"? We should review not only this line but also all the lines in the example of VERBOSE output, I think. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make VACUUM VERBOSE report the number of skipped frozen pages.
Make VACUUM VERBOSE report the number of skipped frozen pages. Previously manual VACUUM did not report the number of skipped frozen pages even when VERBOSE option is specified. But this information is helpful to monitor the VACUUM activity, and also autovacuum reports that number in the log file when the condition of log_autovacuum_min_duration is met. This commit changes VACUUM VERBOSE so that it reports the number of frozen pages that it skips. Author: Masahiko Sawada Reviewed-by: Yugo Nagata and Jim Nasby Discussion: http://postgr.es/m/CAD21AoDZQKCxo0L39Mrq08cONNkXQKXuh=2dp1q8ebmt35s...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/70adf2fbe18f83f34b576ee83f42ea9d28375bf0 Modified Files -- doc/src/sgml/ref/vacuum.sgml | 2 +- src/backend/commands/vacuumlazy.c | 8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Prevent logical rep workers with removed subscriptions from star
Prevent logical rep workers with removed subscriptions from starting. Any logical rep workers must have their subscription entries in pg_subscription. To ensure this, we need to prevent the launcher from starting new worker corresponding to the subscription that DROP SUBSCRIPTION command is removing. To implement this, previously LogicalRepLauncherLock was introduced and held until the end of transaction running DROP SUBSCRIPTION. But using LWLock for that purpose was not valid. Instead, this commit changes DROP SUBSCRIPTION so that it takes AccessExclusiveLock on pg_subscription, in order to ensure that the launcher cannot see any subscriptions being removed. Also this commit gets rid of LogicalRepLauncherLock. Patch by me, reviewed by Petr Jelinek Discussion: https://www.postgresql.org/message-id/cahgqgwhpi8ky-yanffe0sgmhktsycqltnkx07bw9s7-rn17...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4eafdcc27608dfb8a3afa3155d6ae07f66179782 Modified Files -- src/backend/commands/subscriptioncmds.c| 12 ++-- src/backend/replication/logical/launcher.c | 10 -- src/backend/storage/lmgr/lwlocknames.txt | 3 +-- 3 files changed, 7 insertions(+), 18 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command, take 2.
Fix connection leak in DROP SUBSCRIPTION command, take 2. Commit 898a792eb8283e31efc0b6fcbc03bbcd5f7df667 fixed the connection leak issue, but it was an unreliable way of bugfix. This bugfix was assuming that walrcv_command() subroutine cannot throw an error, but it's untenable assumption. For example, if it will be changed so that an error is thrown, connection leak issue will happen again. This patch ensures that the connection is closed even when walrcv_command() subroutine throws an error. Patch by me, reviewed by Petr Jelinek and Michael Paquier Discussion: https://www.postgresql.org/message-id/2058.1487704...@sss.pgh.pa.us Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/77d21970ae19418f321e6a76ddf1a57ae999c77a Modified Files -- src/backend/commands/subscriptioncmds.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.
On Wed, Feb 22, 2017 at 1:27 PM, Michael Paquier wrote: > On Wed, Feb 22, 2017 at 8:39 AM, Fujii Masao wrote: >> On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier >> wrote: >>> On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: >>>> Fujii Masao writes: >>>>> Fix connection leak in DROP SUBSCRIPTION command. >>>>> Previously the command forgot to close the connection to the publisher >>>>> when it failed to drop the replication slot. >>>> >>>> If there's a bug here, this seems like an extremely unreliable way of >>>> fixing it. What if an error gets thrown before you reach that ereport? >>>> >>>> In other words, this coding is assuming that the walrcv_command() >>>> subroutine cannot throw an error, >> >> Yes, but I agree that walrcv_command() may be changed in the future so that >> an error is thrown and current coding is not reliable in that case. >> >>>> which I would consider dangerous >>>> even if it were a fixed subroutine. If it's a hook that's doing >>>> unknown stuff, that seems a completely untenable assumption. You >>>> really need either to hook the cleanup action into normal error >>>> recovery, or to use a PG_TRY block. >>> >>> To be honest, I have thought about using PG_ENSURE_ERROR_CLEANUP() >>> when seeing the thread. If other ERROR messages are generated in the >>> future that the current fix would be unreliable. >> >> What about the attached patch? > > Thanks for the patch. That looks good to me. Petr and Michael, Thanks for the review! Pushed. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.
On Wed, Feb 22, 2017 at 6:57 AM, Michael Paquier wrote: > On Wed, Feb 22, 2017 at 4:12 AM, Tom Lane wrote: >> Fujii Masao writes: >>> Fix connection leak in DROP SUBSCRIPTION command. >>> Previously the command forgot to close the connection to the publisher >>> when it failed to drop the replication slot. >> >> If there's a bug here, this seems like an extremely unreliable way of >> fixing it. What if an error gets thrown before you reach that ereport? >> >> In other words, this coding is assuming that the walrcv_command() >> subroutine cannot throw an error, Yes, but I agree that walrcv_command() may be changed in the future so that an error is thrown and current coding is not reliable in that case. >> which I would consider dangerous >> even if it were a fixed subroutine. If it's a hook that's doing >> unknown stuff, that seems a completely untenable assumption. You >> really need either to hook the cleanup action into normal error >> recovery, or to use a PG_TRY block. > > To be honest, I have thought about using PG_ENSURE_ERROR_CLEANUP() > when seeing the thread. If other ERROR messages are generated in the > future that the current fix would be unreliable. What about the attached patch? Regards, -- Fujii Masao bugfix.patch Description: Binary data -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Make walsender always initialize the buffers.
On Wed, Feb 22, 2017 at 4:04 AM, Tom Lane wrote: > Fujii Masao writes: >> Make walsender always initialize the buffers. >> ... >> Back-patch to 9.4 where replication slot was introduced. > > Doesn't look like you actually pushed the back-patch? I only see > this in HEAD. Oh, sorry... I pushed the back-patch. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make walsender always initialize the buffers.
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes walsender so that it always initialize them before it executes the requested replication command. Back-patch to 9.4 where replication slot was introduced. Problem report and initial patch by Stas Kelvich, modified by me. Report: https://www.postgresql.org/message-id/a1e9cb90-1fac-4cad-8dba-9aa62a6e9...@postgrespro.ru Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/9fab155c68a4e2164c39f61bc849ad669ad54f2c Modified Files -- src/backend/replication/walsender.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make walsender always initialize the buffers.
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes walsender so that it always initialize them before it executes the requested replication command. Back-patch to 9.4 where replication slot was introduced. Problem report and initial patch by Stas Kelvich, modified by me. Report: https://www.postgresql.org/message-id/a1e9cb90-1fac-4cad-8dba-9aa62a6e9...@postgrespro.ru Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/feb659cced9755966190bbabfcead54fcfcddf0e Modified Files -- src/backend/replication/walsender.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make walsender always initialize the buffers.
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes walsender so that it always initialize them before it executes the requested replication command. Back-patch to 9.4 where replication slot was introduced. Problem report and initial patch by Stas Kelvich, modified by me. Report: https://www.postgresql.org/message-id/a1e9cb90-1fac-4cad-8dba-9aa62a6e9...@postgrespro.ru Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a3eb715a36bdd28d809d3dd859f169489352882b Modified Files -- src/backend/replication/walsender.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in comment.
Fix typo in comment. neha khatri Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/e14ec7d346f8686c9471c16a01579d6b1c3b4975 Modified Files -- src/backend/utils/adt/varlena.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix connection leak in DROP SUBSCRIPTION command.
Fix connection leak in DROP SUBSCRIPTION command. Previously the command forgot to close the connection to the publisher when it failed to drop the replication slot. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/898a792eb8283e31efc0b6fcbc03bbcd5f7df667 Modified Files -- src/backend/commands/subscriptioncmds.c | 4 1 file changed, 4 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make walsender always initialize the buffers.
Make walsender always initialize the buffers. Walsender uses the local buffers for each outgoing and incoming message. Previously when creating replication slot, walsender forgot to initialize one of them and which can cause the segmentation fault error. To fix this issue, this commit changes walsender so that it always initialize them before it executes the requested replication command. Back-patch to 9.4 where replication slot was introduced. Problem report and initial patch by Stas Kelvich, modified by me. Report: https://www.postgresql.org/message-id/a1e9cb90-1fac-4cad-8dba-9aa62a6e9...@postgrespro.ru Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1d04a59be31bf004b880226be0e3fe84acff2815 Modified Files -- src/backend/replication/walsender.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove confusing comment about unsupported feature.
Remove confusing comment about unsupported feature. The initial table synchronization feature has not been supported yet, but there was the confusing header comment about it in logical/worker.c. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/d36537008a8d53853d2fda49913cb54fa6e28f94 Modified Files -- src/backend/replication/logical/worker.c | 3 --- 1 file changed, 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Replace reference to "xlog-method" with "wal-method" in error me
Replace reference to "xlog-method" with "wal-method" in error message. Commit 62e8b38 renamed "--xlog-method" option for pg_basebackup to "--wal-method", but forgot to update the error message mentioning that option. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0dfa89ba2992b1be86ad3a5523a8d26dce31a08c Modified Files -- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Replace references to "xlog" with "wal" in docs.
Replace references to "xlog" with "wal" in docs. Commit f82ec32ac30ae7e3ec7c84067192535b2ff8ec0e renamed the pg_xlog directory to pg_wal. To make things consistent, we decided to eliminate "xlog" from user-visible docs. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/f10637ebe02074e264b17606c00bc09da986c60d Modified Files -- doc/src/sgml/datatype.sgml | 2 +- doc/src/sgml/pgstandby.sgml | 2 +- doc/src/sgml/protocol.sgml | 2 +- doc/src/sgml/storage.sgml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION c
Be sure to release LogicalRepLauncherLock in DROP SUBSCRIPTION command. Previously DROP SUBSCRIPTION command forgot to release the lock at all. Original patches by Kyotaro Horiguchi and Michael Paquier, but I didn't use them. Discussion: http://postgr.es/m/20170201.173623.66249355.horiguchi.kyot...@lab.ntt.co.jp Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/39b8cc991fe31ee8df8b0fee467bbd9800fcc1c5 Modified Files -- src/backend/commands/subscriptioncmds.c | 2 ++ 1 file changed, 2 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in description for pg_replication_origin_advance functi
Fix typo in description for pg_replication_origin_advance function. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bdadf36eb40e88f93a9daf20ecd005595ebec1cd Modified Files -- src/include/catalog/pg_proc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix bug in verifying TLI (timeline ID) in WAL page header during
Fix bug in verifying TLI (timeline ID) in WAL page header during recovery.. Previously ValidXLOGHeader() could not handle properly the case where we re-read the WAL segment after reading its subsequent segment having larger TLI. This case can happen, for example, when the WAL record is split across two segments having different TLI. In this case, since the segment we're re-reading has the smaller TLI than its subsequent segment we've already read, ValidXLOGHeader() reported an error "out-of-sequence TLI" even though TLI sequence was valid (i.e., TLI doesn't go backwards across successive WAL pages and segments). This issue was fixed by commit 7fcbf6a405ffc12a4546a25b98592ee6733783fc in 9.3 or later though there is no mention to the bug fix in its commit log. It changed the WAL check code so that it verifies TLI for pages that are later than the last remembered LSN. This patch applies the same change to 9.2 where the issue still existed. Author: Takayuki Tsunakawa and Amit Kapila Reviewed-By: Robert Haas Discussion: https://postgr.es/m/0A3221C70F24FB45833433255569204D1F5E15E5@G01JPEXMBYT05 Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/38bec18056b86f793afa642b2f991ea6ec1b8491 Modified Files -- src/backend/access/transam/xlog.c | 58 +++ 1 file changed, 22 insertions(+), 36 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Mention logical replication tests in src/test/README.
Mention logical replication tests in src/test/README. Craig Ringer Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3eaf03b5d331b7a06d79e5ad2be7e36c4a9c3d72 Modified Files -- src/test/README | 3 +++ 1 file changed, 3 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Be sure to release the lock on failure to launch logical replica
Be sure to release the lock on failure to launch logical replication worker. Petr Jelinek Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dc82f5a6406dfef21ae1668b1c69a32c8a68c670 Modified Files -- src/backend/replication/logical/launcher.c | 1 + 1 file changed, 1 insertion(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add description of temporary column into pg_replication_slots do
Add description of temporary column into pg_replication_slots doc. Ayumi Ishii Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/954737095061e5b5f1d87fb8cc43f7f8afff64c6 Modified Files -- doc/src/sgml/catalogs.sgml | 9 + 1 file changed, 9 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Fix an assertion failure related to an exclusive backup.
Previously multiple sessions could execute pg_start_backup() and
pg_stop_backup() to start and stop an exclusive backup at the same time.
This could trigger the assertion failure of
"FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".
This happend because, even while pg_start_backup() was starting
an exclusive backup, other session could run pg_stop_backup()
concurrently and mark the backup as not-in-progress unconditionally.
This patch introduces ExclusiveBackupState indicating the state of
an exclusive backup. This state is used to ensure that there is only
one session running pg_start_backup() or pg_stop_backup() at
the same time, to avoid the assertion failure.
Back-patch to all supported versions.
Author: Michael Paquier
Reviewed-By: Kyotaro Horiguchi and me
Reported-By: Andreas Seltenreich
Discussion: <87mvktojme@credativ.de>
Branch
--
REL9_2_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/c73157ca0e058806a956b8126f158dcb513b1881
Modified Files
--
src/backend/access/transam/xlog.c | 209 +++---
1 file changed, 147 insertions(+), 62 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Fix an assertion failure related to an exclusive backup.
Previously multiple sessions could execute pg_start_backup() and
pg_stop_backup() to start and stop an exclusive backup at the same time.
This could trigger the assertion failure of
"FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".
This happend because, even while pg_start_backup() was starting
an exclusive backup, other session could run pg_stop_backup()
concurrently and mark the backup as not-in-progress unconditionally.
This patch introduces ExclusiveBackupState indicating the state of
an exclusive backup. This state is used to ensure that there is only
one session running pg_start_backup() or pg_stop_backup() at
the same time, to avoid the assertion failure.
Back-patch to all supported versions.
Author: Michael Paquier
Reviewed-By: Kyotaro Horiguchi and me
Reported-By: Andreas Seltenreich
Discussion: <87mvktojme@credativ.de>
Branch
--
REL9_5_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/dfe348c1b1ca5327cf2ff058b795ac188d442715
Modified Files
--
src/backend/access/transam/xlog.c | 223 ++
1 file changed, 155 insertions(+), 68 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Fix an assertion failure related to an exclusive backup.
Previously multiple sessions could execute pg_start_backup() and
pg_stop_backup() to start and stop an exclusive backup at the same time.
This could trigger the assertion failure of
"FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".
This happend because, even while pg_start_backup() was starting
an exclusive backup, other session could run pg_stop_backup()
concurrently and mark the backup as not-in-progress unconditionally.
This patch introduces ExclusiveBackupState indicating the state of
an exclusive backup. This state is used to ensure that there is only
one session running pg_start_backup() or pg_stop_backup() at
the same time, to avoid the assertion failure.
Back-patch to all supported versions.
Author: Michael Paquier
Reviewed-By: Kyotaro Horiguchi and me
Reported-By: Andreas Seltenreich
Discussion: <87mvktojme@credativ.de>
Branch
--
REL9_4_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/9e7f00d861fffacaec49473f89513ee8abca076c
Modified Files
--
src/backend/access/transam/xlog.c | 210 +++---
1 file changed, 148 insertions(+), 62 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Fix an assertion failure related to an exclusive backup.
Previously multiple sessions could execute pg_start_backup() and
pg_stop_backup() to start and stop an exclusive backup at the same time.
This could trigger the assertion failure of
"FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".
This happend because, even while pg_start_backup() was starting
an exclusive backup, other session could run pg_stop_backup()
concurrently and mark the backup as not-in-progress unconditionally.
This patch introduces ExclusiveBackupState indicating the state of
an exclusive backup. This state is used to ensure that there is only
one session running pg_start_backup() or pg_stop_backup() at
the same time, to avoid the assertion failure.
Back-patch to all supported versions.
Author: Michael Paquier
Reviewed-By: Kyotaro Horiguchi and me
Reported-By: Andreas Seltenreich
Discussion: <87mvktojme@credativ.de>
Branch
--
master
Details
---
http://git.postgresql.org/pg/commitdiff/974ece58bbb3c0ef185a9d44b1cedae51cd56b04
Modified Files
--
src/backend/access/transam/xlog.c | 223 +-
1 file changed, 150 insertions(+), 73 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Fix an assertion failure related to an exclusive backup.
Previously multiple sessions could execute pg_start_backup() and
pg_stop_backup() to start and stop an exclusive backup at the same time.
This could trigger the assertion failure of
"FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".
This happend because, even while pg_start_backup() was starting
an exclusive backup, other session could run pg_stop_backup()
concurrently and mark the backup as not-in-progress unconditionally.
This patch introduces ExclusiveBackupState indicating the state of
an exclusive backup. This state is used to ensure that there is only
one session running pg_start_backup() or pg_stop_backup() at
the same time, to avoid the assertion failure.
Back-patch to all supported versions.
Author: Michael Paquier
Reviewed-By: Kyotaro Horiguchi and me
Reported-By: Andreas Seltenreich
Discussion: <87mvktojme@credativ.de>
Branch
--
REL9_6_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/60a8b63d24321f5162dfcaf1502936c7ed00b63e
Modified Files
--
src/backend/access/transam/xlog.c | 223 +-
1 file changed, 150 insertions(+), 73 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix an assertion failure related to an exclusive backup.
Fix an assertion failure related to an exclusive backup.
Previously multiple sessions could execute pg_start_backup() and
pg_stop_backup() to start and stop an exclusive backup at the same time.
This could trigger the assertion failure of
"FailedAssertion("!(XLogCtl->Insert.exclusiveBackup)".
This happend because, even while pg_start_backup() was starting
an exclusive backup, other session could run pg_stop_backup()
concurrently and mark the backup as not-in-progress unconditionally.
This patch introduces ExclusiveBackupState indicating the state of
an exclusive backup. This state is used to ensure that there is only
one session running pg_start_backup() or pg_stop_backup() at
the same time, to avoid the assertion failure.
Back-patch to all supported versions.
Author: Michael Paquier
Reviewed-By: Kyotaro Horiguchi and me
Reported-By: Andreas Seltenreich
Discussion: <87mvktojme@credativ.de>
Branch
--
REL9_3_STABLE
Details
---
http://git.postgresql.org/pg/commitdiff/f64b11fa063de85d6d394398d8e9bbe07d588f50
Modified Files
--
src/backend/access/transam/xlog.c | 209 +++---
1 file changed, 147 insertions(+), 62 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typos in comments.
Fix typos in comments. Masahiko Sawada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8fa6019b405f9d39539a77c6f5f11fe640ddf955 Modified Files -- src/backend/storage/lmgr/condition_variable.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Forbid invalid combination of options in pg_basebackup.
Forbid invalid combination of options in pg_basebackup. Commit 56c7d8d4552180fd66fe48423bb2a9bb767c2d87 allowed pg_basebackup to stream WAL in tar mode. But there is the restriction that WAL streaming in tar mode works only when the value - (dash) is not specified as output directory. This means that the combination of three options "-D -", "-F t" and "-X stream" is invalid. However, previously, even when those options were specified at the same time, pg_basebackup background process unexpectedly started streaming WAL. And then it exited with an error. This commit changes pg_basebackup so that it errors out on such invalid combination of options at the beginning. Reviewed by Magnus Hagander, and patch by me. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/ecbdc4c555f43b1ac284c734752b00c2ea6f277b Modified Files -- src/bin/pg_basebackup/pg_basebackup.c | 10 ++ 1 file changed, 10 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Support quorum-based synchronous replication.
Support quorum-based synchronous replication. This feature is also known as "quorum commit" especially in discussion on pgsql-hackers. This commit adds the following new syntaxes into synchronous_standby_names GUC. By using FIRST and ANY keywords, users can specify the method to choose synchronous standbys from the listed servers. FIRST num_sync (standby_name [, ...]) ANY num_sync (standby_name [, ...]) The keyword FIRST specifies a priority-based synchronous replication which was available also in 9.6 or before. This method makes transaction commits wait until their WAL records are replicated to num_sync synchronous standbys chosen based on their priorities. The keyword ANY specifies a quorum-based synchronous replication and makes transaction commits wait until their WAL records are replicated to *at least* num_sync listed standbys. In this method, the values of sync_state.pg_stat_replication for the listed standbys are reported as "quorum". The priority is still assigned to each standby, but not used in this method. The existing syntaxes having neither FIRST nor ANY keyword are still supported. They are the same as new syntax with FIRST keyword, i.e., a priorirty-based synchronous replication. Author: Masahiko Sawada Reviewed-By: Michael Paquier, Amit Kapila and me Discussion: Many thanks to the various individuals who were involved in discussing and developing this feature. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/3901fd70cc7ccacef1b0549a6835bb7d8dcaae43 Modified Files -- doc/src/sgml/config.sgml | 68 -- doc/src/sgml/high-availability.sgml | 44 +++- doc/src/sgml/monitoring.sgml | 9 +- src/backend/replication/Makefile | 2 +- src/backend/replication/syncrep.c | 289 ++ src/backend/replication/syncrep_gram.y| 14 +- src/backend/replication/syncrep_scanner.l | 3 + src/backend/replication/walsender.c | 12 +- src/backend/utils/misc/postgresql.conf.sample | 3 +- src/include/replication/syncrep.h | 7 + src/test/recovery/t/007_sync_rep.pl | 33 ++- 11 files changed, 397 insertions(+), 87 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Ensure that num_sync is greater than zero in synchronous_standby
Ensure that num_sync is greater than zero in synchronous_standby_names. Previously num_sync could be set to zero and this setting caused an assertion failure. This means that multiple synchronous standbys code should assume that num_sync is greater than zero. Also setting num_sync to zero is nonsense because it's basically the configuration for synchronous replication. If users want not to make transaction commits wait for any standbys, synchronous_standby_names should be emptied to disable synchronous replication instead of setting num_sync to zero. This patch forbids users from setting num_sync to zero in synchronous_standby_names. If zero is specified, an error will happen during processing the parameter settings. Back-patch to 9.6 where multiple synchronous standbys feature was added. Patch by me. Reviewed by Tom Lane. Discussion: Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6c75fb6b3dbeda4dac19cee8f2d5cc7f38f362ee Modified Files -- src/backend/replication/syncrep.c | 7 +++ 1 file changed, 7 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Ensure that num_sync is greater than zero in synchronous_standby
Ensure that num_sync is greater than zero in synchronous_standby_names. Previously num_sync could be set to zero and this setting caused an assertion failure. This means that multiple synchronous standbys code should assume that num_sync is greater than zero. Also setting num_sync to zero is nonsense because it's basically the configuration for synchronous replication. If users want not to make transaction commits wait for any standbys, synchronous_standby_names should be emptied to disable synchronous replication instead of setting num_sync to zero. This patch forbids users from setting num_sync to zero in synchronous_standby_names. If zero is specified, an error will happen during processing the parameter settings. Back-patch to 9.6 where multiple synchronous standbys feature was added. Patch by me. Reviewed by Tom Lane. Discussion: Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/93eb619cd35b8adcfe6c86e34ea45d2e8edd322b Modified Files -- src/backend/replication/syncrep.c | 7 +++ 1 file changed, 7 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing documentation for effective_io_concurrency tablespac
Add missing documentation for effective_io_concurrency tablespace option. The description of effective_io_concurrency option was missing in ALTER TABLESPACE docs though it's included in CREATE TABLESPACE one. Back-patch to 9.6 where effective_io_concurrency tablespace option was added. Michael Paquier, reported by Marc-Olaf Jaschke Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b344b879d3d3880b21c44687a3fe09e81e9ad3a9 Modified Files -- doc/src/sgml/ref/alter_tablespace.sgml | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add missing documentation for effective_io_concurrency tablespac
Add missing documentation for effective_io_concurrency tablespace option. The description of effective_io_concurrency option was missing in ALTER TABLESPACE docs though it's included in CREATE TABLESPACE one. Back-patch to 9.6 where effective_io_concurrency tablespace option was added. Michael Paquier, reported by Marc-Olaf Jaschke Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/4e344c2cf4ff00ca38ea0035bc137dab95fdd0c0 Modified Files -- doc/src/sgml/ref/alter_tablespace.sgml | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Improve documentation about pg_stat_replication view.
Improve documentation about pg_stat_replication view. Add the descriptions of possible values in "state" and "sync_state" columns of pg_stat_replication view. Author: Michael Paquier, slightly modified by me Discussion: Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dfe530a09226a9de80f2b4c3d5f667bf51481c49 Modified Files -- doc/src/sgml/high-availability.sgml | 6 + doc/src/sgml/monitoring.sgml| 51 +++-- 2 files changed, 55 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in docs.
Fix typo in docs. Reported-by: Darko Prelec Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/daac8e30eb7874722f277ae3461abe46a39e56ed Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in docs.
Fix typo in docs. Reported-by: Darko Prelec Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/efeb3135061dd45d3882eadd878ac09943d0362a Modified Files -- doc/src/sgml/parallel.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect output from gin_desc().
Fix incorrect output from gin_desc(). Previously gin_desc() displayed incorrect output "unknown action 0" for XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE records with valid actions. The cause of this problem was that gin_desc() wrongly used XLogRecGetData() to extract data from those records. Since they were registered by XLogRegisterBufData(), gin_desc() should have used XLogRecGetBlockData(), instead, like gin_redo(). Also there were other differences about how to treat XLOG_GIN_INSERT record between gin_desc() and gin_redo(). This commit fixes gin_desc() routine so that it treats those records in the same way as gin_redo(). Batch-patch to 9.5 where WAL record format was revamped and XLogRegisterBufData() was added. Reported-By: Andres Freund Reviewed-By: Tom Lane Discussion: <20160509194645.7lewnpw647zeg...@alap3.anarazel.de> Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/5dc851afde8d9ef9947f21799f7a1b08bf0bf812 Modified Files -- src/backend/access/rmgrdesc/gindesc.c | 45 +++ 1 file changed, 24 insertions(+), 21 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect output from gin_desc().
Fix incorrect output from gin_desc(). Previously gin_desc() displayed incorrect output "unknown action 0" for XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE records with valid actions. The cause of this problem was that gin_desc() wrongly used XLogRecGetData() to extract data from those records. Since they were registered by XLogRegisterBufData(), gin_desc() should have used XLogRecGetBlockData(), instead, like gin_redo(). Also there were other differences about how to treat XLOG_GIN_INSERT record between gin_desc() and gin_redo(). This commit fixes gin_desc() routine so that it treats those records in the same way as gin_redo(). Batch-patch to 9.5 where WAL record format was revamped and XLogRegisterBufData() was added. Reported-By: Andres Freund Reviewed-By: Tom Lane Discussion: <20160509194645.7lewnpw647zeg...@alap3.anarazel.de> Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/71267066e95be2906a0224b19f548b57b46db91d Modified Files -- src/backend/access/rmgrdesc/gindesc.c | 45 +++ 1 file changed, 24 insertions(+), 21 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect output from gin_desc().
Fix incorrect output from gin_desc(). Previously gin_desc() displayed incorrect output "unknown action 0" for XLOG_GIN_INSERT and XLOG_GIN_VACUUM_DATA_LEAF_PAGE records with valid actions. The cause of this problem was that gin_desc() wrongly used XLogRecGetData() to extract data from those records. Since they were registered by XLogRegisterBufData(), gin_desc() should have used XLogRecGetBlockData(), instead, like gin_redo(). Also there were other differences about how to treat XLOG_GIN_INSERT record between gin_desc() and gin_redo(). This commit fixes gin_desc() routine so that it treats those records in the same way as gin_redo(). Batch-patch to 9.5 where WAL record format was revamped and XLogRegisterBufData() was added. Reported-By: Andres Freund Reviewed-By: Tom Lane Discussion: <20160509194645.7lewnpw647zeg...@alap3.anarazel.de> Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/8606271640401b5a4efd20c54e2850fa88118eb8 Modified Files -- src/backend/access/rmgrdesc/gindesc.c | 45 +++ 1 file changed, 24 insertions(+), 21 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typos in comments.
Fix typos in comments. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bd082231edbaf25626a023913394b611fe7928e8 Modified Files -- src/backend/access/brin/brin_inclusion.c | 2 +- src/timezone/localtime.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits on a page, it could not find the valid WAL record to start reading from in that case. This patch changes pg_xlogdump so that it can handle a continuation WAL record which crosses a page boundary and find the valid record to start reading from. Back-patch to 9.3 where pg_xlogdump was introduced. Author: Pavan Deolasee Reviewed-By: Michael Paquier and Craig Ringer Discussion: caboikdpspbymig6j01dkq6om2+bnkxhtpkoyqhm2a4oywgk...@mail.gmail.com Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/7dfb9b4796e05743398fc578ac7b25eab086721a Modified Files -- src/backend/access/transam/xlogreader.c | 91 +++-- 1 file changed, 64 insertions(+), 27 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits on a page, it could not find the valid WAL record to start reading from in that case. This patch changes pg_xlogdump so that it can handle a continuation WAL record which crosses a page boundary and find the valid record to start reading from. Back-patch to 9.3 where pg_xlogdump was introduced. Author: Pavan Deolasee Reviewed-By: Michael Paquier and Craig Ringer Discussion: caboikdpspbymig6j01dkq6om2+bnkxhtpkoyqhm2a4oywgk...@mail.gmail.com Branch -- REL9_6_STABLE Details --- http://git.postgresql.org/pg/commitdiff/2802b02a540c0f5bc2d11e801dc527d4240ed404 Modified Files -- src/backend/access/transam/xlogreader.c | 91 +++-- 1 file changed, 64 insertions(+), 27 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits on a page, it could not find the valid WAL record to start reading from in that case. This patch changes pg_xlogdump so that it can handle a continuation WAL record which crosses a page boundary and find the valid record to start reading from. Back-patch to 9.3 where pg_xlogdump was introduced. Author: Pavan Deolasee Reviewed-By: Michael Paquier and Craig Ringer Discussion: caboikdpspbymig6j01dkq6om2+bnkxhtpkoyqhm2a4oywgk...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/bab7823a49bb210b8920ae59e5126d27e4d63833 Modified Files -- src/backend/access/transam/xlogreader.c | 91 +++-- 1 file changed, 64 insertions(+), 27 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits on a page, it could not find the valid WAL record to start reading from in that case. This patch changes pg_xlogdump so that it can handle a continuation WAL record which crosses a page boundary and find the valid record to start reading from. Back-patch to 9.3 where pg_xlogdump was introduced. Author: Pavan Deolasee Reviewed-By: Michael Paquier and Craig Ringer Discussion: caboikdpspbymig6j01dkq6om2+bnkxhtpkoyqhm2a4oywgk...@mail.gmail.com Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5833306dd691f3827ad0856246864626ab1deeb8 Modified Files -- src/backend/access/transam/xlogreader.c | 91 +++-- 1 file changed, 64 insertions(+), 27 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTR
Fix pg_xlogdump so that it handles cross-page XLP_FIRST_IS_CONTRECORD record. Previously pg_xlogdump failed to dump the contents of the WAL file if the file starts with the continuation WAL record which spans more than one pages. Since pg_xlogdump assumed that the continuation record always fits on a page, it could not find the valid WAL record to start reading from in that case. This patch changes pg_xlogdump so that it can handle a continuation WAL record which crosses a page boundary and find the valid record to start reading from. Back-patch to 9.3 where pg_xlogdump was introduced. Author: Pavan Deolasee Reviewed-By: Michael Paquier and Craig Ringer Discussion: caboikdpspbymig6j01dkq6om2+bnkxhtpkoyqhm2a4oywgk...@mail.gmail.com Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/314a25fb3ae3ae2fc6007fd39ff01da7558565a4 Modified Files -- src/backend/access/transam/xlogreader.c | 91 +++-- 1 file changed, 64 insertions(+), 27 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add note about unused arguments for pg_replication_origin_xact_r
Add note about unused arguments for pg_replication_origin_xact_reset() in docs. In 9.5, two arguments were introduced into pg_replication_origin_xact_reset() by mistake while they are actually not used at all. We cannot fix this issue for 9.5 anymore because it needs a catalog version bump. Instead, we add a note about those unused arguments into the document. Reviewed-By: Andres Freund Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b07058c213725e9493052ffe0a219323f74e8ed3 Modified Files -- doc/src/sgml/func.sgml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove unused arguments from pg_replication_origin_xact_reset fu
Remove unused arguments from pg_replication_origin_xact_reset function. The document specifies that pg_replication_origin_xact_reset function doesn't have any argument variables. But previously it was actually defined so as to have two argument variables, though they were not used at all. That is, the pg_proc entry for that function was incorrect. This patch fixes the pg_proc entry and removes those two arguments from the function definition. No back-patch because this change needs a catalog version bump although the issue exists in 9.5 as well. Instead, a note about those unused argument variables will be added to 9.5 document later. Catalog version bumped due to the change of pg_proc. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/dd5eb805d5e5384963f09c9986845a544ef41810 Modified Files -- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hvfm0b64b1_bpvk...@mail.gmail.com Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/74d8c95b7456faefdd4244acf854361711fb42ce Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hvfm0b64b1_bpvk...@mail.gmail.com Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/dbe56f2a1d8774b38e0277eb13e1cf4585ba489c Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hvfm0b64b1_bpvk...@mail.gmail.com Branch -- REL9_1_STABLE Details --- http://git.postgresql.org/pg/commitdiff/366f4a96248dc85a37b17c78ce41d2a531377ba0 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hvfm0b64b1_bpvk...@mail.gmail.com Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/013f423729a8e7b75bbb80db5212fe320a146343 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hvfm0b64b1_bpvk...@mail.gmail.com Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/928e92fda30fa61688534802c849797c9986dc4c Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix pg_basebackup so that it accepts 0 as a valid compression le
Fix pg_basebackup so that it accepts 0 as a valid compression level. The help message for pg_basebackup specifies that the numbers 0 through 9 are accepted as valid values of -Z option. But, previously -Z 0 was rejected as an invalid compression level. Per discussion, it's better to make pg_basebackup treat 0 as valid compression level meaning no compression, like pg_dump. Back-patch to all supported versions. Reported-By: Jeff Janes Reviewed-By: Amit Kapila Discussion: CAMkU=1x+GwjSayc57v6w87ij6iRGFWt=hvfm0b64b1_bpvk...@mail.gmail.com Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/a216177599928d409d90fe06678e1cc6fb2be234 Modified Files -- doc/src/sgml/ref/pg_basebackup.sgml | 2 +- src/bin/pg_basebackup/pg_basebackup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_4_STABLE Details --- http://git.postgresql.org/pg/commitdiff/087ac1dc60faa47d324400728e1365f75c914b5d Modified Files -- doc/src/sgml/information_schema.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/de8c92e6caf0cd8683b23a222d4bd88a90496840 Modified Files -- doc/src/sgml/information_schema.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_2_STABLE Details --- http://git.postgresql.org/pg/commitdiff/5e50a6718ac523be2fd9265463ecbbf21da43f25 Modified Files -- doc/src/sgml/information_schema.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_3_STABLE Details --- http://git.postgresql.org/pg/commitdiff/b54ba3bc5be5437b15c5cb657a097a2b3cb91d6b Modified Files -- doc/src/sgml/information_schema.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix incorrect description of udt_privileges view in documentatio
Fix incorrect description of udt_privileges view in documentation. The description of udt_privileges view contained an incorrect copy-pasted word. Back-patch to 9.2 where udt_privileges view was added. Author: Alexander Law Branch -- REL9_5_STABLE Details --- http://git.postgresql.org/pg/commitdiff/6b8a89e646be8a25771e292e09550aa1abe7019d Modified Files -- doc/src/sgml/information_schema.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix improper example of using psql() function in TAP tests docum
Fix improper example of using psql() function in TAP tests documentation. In an example of TAP test scripts, there is the test checking whether the result of the query is expected or not. But, in previous example, the exit code of psql instead of the query result was checked unexpectedly. Author: Ildar Musin Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c1a95425780ef8e72c2f65504a7e90bcb223ca4a Modified Files -- src/test/perl/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in comment.
Fix typo in comment. Author: Masahiko Sawada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1804d1555f56fcad4ce62e160bab17bdff6c94aa Modified Files -- contrib/postgres_fdw/deparse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Rename pg_stat_wal_receiver.conn_info to conninfo.
Rename pg_stat_wal_receiver.conn_info to conninfo. Per discussion on pgsql-hackers, conninfo is better as the column name because it's more commonly used in PostgreSQL. Catalog version bumped due to the change of pg_proc. Author: Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/60d50769b70ca5030711f70c86d7a2d3bcf34963 Modified Files -- doc/src/sgml/monitoring.sgml | 2 +- src/backend/catalog/system_views.sql | 2 +- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 2 +- src/test/regress/expected/rules.out | 4 ++-- 5 files changed, 6 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in comment.
Fix typo in comment. Author: Masahiko Sawada Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/1109164913caf7fa64e75e0b9fa64f7ba5fe5753 Modified Files -- src/backend/utils/adt/jsonb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix typo in docs.
Fix typo in docs. Artur Zakirov Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8ce8307bd4d6028371c6e8b51bdc6ad260baa03a Modified Files -- doc/src/sgml/indexam.sgml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Make regression test for multiple synchronous standbys more stab
Make regression test for multiple synchronous standbys more stable. The regression test checks whether the output of pg_stat_replication is expected or not after changing synchronous_standby_names and reloading the configuration file. Regarding this test logic, previously there was a timing issue which made the test result unstable. That is, pg_stat_replication could return unexpected result during small window after the configuration file was reloaded before new setting value took effect, and which made the test fail. This commit changes the test logic so that it uses a loop with a timeout to give some room for the test to pass. Now the test fails only when pg_stat_replication keeps returning unexpected result for 30 seconds. Michael Paquier Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/36c1c91604cee164c6487afb99508f7ff8737b96 Modified Files -- src/test/recovery/t/007_sync_rep.pl | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix duplicated index entry in doc.
Fix duplicated index entry in doc. Commit cfe96ae corrected the name of pg_logical_emit_message() in its index entry. But this typo fix caused duplicated index entry because there was another index entry for the function. Spotted by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/c8cb7453233b31a177b08a3b2bdac4c31508dc00 Modified Files -- doc/src/sgml/func.sgml | 3 --- 1 file changed, 3 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Remove unused function GetOldestWALSendPointer from walsender co
Remove unused function GetOldestWALSendPointer from walsender code. That unused function was introduced as a sample because synchronous replication or replication monitoring tools might need it in the future. Recently commit 989be08 added the function SyncRepGetOldestSyncRecPtr which provides almost the same functionality for multiple synchronous standbys feature. So it's time to remove that unused sample function. This commit does that. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/46d73e0d65eef19e25bb0d31f1e5c23ff40a3444 Modified Files -- src/backend/replication/walsender.c | 41 - 1 file changed, 41 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix documented return type of pg_logical_emit_message() in func.
Fix documented return type of pg_logical_emit_message() in func.sgml. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/cfe96ae24c97ff376157c48ccd5ca6d3938632be Modified Files -- doc/src/sgml/func.sgml | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Use ereport(ERROR) instead of Assert() to emit syncrep_parser er
Use ereport(ERROR) instead of Assert() to emit syncrep_parser error. The existing code would either Assert or generate an invalid SyncRepConfig variable, neither of which is desirable. A regular error should be thrown instead. This commit silences compiler warning in non assertion-enabled builds. Per report from Jeff Janes. Suggested fix by Tom Lane. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/0038c1e2181b520a9307aae6587e110468072392 Modified Files -- src/backend/replication/syncrep.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add regression tests for multiple synchronous standbys.
Add regression tests for multiple synchronous standbys. Authors: Suraj Kharage, Michael Paquier, Masahiko Sawada, refactored by me Reviewed-By: Kyotaro Horiguchi Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/196b72fb9a5556c66f2b012cc4e869175a3049fa Modified Files -- src/test/perl/PostgresNode.pm | 18 + src/test/recovery/t/007_sync_rep.pl | 149 2 files changed, 167 insertions(+) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Fix a couple of places in doc that implied there was only one sy
Fix a couple of places in doc that implied there was only one sync standby. Thomas Munro Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8643b91ecf8f47a1307df4a00d66b2fceada0d6f Modified Files -- doc/src/sgml/high-availability.sgml | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Generic Messages for Logical Decoding
On Thu, Apr 7, 2016 at 1:47 PM, Andres Freund wrote: > On 2016-04-07 12:26:28 +0900, Fujii Masao wrote: >> In my example, the WAL record of INSERT that I executed last should be in >> 00010005. But pg_xlogdump could not display that. >> The output of pg_xlogdump was: >> >> $ pg_xlogdump data/pg_xlog/00010005 >> pg_xlogdump: FATAL: could not find a valid record after 0/500 >> >> ISTM that if a WAL file starts with the latter half of LOGICAL MESSAGE >> WAL data, pg_xlogdump treats it as invalid and gives up dumping the >> remaining WAL data in the file. > > That'd obviously be something to investigate. IIRC there's a thread > nearby about something like this. Okay, will check. Thanks for the info! > But just to confirm, if you use -s > over multiple records it works? Yeah, it worked expected. Regards, -- Fujii Masao -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
Re: [COMMITTERS] pgsql: Generic Messages for Logical Decoding
On Thu, Apr 7, 2016 at 12:06 AM, Andres Freund wrote:
>
>
> On April 6, 2016 5:00:54 PM GMT+02:00, Fujii Masao
> wrote:
>>On Wed, Apr 6, 2016 at 6:08 PM, Simon Riggs
>>wrote:
>>> Generic Messages for Logical Decoding
>>>
>>> API and mechanism to allow generic messages to be inserted into WAL
>>that are
>>> intended to be read by logical decoding plugins. This commit adds an
>>optional
>>> new callback to the logical decoding API.
>>
>>When I specify very long text message, pg_xlogdump failed to dump
>>correctly the WAL file which should contain that inserted text message.
>>Isn't this a bug?
>>
>>You can reproduce the problem by the following steps.
>>
>>=# SELECT pg_xlogfile_name(pg_switch_xlog());
>> pg_xlogfile_name
>>--
>> 00010003
>>(1 row)
>>
>>=# SELECT pg_xlogfile_name(pg_current_xlog_location());
>> pg_xlogfile_name
>>--
>> 00010003
>>(1 row)
>>
>>=# SELECT pg_logical_emit_message(true, 'test',
>>repeat('0123456789ABCDEFG', 1024*1024));
>> pg_logical_emit_message
>>-
>> 0/510CD40
>>(1 row)
>>
>>=# SELECT pg_xlogfile_name(pg_current_xlog_location());
>> pg_xlogfile_name
>>--
>> 00010005
>>(1 row)
>>
>>=# insert into t values(0,0);
>>INSERT 0 1
>>postgres=# SELECT pg_xlogfile_name(pg_current_xlog_location());
>> pg_xlogfile_name
>>--
>> 00010005
>>(1 row)
>>
>>The WAL record of pg_logical_emit_message() should be stored in
>>00010004 and 00010005.
>>The WAL record of last insertion should be stored in
>>00010005.
>>But the results of pg_xlogdump were wrong as follows.
>>
>>$ pg_xlogdump data/pg_xlog/00010004
>>rmgr: Standby len (rec/tot): 24/50, tx: 0, lsn:
>>0/0428, prev 0/030146F8, desc: RUNNING_XACTS nextXid 863
>>latestCompletedXid 862 oldestRunningXid 863
>>
>>$ pg_xlogdump data/pg_xlog/00010005
>>pg_xlogdump: FATAL: could not find a valid record after 0/500
>
> If you specify a file it only looks at records in that file. Try with -s.
In my example, the WAL record of INSERT that I executed last should be in
00010005. But pg_xlogdump could not display that.
The output of pg_xlogdump was:
$ pg_xlogdump data/pg_xlog/00010005
pg_xlogdump: FATAL: could not find a valid record after 0/500
ISTM that if a WAL file starts with the latter half of LOGICAL MESSAGE
WAL data, pg_xlogdump treats it as invalid and gives up dumping the
remaining WAL data in the file.
Regards,
--
Fujii Masao
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
