[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date.

Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ab8eae0bb5a1345eaa39aceb584623ae41691e5b

Modified Files
--
src/tools/msvc/Solution.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date.

Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ad083e4ede522548045989995b36f3fe2d16a984

Modified Files
--
src/tools/msvc/Solution.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date.

Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/def9ef5a7b123aa536345a6dbe1d6354d1475992

Modified Files
--
src/tools/msvc/Solution.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date.

Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ca853a244559b339b3a9da321844b852367e8140

Modified Files
--
src/tools/msvc/Solution.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date.

Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/9363b8b79b0f2475b5b607fe4e0aa73a86398223

Modified Files
--
src/tools/msvc/Solution.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Rebuild spiexceptions.h when out of date.

2017-11-12 Thread Noah Misch
MSVC: Rebuild spiexceptions.h when out of date.

Also, add a warning to catch future instances of naming a nonexistent
file as a prerequisite.  Back-patch to 9.3 (all supported versions).

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/64725d7f98a00a292fd2ed9fffb6ae254a5f095d

Modified Files
--
src/tools/msvc/Solution.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities.  We have experienced crashes before reaching the
former call site.  Given such an early crash, this change cannot hurt
and may produce a helpful dump.  Absent an early crash, this change has
no effect.  Back-patch to 9.3 (all supported versions).

Takayuki Tsunakawa

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/e17b38db663949e7b22aa92c2c57dcdf518ecee9

Modified Files
--
src/backend/main/main.c | 16 
1 file changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities.  We have experienced crashes before reaching the
former call site.  Given such an early crash, this change cannot hurt
and may produce a helpful dump.  Absent an early crash, this change has
no effect.  Back-patch to 9.3 (all supported versions).

Takayuki Tsunakawa

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b2df91f2f38ebc46ab3dbda846c4278d6e67aa83

Modified Files
--
src/backend/main/main.c | 16 
1 file changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities.  We have experienced crashes before reaching the
former call site.  Given such an early crash, this change cannot hurt
and may produce a helpful dump.  Absent an early crash, this change has
no effect.  Back-patch to 9.3 (all supported versions).

Takayuki Tsunakawa

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/cbfffee41c3f571fa3fcb26fca5eb11bc508f972

Modified Files
--
src/backend/main/main.c | 16 
1 file changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities.  We have experienced crashes before reaching the
former call site.  Given such an early crash, this change cannot hurt
and may produce a helpful dump.  Absent an early crash, this change has
no effect.  Back-patch to 9.3 (all supported versions).

Takayuki Tsunakawa

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d6387e27e952a687fd2d89874d928a5d27d1fb55

Modified Files
--
src/backend/main/main.c | 16 
1 file changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities.  We have experienced crashes before reaching the
former call site.  Given such an early crash, this change cannot hurt
and may produce a helpful dump.  Absent an early crash, this change has
no effect.  Back-patch to 9.3 (all supported versions).

Takayuki Tsunakawa

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1c065901e3408c3db43593e55aa32da32302dd87

Modified Files
--
src/backend/main/main.c | 16 
1 file changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Install Windows crash dump handler before all else.

2017-11-12 Thread Noah Misch
Install Windows crash dump handler before all else.

Apart from calling write_stderr() on failure, the handler depends on no
PostgreSQL facilities.  We have experienced crashes before reaching the
former call site.  Given such an early crash, this change cannot hurt
and may produce a helpful dump.  Absent an early crash, this change has
no effect.  Back-patch to 9.3 (all supported versions).

Takayuki Tsunakawa

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CD13@G01JPEXMBYT05

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/8c92e66f1a168fdb0862b8d96db4fe0353effc9d

Modified Files
--
src/backend/main/main.c | 16 
1 file changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit().  This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7.  Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect.  Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d74db7a35c8dd18342fdf403375af55e2561e61e

Modified Files
--
src/backend/utils/error/elog.c | 5 +
src/backend/utils/mb/mbutils.c | 6 --
2 files changed, 9 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit().  This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7.  Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect.  Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/dcbec53f4d90af369192695ee53f3b97e492b3bf

Modified Files
--
src/backend/utils/error/elog.c | 5 +
src/backend/utils/mb/mbutils.c | 6 --
2 files changed, 9 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit().  This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7.  Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect.  Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/19cf9e96ae11b549073da6e63b317ec7ac1fb61e

Modified Files
--
src/backend/utils/error/elog.c | 5 +
src/backend/utils/mb/mbutils.c | 6 --
2 files changed, 9 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit().  This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7.  Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect.  Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e02571b73f2d8124fe75d7408f9b63d4c5fe03b0

Modified Files
--
src/backend/utils/error/elog.c | 5 +
src/backend/utils/mb/mbutils.c | 6 --
2 files changed, 9 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit().  This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7.  Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect.  Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/fd5da32fc62f96952a54696f8ab2ce913fe19bc0

Modified Files
--
src/backend/utils/error/elog.c | 5 +
src/backend/utils/mb/mbutils.c | 6 --
2 files changed, 9 insertions(+), 2 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't call pgwin32_message_to_UTF16() without CurrentMemoryConte

2017-11-12 Thread Noah Misch
Don't call pgwin32_message_to_UTF16() without CurrentMemoryContext.

PostgreSQL running as a Windows service crashed upon calling
write_stderr() before MemoryContextInit().  This fix completes work
started in 5735efee15540765315aa8c1a230575e756037f7.  Messages this
early contain only ASCII bytes; if we removed the CurrentMemoryContext
requirement, the ensuing conversions would have no effect.  Back-patch
to 9.3 (all supported versions).

Takayuki Tsunakawa, reviewed by Michael Paquier.

Discussion: 
https://postgr.es/m/0A3221C70F24FB45833433255569204D1F80CC73@G01JPEXMBYT05

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/30e99efe82c71c0320983dee5a9789e9f3f8a8e3

Modified Files
--
src/backend/utils/error/elog.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6.

Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed
"localhost" resolves to both ::1 and 127.0.0.1.  We gain nothing from
that assumption, and it does not hold in a default installation of Red
Hat Enterprise Linux 5.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ad21f3481d14ae156c8287a4e23bdd570a50b1b0

Modified Files
--
src/interfaces/ecpg/test/connect/test1.pgc | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.c  | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.stderr | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp.

This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it.  To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/4cd5d8a9eb7be2906602a97d39c2bd4fb9e8153f

Modified Files
--
src/interfaces/ecpg/test/Makefile  |  4 +--
src/interfaces/ecpg/test/ecpg_schedule_tcp | 55 --
2 files changed, 2 insertions(+), 57 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp.

This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it.  To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1f44160eb720c2bb0fd9f9cafa784c2d53e95a44

Modified Files
--
src/interfaces/ecpg/test/Makefile  |  4 +--
src/interfaces/ecpg/test/ecpg_schedule_tcp | 55 --
2 files changed, 2 insertions(+), 57 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp.

This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it.  To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ef73c355f146844838af650d310a45e0f93d408c

Modified Files
--
src/interfaces/ecpg/test/Makefile  |  4 +--
src/interfaces/ecpg/test/ecpg_schedule_tcp | 55 --
2 files changed, 2 insertions(+), 57 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp.

This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it.  To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line.  Back-patch to 9.3 (all supported versions).

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/dc10deb2b8ce73a8fc8a97c9aad43edbc1c008a7

Modified Files
--
src/interfaces/ecpg/test/Makefile  |  4 +--
src/interfaces/ecpg/test/ecpg_schedule_tcp | 55 --
2 files changed, 2 insertions(+), 57 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6.

Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed
"localhost" resolves to both ::1 and 127.0.0.1.  We gain nothing from
that assumption, and it does not hold in a default installation of Red
Hat Enterprise Linux 5.  Back-patch to 9.3 (all supported versions).

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/9e61a1a29869992255948c07086c5840b5c0c4f4

Modified Files
--
src/interfaces/ecpg/test/connect/test1.pgc | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.c  | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.stderr | 7 ++-
3 files changed, 4 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6.

Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed
"localhost" resolves to both ::1 and 127.0.0.1.  We gain nothing from
that assumption, and it does not hold in a default installation of Red
Hat Enterprise Linux 5.  Back-patch to 9.3 (all supported versions).

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/34baf8a00b018caf7269134cf9b461266e66d9a7

Modified Files
--
src/interfaces/ecpg/test/connect/test1.pgc | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.c  | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.stderr | 7 ++-
3 files changed, 4 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6.

Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed
"localhost" resolves to both ::1 and 127.0.0.1.  We gain nothing from
that assumption, and it does not hold in a default installation of Red
Hat Enterprise Linux 5.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/65fd34f7cc6c4ab729b93bef55095c0156d7c0d4

Modified Files
--
src/interfaces/ecpg/test/connect/test1.pgc | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.c  | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.stderr | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp.

This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it.  To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line.  Back-patch to 9.3 (all supported versions).

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/0b7e76eb2b142d0b4a2a831e7fa1fac44820f52c

Modified Files
--
src/interfaces/ecpg/test/Makefile  |  4 +--
src/interfaces/ecpg/test/ecpg_schedule_tcp | 55 --
2 files changed, 2 insertions(+), 57 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6.

Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed
"localhost" resolves to both ::1 and 127.0.0.1.  We gain nothing from
that assumption, and it does not hold in a default installation of Red
Hat Enterprise Linux 5.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/3c80348d24914d9ddf65d56d2c343a7f2b820705

Modified Files
--
src/interfaces/ecpg/test/connect/test1.pgc | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.c  | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.stderr | 7 ++-
3 files changed, 4 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add post-2010 ecpg tests to checktcp.

2017-11-11 Thread Noah Misch
Add post-2010 ecpg tests to checktcp.

This suite had been a proper superset of the regular ecpg test suite,
but the three newest tests didn't reach it.  To make this less likely to
recur, delete the extra schedule file and pass the TCP-specific test on
the command line.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ae5489e1470c04e8c96999204d85d940dc737142

Modified Files
--
src/interfaces/ecpg/test/Makefile  |  4 +--
src/interfaces/ecpg/test/ecpg_schedule_tcp | 55 --
2 files changed, 2 insertions(+), 57 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Make connect/test1 independent of localhost IPv6.

2017-11-11 Thread Noah Misch
Make connect/test1 independent of localhost IPv6.

Since commit 868898739a8da9ab74c105b8349b7b5c711f265a, it has assumed
"localhost" resolves to both ::1 and 127.0.0.1.  We gain nothing from
that assumption, and it does not hold in a default installation of Red
Hat Enterprise Linux 5.  Back-patch to 9.3 (all supported versions).

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/8dc94625b444758d473a728c7bc764ef567bc0cb

Modified Files
--
src/interfaces/ecpg/test/connect/test1.pgc | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.c  | 2 +-
src/interfaces/ecpg/test/expected/connect-test1.stderr | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix connect/test1 expected output.

2017-11-11 Thread Noah Misch
Fix connect/test1 expected output.

The test runs only as part of "checktcp".  This is a back-patch to 9.5
and 9.4 of part of commit 868898739a8da9ab74c105b8349b7b5c711f265a.
Oversight in commit 61bee9f756ce875f3b678099a6bb9654bd2fa21a.

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/dfabce8827e65c3a48051526451c1b514b223ba1

Modified Files
--
src/interfaces/ecpg/test/expected/connect-test1.stderr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix connect/test1 expected output.

2017-11-11 Thread Noah Misch
Fix connect/test1 expected output.

The test runs only as part of "checktcp".  This is a back-patch to 9.5
and 9.4 of part of commit 868898739a8da9ab74c105b8349b7b5c711f265a.
Oversight in commit 61bee9f756ce875f3b678099a6bb9654bd2fa21a.

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/320636df96ccb42883e21fb88832f395da9bcf9e

Modified Files
--
src/interfaces/ecpg/test/expected/connect-test1.stderr | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds.

To ensure stable output, catch one more configuration-specific error.
Back-patch to 9.3, like the commit that added the test.

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f5260d5ad43ba04c63f0b44f532af9ae58703076

Modified Files
--
src/test/regress/expected/xml.out   | 16 ++--
src/test/regress/expected/xml_1.out | 20 ++--
src/test/regress/expected/xml_2.out | 16 ++--
src/test/regress/sql/xml.sql| 16 ++--
4 files changed, 40 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds.

To ensure stable output, catch one more configuration-specific error.
Back-patch to 9.3, like the commit that added the test.

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/742471ef978c95443c8fd96118360d88b57a30fc

Modified Files
--
src/test/regress/expected/xml.out   | 16 ++--
src/test/regress/expected/xml_1.out | 20 ++--
src/test/regress/expected/xml_2.out | 16 ++--
src/test/regress/sql/xml.sql| 16 ++--
4 files changed, 40 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds.

To ensure stable output, catch one more configuration-specific error.
Back-patch to 9.3, like the commit that added the test.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/4b865aee2582292a42a8e58247a41b46f5aa8a82

Modified Files
--
src/test/regress/expected/xml.out   | 16 ++--
src/test/regress/expected/xml_1.out | 20 ++--
src/test/regress/expected/xml_2.out | 16 ++--
src/test/regress/sql/xml.sql| 16 ++--
4 files changed, 40 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds.

To ensure stable output, catch one more configuration-specific error.
Back-patch to 9.3, like the commit that added the test.

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/075ced2a4c09fad1a27ec545ab632cf1504e534f

Modified Files
--
src/test/regress/expected/xml.out   | 16 ++--
src/test/regress/expected/xml_1.out | 20 ++--
src/test/regress/expected/xml_2.out | 16 ++--
src/test/regress/sql/xml.sql| 16 ++--
4 files changed, 40 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds.

To ensure stable output, catch one more configuration-specific error.
Back-patch to 9.3, like the commit that added the test.

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/739f1f6ac1b4df67d5ea0579f24441e162324749

Modified Files
--
src/test/regress/expected/xml.out   | 16 ++--
src/test/regress/expected/xml_1.out | 20 ++--
src/test/regress/expected/xml_2.out | 16 ++--
src/test/regress/sql/xml.sql| 16 ++--
4 files changed, 40 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix previous commit's test, for non-UTF8 databases with non-XML

2017-11-11 Thread Noah Misch
Fix previous commit's test, for non-UTF8 databases with non-XML builds.

To ensure stable output, catch one more configuration-specific error.
Back-patch to 9.3, like the commit that added the test.

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/e48fb50d8b4868de821f09f19985e35dc5f41c44

Modified Files
--
src/test/regress/expected/xml.out   | 16 ++--
src/test/regress/expected/xml_1.out | 20 ++--
src/test/regress/expected/xml_2.out | 16 ++--
src/test/regress/sql/xml.sql| 16 ++--
4 files changed, 40 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
Ignore XML declaration in xpath_internal(), for UTF8 databases.

When a value contained an XML declaration naming some other encoding,
this function interpreted UTF8 bytes as the named encoding, yielding
mojibake.  xml_parse() already has similar logic.  This would be
necessary but not sufficient for non-UTF8 databases, so preserve
behavior there until the xpath facility can support such databases
comprehensively.  Back-patch to 9.3 (all supported versions).

Pavel Stehule and Noah Misch

Discussion: 
https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/46fb15f48a2d76beccf8d422f699373b60e954f6

Modified Files
--
src/backend/utils/adt/xml.c | 14 +-
src/test/regress/expected/xml.out   | 31 +++
src/test/regress/expected/xml_1.out | 35 +++
src/test/regress/expected/xml_2.out | 31 +++
src/test/regress/sql/xml.sql| 32 
5 files changed, 142 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
Ignore XML declaration in xpath_internal(), for UTF8 databases.

When a value contained an XML declaration naming some other encoding,
this function interpreted UTF8 bytes as the named encoding, yielding
mojibake.  xml_parse() already has similar logic.  This would be
necessary but not sufficient for non-UTF8 databases, so preserve
behavior there until the xpath facility can support such databases
comprehensively.  Back-patch to 9.3 (all supported versions).

Pavel Stehule and Noah Misch

Discussion: 
https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/30a5e940ac9a96c5fee449223528a1b502ed

Modified Files
--
src/backend/utils/adt/xml.c | 14 +-
src/test/regress/expected/xml.out   | 31 +++
src/test/regress/expected/xml_1.out | 35 +++
src/test/regress/expected/xml_2.out | 31 +++
src/test/regress/sql/xml.sql| 32 
5 files changed, 142 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
Ignore XML declaration in xpath_internal(), for UTF8 databases.

When a value contained an XML declaration naming some other encoding,
this function interpreted UTF8 bytes as the named encoding, yielding
mojibake.  xml_parse() already has similar logic.  This would be
necessary but not sufficient for non-UTF8 databases, so preserve
behavior there until the xpath facility can support such databases
comprehensively.  Back-patch to 9.3 (all supported versions).

Pavel Stehule and Noah Misch

Discussion: 
https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/d8406b9de910bf77d74ac644817b42fb4cf2ad03

Modified Files
--
src/backend/utils/adt/xml.c | 14 +-
src/test/regress/expected/xml.out   | 31 +++
src/test/regress/expected/xml_1.out | 35 +++
src/test/regress/expected/xml_2.out | 31 +++
src/test/regress/sql/xml.sql| 32 
5 files changed, 142 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
Ignore XML declaration in xpath_internal(), for UTF8 databases.

When a value contained an XML declaration naming some other encoding,
this function interpreted UTF8 bytes as the named encoding, yielding
mojibake.  xml_parse() already has similar logic.  This would be
necessary but not sufficient for non-UTF8 databases, so preserve
behavior there until the xpath facility can support such databases
comprehensively.  Back-patch to 9.3 (all supported versions).

Pavel Stehule and Noah Misch

Discussion: 
https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/2918fcedbf2b2adab688a7849ecce4556ef912ac

Modified Files
--
src/backend/utils/adt/xml.c | 14 +-
src/test/regress/expected/xml.out   | 31 +++
src/test/regress/expected/xml_1.out | 35 +++
src/test/regress/expected/xml_2.out | 31 +++
src/test/regress/sql/xml.sql| 32 
5 files changed, 142 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
Ignore XML declaration in xpath_internal(), for UTF8 databases.

When a value contained an XML declaration naming some other encoding,
this function interpreted UTF8 bytes as the named encoding, yielding
mojibake.  xml_parse() already has similar logic.  This would be
necessary but not sufficient for non-UTF8 databases, so preserve
behavior there until the xpath facility can support such databases
comprehensively.  Back-patch to 9.3 (all supported versions).

Pavel Stehule and Noah Misch

Discussion: 
https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2f4061aff504049767602927e69c85b5b4621273

Modified Files
--
src/backend/utils/adt/xml.c | 14 +-
src/test/regress/expected/xml.out   | 31 +++
src/test/regress/expected/xml_1.out | 35 +++
src/test/regress/expected/xml_2.out | 31 +++
src/test/regress/sql/xml.sql| 32 
5 files changed, 142 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore XML declaration in xpath_internal(), for UTF8 databases.

2017-11-11 Thread Noah Misch
Ignore XML declaration in xpath_internal(), for UTF8 databases.

When a value contained an XML declaration naming some other encoding,
this function interpreted UTF8 bytes as the named encoding, yielding
mojibake.  xml_parse() already has similar logic.  This would be
necessary but not sufficient for non-UTF8 databases, so preserve
behavior there until the xpath facility can support such databases
comprehensively.  Back-patch to 9.3 (all supported versions).

Pavel Stehule and Noah Misch

Discussion: 
https://postgr.es/m/CAFj8pRC-dM=tT=qkgi+achkm+gwpmjyoayguufxvumcxkdg...@mail.gmail.com

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/e7083dfce5754e38063502c683b7b7fa57021893

Modified Files
--
src/backend/utils/adt/xml.c | 14 +-
src/test/regress/expected/xml.out   | 31 +++
src/test/regress/expected/xml_1.out | 35 +++
src/test/regress/expected/xml_2.out | 31 +++
src/test/regress/sql/xml.sql| 32 
5 files changed, 142 insertions(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/dfc015dcf46c1996bd7ed5866e9e045d258604b3

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/eda780281c9c09599d12e783c51905078674b2e8

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6b0b983f793b5c9ea68167a408ef58d40b942596

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ed546dd06195c27d92ae46f2bb1a74261bcb49e6

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/29d06705194396d46004a48bf56e741c79269790

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b7d6f75072b3569d7d2acce04669e72086b547cb

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: start-scripts: switch to $PGUSER before opening $PGLOG.

2017-11-09 Thread Noah Misch
start-scripts: switch to $PGUSER before opening $PGLOG.

By default, $PGUSER has permission to unlink $PGLOG.  If $PGUSER
replaces $PGLOG with a symbolic link, the server will corrupt the
link-targeted file by appending log messages.  Since these scripts open
$PGLOG as root, the attack works regardless of target file ownership.

"make install" does not install these scripts anywhere.  Users having
manually installed them in the past should repeat that process to
acquire this fix.  Most script users have $PGLOG writable to root only,
located in $PGDATA.  Just before updating one of these scripts, such
users should rename $PGLOG to $PGLOG.old.  The script will then recreate
$PGLOG with proper ownership.

Reviewed by Peter Eisentraut.  Reported by Antoine Scemama.

Security: CVE-2017-12172

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b5002976804cfd42ada725b30cff324ebd3e9638

Modified Files
--
contrib/start-scripts/freebsd| 4 ++--
contrib/start-scripts/linux  | 4 ++--
contrib/start-scripts/osx/PostgreSQL | 8 
3 files changed, 8 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one.

Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly.  Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/modules examples worked properly when called as "make -C
src/test/modules/$FOO check", but "make -j" allowed the test to start
before the temporary installation was in place.  Back-patch to 9.5,
where commit dcae5faccab64776376d354decda0017c648bb53 introduced the
shared temp-install.

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/937f67800a7d3c30870af7b1115a76f44bc26e78

Modified Files
--
src/interfaces/ecpg/test/Makefile  | 4 ++--
src/test/locale/Makefile   | 1 +
src/test/modules/brin/Makefile | 4 ++--
src/test/modules/commit_ts/Makefile| 2 +-
src/test/modules/test_pg_dump/Makefile | 2 +-
src/test/regress/GNUmakefile   | 4 ++--
6 files changed, 9 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one.

Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly.  Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/modules examples worked properly when called as "make -C
src/test/modules/$FOO check", but "make -j" allowed the test to start
before the temporary installation was in place.  Back-patch to 9.5,
where commit dcae5faccab64776376d354decda0017c648bb53 introduced the
shared temp-install.

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/971983f42fe6e8b90490a76a649f0c92905d7d47

Modified Files
--
src/interfaces/ecpg/test/Makefile  | 2 +-
src/test/locale/Makefile   | 1 +
src/test/modules/brin/Makefile | 2 +-
src/test/modules/commit_ts/Makefile| 2 +-
src/test/modules/test_pg_dump/Makefile | 2 +-
src/test/regress/GNUmakefile   | 4 ++--
6 files changed, 7 insertions(+), 6 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one.

Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly.  Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/modules examples worked properly when called as "make -C
src/test/modules/$FOO check", but "make -j" allowed the test to start
before the temporary installation was in place.  Back-patch to 9.5,
where commit dcae5faccab64776376d354decda0017c648bb53 introduced the
shared temp-install.

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/014c5cd8767161995278bc1f4e2fcfb1b703dad1

Modified Files
--
src/interfaces/ecpg/test/Makefile | 2 +-
src/test/locale/Makefile  | 1 +
src/test/modules/brin/Makefile| 2 +-
src/test/regress/GNUmakefile  | 4 ++--
4 files changed, 5 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Add a temp-install prerequisite to "check"-like targets not havi

2017-11-05 Thread Noah Misch
Add a temp-install prerequisite to "check"-like targets not having one.

Makefile.global assigns this prerequisite to every target named "check",
but similar targets must mention it explicitly.  Affected targets
failed, tested $PATH binaries, or tested a stale temporary installation.
The src/test/modules examples worked properly when called as "make -C
src/test/modules/$FOO check", but "make -j" allowed the test to start
before the temporary installation was in place.  Back-patch to 9.5,
where commit dcae5faccab64776376d354decda0017c648bb53 introduced the
shared temp-install.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/c66b438db62748000700c9b90b585e756dd54141

Modified Files
--
src/interfaces/ecpg/test/Makefile  | 4 ++--
src/test/locale/Makefile   | 1 +
src/test/modules/brin/Makefile | 4 ++--
src/test/modules/commit_ts/Makefile| 2 +-
src/test/modules/test_pg_dump/Makefile | 2 +-
src/test/regress/GNUmakefile   | 4 ++--
6 files changed, 9 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

This restores the ability, essentially lost in commit
ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under
REPEATABLE READ isolation.  Back-patch to 9.4, like that commit.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/ca+tgmoahwdm-7fperbxzu9uz99lpmumepsxltw9tmrogzwn...@mail.gmail.com

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2a2e2e85e0f67213816126d654615413930dd8b3

Modified Files
--
src/backend/commands/copy.c  | 18 +++---
src/backend/utils/time/snapmgr.c |  8 
2 files changed, 23 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

This restores the ability, essentially lost in commit
ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under
REPEATABLE READ isolation.  Back-patch to 9.4, like that commit.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/ca+tgmoahwdm-7fperbxzu9uz99lpmumepsxltw9tmrogzwn...@mail.gmail.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2168f37c4db65f40925f4f8ccbb901544a5edb84

Modified Files
--
src/backend/commands/copy.c  | 18 +++---
src/backend/utils/time/snapmgr.c |  8 
2 files changed, 23 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

This restores the ability, essentially lost in commit
ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under
REPEATABLE READ isolation.  Back-patch to 9.4, like that commit.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/ca+tgmoahwdm-7fperbxzu9uz99lpmumepsxltw9tmrogzwn...@mail.gmail.com

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/7932891ab9ccfa5003a8dce9af0bea60427469b3

Modified Files
--
src/backend/commands/copy.c  | 18 +++---
src/backend/utils/time/snapmgr.c |  8 
2 files changed, 23 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

This restores the ability, essentially lost in commit
ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under
REPEATABLE READ isolation.  Back-patch to 9.4, like that commit.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/ca+tgmoahwdm-7fperbxzu9uz99lpmumepsxltw9tmrogzwn...@mail.gmail.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/1cac62dac0cfdcacdb2c2b1577dadf101ef7f1f4

Modified Files
--
src/backend/commands/copy.c  | 18 +++---
src/backend/utils/time/snapmgr.c |  8 
2 files changed, 23 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

2017-11-05 Thread Noah Misch
Ignore CatalogSnapshot when checking COPY FREEZE prerequisites.

This restores the ability, essentially lost in commit
ffaa44cb559db332baeee7d25dedd74a61974203, to use COPY FREEZE under
REPEATABLE READ isolation.  Back-patch to 9.4, like that commit.

Reviewed by Tom Lane.

Discussion: 
https://postgr.es/m/ca+tgmoahwdm-7fperbxzu9uz99lpmumepsxltw9tmrogzwn...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/bab3a714b62160f0e89c8943c5e054649cd58945

Modified Files
--
src/backend/commands/copy.c  | 18 +++---
src/backend/utils/time/snapmgr.c |  8 
2 files changed, 23 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: In client support of v10 features, use standard schema handling.

2017-11-01 Thread Noah Misch
In client support of v10 features, use standard schema handling.

Back-patch to v10.  This continues the work of commit
080351466c5a669bf35a323bdec9e296330a5dbb.

Discussion: 
https://postgr.es/m/CAKOSWN=ds66zlw2sqkltm8wbxfgdbc_odkmt3djfpt2me5k...@mail.gmail.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/f4e13963ca88365263533d3cf523408d60b9f33f

Modified Files
--
src/bin/pg_dump/pg_dump.c | 22 +++---
src/bin/psql/describe.c   |  2 +-
2 files changed, 16 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: In client support of v10 features, use standard schema handling.

2017-11-01 Thread Noah Misch
In client support of v10 features, use standard schema handling.

Back-patch to v10.  This continues the work of commit
080351466c5a669bf35a323bdec9e296330a5dbb.

Discussion: 
https://postgr.es/m/CAKOSWN=ds66zlw2sqkltm8wbxfgdbc_odkmt3djfpt2me5k...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/51f4d3ed7ea40998f66e15830aa84009c0e36e11

Modified Files
--
src/bin/pg_dump/pg_dump.c | 22 +++---
src/bin/psql/describe.c   |  2 +-
2 files changed, 16 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-13 Thread Noah Misch
In an earlier message, I said I didn't see the problem with xlc 13.1.3.  I
withdraw that statement.  I had tested old code (commit c629324, 20 Aug),
rendering the test invalid.  xlc 13.1.3 does break commit 91d5f1a, and
removing "restrict" fixes things as it did the older version.

On Thu, Oct 12, 2017 at 10:44:20PM -0400, Tom Lane wrote:
> Noah Misch  writes:
> > On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote:
> >> Noah, any chance you could force restrict to off on that animal?
> 
> > I can confirm it allows "make check" to pass.
> 
> So that leaves us with two theories:
> 
> 1. hornet's compiler contains a bug that causes it to misoptimize
> in the presence of "restrict".
> 
> 2. There's a bug in the way HEAD is applying "restrict", which happens
> not to manifest on other platforms.
> 
> While I have to agree with Andres' evident feeling that it's probably
> #1, I do not think we should dismiss #2 without inquiring a bit
> harder.  It would be really useful, I think, if we could characterize
> exactly how the RowDescription output is broken in that build.
> Noah, could you capture some of those messages somehow?

I hacked psql to call PQtrace() and ran "psql -Xc 'select true'" in the
defective configuration and in a working x64 GNU/Linux configuration.  I've
attached both PQtrace() products.
To backend> Msg Q
To backend> "select true"
To backend> Msg complete, length 17
>From backend> T
>From backend (#4)> 17
>From backend (#2)> 1
>From backend> "bool"
>From backend (#4)> 1
>From backend (#2)> 0
>From backend (#4)> 1140850688
>From backend (#2)> 2816
>From backend (#4)> 16777216
>From backend (#2)> 372
>From backend> D
>From backend (#4)> 11
>From backend> C
>From backend (#4)> 13
>From backend> "SELECT 1"
>From backend> Z
>From backend (#4)> 5
>From backend> Z
>From backend (#4)> 5
>From backend> I
To backend> Msg X
To backend> Msg complete, length 5
To backend> Msg Q
To backend> "select true"
To backend> Msg complete, length 17
>From backend> T
>From backend (#4)> 29
>From backend (#2)> 1
>From backend> "bool"
>From backend (#4)> 0
>From backend (#2)> 0
>From backend (#4)> 16
>From backend (#2)> 1
>From backend (#4)> -1
>From backend (#2)> 0
>From backend> D
>From backend (#4)> 11
>From backend (#2)> 1
>From backend (#4)> 1
>From backend (1)> t
>From backend> C
>From backend (#4)> 13
>From backend> "SELECT 1"
>From backend> Z
>From backend (#4)> 5
>From backend> Z
>From backend (#4)> 5
>From backend> I
To backend> Msg X
To backend> Msg complete, length 5

-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-12 Thread Noah Misch
On Thu, Oct 12, 2017 at 04:48:29PM -0700, Andres Freund wrote:
> On 2017-10-12 16:08:44 -0700, Andres Freund wrote:
> > wrap-gcc -D_THREAD_SAFE=1 -D_LARGE_FILES=1 -maix64 -Wall 
> > -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
> > -Wendif-labels -Wmissing-format-attribute -Wformat-security 
> > -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -O2 
> > -D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS  -DFRONTEND 
> > -DUNSAFE_STAT_OK -I. -I../../../src/include   -I../../../src/port 
> > -I../../../src/port -DSO_MAJOR_VERSION=5  -c -o fe-connect.o fe-connect.c
> > fe-connect.c: In function 'PQconnectPoll':
> > fe-connect.c:2382:6: warning: implicit declaration of function 'getpeereid' 
> > [-Wimplicit-function-declaration]
> >   if (getpeereid(conn->sock, &uid, &gid) != 0)
> >   ^
> > 
> > Looks like we're missing
> > #include 
> 
> Hm, it got removed as part of
> http://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=9e3755ecb2d058f7d123dd35a2e1784006190962
> but that's not an explanation, because
> c.h includes sys/types.h. Which according to IBM's docs
> https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.basetrf1/getpeereid.htm
> is the right thing to include.  Given that xlc doesn't complain, I'll
> just assume this is some issue with the headers gcc uses on aix, but I'm
> far from confident.

The relevant xlc warning is disabled by default.  "xlc -qinfo=pro" does
complain.   provides no such prototype.   provides
a getpeereid() prototype, but under C++ only.  (For getpeername(), it provides
both C and C++ prototypes.)  Thus, the AIX documentation is wrong, and
/usr/include is buggy.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Improve performance of SendRowDescriptionMessage.

2017-10-12 Thread Noah Misch
On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote:
> So we've two animals (hornet, sungazer) that are:
> #define SIZEOF_SIZE_T 8
> #define WORDS_BIGENDIAN 1
> #define restrict __restrict
> 
> one compiled with xlc that fails and one with gcc that succeeds. I'm
> hesitant to reach for that, but I wonder if there's a compiler
> bug. Alternatively there could be some undefined behaviour here that
> only triggers on xlc 64bit, but I'm not quite seeing it.
> 
> Noah, any chance you could force restrict to off on that animal?

I can confirm it allows "make check" to pass.  Specifically, I did this
against commit 91d5f1a:

--- src/include/pg_config.h~2017-10-12 18:11:33.0 -0700
+++ src/include/pg_config.h 2017-10-12 18:22:34.0 -0700
@@ -929 +929 @@
- #define pg_restrict __restrict
+ #define pg_restrict
@@ -934 +934 @@
- #define restrict __restrict
+ #define restrict

I have no reason to believe this is specific to hornet's installation, so I
recommend against altering hornet's configuration.  It's too likely that the
next xlc user will need to do the same thing.  I don't see the problem with
xlc 13.1.3, though.

> Otherwise I can push a platform fix that disables it.

This sounds reasonable.

nm


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: Remove ICU tests from default run

2017-10-06 Thread Noah Misch
On Sat, Mar 25, 2017 at 04:30:45AM +, Peter Eisentraut wrote:
> Remove ICU tests from default run
> 
> These tests require the test database to be in UTF8 encoding.  Until
> there is a better solution, take them out of the default test set and
> treat them like the existing collate.linux.utf8 test, meaning it has to
> be selected manually.

I'm thinking the regression suite should create an ENCODING=UTF8, LOCALE=C
database in addition to the traditional one.  This isn't the first or the
second use case for such a database.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/c8178929c55e5424b6c47014579bfbf68886f444

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
3 files changed, 111 insertions(+), 21 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/43661926deb7d412ae3a22a43dadb9def7b7e46c

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
2 files changed, 74 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/2e7f6b6b2a214f8f5fa8ec448807c3a1a2c8b897

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
4 files changed, 148 insertions(+), 28 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/6525a3a70968007666b5fce440f57b8bf7e6303f

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
1 file changed, 37 insertions(+), 7 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/59597e6485847ae40eab2e80ff04af3e8663f2d8

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
doc/src/sgml/release-9.6.sgml | 44 ---
5 files changed, 185 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bfd551570265049ea17f18f65a156c1d8ba66a23

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
doc/src/sgml/release-9.6.sgml | 44 ---
5 files changed, 185 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Don't recommend "DROP SCHEMA information_schema CASCADE".

2017-09-26 Thread Noah Misch
Don't recommend "DROP SCHEMA information_schema CASCADE".

It drops objects outside information_schema that depend on objects
inside information_schema.  For example, it will drop a user-defined
view if the view query refers to information_schema.

Discussion: https://postgr.es/m/20170831025345.ge3963...@rfd.leadboat.com

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b5ee5328bdd086fa7db1845928ef0bc87b495aaf

Modified Files
--
doc/src/sgml/release-9.2.sgml | 44 ---
doc/src/sgml/release-9.3.sgml | 44 ---
doc/src/sgml/release-9.4.sgml | 44 ---
doc/src/sgml/release-9.5.sgml | 44 ---
doc/src/sgml/release-9.6.sgml | 44 ---
5 files changed, 185 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Inject $(ICU_LIBS) regardless of platform.

2017-08-20 Thread Noah Misch
Inject $(ICU_LIBS) regardless of platform.

It appeared in a conditional that excludes AIX, Cygwin and MinGW.  Give
ICU support a chance to work on those platforms.  Back-patch to v10,
where ICU support was introduced.

Branch
--
REL_10_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b8a25494819ac2551a71674effb7f50a7b7b74f6

Modified Files
--
src/backend/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Inject $(ICU_LIBS) regardless of platform.

2017-08-20 Thread Noah Misch
Inject $(ICU_LIBS) regardless of platform.

It appeared in a conditional that excludes AIX, Cygwin and MinGW.  Give
ICU support a chance to work on those platforms.  Back-patch to v10,
where ICU support was introduced.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/66ed3829df959adb47f71d7c903ac59f0670f3e1

Modified Files
--
src/backend/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Fix vertical spanning in table "wait_event Description".

2017-08-12 Thread Noah Misch
Fix vertical spanning in table "wait_event Description".

Michael Paquier

Discussion: 
https://postgr.es/m/cab7npqqr3keqvxeuunycm7tdk2fb9oluq8du0+y0rzeon_1...@mail.gmail.com

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e88928c50dfe2623c899f82b54aad69da248ad07

Modified Files
--
doc/src/sgml/monitoring.sgml | 8 
1 file changed, 4 insertions(+), 4 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options.

Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make
pg_user_mappings enforce the qualifications user_mapping_options had
been enforcing, but its removal of a longstanding restriction left them
distinct when the current user is the subject of a mapping yet has no
server privileges.  user_mapping_options emits no rows for such a
mapping, but pg_user_mappings includes full umoptions.  Change
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like
the above commit.

Reviewed by Tom Lane.  Reported by Jeff Janes.

Security: CVE-2017-7547

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b6e39ca924e5fa0e83ce3e04dad82559983f

Modified Files
--
doc/src/sgml/catalogs.sgml | 32 --
src/backend/catalog/system_views.sql   |  4 +++-
src/test/regress/expected/foreign_data.out | 32 --
src/test/regress/expected/rules.out|  2 +-
src/test/regress/sql/foreign_data.sql  | 17 +---
5 files changed, 57 insertions(+), 30 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options.

Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make
pg_user_mappings enforce the qualifications user_mapping_options had
been enforcing, but its removal of a longstanding restriction left them
distinct when the current user is the subject of a mapping yet has no
server privileges.  user_mapping_options emits no rows for such a
mapping, but pg_user_mappings includes full umoptions.  Change
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like
the above commit.

Reviewed by Tom Lane.  Reported by Jeff Janes.

Security: CVE-2017-7547

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/5e8e009146e3cae5c596d6e857a9c98fe22657b8

Modified Files
--
doc/src/sgml/catalogs.sgml |   32 +-
src/backend/catalog/system_views.sql   |4 +-
src/test/regress/expected/foreign_data.out |   32 +-
src/test/regress/expected/rules.out| 1600 ++--
src/test/regress/sql/foreign_data.sql  |   17 +-
5 files changed, 856 insertions(+), 829 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options.

Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make
pg_user_mappings enforce the qualifications user_mapping_options had
been enforcing, but its removal of a longstanding restriction left them
distinct when the current user is the subject of a mapping yet has no
server privileges.  user_mapping_options emits no rows for such a
mapping, but pg_user_mappings includes full umoptions.  Change
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like
the above commit.

Reviewed by Tom Lane.  Reported by Jeff Janes.

Security: CVE-2017-7547

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/36f9f60958d471c62515494a0c7b0058e578c2eb

Modified Files
--
doc/src/sgml/catalogs.sgml | 32 +++-
src/backend/catalog/system_views.sql   |  4 ++-
src/test/regress/expected/foreign_data.out | 39 +++---
src/test/regress/expected/rules.out|  2 +-
src/test/regress/sql/foreign_data.sql  | 19 +--
5 files changed, 61 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options.

Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make
pg_user_mappings enforce the qualifications user_mapping_options had
been enforcing, but its removal of a longstanding restriction left them
distinct when the current user is the subject of a mapping yet has no
server privileges.  user_mapping_options emits no rows for such a
mapping, but pg_user_mappings includes full umoptions.  Change
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like
the above commit.

Reviewed by Tom Lane.  Reported by Jeff Janes.

Security: CVE-2017-7547

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/156099630320fcb72d41ae90b91f15ed0dfbc271

Modified Files
--
doc/src/sgml/catalogs.sgml | 32 +++-
src/backend/catalog/system_views.sql   |  4 ++-
src/test/regress/expected/foreign_data.out | 39 +++---
src/test/regress/expected/rules.out|  2 +-
src/test/regress/sql/foreign_data.sql  | 19 +--
5 files changed, 61 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options.

Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make
pg_user_mappings enforce the qualifications user_mapping_options had
been enforcing, but its removal of a longstanding restriction left them
distinct when the current user is the subject of a mapping yet has no
server privileges.  user_mapping_options emits no rows for such a
mapping, but pg_user_mappings includes full umoptions.  Change
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like
the above commit.

Reviewed by Tom Lane.  Reported by Jeff Janes.

Security: CVE-2017-7547

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/e568e1eee4650227170cf8c64eedb74bafd7d1f0

Modified Files
--
doc/src/sgml/catalogs.sgml | 32 +++-
src/backend/catalog/system_views.sql   |  4 ++-
src/test/regress/expected/foreign_data.out | 39 +++---
src/test/regress/expected/rules.out|  2 +-
src/test/regress/sql/foreign_data.sql  | 19 +--
5 files changed, 61 insertions(+), 35 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Again match pg_user_mappings to information_schema.user_mapping_

2017-08-10 Thread Noah Misch
Again match pg_user_mappings to information_schema.user_mapping_options.

Commit 3eefc51053f250837c3115c12f8119d16881a2d7 claimed to make
pg_user_mappings enforce the qualifications user_mapping_options had
been enforcing, but its removal of a longstanding restriction left them
distinct when the current user is the subject of a mapping yet has no
server privileges.  user_mapping_options emits no rows for such a
mapping, but pg_user_mappings includes full umoptions.  Change
pg_user_mappings to show null for umoptions.  Back-patch to 9.2, like
the above commit.

Reviewed by Tom Lane.  Reported by Jeff Janes.

Security: CVE-2017-7547

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/e255e97a2635cc74fd0efa41b6e872941995e237

Modified Files
--
doc/src/sgml/catalogs.sgml | 32 --
src/backend/catalog/system_views.sql   |  4 +++-
src/test/regress/expected/foreign_data.out | 32 --
src/test/regress/expected/rules.out|  2 +-
src/test/regress/sql/foreign_data.sql  | 17 +---
5 files changed, 57 insertions(+), 30 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Disclaim xmltable() support for non-UTF8 databases.

2017-08-07 Thread Noah Misch
Disclaim xmltable() support for non-UTF8 databases.

The xmltable() implementation mirrors xpath(), including its lack of
character encoding awareness.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/b4a2eea030ba74ea84335c7d5bc999f693ffd9a4

Modified Files
--
doc/src/sgml/datatype.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Finish clean.bat build artifact coverage.

2017-07-24 Thread Noah Misch
MSVC: Finish clean.bat build artifact coverage.

With this, "git clean -dnx" is clear after a "clean dist" following a
build.  Preserve sql_help.h in non-dist cleans, like the Makefile does.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/bbbd9121e63f9f7cf8cc86025d5d848fba477eb4

Modified Files
--
src/tools/msvc/clean.bat | 29 ++---
1 file changed, 26 insertions(+), 3 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib.

ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.
Back-patch to 9.2, like the commit recognizing tcl86t.lib.

Branch
--
REL9_3_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/9842c1b559a9041371fb7d30a83cb94d2de79896

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib.

ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.
Back-patch to 9.2, like the commit recognizing tcl86t.lib.

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bcc2c3b4572491fef845de30b0ed369f09635586

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib.

ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.
Back-patch to 9.2, like the commit recognizing tcl86t.lib.

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/0328bd1ef3c991d4764d8437d9a407033d4d4a5c

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib.

ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.
Back-patch to 9.2, like the commit recognizing tcl86t.lib.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/71ad8000da5d836c9ca117a164c38d84284a336f

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib.

ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.
Back-patch to 9.2, like the commit recognizing tcl86t.lib.

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/4885e5c88b274d8f7da9f4dcbbe0006aa9124420

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Accept tcl86.lib in addition to tcl86t.lib.

2017-07-23 Thread Noah Misch
MSVC: Accept tcl86.lib in addition to tcl86t.lib.

ActiveTcl8.6.4.1.299124-win32-x86_64-threaded.exe ships just tcl86.lib.
Back-patch to 9.2, like the commit recognizing tcl86t.lib.

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/bef96e57e0de095a581065f386bc0beb4195a858

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Don't link libpgcommon into pgcrypto.

2017-07-16 Thread Noah Misch
MSVC: Don't link libpgcommon into pgcrypto.

Doing so was useful in 273c458a2b3a0fb73968020ea5e9e35eb6928967 but
became obsolete when 818fd4a67d610991757b610755e3065fb99d80a5 caused
postgres.exe to provide the relevant symbols.  No other loadable module
links to libpgcommon directly.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/2f7f45a64badec18ce75e44ca35c078f08e2651e

Modified Files
--
src/tools/msvc/Mkvcbuild.pm | 1 -
1 file changed, 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: MSVC: Repair libpq.rc generator.

2017-07-09 Thread Noah Misch
MSVC: Repair libpq.rc generator.

It generates an empty file, so libpq.dll advertises no version
information.  Commit facde2a98f0b5f7689b4e30a9e7376e926e733b8
mistranslated "print O;" in this one place.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/3381898f983b9d41c20b50bb1b39c173aa0129e3

Modified Files
--
src/tools/msvc/Solution.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Reconcile nodes/*funcs.c with PostgreSQL 10 work.

2017-06-16 Thread Noah Misch
Reconcile nodes/*funcs.c with PostgreSQL 10 work.

The _equalTableFunc() omission of coltypmods has semantic significance,
but I did not track down resulting user-visible bugs, if any.  The other
changes are cosmetic only, affecting order.  catversion bump due to
readfuncs.c field order change.

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/39ac55918fc31b9bf88185d28ebe7ddc58d01181

Modified Files
--
src/backend/nodes/copyfuncs.c|  6 +++---
src/backend/nodes/equalfuncs.c   | 14 ++
src/backend/nodes/outfuncs.c |  2 +-
src/backend/nodes/readfuncs.c|  2 +-
src/include/catalog/catversion.h |  2 +-
5 files changed, 12 insertions(+), 14 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-29 Thread Noah Misch
On Mon, May 29, 2017 at 03:20:41AM +, Tom Lane wrote:
> Annotate the fact that somebody added location fields to PartitionBoundSpec
> and PartitionRangeDatum but forgot to handle them in
> outfuncs.c/readfuncs.c.  This is fairly harmless for production purposes
> (since readfuncs.c would just substitute -1 anyway) but it's still bogus.
> It's not worth forcing a post-beta1 initdb just to fix this, but if we
> have another reason to force initdb before 10.0, we should go back and
> clean this up.

+1 for immediately forcing initdb for this, getting it out of the way.  We're
already unlikely to reach 10.0 without bumping catversion, but if we otherwise
did, releasing 10.0 with a 10beta1 catversion would have negative value.


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options.

Both views replace the umoptions field with NULL when the user does not
meet qualifications to see it.  They used different qualifications, and
pg_user_mappings documented qualifications did not match its implemented
qualifications.  Make its documentation and implementation match those
of user_mapping_options.  One might argue for stronger qualifications,
but these have long, documented tenure.  pg_user_mappings has always
exhibited this problem, so back-patch to 9.2 (all supported versions).

Michael Paquier and Feike Steenbergen.  Reviewed by Jeff Janes.
Reported by Andrew Wheelwright.

Security: CVE-2017-7486

Branch
--
REL9_5_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/db2158108674812abe883f7e0bd14eb2024ea8f3

Modified Files
--
doc/src/sgml/catalogs.sgml |  7 ++--
src/backend/catalog/system_views.sql   | 10 +++---
src/test/regress/expected/foreign_data.out | 54 ++
src/test/regress/expected/rules.out|  4 ++-
src/test/regress/sql/foreign_data.sql  | 15 +
5 files changed, 82 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options.

Both views replace the umoptions field with NULL when the user does not
meet qualifications to see it.  They used different qualifications, and
pg_user_mappings documented qualifications did not match its implemented
qualifications.  Make its documentation and implementation match those
of user_mapping_options.  One might argue for stronger qualifications,
but these have long, documented tenure.  pg_user_mappings has always
exhibited this problem, so back-patch to 9.2 (all supported versions).

Michael Paquier and Feike Steenbergen.  Reviewed by Jeff Janes.
Reported by Andrew Wheelwright.

Security: CVE-2017-7486

Branch
--
REL9_2_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/99cbb0bd9abc4c3b85a2de2f2e83b5ddc5d38d35

Modified Files
--
doc/src/sgml/catalogs.sgml |  7 ++--
src/backend/catalog/system_views.sql   | 10 +++---
src/test/regress/expected/foreign_data.out | 54 ++
src/test/regress/expected/rules.out|  2 +-
src/test/regress/sql/foreign_data.sql  | 15 +
5 files changed, 80 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq.

Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the,
already then, deprecated requiressl parameter into conninfo_storeval().
The default PGREQUIRESSL environment variable was however lost in the
change resulting in a potentially silent accept of a non-SSL connection
even when set.  Its documentation remained.  Restore its implementation.
Also amend the documentation to mark PGREQUIRESSL as deprecated for
those not following the link to requiressl.  Back-patch to 9.3, where
commit 65c3bf1 first appeared.

Behavior has been more complex when the user provides both deprecated
and non-deprecated settings.  Before commit 65c3bf1, libpq operated
according to the first of these found:

  requiressl=1
  PGREQUIRESSL=1
  sslmode=*
  PGSSLMODE=*

(Note requiressl=0 didn't override sslmode=*; it would only suppress
PGREQUIRESSL=1 or a previous requiressl=1.  PGREQUIRESSL=0 had no effect
whatsoever.)  Starting with commit 65c3bf1, libpq ignored PGREQUIRESSL,
and order of precedence changed to this:

  last of requiressl=* or sslmode=*
  PGSSLMODE=*

Starting now, adopt the following order of precedence:

  last of requiressl=* or sslmode=*
  PGSSLMODE=*
  PGREQUIRESSL=1

This retains the 65c3bf1 behavior for connection strings that contain
both requiressl=* and sslmode=*.  It retains the 65c3bf1 change that
either connection string option overrides both environment variables.
For the first time, PGSSLMODE has precedence over PGREQUIRESSL; this
avoids reducing security of "PGREQUIRESSL=1 PGSSLMODE=verify-full"
configurations originating under v9.3 and later.

Daniel Gustafsson

Security: CVE-2017-7485

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/ed36c1fe172aec866d92d6e5071150a0ec901f8b

Modified Files
--
doc/src/sgml/libpq.sgml   |  3 +++
src/interfaces/libpq/fe-connect.c | 24 
2 files changed, 27 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options.

Both views replace the umoptions field with NULL when the user does not
meet qualifications to see it.  They used different qualifications, and
pg_user_mappings documented qualifications did not match its implemented
qualifications.  Make its documentation and implementation match those
of user_mapping_options.  One might argue for stronger qualifications,
but these have long, documented tenure.  pg_user_mappings has always
exhibited this problem, so back-patch to 9.2 (all supported versions).

Michael Paquier and Feike Steenbergen.  Reviewed by Jeff Janes.
Reported by Andrew Wheelwright.

Security: CVE-2017-7486

Branch
--
master

Details
---
https://git.postgresql.org/pg/commitdiff/3eefc51053f250837c3115c12f8119d16881a2d7

Modified Files
--
doc/src/sgml/catalogs.sgml |  7 ++--
src/backend/catalog/system_views.sql   | 10 +++---
src/test/regress/expected/foreign_data.out | 54 ++
src/test/regress/expected/rules.out|  4 ++-
src/test/regress/sql/foreign_data.sql  | 15 +
5 files changed, 82 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Restore PGREQUIRESSL recognition in libpq.

2017-05-11 Thread Noah Misch
Restore PGREQUIRESSL recognition in libpq.

Commit 65c3bf19fd3e1f6a591618e92eb4c54d0b217564 moved handling of the,
already then, deprecated requiressl parameter into conninfo_storeval().
The default PGREQUIRESSL environment variable was however lost in the
change resulting in a potentially silent accept of a non-SSL connection
even when set.  Its documentation remained.  Restore its implementation.
Also amend the documentation to mark PGREQUIRESSL as deprecated for
those not following the link to requiressl.  Back-patch to 9.3, where
commit 65c3bf1 first appeared.

Behavior has been more complex when the user provides both deprecated
and non-deprecated settings.  Before commit 65c3bf1, libpq operated
according to the first of these found:

  requiressl=1
  PGREQUIRESSL=1
  sslmode=*
  PGSSLMODE=*

(Note requiressl=0 didn't override sslmode=*; it would only suppress
PGREQUIRESSL=1 or a previous requiressl=1.  PGREQUIRESSL=0 had no effect
whatsoever.)  Starting with commit 65c3bf1, libpq ignored PGREQUIRESSL,
and order of precedence changed to this:

  last of requiressl=* or sslmode=*
  PGSSLMODE=*

Starting now, adopt the following order of precedence:

  last of requiressl=* or sslmode=*
  PGSSLMODE=*
  PGREQUIRESSL=1

This retains the 65c3bf1 behavior for connection strings that contain
both requiressl=* and sslmode=*.  It retains the 65c3bf1 change that
either connection string option overrides both environment variables.
For the first time, PGSSLMODE has precedence over PGREQUIRESSL; this
avoids reducing security of "PGREQUIRESSL=1 PGSSLMODE=verify-full"
configurations originating under v9.3 and later.

Daniel Gustafsson

Security: CVE-2017-7485

Branch
--
REL9_6_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/aafbd1df969135c185947c596c46608fc9f4a67c

Modified Files
--
doc/src/sgml/libpq.sgml   |  3 +++
src/interfaces/libpq/fe-connect.c | 24 
2 files changed, 27 insertions(+)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: Match pg_user_mappings limits to information_schema.user_mapping

2017-05-11 Thread Noah Misch
Match pg_user_mappings limits to information_schema.user_mapping_options.

Both views replace the umoptions field with NULL when the user does not
meet qualifications to see it.  They used different qualifications, and
pg_user_mappings documented qualifications did not match its implemented
qualifications.  Make its documentation and implementation match those
of user_mapping_options.  One might argue for stronger qualifications,
but these have long, documented tenure.  pg_user_mappings has always
exhibited this problem, so back-patch to 9.2 (all supported versions).

Michael Paquier and Feike Steenbergen.  Reviewed by Jeff Janes.
Reported by Andrew Wheelwright.

Security: CVE-2017-7486

Branch
--
REL9_4_STABLE

Details
---
https://git.postgresql.org/pg/commitdiff/b2423f0fa21b38e9a33782dccad028dca903ea3d

Modified Files
--
doc/src/sgml/catalogs.sgml |  7 ++--
src/backend/catalog/system_views.sql   | 10 +++---
src/test/regress/expected/foreign_data.out | 54 ++
src/test/regress/expected/rules.out|  4 ++-
src/test/regress/sql/foreign_data.sql  | 15 +
5 files changed, 82 insertions(+), 8 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


  1   2   3   4   5   6   7   8   >