[COMMITTERS] pgsql: PL/Perl portability fix: absorb relevant -D switches from Perl.
PL/Perl portability fix: absorb relevant -D switches from Perl. Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db, which see for more info. Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42, so Coverity doesn't whine about the back branches. Ashutosh Sharma, some adjustments by me Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=r...@mail.gmail.com Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/df52739ce3e7b57791c3d2278fa945a4bed61947 Modified Files -- config/perl.m4 | 25 + configure | 13 + configure.in | 1 + contrib/hstore_plperl/Makefile | 2 +- src/Makefile.global.in | 1 + src/pl/plperl/GNUmakefile | 6 +- src/pl/plperl/plperl.c | 28 +--- src/tools/msvc/Mkvcbuild.pm| 27 +-- 8 files changed, 88 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Perl portability fix: absorb relevant -D switches from Perl.
PL/Perl portability fix: absorb relevant -D switches from Perl. Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db, which see for more info. Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42, so Coverity doesn't whine about the back branches. Ashutosh Sharma, some adjustments by me Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=r...@mail.gmail.com Branch -- REL9_4_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9cbdc689418b8a3e5b918ba9b76c5ed91d7406c0 Modified Files -- config/perl.m4 | 25 + configure | 13 + configure.in| 1 + src/Makefile.global.in | 1 + src/pl/plperl/GNUmakefile | 6 +- src/pl/plperl/plperl.c | 28 +--- src/tools/msvc/Mkvcbuild.pm | 21 - 7 files changed, 82 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Perl portability fix: absorb relevant -D switches from Perl.
PL/Perl portability fix: absorb relevant -D switches from Perl. Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db, which see for more info. Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42, so Coverity doesn't whine about the back branches. Ashutosh Sharma, some adjustments by me Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=r...@mail.gmail.com Branch -- REL9_3_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0d8f015e7726f5c9635b0b435a4cdf4d6dcdfdbe Modified Files -- config/perl.m4 | 25 + configure | 13 + configure.in| 1 + src/Makefile.global.in | 1 + src/pl/plperl/GNUmakefile | 6 +- src/pl/plperl/plperl.c | 28 +--- src/tools/msvc/Mkvcbuild.pm | 21 - 7 files changed, 82 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Perl portability fix: absorb relevant -D switches from Perl.
PL/Perl portability fix: absorb relevant -D switches from Perl. Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db, which see for more info. Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42, so Coverity doesn't whine about the back branches. Ashutosh Sharma, some adjustments by me Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=r...@mail.gmail.com Branch -- REL9_2_STABLE Details --- https://git.postgresql.org/pg/commitdiff/456c7dff2af1b32ae2d1922ca672cf93ec9edf1d Modified Files -- config/perl.m4 | 25 + configure | 13 + configure.in| 1 + src/Makefile.global.in | 1 + src/pl/plperl/GNUmakefile | 6 +- src/pl/plperl/plperl.c | 28 +--- src/tools/msvc/Mkvcbuild.pm | 21 - 7 files changed, 82 insertions(+), 13 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Perl portability fix: absorb relevant -D switches from Perl.
PL/Perl portability fix: absorb relevant -D switches from Perl. Back-patch of commit 3c163a7fc76debbbdad1bdd3c43721cffe72f4db, which see for more info. Also throw in commit b4cc35fbb709bd6fcae8998f041fd731c9acbf42, so Coverity doesn't whine about the back branches. Ashutosh Sharma, some adjustments by me Discussion: https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=r...@mail.gmail.com Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1e58c503ec46ec78ddf19aa5bad7d095f14e042b Modified Files -- config/perl.m4 | 25 + configure | 13 + configure.in | 1 + contrib/hstore_plperl/Makefile | 2 +- src/Makefile.global.in | 1 + src/pl/plperl/GNUmakefile | 6 +- src/pl/plperl/plperl.c | 28 +--- src/tools/msvc/Mkvcbuild.pm| 27 +-- 8 files changed, 88 insertions(+), 15 deletions(-) -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: PL/Perl portability fix: absorb relevant -D switches from Perl.
PL/Perl portability fix: absorb relevant -D switches from Perl.
The Perl documentation is very clear that stuff calling libperl should
be built with the compiler switches shown by Perl's $Config{ccflags}.
We'd been ignoring that up to now, and mostly getting away with it,
but recent Perl versions contain ABI compatibility cross-checks that
fail on some builds because of this omission. In particular the
sizeof(PerlInterpreter) can come out different due to some fields being
added or removed; which means we have a live ABI hazard that we'd better
fix rather than continuing to sweep it under the rug.
However, it still seems like a bad idea to just absorb $Config{ccflags}
verbatim. In some environments Perl was built with a different compiler
that doesn't even use the same switch syntax. -D switch syntax is pretty
universal though, and absorbing Perl's -D switches really ought to be
enough to fix the problem.
Furthermore, Perl likes to inject stuff like -D_LARGEFILE_SOURCE and
-D_FILE_OFFSET_BITS=64 into $Config{ccflags}, which affect libc ABIs on
platforms where they're relevant. Adopting those seems dangerous too.
It's unclear whether a build wherein Perl and Postgres have different ideas
of sizeof(off_t) etc would work, or whether anyone would care about making
it work. But it's dead certain that having different stdio ABIs in
core Postgres and PL/Perl will not work; we've seen that movie before.
Therefore, let's also ignore -D switches for symbols beginning with
underscore. The symbols that we actually need to import should be the ones
mentioned in perl.h's PL_bincompat_options stanza, and none of those start
with underscore, so this seems likely to work. (If it turns out not to
work everywhere, we could consider intersecting the symbols mentioned in
PL_bincompat_options with the -D switches. But that will be much more
complicated, so let's try this way first.)
This will need to be back-patched, but first let's see what the
buildfarm makes of it.
Ashutosh Sharma, some adjustments by me
Discussion:
https://postgr.es/m/CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=r...@mail.gmail.com
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/3c163a7fc76debbbdad1bdd3c43721cffe72f4db
Modified Files
--
config/perl.m4 | 25 +
configure | 13 +
configure.in | 1 +
contrib/hstore_plperl/Makefile | 2 +-
src/Makefile.global.in | 1 +
src/pl/plperl/GNUmakefile | 6 +-
src/tools/msvc/Mkvcbuild.pm| 27 +--
7 files changed, 71 insertions(+), 4 deletions(-)
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
