Re: [COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup

2017-01-30 Thread Alvaro Herrera
Stephen Frost wrote:
> * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:

> > This will be undone by the next perltidy run.
> 
> Ugh.
> 
> I certainly hope what was there before wasn't the result of a perltidy
> run as it was quite ugly and inconsistent..

Maybe it was.  I checked the diff after running perltidy after your
commit and there are some changes that look like a reversion of your
changes, but I don't know if there are other changes.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


Re: [COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup

2017-01-30 Thread Stephen Frost
* Alvaro Herrera (alvhe...@2ndquadrant.com) wrote:
> Stephen Frost wrote:
> > test_pg_dump TAP test whitespace cleanup
> > 
> > The formatting of the perl hashes used in the TAP tests for test_pg_dump
> > was rather horribly inconsistent and made it more difficult than it
> > really should have been to add new tests or adjust what tests are for
> > what runs, etc.
> > 
> > Reformat to clean that all up.
> > 
> > Whitespace-only changes.
> 
> This will be undone by the next perltidy run.

Ugh.

I certainly hope what was there before wasn't the result of a perltidy
run as it was quite ugly and inconsistent..

Thanks!

Stephen


signature.asc
Description: Digital signature


Re: [COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup

2017-01-30 Thread Alvaro Herrera
Stephen Frost wrote:
> test_pg_dump TAP test whitespace cleanup
> 
> The formatting of the perl hashes used in the TAP tests for test_pg_dump
> was rather horribly inconsistent and made it more difficult than it
> really should have been to add new tests or adjust what tests are for
> what runs, etc.
> 
> Reformat to clean that all up.
> 
> Whitespace-only changes.

This will be undone by the next perltidy run.

-- 
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup

2017-01-29 Thread Stephen Frost
test_pg_dump TAP test whitespace cleanup

The formatting of the perl hashes used in the TAP tests for test_pg_dump
was rather horribly inconsistent and made it more difficult than it
really should have been to add new tests or adjust what tests are for
what runs, etc.

Reformat to clean that all up.

Whitespace-only changes.

Branch
--
REL9_6_STABLE

Details
---
http://git.postgresql.org/pg/commitdiff/73cd4896f41052bdaf779fa1b63aca5f10c56a62

Modified Files
--
src/test/modules/test_pg_dump/t/001_base.pl | 784 
1 file changed, 462 insertions(+), 322 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers


[COMMITTERS] pgsql: test_pg_dump TAP test whitespace cleanup

2017-01-29 Thread Stephen Frost
test_pg_dump TAP test whitespace cleanup

The formatting of the perl hashes used in the TAP tests for test_pg_dump
was rather horribly inconsistent and made it more difficult than it
really should have been to add new tests or adjust what tests are for
what runs, etc.

Reformat to clean that all up.

Whitespace-only changes.

Branch
--
master

Details
---
http://git.postgresql.org/pg/commitdiff/fb94ca77f1400e236b00d432dccfbe4f1124971c

Modified Files
--
src/test/modules/test_pg_dump/t/001_base.pl | 784 
1 file changed, 462 insertions(+), 322 deletions(-)


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers