[COMMITTERS] pgsql-server/src/backend/storage/buffer Tag: R ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 12:53:30

Modified files:
src/backend/storage/buffer: Tag: REL7_4_STABLE bufmgr.c 

Log message:
Force zero_damaged_pages to be effectively ON during recovery from WAL,
since there is no need to worry about damaged pages when we are going to
overwrite them anyway from the WAL.  Per recent discussion.


---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[COMMITTERS] pgsql-server/src/backend/storage/buffer bufmgr.c

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 12:53:20

Modified files:
src/backend/storage/buffer: bufmgr.c 

Log message:
Force zero_damaged_pages to be effectively ON during recovery from WAL,
since there is no need to worry about damaged pages when we are going to
overwrite them anyway from the WAL.  Per recent discussion.


---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html


[COMMITTERS] pgsql-server/src/backend/storage/buffer Tag: R ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 12:53:42

Modified files:
src/backend/storage/buffer: Tag: REL7_3_STABLE bufmgr.c 

Log message:
Force zero_damaged_pages to be effectively ON during recovery from WAL,
since there is no need to worry about damaged pages when we are going to
overwrite them anyway from the WAL.  Per recent discussion.


---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster


[COMMITTERS] pgsql-server/doc/src/sgml/ref create_trigger.sgml

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 13:58:27

Modified files:
doc/src/sgml/ref: create_trigger.sgml 

Log message:
Fix typos noted by Halley Pacheco de Oliveira.


---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[COMMITTERS] pgsql-server/doc/src/sgml/ref Tag: REL7_4_STAB ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 13:58:38

Modified files:
doc/src/sgml/ref: Tag: REL7_4_STABLE create_trigger.sgml 

Log message:
Fix typos noted by Halley Pacheco de Oliveira.


---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster


[COMMITTERS] pgsql-server/src/backend/utils/adt network.c

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 14:50:19

Modified files:
src/backend/utils/adt: network.c 

Log message:
netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.


---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


[COMMITTERS] pgsql-server/src/backend/utils/adt Tag: REL7_4 ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 14:50:29

Modified files:
src/backend/utils/adt: Tag: REL7_4_STABLE network.c 

Log message:
netmask() and hostmask() functions should return maximum-length masklen,
per gripe from Joe Sunday.


---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


Re: [COMMITTERS] pgsql-server/src/backend/utils/adt network.c

2003-12-01 Thread Neil Conway
[EMAIL PROTECTED] (Tom Lane) writes:
>   netmask() and hostmask() functions should return maximum-length masklen,
>   per gripe from Joe Sunday.

Should we add some regression tests for this behavior?

-Neil


---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


Re: [COMMITTERS] pgsql-server/src/backend/utils/adt network.c

2003-12-01 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes:
> [EMAIL PROTECTED] (Tom Lane) writes:
>> netmask() and hostmask() functions should return maximum-length masklen,
>> per gripe from Joe Sunday.

> Should we add some regression tests for this behavior?

Don't much care --- it doesn't seem like the kind of thing that's likely
to break again, unless someone deliberately changes the behavior (which
is what happened here AFAICT; a regression test would hardly prevent it).

regards, tom lane

---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[COMMITTERS] pgsql-server/doc/src/sgml datatype.sgml dateti ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 16:34:54

Modified files:
doc/src/sgml   : datatype.sgml datetime.sgml 

Log message:
Minor wordsmithing in datetime docs to try to address gripes raised by
cnliou.


---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[COMMITTERS] pgsql-server/doc/src/sgml Tag: REL7_4_STABLE d ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 16:35:04

Modified files:
doc/src/sgml   : Tag: REL7_4_STABLE datatype.sgml datetime.sgml 

Log message:
Minor wordsmithing in datetime docs to try to address gripes raised by
cnliou.


---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html


[COMMITTERS] pgsql-server/src backend/utils/adt/int.c backe ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 17:52:38

Modified files:
src/backend/utils/adt: int.c int8.c numeric.c 
src/include/catalog: pg_operator.h pg_proc.h 
src/include/utils: builtins.h int8.h 
src/test/regress/expected: create_operator.out 
src/test/regress/sql: create_operator.sql 

Log message:
Attached is a patch implementing factorial(), returning numeric. Points
to note:

1) arttype is numeric. I thought this was the best way of allowing
arbitarily large factorials, even though factorial(2^63) is a large
number. Happy to change to integers if this is overkill.
2) since we're accepting numeric arguments, the patch tests for floats.
If a numeric is passed with non-zero decimal portion, an error is raised
since (from memory) they are undefined.

Gavin Sherry


---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


[COMMITTERS] pgsql-server/doc/src/sgml typeconv.sgml

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 17:53:15

Modified files:
doc/src/sgml   : typeconv.sgml 

Log message:
Remove mention of factorial as casting example.  New example needed.


---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


[COMMITTERS] pgsql-server/src backend/storage/ipc/ipci.c ba ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 17:59:26

Modified files:
src/backend/storage/ipc: ipci.c 
src/backend/storage/lmgr: deadlock.c lmgr.c lock.c proc.c 
src/include/storage: lmgr.h lock.h proc.h 

Log message:
Try to reduce confusion about what is a lock method identifier, a lock
method control structure, or a table of control structures.

. Use type LOCKMASK where an int is not a counter.

. Get rid of INVALID_TABLEID, use INVALID_LOCKMETHOD instead.

. Use INVALID_LOCKMETHOD instead of (LOCKMETHOD) NULL, because
LOCKMETHOD is not a pointer.

. Define and use macro LockMethodIsValid.

. Rename LOCKMETHOD to LOCKMETHODID.

. Remove global variable LongTermTableId in lmgr.c, because it is
never used.

. Make LockTableId static in lmgr.c, because it is used nowhere else.
Why not remove it and use DEFAULT_LOCKMETHOD?

. Rename the lock method control structure from LOCKMETHODTABLE to
LockMethodData.  Introduce a pointer type named LockMethod.

. Remove elog(FATAL) after InitLockTable() call in
CreateSharedMemoryAndSemaphores(), because if something goes wrong,
there is elog(FATAL) in LockMethodTableInit(), and if this doesn't
help, an elog(ERROR) in InitLockTable() is promoted to FATAL.

. Make InitLockTable() void, because its only caller does not use its
return value any more.

. Rename variables in lock.c to avoid statements like
LockMethodTable[NumLockMethods] = lockMethodTable;
lockMethodTable = LockMethodTable[lockmethod];

. Change LOCKMETHODID type to uint16 to fit into struct LOCKTAG.

. Remove static variables BITS_OFF and BITS_ON from lock.c, because
I agree to this doubt:
* XXX is a fetch from a static array really faster than a shift?

. Define and use macros LOCKBIT_ON/OFF.

Manfred Koizar


---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[COMMITTERS] pgsql-server/ oc/src/sgml/datatype.sgml oc/src ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:08:03

Modified files:
doc/src/sgml   : datatype.sgml runtime.sgml spi.sgml 
doc/src/sgml/ref: alter_table.sgml create_table.sgml 
  create_table_as.sgml pg_dump.sgml prepare.sgml 
  select_into.sgml 
src/backend/executor: execMain.c 
src/backend/parser: gram.y 
src/backend/utils/misc: guc.c postgresql.conf.sample 
src/bin/pg_dump: pg_dump.c 
src/bin/psql   : tab-complete.c 
src/include/utils: guc.h 
src/test/regress/expected: without_oid.out 
src/test/regress/sql: without_oid.sql 

Log message:
This patch adds a new GUC var, "default_with_oids", which follows the
proposal for eventually deprecating OIDs on user tables that I posted
earlier to pgsql-hackers. pg_dump now always specifies WITH OIDS or
WITHOUT OIDS when dumping a table. The documentation has been updated.

Neil Conway


---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html


[COMMITTERS] pgsql-server/src/bin/psql describe.c

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:11:07

Modified files:
src/bin/psql   : describe.c 

Log message:
This patch finishes off the work that I did with making view
definitions use pretty printing.

It does:

* Pretty index predicates
* Pretty rule definitions
* Uppercases PRIMARY KEY and UNIQUE to be consistent with CHECK and
FOREIGN KEY
* View rules are improved to match table rules:

Christopher Kings-Lynne


---(end of broadcast)---
TIP 8: explain analyze is your friend


Re: [COMMITTERS] pgsql-server/src/bin/psql describe.c

2003-12-01 Thread Bruce Momjian

Yes, this was the CHECK part applied by Tom to 7.4.

---

Tom Lane wrote:
> CVSROOT:  /cvsroot
> Module name:  pgsql-server
> Changes by:   [EMAIL PROTECTED]   03/10/16 21:57:04
> 
> Modified files:
>   src/bin/psql   : describe.c 
> 
> Log message:
>   Use pg_get_constraintdef() rather than pg_constraint.consrc; this is
>   a portion of a patch recently submitted by Christopher Kings-Lynne.
>   Applied by agreement that this is a bug fix.
> 
> 
> ---(end of broadcast)---
> TIP 5: Have you checked our extensive FAQ?
> 
>http://www.postgresql.org/docs/faqs/FAQ.html
> 

-- 
  Bruce Momjian|  http://candle.pha.pa.us
  [EMAIL PROTECTED]   |  (610) 359-1001
  +  If your life is a hard drive, |  13 Roberts Road
  +  Christ can be your backup.|  Newtown Square, Pennsylvania 19073

---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?

   http://www.postgresql.org/docs/faqs/FAQ.html


[COMMITTERS] pgsql-server/src/bin/psql command.c common.h c ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:14:41

Modified files:
src/bin/psql   : command.c common.h copy.c stringutils.c 
 tab-complete.c variables.c 

Log message:
This patch reduces some unsightly #ifdefs, and fixes two typos in
comments in the psql code. This doesn't make any functional change, so
feel free to save it for 7.5

Neil Conway


---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])


[COMMITTERS] pgsql-server/src backend/bootstrap/bootstrap.c ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:15:40

Modified files:
src/backend/bootstrap: bootstrap.c 
src/backend/port: sysv_sema.c sysv_shmem.c 
src/backend/postmaster: postmaster.c 
src/backend/tcop: postgres.c 
src/include/storage: pg_shmem.h 

Log message:
Avoid assuming that type key_t is 32 bits, since it reportedly isn't
on 64-bit Solaris.  Use a non-system-dependent datatype for UsedShmemSegID,
namely unsigned long (which we were already assuming could hold a shmem
key anyway, cf RecordSharedMemoryInLockFile).


---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


[COMMITTERS] pgsql-server/ oc/src/sgml/ref/psql-ref.sgml rc ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:22:02

Modified files:
doc/src/sgml/ref: psql-ref.sgml 
src/bin/psql   : command.c describe.c describe.h help.c 
 tab-complete.c 

Log message:
attached is a patch that adds display of the groups a user belongs to to
\du and a \dg command to psql. It's against 7.4beta5.

Markus Bertheau <[EMAIL PROTECTED]>


---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])


[COMMITTERS] pgsql-server/doc TODO

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:22:44

Modified files:
doc: TODO 

Log message:
Update for patches applied:

< * Change factorial to return a numeric
> * -Change factorial to return a numeric (Gavin)
258c258
< * Allow psql \du to show groups, and add \dg for groups
> * -Allow psql \du to show groups, and add \dg for groups


---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])


[COMMITTERS] pgsql-server/src Makefile.shlib

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:23:06

Modified files:
src: Makefile.shlib 

Log message:
Win32 patch for Makefile.shlib

Claudio Natoli


---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings


[COMMITTERS] pgsql-server/src/bin/psql help.c

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:34:48

Modified files:
src/bin/psql   : help.c 

Log message:
This makes help like this:

\lo_export LOBOID FILE
\lo_import FILE [COMMENT]
\lo_list
\lo_unlink LOBOIDlarge object operations

Instead of not saying anything about what arguments are required.

Christopher Kings-Lynne


---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index scan if your
  joining column's datatypes do not match


[COMMITTERS] pgsql-server/doc/src/sgml ecpg.sgml

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 18:36:40

Modified files:
doc/src/sgml   : ecpg.sgml 

Log message:
Hi, this doco patch is a quick one to add explicit mention of the need
for the AT clause in threaded ECPG applications.

Philip Yarra


---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster


[COMMITTERS] pgsql-server/src/backend/executor execTuples.c

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:09:03

Modified files:
src/backend/executor: execTuples.c 

Log message:
This patch refactors execTuples.c in two ways.

Neil Conway


---(end of broadcast)---
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])


[COMMITTERS] pgsql-server/src/include/utils builtins.h

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:12:16

Modified files:
src/include/utils: builtins.h 

Log message:
The attached patch enables contrib/cube to build cleanly under Cygwin
(again).  Please consider this patch for the 7.4.1 branch (if there will
be one) too.

Jason Tishler


---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
  subscribe-nomail command to [EMAIL PROTECTED] so that your
  message can get through to the mailing list cleanly


[COMMITTERS] pgsql-server/contrib/pg_autovacuum pg_autovacuum.c

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:13:07

Modified files:
contrib/pg_autovacuum: pg_autovacuum.c 

Log message:
I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is
not initialized if a log file is not specified on the command line.  This
causes an immediate segfault on systems that fill allocated memory with some
value other than zero (my FreeBSD machine uses 0xD0).

Several crashes later I discovered that args->user, password, host, and port
are also used without being initialized.

This doesn't appear to be fixed in CVS and I came up empty on a mailing list
search -- hope it hasn't been reported already.

Craig Boston


---(end of broadcast)---
TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]


[COMMITTERS] pgsql-server/contrib/pg_autovacuum Tag: REL7_4 ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:14:29

Modified files:
contrib/pg_autovacuum: Tag: REL7_4_STABLE pg_autovacuum.c 

Log message:
I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is
not initialized if a log file is not specified on the command line.  This
causes an immediate segfault on systems that fill allocated memory with some
value other than zero (my FreeBSD machine uses 0xD0).

Several crashes later I discovered that args->user, password, host, and port
are also used without being initialized.

This doesn't appear to be fixed in CVS and I came up empty on a mailing list
search -- hope it hasn't been reported already.

Craig Boston


---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


[COMMITTERS] pgsql-server/src/bin/initdb initdb.c

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:15:47

Modified files:
src/bin/initdb : initdb.c 

Log message:
Fix initdb use of mkdir_p().

Andrew Dunstan


---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


[COMMITTERS] pgsql-server/contrib/pg_autovacuum pg_autovacu ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:19:33

Modified files:
contrib/pg_autovacuum: pg_autovacuum.c pg_autovacuum.h 

Log message:
I've run across a pretty serious problem with pg_autovacuum.
pg_autovacuum looses track of any table that's ever been truncated
(possibly other situations too).   When i truncate a table it gets a
new relfilenode in pg_class.  This is a problem because pg_autovacuum
assumes pg_class.relfilenode will join to pg_stats_all_tables.relid.
pg_stats_all_tables.relid is actallly the oid from pg_class, not the
relfilenode.   These two values start out equal so pg_autovacuum works
initially, but it fails later on because of this incorrect assumption.

This patch fixes that problem.  Applied to HEAD and 7.4.X.

Brian Hirt


---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


[COMMITTERS] pgsql-server/contrib/pg_autovacuum Tag: REL7_4 ...

2003-12-01 Thread Bruce Momjian
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 19:19:55

Modified files:
contrib/pg_autovacuum: Tag: REL7_4_STABLE pg_autovacuum.c 
   pg_autovacuum.h 

Log message:
I've run across a pretty serious problem with pg_autovacuum.
pg_autovacuum looses track of any table that's ever been truncated
(possibly other situations too).   When i truncate a table it gets a
new relfilenode in pg_class.  This is a problem because pg_autovacuum
assumes pg_class.relfilenode will join to pg_stats_all_tables.relid.
pg_stats_all_tables.relid is actallly the oid from pg_class, not the
relfilenode.   These two values start out equal so pg_autovacuum works
initially, but it fails later on because of this incorrect assumption.

This patch fixes that problem.  Applied to HEAD and 7.4.X.

Brian Hirt


---(end of broadcast)---
TIP 6: Have you searched our list archives?

   http://archives.postgresql.org


[COMMITTERS] pgsql-server/ oc/src/sgml/ref/drop_operator.sg ...

2003-12-01 Thread Tom Lane
CVSROOT:/cvsroot
Module name:pgsql-server
Changes by: [EMAIL PROTECTED]   03/12/01 20:26:59

Modified files:
doc/src/sgml/ref: drop_operator.sgml 
doc/src/sgml   : typeconv.sgml 
src/backend/utils/adt: numeric.c 

Log message:
Code and docs review for numeric-factorial patch.


---(end of broadcast)---
TIP 7: don't forget to increase your free space map settings