[COMMITTERS] pgsql: Clean up pg_dump tests, re-enable BLOB testing
Clean up pg_dump tests, re-enable BLOB testing Add a loop to check that each test covers all of the pg_dump runs. We (I) had been a bit sloppy when adding new runs and not making sure to mark if they should be under like or unlike for each test, this loop makes sure that the test system will complain if any are forgotten in the future. The loop also correctly handles the 'catch all' cases, which are used to avoid running unnecessary specific checks when a single catch-all can be done (eg: a no-acl run should not have any GRANT commands). Also, re-enable the testing of blobs, but use lo_from_bytea() instead of trying to be cute and writing out to a file and then reading it back in with psql, which proved to be difficult for some buildfarm members. This allows us to add support for testing the --no-blobs option which will be getting added shortly, provided the buildfarm doesn't blow up on this. Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/8f91f323b4feef0371cd3db51be3007e44abd5e8 Modified Files -- src/bin/pg_dump/t/002_pg_dump.pl | 860 +++ 1 file changed, 695 insertions(+), 165 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
[COMMITTERS] pgsql: Add pg_sequences view
Add pg_sequences view Like pg_tables, pg_views, and others, this view contains information about sequences in a way that is independent of the system catalog layout but more comprehensive than the information schema. To help implement the view, add a new internal function pg_sequence_last_value() to return the last value of a sequence. This is kept separate from pg_sequence_parameters() to separate querying run-time state from catalog-like information. Reviewed-by: Andreas Karlsson Branch -- master Details --- http://git.postgresql.org/pg/commitdiff/67dc4ccbb2e1c27da823eced66d9217a5652cbb0 Modified Files -- doc/src/sgml/catalogs.sgml | 97 src/backend/catalog/system_views.sql | 17 ++ src/backend/commands/sequence.c | 49 +++- src/include/catalog/catversion.h | 2 +- src/include/catalog/pg_proc.h| 4 +- src/include/commands/sequence.h | 1 + src/test/regress/expected/rules.out | 14 + src/test/regress/expected/sequence.out | 23 +++- src/test/regress/expected/sequence_1.out | 23 +++- src/test/regress/sql/sequence.sql| 13 - 10 files changed, 233 insertions(+), 10 deletions(-) -- Sent via pgsql-committers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers
