Re: Documentation: 21.5. Default Roles

2020-01-07 Thread Laurenz Albe
On Fri, 2019-12-27 at 12:16 -0500, Bruce Momjian wrote:
> On Fri, Dec 27, 2019 at 05:44:10AM +, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> > 
> > Page: https://www.postgresql.org/docs/12/default-roles.html
> > Description:
> > 
> > The title is wrong.   The roles are not defaults; they are predefined and
> > privileged.  The title suggests that a user should expect  to be assigned
> > these roles.   "21.5 Sub-Administrator Roles"  would be accurate--improving
> > clarity over all  and removing any need to explain why postgres is not in
> > this list of roles.
> > 
> 
> Good points.  I have developed the attached documentation patch which
> includes your ideas.

+1

I think that "predefined role" is better than "default role".

Yours,
Laurenz Albe
-- 
Cybertec | https://www.cybertec-postgresql.com





Re: is_nullable column of information_schema.columns table

2020-01-07 Thread Laurenz Albe
On Sat, 2019-12-28 at 20:19 +, PG Doc comments form wrote:
> Page: https://www.postgresql.org/docs/12/infoschema-columns.html
> Description:
> 
> is_nullable column of information_schema.columns table does not show correct
> values for columns of views. For tables that column shows correct values
> whether a column is nullable or not. I think the documentation should
> include this information although better solution is to correct that error.

All columns of a view are defined as nullable, whether they can assume
that value or not.  PostgreSQL does not attempt to deduce the nullability
of columns from the view definition.

So the information in information_schema.columns is correct.
Remember that nullability does not imply that there are actually NULL values.

Yours,
Laurenz Albe
-- 
Cybertec | https://www.cybertec-postgresql.com





Re: glossary

2020-01-07 Thread Laurenz Albe
On Thu, 2020-01-02 at 21:24 +, PG Doc comments form wrote:
> Page: https://www.postgresql.org/docs/12/creating-cluster.html
> Description:
> 
> It would be great to have a glossary as an appendix, to define concepts such
> as cluster, schema, tablespace, database.

Does the index help?
https://www.postgresql.org/docs/current/bookindex.html

Yours,
Laurenz Albe
-- 
Cybertec | https://www.cybertec-postgresql.com





Re: Put cluster in the hierarchy in 22.1

2020-01-07 Thread Laurenz Albe
On Fri, 2020-01-03 at 03:35 +, PG Doc comments form wrote:
> Page: https://www.postgresql.org/docs/12/manage-ag-overview.html
> Description:
> 
> 22.1 says "So the full hierarchy is: server, database, schema, table (or
> some other kind of object, such as a function)." Could "cluster" be added in
> there for completeness sake?  "So the full hierarchy is: server, cluster,
> database, schema, table (or some other kind of object, such as a function)."
> It might be nice to have a graphic showing the relationships, adding other
> things as well: columns, constraints, triggers, etc.

"Server" and "cluster" are synonymous here.
Perhaps we should include "cluster" in parentheses behind "server".

Yours,
Laurenz Albe
-- 
Cybertec | https://www.cybertec-postgresql.com