Re: Documentation: 21.5. Default Roles

[Jonathan S. Katz]

On 4/28/20 2:19 PM, Magnus Hagander wrote:
> On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz  > wrote:
> 
> On 4/9/20 11:45 PM, Bruce Momjian wrote:
> > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
> >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> >>> Jonathan, Stephen, with the minor release done, can we focus on
> adding
> >>> the URL redirect and completing the patch to rename this feature
> in the
> >>> docs?  Thanks.
> >>
> >> Yes, I have a prototype for this ready, which I had scrambled
> together
> >> before the release. I am happy to make it committable in the
> coming days.
> >
> > Thanks.  Once that is done Stephen can apply my patch with his
> > additions.
> 
> Please see attached patch for pgweb that allows for the documentation to
> be redirected from a page that is removed to a newer page. The way
> it works:
> 
> - Checks to see if a page is found. If it is, great!
> - Now if a page 404s, we first check to see if there is a forwarding
> address, i.e. the new page. If it is, we issue a 301 (permanent
> redirecTt).
> - If it's still not found, we abort.
> 
> I believe this gives us the desired behavior.
> 
> Thoughts on the patch?
> 
> 
>  Looks good to me. Go for it.

This is deployed. Ready for the patch in core.

Thanks!

Jonathan



signature.asc
Description: OpenPGP digital signature

Re: Documentation: 21.5. Default Roles

[Magnus Hagander]

On Tue, Apr 28, 2020 at 8:20 PM Stephen Frost  wrote:

> Greetings,
>
> * Magnus Hagander (mag...@hagander.net) wrote:
> > On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz 
> > wrote:
> >
> > > On 4/9/20 11:45 PM, Bruce Momjian wrote:
> > > > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
> > > >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> > > >>> Jonathan, Stephen, with the minor release done, can we focus on
> adding
> > > >>> the URL redirect and completing the patch to rename this feature
> in the
> > > >>> docs?  Thanks.
> > > >>
> > > >> Yes, I have a prototype for this ready, which I had scrambled
> together
> > > >> before the release. I am happy to make it committable in the coming
> > > days.
> > > >
> > > > Thanks.  Once that is done Stephen can apply my patch with his
> > > > additions.
> > >
> > > Please see attached patch for pgweb that allows for the documentation
> to
> > > be redirected from a page that is removed to a newer page. The way it
> > > works:
> > >
> > > - Checks to see if a page is found. If it is, great!
> > > - Now if a page 404s, we first check to see if there is a forwarding
> > > address, i.e. the new page. If it is, we issue a 301 (permanent
> redirecTt).
> > > - If it's still not found, we abort.
> > >
> > > I believe this gives us the desired behavior.
> > >
> > > Thoughts on the patch?
> >
> >  Looks good to me. Go for it.
>
> What's the plan for how to maintain it going forward?  Just email -docs
> and ask someone to perform the update whenever a release is going out..?
> Or do we have some kind of better process in mind?
>
>
GIven how seldom this happens, I think that's perfectly fine. Same as we
already do with the page aliases.

//Magnus

Re: Documentation: 21.5. Default Roles

[Stephen Frost]

Greetings,

* Magnus Hagander (mag...@hagander.net) wrote:
> On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz 
> wrote:
> 
> > On 4/9/20 11:45 PM, Bruce Momjian wrote:
> > > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
> > >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> > >>> Jonathan, Stephen, with the minor release done, can we focus on adding
> > >>> the URL redirect and completing the patch to rename this feature in the
> > >>> docs?  Thanks.
> > >>
> > >> Yes, I have a prototype for this ready, which I had scrambled together
> > >> before the release. I am happy to make it committable in the coming
> > days.
> > >
> > > Thanks.  Once that is done Stephen can apply my patch with his
> > > additions.
> >
> > Please see attached patch for pgweb that allows for the documentation to
> > be redirected from a page that is removed to a newer page. The way it
> > works:
> >
> > - Checks to see if a page is found. If it is, great!
> > - Now if a page 404s, we first check to see if there is a forwarding
> > address, i.e. the new page. If it is, we issue a 301 (permanent redirecTt).
> > - If it's still not found, we abort.
> >
> > I believe this gives us the desired behavior.
> >
> > Thoughts on the patch?
> 
>  Looks good to me. Go for it.

What's the plan for how to maintain it going forward?  Just email -docs
and ask someone to perform the update whenever a release is going out..?
Or do we have some kind of better process in mind?

Thanks!

Stephen


signature.asc
Description: PGP signature

Re: Documentation: 21.5. Default Roles

[Magnus Hagander]

On Sat, Apr 25, 2020 at 1:38 AM Jonathan S. Katz 
wrote:

> On 4/9/20 11:45 PM, Bruce Momjian wrote:
> > On Thu, Apr  9, 2020 at 08:47:56PM -0400, Jonathan Katz wrote:
> >> On 4/9/20 4:57 PM, Bruce Momjian wrote:
> >>> Jonathan, Stephen, with the minor release done, can we focus on adding
> >>> the URL redirect and completing the patch to rename this feature in the
> >>> docs?  Thanks.
> >>
> >> Yes, I have a prototype for this ready, which I had scrambled together
> >> before the release. I am happy to make it committable in the coming
> days.
> >
> > Thanks.  Once that is done Stephen can apply my patch with his
> > additions.
>
> Please see attached patch for pgweb that allows for the documentation to
> be redirected from a page that is removed to a newer page. The way it
> works:
>
> - Checks to see if a page is found. If it is, great!
> - Now if a page 404s, we first check to see if there is a forwarding
> address, i.e. the new page. If it is, we issue a 301 (permanent redirecTt).
> - If it's still not found, we abort.
>
> I believe this gives us the desired behavior.
>
> Thoughts on the patch?
>

 Looks good to me. Go for it.

//Magnus

Re: Roles for pg_basebackup

[Daniel Gustafsson]

> On 28 Apr 2020, at 07:22, Fujii Masao  wrote:
> 
> On 2020/04/28 13:37, Michael Paquier wrote:
>> On Mon, Apr 27, 2020 at 12:16:41PM +0200, Daniel Gustafsson wrote:
>>> Based on a recent conversation about backups I had I propose a small tweak 
>>> to
>>> the pg_basebackup documentation.  Listing the user types in the reverse 
>>> order
>>> from today, putting superuser last, makes it IMO a little clearer that a
>>> REPLICATION role is preferrable to using a superuser for running backups.
>> Makes sense to me.  We do that in logical-replication.sgml as well as
>> pg_rewind.sgml (the latter outlines superuser rights last).
> 
> Seems there are other documentations having the similar description,
> for example, pg_receivewal.sgml, func.sgml and high-availability.sgml.
> Isn't it better to update also them at the same time?

That doe make sense.  I've updated the places where I think a user configuring
the system might conceivably infer a preference from the order, but have left
the other ones as is.

cheers ./daniel



pg_basebackup_user-v2.diff
Description: Binary data