Re: Documentation: 21.5. Default Roles
Greetings, * Stephen Frost (sfr...@snowman.net) wrote: > * Bruce Momjian (br...@momjian.us) wrote: > > On Fri, Oct 23, 2020 at 05:40:37PM -0400, Stephen Frost wrote: > > > Therefore, on the whole, the proposal that I would put out there is: > > > > > > - Rename everything (code, docs, etc) to 'predefined roles' for v14+ > > > - Update the documentation (only) in back-branches to mention that the > > > feature was renamed in v14 to 'predefined roles' > > > - Use the 'doc page alias' feature to make the documentation page for > > > 'default roles' on the older versions link to 'predefined roles' in > > > the newer versions, and vice-versa > > > > Sure, that works for me. If it was only docs, backpatch makes more > > sense, but once you showed the renaming in those other areas, > > master-only makes more sense. Thanks for working on this. > > I've written a patch to begin to make this change and sent it into > -hackers for comments, thread is here: > > https://postgr.es/m/20201120211304.gg16...@tamriel.snowman.net Just to wrap this up- this change has now been committed for v14. Thanks, Stephen signature.asc Description: PGP signature
Re: [PATCH] add link to domain data types section from locale documentation
On 30.03.21 21:46, Anton Voloshin wrote: Hello. While browsing character set collation documentation [1] I've found myself a bit puzzled by unfamiliar terminology: > of course a domain over a collatable data type is collatable Of course, it only takes a search or two to find out the exact meaning of "domain" in this context, but I think it would be useful to make this word a link to the relevant section as a help for less experienced users like myself. I've attached a patch that does that. Please let me know whether this fix is desirable and correct (I'm new to Postgres) and if there is a better way of suggesting an improvement for the documentation. [1] https://www.postgresql.org/docs/current/collation.html It's likely that the term "domain" within an SQL context confuse some people. An additional remark in the glossary concerning the SQL and IP meaning may be helpful. -- Jürgen Purtz diff --git a/doc/src/sgml/charset.sgml b/doc/src/sgml/charset.sgml index 1b00e543a6..300a0d83d4 100644 --- a/doc/src/sgml/charset.sgml +++ b/doc/src/sgml/charset.sgml @@ -346,7 +346,8 @@ initdb --locale=sv_SE collation. (The built-in collatable data types are text, varchar, and char. User-defined base types can also be marked collatable, and of course -a domain over a collatable data type is collatable.) If the +a domain over a collatable data type +is collatable.) If the expression is a column reference, the collation of the expression is the defined collation of the column. If the expression is a constant, the collation is the default collation of the data type of the diff --git a/doc/src/sgml/glossary.sgml b/doc/src/sgml/glossary.sgml index 41f3e5ee86..a7a0e35ac5 100644 --- a/doc/src/sgml/glossary.sgml +++ b/doc/src/sgml/glossary.sgml @@ -508,6 +508,27 @@ + + Domain (Internet) + + + A realm to administer certain Internet resources. + + + + + + Domain (SQL) + + + A user-defined data type that is based on another underlying data type. + + + For more information, see . + + + + Durability
Re: [PATCH] add link to domain data types section from locale documentation
On 01.04.2021 10:46, Laurenz Albe wrote: The committers are currently busy with the commitfest. You could add it to the next commitfest so that it does not get forgotten. Thanks. Added for 2021-07 commitfest: https://commitfest.postgresql.org/33/3056/ -- Anton Voloshin Postgres Professional: https://www.postgrespro.com Russian Postgres Company
Re: [PATCH] add link to domain data types section from locale documentation
On Thu, 2021-04-01 at 09:54 +0300, Anton Voloshin wrote: > Thanks! Should I do something to ensure this doc patch getting committed > to Postgres? Or will it be picked up from my [1] original email by some > committer without any further efforts from my side? The committers are currently busy with the commitfest. You could add it to the next commitfest so that it does not get forgotten. Yours, Laurenz Albe
Re: [PATCH] add link to domain data types section from locale documentation
On 31.03.2021 12:48, Laurenz Albe wrote: On Tue, 2021-03-30 at 22:46 +0300, Anton Voloshin wrote: I've attached a patch that does that. Please let me know whether this fix is desirable and correct (I'm new to Postgres) and if there is a better way of suggesting an improvement for the documentation. +1 Thanks! Should I do something to ensure this doc patch getting committed to Postgres? Or will it be picked up from my [1] original email by some committer without any further efforts from my side? [1] https://www.postgresql.org/message-id/2ea65bdf-1380-f088-02bd-ff1a31ed265c%40postgrespro.ru -- Anton Voloshin Postgres Professional: https://www.postgrespro.com Russian Postgres Company
