Re: "System roles" mentioned in psql documentation

2018-08-23 Thread Michael Paquier
On Thu, Aug 23, 2018 at 10:53:35AM +0200, Jürgen Purtz wrote:
> This inconsistency is part of the more general problem that we miss a
> chapter, where our basic terms like 'database', 'cluster', 'segment',
> 'catalog', 'schema', ... are explicitly defined.

You may have a point here, not in the way of reworking entirely the
documentation, but in the fact that we may want to use "system objects"
instead of "system roles".  I am not personally sure that it is a better
improvement than using "default roles", but that's a point to raise.
--
Michael


signature.asc
Description: PGP signature


Re: "System roles" mentioned in psql documentation

2018-08-23 Thread Jonathan S. Katz

> On Aug 23, 2018, at 3:58 AM, Michael Paquier  wrote:
> 
> Hi all,
> 
> I have noticed that psql documentation mentions "system roles", however
> in all other parts of the docs, we use the term "default roles".
> Shouldn't we make this term more consistent and also add a link to the
> table describing those roles?  Please see the attached.

I did a quick search for other cases of “system roles” with nothing coming
up, so it looks like you caught the only reference. LGTM.

Thanks!

Jonathan



signature.asc
Description: Message signed with OpenPGP


Re: "System roles" mentioned in psql documentation

2018-08-23 Thread Jürgen Purtz
This inconsistency is part of the more general problem that we miss a 
chapter, where our basic terms like 'database', 'cluster', 'segment', 
'catalog', 'schema', ... are explicitly defined.


Kind regards

Jürgen Purtz





"System roles" mentioned in psql documentation

2018-08-23 Thread Michael Paquier
Hi all,

I have noticed that psql documentation mentions "system roles", however
in all other parts of the docs, we use the term "default roles".
Shouldn't we make this term more consistent and also add a link to the
table describing those roles?  Please see the attached.

Thanks,
--
Michael
diff --git a/doc/src/sgml/ref/psql-ref.sgml b/doc/src/sgml/ref/psql-ref.sgml
index eb9d93a168..df762b811c 100644
--- a/doc/src/sgml/ref/psql-ref.sgml
+++ b/doc/src/sgml/ref/psql-ref.sgml
@@ -1521,7 +1521,8 @@ testdb=
 unified into roles, this command is now equivalent to
 \du.)
 By default, only user-created roles are shown; supply the
-S modifier to include system roles.
+S modifier to include default roles described in
+.
 If pattern is specified,
 only those roles whose names match the pattern are listed.
 If the form \dg+ is used, additional information
@@ -1711,7 +1712,8 @@ testdb=
 unified into roles, this command is now equivalent to
 \dg.)
 By default, only user-created roles are shown; supply the
-S modifier to include system roles.
+S modifier to include default roles described
+in .
 If pattern is specified,
 only those roles whose names match the pattern are listed.
 If the form \du+ is used, additional information


signature.asc
Description: PGP signature