Re: documentation pdf build fail (HEAD)

2020-03-24 Thread Tom Lane
Peter Eisentraut  writes:
> On 2020-03-24 15:31, Tom Lane wrote:
>> The problem seems to be that cedffbdb8
>> introduced some broken table markup.  I wonder why xmllint
>> failed to catch it?

> It's not a validity issue in the DocBook markup.  The error comes from 
> FOP, which complains because it requires the column count, but other 
> processors don't necessarily require it.

Maybe not, but if the count is there, shouldn't it be checked?

In this particular case, the table was obviously broken if you looked
at the rendered HTML, but I'd kind of expect the toolchain to provide
basic sanity checks without having to do that.

regards, tom lane




Re: documentation pdf build fail (HEAD)

2020-03-24 Thread Peter Eisentraut

On 2020-03-24 15:31, Tom Lane wrote:

The problem seems to be that cedffbdb8
introduced some broken table markup.  I wonder why xmllint
failed to catch it?


It's not a validity issue in the DocBook markup.  The error comes from 
FOP, which complains because it requires the column count, but other 
processors don't necessarily require it.


--
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




Re: documentation pdf build fail (HEAD)

2020-03-24 Thread Tom Lane
Erikjan Rijkers  writes:
> I build the pdf (for HEAD) almost daily without problems, but at the 
> moment I get the error below.
> I am not sure whether to blame my particular setup (debian stretch), or 
> whether there might be an error in the .sgml.  The html files still 
> build OK.

Yeah, I see it too.  The problem seems to be that cedffbdb8
introduced some broken table markup.  I wonder why xmllint
failed to catch it?  While catching morerows mistakes might be
hard in general, it shouldn't have been difficult to notice that
this table row contained more columns than the table spec allowed.

> If anyone has a suggestion on how to tackle this I'd be grateful.

The "position" noted in the error report seems to be a line number
and column number in the .fo file.  Once you go there and look around
at surrounding text, you can locate the matching .sgml input and then
try to eyeball what's wrong with it.

Fix pushed.

regards, tom lane




Re: documentation pdf build fail (HEAD)

2020-03-24 Thread Jürgen Purtz

Ubuntu 18.04: no crash, but possibly a side effect:

[INFO] FOUserAgent - Rendered page #2685.
[INFO] FOUserAgent - Rendered page #2686.
[INFO] FOUserAgent - Rendered page #2687.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"function-encode" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"function-decode" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-altercollation-notes-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-altertable-notes-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-createaggregate-notes-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-createindex-storage-parameters-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-createindex-concurrently-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-createtable-storage-parameters-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-createtable-compatibility-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-declare-notes-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-inserting-params-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-on-conflict-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-prepare-examples-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-reindex-concurrently-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-with-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-from-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-where-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-groupby-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-having-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-window-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-select-list-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-distinct-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-union-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-intersect-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-except-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-orderby-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-limit-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"sql-for-update-share-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"pg-dump-examples-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-psql-patterns-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-psql-variables-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-psql-interpolation-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-psql-prompting-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-psql-environment-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-psql-examples-title" found.
[WARN] FOUserAgent - Destination: Unresolved ID reference 
"app-postgres-single-user-title" found.

[INFO] FOUserAgent - Rendered page #2688.
[WARN] FOUserAgent - Page 226: Unresolved ID reference "function-decode" 
found.
[WARN] FOUserAgent - Page 226: Unresolved ID reference "function-encode" 
found.


Kind regards, J. Purtz





documentation pdf build fail (HEAD)

2020-03-24 Thread Erikjan Rijkers

Hello,

I build the pdf (for HEAD) almost daily without problems, but at the 
moment I get the error below.


I am not sure whether to blame my particular setup (debian stretch), or 
whether there might be an error in the .sgml.  The html files still 
build OK.


If anyone has a suggestion on how to tackle this I'd be grateful.

thanks,

Erik Rijkers



[...]
[INFO] FOUserAgent - Rendered page #526.
[INFO] FOUserAgent - Rendered page #527.
[INFO] FOUserAgent - Rendered page #528.
[INFO] FOUserAgent - Rendered page #529.
[[ERROR] FOP - Exception org.apache.fop.fo.ValidationException: The column-number or number of 
cells in the row overflows the number of fo:table-columns specified for 
the table. (See position 47337:52207)
javax.xml.transform.TransformerException: 
org.apache.fop.fo.ValidationException: The column-number or number of 
cells in the row overflows the number of fo:table-columns specified for 
the table. (See position 47337:52207)>org.apache.fop.apps.FOPException: 
org.apache.fop.fo.ValidationException: The column-number or number of 
cells in the row overflows the number of fo:table-columns specified for 
the table. (See position 47337:52207)
javax.xml.transform.TransformerException: 
org.apache.fop.fo.ValidationException: The column-number or number of 
cells in the row overflows the number of fo:table-columns specified for 
the table. (See position 47337:52207)
at 
org.apache.fop.cli.InputHandler.transformTo(InputHandler.java:289)
at 
org.apache.fop.cli.InputHandler.renderTo(InputHandler.java:115)

at org.apache.fop.cli.Main.startFOP(Main.java:186)
at org.apache.fop.cli.Main.main(Main.java:217)
Caused by: javax.xml.transform.TransformerException: 
org.apache.fop.fo.ValidationException: The column-number or number of 
cells in the row overflows the number of fo:table-columns specified for 
the table. (See position 47337:52207)
at 
org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:502)
at 
org.apache.fop.cli.InputHandler.transformTo(InputHandler.java:286)

... 3 more
Caused by: org.apache.fop.fo.ValidationException: The column-number or 
number of cells in the row overflows the number of fo:table-columns 
specified for the table. (See position 47337:52207)
at 
org.apache.fop.events.ValidationExceptionFactory.createException(ValidationExceptionFactory.java:38)
at 
org.apache.fop.events.EventExceptionManager.throwException(EventExceptionManager.java:58)
at 
org.apache.fop.events.DefaultEventBroadcaster$1.invoke(DefaultEventBroadcaster.java:175)

at com.sun.proxy.$Proxy4.tooManyCells(Unknown Source)
at 
org.apache.fop.fo.flow.table.TableCellContainer.addTableCellChild(TableCellContainer.java:75)
at 
org.apache.fop.fo.flow.table.TableRow.addChildNode(TableRow.java:95)
at 
org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:324)
at 
org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179)
at 
org.apache.xalan.transformer.TransformerIdentityImpl.startElement(TransformerIdentityImpl.java:1073)
at 
org.apache.xerces.parsers.AbstractSAXParser.startElement(Unknown Source)
at 
org.apache.xerces.xinclude.XIncludeHandler.startElement(Unknown Source)
at 
org.apache.xerces.impl.XMLNSDocumentScannerImpl.scanStartElement(Unknown 
Source)
at 
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl$FragmentContentDispatcher.dispatch(Unknown 
Source)
at 
org.apache.xerces.impl.XMLDocumentFragmentScannerImpl.scanDocument(Unknown 
Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
Source)
at org.apache.xerces.parsers.XML11Configuration.parse(Unknown 
Source)

at org.apache.xerces.parsers.XMLParser.parse(Unknown Source)
at org.apache.xerces.parsers.AbstractSAXParser.parse(Unknown 
Source)
at 
org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser.parse(Unknown Source)
at 
org.apache.xalan.transformer.TransformerIdentityImpl.transform(TransformerIdentityImpl.java:485)

... 4 more