Some typos in documentation

2019-01-12 Thread Alexander Lakhin
Hello,
While cross-checking the unique words in doc/ I found a few typos.

REL9_6_STABLE
transcations
(Also there are two 'transcation's in src/bin/psql/po/tr.po, probably
these are typos too.)

REL_10_STABLE+
PQencryptPasswodConn

pg_current_logfiles -- there is only the "pg_current_logfile" function.

NOCONNECT -- this option was replaced with "connect = false" by commit
b807f5982.

LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in
pgstat.c) or LockFileCreateWRITE in pg.stat.s should use CamelCase in
whole. I don't find any dependencies so I would prefer the latter.

REL_11_STABLE+
pg_execute_server_programs -- I could find only the
pg_execute_server_program role in pg_authid.dat.

All the corresponding patches are attached.

Best regards,
Alexander


diff --git a/doc/src/sgml/maintenance.sgml b/doc/src/sgml/maintenance.sgml
index da3a900dc1..5f3adc98c9 100644
--- a/doc/src/sgml/maintenance.sgml
+++ b/doc/src/sgml/maintenance.sgml
@@ -594,7 +594,7 @@ SELECT datname, age(datfrozenxid) FROM pg_database;
 scans every page in the table that is not already all-frozen, it should
 set age(relfrozenxid) to a value just a little more than the
 vacuum_freeze_min_age setting
-that was used (more by the number of transcations started since the
+that was used (more by the number of transactions started since the
 VACUUM started).  If no relfrozenxid-advancing
 VACUUM is issued on the table until
 autovacuum_freeze_max_age is reached, an autovacuum will soon

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index e8ec495d03..ad2e3a4466 100644
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -6106,7 +6106,7 @@ char *PQencryptPasswordConn(PGconn *conn, const char *passwd, const char *user,
 char *PQencryptPassword(const char *passwd, const char *user);
 
   PQencryptPassword is an older, deprecated version of
-  PQencryptPasswodConn. The difference is that
+  PQencryptPasswordConn. The difference is that
   PQencryptPassword does not
   require a connection object, and md5 is always used as the
   encryption algorithm.

diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 0915be0d6d..8fd1288dca 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -16153,7 +16153,7 @@ SET search_path TO schema , schema, ..
 optional parameter. The return value is NULL when the
 log format requested is not a configured
 .  The
-pg_current_logfiles reflects the contents of the
+pg_current_logfile reflects the contents of the
 current_logfiles file.

 

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index 4c63ebb7b0..c221d2a080 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -1246,7 +1246,7 @@ CREATE DATABASE foo WITH TEMPLATE template0;
   
When dumping logical replication subscriptions,
pg_dump will generate CREATE
-   SUBSCRIPTION commands that use the NOCONNECT
+   SUBSCRIPTION commands that use the connect = false
option, so that restoring the subscription does not make remote connections
for creating a replication slot or for initial table copy.  That way, the
dump can be restored without requiring network access to the remote

diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
index 302c331c49..ac658dcb24 100644
--- a/src/backend/postmaster/pgstat.c
+++ b/src/backend/postmaster/pgstat.c
@@ -3745,7 +3745,7 @@ pgstat_get_wait_io(WaitEventIO w)
 			event_name = "LockFileCreateSync";
 			break;
 		case WAIT_EVENT_LOCK_FILE_CREATE_WRITE:
-			event_name = "LockFileCreateWRITE";
+			event_name = "LockFileCreateWrite";
 			break;
 		case WAIT_EVENT_LOCK_FILE_RECHECKDATADIR_READ:
 			event_name = "LockFileReCheckDataDirRead";

diff --git a/doc/src/sgml/file-fdw.sgml b/doc/src/sgml/file-fdw.sgml
index 955a13ab7d..d80142b4fd 100644
--- a/doc/src/sgml/file-fdw.sgml
+++ b/doc/src/sgml/file-fdw.sgml
@@ -188,7 +188,7 @@
  
   Changing table-level options requires being a superuser or having the privileges
   of the default role pg_read_server_files (to use a filename) or
-  the default role pg_execute_server_programs (to use a program),
+  the default role pg_execute_server_program (to use a program),
   for security reasons: only certain users should be able to control which file is
   read or which program is run.  In principle regular users could be allowed to
   change the other options, but that's not supported at present.



Re: Some typos in documentation

2019-01-12 Thread Michael Paquier
On Sun, Jan 13, 2019 at 12:17:07AM +0300, Alexander Lakhin wrote:
> While cross-checking the unique words in doc/ I found a few typos.

Those are good finds, thanks for the report!

> LockFileCreateWrite -- Should be spelled as LockFileCreateWRITE (as in
> pgstat.c) or LockFileCreateWRITE in pg.stat.s should use CamelCase in
> whole. I don't find any dependencies so I would prefer the latter.

For consistency with the rest I think that we should use
LockFileCreateWrite in pgstat.c as well as you do, though this could
be qualified as a behavior change.  That's also the grammar which is
documented since the beginning.  Any objections from others?

> All the corresponding patches are attached.

Cool, I'll see to apply them where needed.  I'll just wait to see if
anybody has comments about the pgstat.c portion.
--
Michael


signature.asc
Description: PGP signature