Re: Explanations not clear

2024-05-13 Thread Jeff Davis
On Wed, 2024-05-08 at 08:52 +0200, Peter Eisentraut wrote:
> > I created a collation specifying the ks-level3 setting and with
> > deterministic set to false. But when I compare "a_b" to "a-b" with
> > this
> > collation I get false. According to the table 24.1 it should yield
> > true.
> > Only after adding ka-shifted this comparison becomes true. The
> > interactions
> > of the different options are not very clear.
> 
> I think table 24.1 is somewhat incorrect in the sense that
> punctuation 
> is only level 4 if you use ka-shifted, otherwise it's level 1.  This 
> should perhaps be clarified.

One option is to just include 3 levels (plus "identic") in the table,
and then later document that ka-shifted creates a fourth level and
moves punctuation character differences into that level. That explains
the mechanism but detracts from the examples.

Another option is to say that all the examples in the table are using
ka-shifted for illustration purposes. I like this option, but it's a
bit awkward because it refers to something that hasn't been explained
yet. It's also only relevant for the 'x-y' = 'x_y' example, which might
be slightly confusing.

Thoughts?

Regards,
Jeff Davis





Re: roles that have the CREATEROLE privilege can no longer GRANT predefined roles

2024-05-13 Thread David G. Johnston
On Thu, May 2, 2024 at 3:36 AM Laurenz Albe 
wrote:

> On Wed, 2024-05-01 at 16:09 +, PG Doc comments form wrote:
> > Page: https://www.postgresql.org/docs/16/predefined-roles.html
> >
> > roles that have the CREATEROLE privilege can no longer GRANT predefined
> > roles unless they are part of it having the WITH ADMIN option. this
> needs to
> > be corrected in the documentation
>
> I see what you mean.  This text:
>
>   Administrators (including roles that have the CREATEROLE privilege)
>   can GRANT these roles to users and/or other roles ...
>
> should probably become
>
>   Administrators (including roles that have the CREATEROLE privilege and
> have been
>   granted the predefined role with the ADMIN option)
>   can GRANT these roles to users and/or other roles ...
>
>
I would suggest just replacing the attempt at describing "performing
group membership" here with a link to:

https://www.postgresql.org/docs/current/role-membership.html
Like this:
"Normal roles can exercise these privileges by being added as
member of these group roles as described in ."

There isn't anything about these predefined roles and role membership that
doesn't apply to any other role.

Though skimming that section it seems to need updating along the lines
discussed above.

David J.