Re: Duplicated name of subsection 29.5.1

2025-08-07 Thread Yaroslav Saburov
Sorry, my mistake.

> 7 серп. 2025 р. о 15:15 Daniel Gustafsson  пише:
> 
> 
>> 
>>> On 7 Aug 2025, at 08:22, PG Doc comments form  
>>> wrote:
>> 
>> In section 29.5. Column Lists there are two identical subsections '29.5.1.
>> Examples', with the same link
> 
> The first link on the page, in red, is actually the table of contents for the
> section 29.5, but it does look a bit like a subsection heading given that 
> there
> is only one entry.
> 
> --
> Daniel Gustafsson
> 




Re: Duplicated name of subsection 29.5.1

2025-08-07 Thread Daniel Gustafsson
> On 7 Aug 2025, at 18:23, Yaroslav Saburov  wrote:
> 
> Sorry, my mistake.

No problems at all, thanks for the report!

--
Daniel Gustafsson





Duplicated name of subsection 29.5.1

2025-08-07 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/17/logical-replication-col-lists.html
Description:

In section 29.5. Column Lists there are two identical subsections '29.5.1.
Examples', with the same link


add alias FLOAT for double precision

2025-08-07 Thread PG Doc comments form
The following documentation comment has been logged on the website:

Page: https://www.postgresql.org/docs/17/datatype.html
Description:

In table 8.1 (
https://www.postgresql.org/docs/current/datatype.html#DATATYPE-TABLE ) the
FLOAT alias isn't listed, I think it would make sense to include beside
FLOAT8.


Re: add alias FLOAT for double precision

2025-08-07 Thread Euler Taveira
On Thu, Aug 7, 2025, at 7:35 AM, PG Doc comments form wrote:
> In table 8.1 (
> https://www.postgresql.org/docs/current/datatype.html#DATATYPE-TABLE ) the
> FLOAT alias isn't listed, I think it would make sense to include beside
> FLOAT8.

Makes sense.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/From dab483c89424075eef0f1b939334c02dbc0227a8 Mon Sep 17 00:00:00 2001
From: Euler Taveira 
Date: Thu, 7 Aug 2025 10:48:41 -0300
Subject: [PATCH v1] doc: Add float as an alias to double precision

Although "Floating-Point Types" section says that "float" data type is
taken to mean "double precision", this information is not reflected into
the data type table that lists all data type aliases.
---
 doc/src/sgml/datatype.sgml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/src/sgml/datatype.sgml b/doc/src/sgml/datatype.sgml
index 0994e089311..7458f216e50 100644
--- a/doc/src/sgml/datatype.sgml
+++ b/doc/src/sgml/datatype.sgml
@@ -117,7 +117,7 @@
 
   
double precision
-   float8
+   float, float8
double precision floating-point number (8 bytes)
   
 
-- 
2.39.5



Re: Duplicated name of subsection 29.5.1

2025-08-07 Thread Daniel Gustafsson
> On 7 Aug 2025, at 08:22, PG Doc comments form  wrote:

> In section 29.5. Column Lists there are two identical subsections '29.5.1.
> Examples', with the same link

The first link on the page, in red, is actually the table of contents for the
section 29.5, but it does look a bit like a subsection heading given that there
is only one entry.

--
Daniel Gustafsson





Re: Initcap works differently with different locale providers

2025-08-07 Thread Alexander Korotkov
On Wed, Aug 6, 2025 at 9:21 PM Jeff Davis  wrote:
> > Yes, I was not in favor of backpatching this, since it was not a bug
> > fix.  And it turns out it was incomplete.  I think we should revert
> > all
> > the backpatches and iterate on getting the documentation the way we
> > want
> > in master.
>
> +1.

Done, reverted everywhere except master.

--
Regards,
Alexander Korotkov
Supabase




Re: Make pgoutput documentation easier to find

2025-08-07 Thread Euler Taveira
On Wed, Aug 6, 2025, at 10:48 AM, Fujii Masao wrote:
> On Wed, Aug 6, 2025 at 8:36 PM Peter Eisentraut  wrote:
>>
>> On 03.08.25 03:32, Fujii Masao wrote:
>> > The current documentation for pgoutput is buried in the logical streaming
>> > replication protocol section (in protocol.sgml), and there's no index entry
>> > for it. This makes it hard to discover and access, for example, when trying
>> > to look up the options it supports.
>> >
>> > I've often struggled to locate this information myself, so I'd like to
>> > propose moving the pgoutput documentation to the logical decoding section
>> > and adding an index entry. The attached patch does that. I think this 
>> > change
>> > will make it much easier for users to find the relevant details.
>>
>> This would move the documentation of pgoutput from "Internals" to
>> "Server Programming".  So it's a question of whether this is something
>> we want to advertise that people can use directly.  In the past,
>> pgoutput was an implementation detail of logical replication.  But I
>> gather people are using it for other things now?
>
> I've heard that Debezium users, a tool for change data capture, can use
> pgoutput as the logical decoding plugin. I also know users, including
> some of my colleagues, who use pgoutput with pg_recvlogical to capture
> messages inserted via pg_logical_emit_message().
>

pgoutput is our defacto output plugin and I think we consider it a mature piece
of code. If you are worried about compatibility, version 18 added the
pg_get_loaded_modules() function to find the loadable module version -- see
commit 55527368bd07.

There might be cases where you need to debug logical replication (conflicts?)
and you need to pass the exact output plugin options via SQL
(pg_logical_slot_*_changes) to obtain the changes.

If we keep it in the "Internals" chapter, it seems it is something to
PostgreSQL developers (as the chapter description says); it is not. Advanced
users can make good use of this. The new links will help users to find the
moved information if you are searching it into the "Internals" section.

Since you are proposing this change, I'm wondering if we shouldn't move
"Writing Logical Decoding Output Plugins" to "Internals" chapter. It contains
information to PostgreSQL developers. It is a bit off-topic for this thread but
we can also move part of the "Background Worker Processes", part of the
"Archive Modules" and part of the "OAuth Validator Modules" section (2
subsections that describe the API) into "Internals" chapter.


-- 
Euler Taveira
EDB   https://www.enterprisedb.com/




Re: add alias FLOAT for double precision

2025-08-07 Thread Tom Lane
"Euler Taveira"  writes:
> On Thu, Aug 7, 2025, at 7:35 AM, PG Doc comments form wrote:
>> In table 8.1 (
>> https://www.postgresql.org/docs/current/datatype.html#DATATYPE-TABLE ) the
>> FLOAT alias isn't listed, I think it would make sense to include beside
>> FLOAT8.

> Makes sense.

Agreed, pushed.

regards, tom lane