Re: doc: Fix missing or duplicate closing parentheses in some documents
Thank you for checking! >"a regular expression (when starting with a slash (/))" >to this: >"a regular expression starting with a slash (/)" Yes, I agree with you. I also think this is easier to read. Regards, 2025年11月7日(金) 13:08 Erik Wienhold : > On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote: > > I found that the parentheses seemed not to be handled correctly in > > following 3 documents, so I attach the patch for this. > > > > - closing parentheses is missing > > - doc/src/sgml/client-auth.sgml > > > > - closing parentheses is duplicate > > - doc/src/sgml/ltree.sgml > > - doc/src/sgml/trigger.sgml > > All three changes make sense. Although I would rephrase the part in > client-auth.sgml from this: > > "a regular expression (when starting with a slash (/))" > > to this: > > "a regular expression starting with a slash (/)" > > The latter reads nicer IMO and avoids the double closing parenthesis > which I find a bit awkward. > > -- > Erik Wienhold >
Re: doc: Fix missing or duplicate closing parentheses in some documents
On 2025-11-07 02:40 +0100, Daisuke Higuchi wrote: > I found that the parentheses seemed not to be handled correctly in > following 3 documents, so I attach the patch for this. > > - closing parentheses is missing > - doc/src/sgml/client-auth.sgml > > - closing parentheses is duplicate > - doc/src/sgml/ltree.sgml > - doc/src/sgml/trigger.sgml All three changes make sense. Although I would rephrase the part in client-auth.sgml from this: "a regular expression (when starting with a slash (/))" to this: "a regular expression starting with a slash (/)" The latter reads nicer IMO and avoids the double closing parenthesis which I find a bit awkward. -- Erik Wienhold
Re: Use uppercase keywords in foreign key tutorial
On 2025-11-06 04:06 +0100, David Rowley wrote: > On Thu, 6 Nov 2025 at 07:09, Erik Wienhold wrote: > > > > On 2025-11-04 03:09 +0100, David Rowley wrote: > > > I think just the keyword upper casing is a good idea for now. I'm > > > starting to lose hope that there's enough merit and consistency to the > > > proposed whitespace changes. Maybe there's a subset of it that does > > > make sense to do. > > > > Done in the attached v6. But I kept the few whitespace changes on lines > > where I change keywords to uppercase. It's mostly a single space after > > commas in column and parameter lists which I think also enhances > > readability. > > I reviewed this and double checked you left "uPDaTE" in [1]. Found no > issues, so pushed. > > Thank you. > > David > > [1] https://www.postgresql.org/docs/current/sql-syntax-lexical.html Thank you, David! -- Erik Wienhold
doc: Fix missing or duplicate closing parentheses in some documents
Hi I found that the parentheses seemed not to be handled correctly in following 3 documents, so I attach the patch for this. - closing parentheses is missing - doc/src/sgml/client-auth.sgml - closing parentheses is duplicate - doc/src/sgml/ltree.sgml - doc/src/sgml/trigger.sgml Regards doc_fix_missing_parentheses_client-auth.patch Description: Binary data doc_fix_duplicate_parentheses_trigger.patch Description: Binary data doc_fix_duplicate_parentheses_ltree.patch Description: Binary data
