Re: [COMMITTERS] pgsql: Add much-more-extensive TAP tests for pgbench.

2018-03-06 Thread Peter Eisentraut 
On 3/2/18 20:19, Tom Lane wrote:
> Peter Eisentraut  writes:
>> On 9/8/17 09:32, Tom Lane wrote:
>>> Add much-more-extensive TAP tests for pgbench.
> 
>> The use of done_testing() raises the requirement of Test::More from 0.82
>> to 0.87.  That seems OK, but we should update the version requirement in
>> TestLib.pm.  Any concerns?
> 
> Probably not, given that none of the buildfarm machines have whined
> (although I'm not sure if all the older ones run the TAP tests?).

done

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [COMMITTERS] pgsql: Add much-more-extensive TAP tests for pgbench.

2018-03-02 Thread Tom Lane 
Peter Eisentraut  writes:
> On 9/8/17 09:32, Tom Lane wrote:
>> Add much-more-extensive TAP tests for pgbench.

> The use of done_testing() raises the requirement of Test::More from 0.82
> to 0.87.  That seems OK, but we should update the version requirement in
> TestLib.pm.  Any concerns?

Probably not, given that none of the buildfarm machines have whined
(although I'm not sure if all the older ones run the TAP tests?).

I have some recollection that when I was trying to set up
the-oldest-supported-Perl-version on prairiedog, I couldn't even
find Test::More 0.82 anywhere.  What's actually there is a good
bit newer, anyway.

regards, tom lane

Re: [COMMITTERS] pgsql: Add much-more-extensive TAP tests for pgbench.

2018-03-02 Thread Peter Eisentraut 
On 9/8/17 09:32, Tom Lane wrote:
> Add much-more-extensive TAP tests for pgbench.
> 
> Fabien Coelho, reviewed by Nikolay Shaplov and myself

The use of done_testing() raises the requirement of Test::More from 0.82
to 0.87.  That seems OK, but we should update the version requirement in
TestLib.pm.  Any concerns?

-- 
Peter Eisentraut  http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services